Mael Rouxel-Labbé
131242bb80
Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_5.3-GF
2021-10-12 09:29:23 +02:00
Mael Rouxel-Labbé
590ddf8015
Various fixes for pmaps:
...
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
a reference (to avoid `typename PM::reference r = get(m, k)`,
which will take a ref to a temporary if the `reference`
typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
**mutable** property map: the `put()` is `map[k] = v`, which
is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
not a reference in `get(map, key)`. You can have a readable property map
returning a reference through its `get(map, key)`, but if there is
no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
* `value_type& operator[](key&)`
* `ref get(map, const key&)`
* `put(map, const key&, const value_type&)`
and non-mutable lvalue pmap:
* `const value_type& operator[](const key&)`
* `ref get(map, const key&)`
but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé
df560987a6
Whitespace & cleaning changes
2021-10-08 12:13:43 +02:00
Laurent Rineau
0e3b73852f
Merge branch '5.2.x-branch' into 5.3.x-branch
2021-10-07 14:26:14 +02:00
Mael Rouxel-Labbé
863ab7541c
Various whitespace fixes
2021-10-05 12:14:03 +02:00
Mael Rouxel-Labbé
c8cc0747fa
Clarify binary warning
2021-09-27 15:33:42 +02:00
Sebastien Loriot
c25c7c4668
Merge pull request #5882 from sloriot/Data-Ply_edge_prop
...
Update PLY files to valid format
2021-08-12 10:24:32 +02:00
Sébastien Loriot
cff3cdb40e
Merge remote-tracking branch 'cgal/5.2.x-branch' into HEAD
2021-08-12 10:23:57 +02:00
Sébastien Loriot
8123a841f2
update to valid format
2021-07-30 10:16:58 +02:00
Sébastien Loriot
65f3803bab
compatibility for files written with the old code
2021-07-30 10:13:26 +02:00
Dan Bumbarger
149b5af81f
Update PLY.h
...
Aligned Edge property to PLY standard
2021-07-30 10:11:52 +02:00
Laurent Rineau
d6b2c8d9dc
Merge pull request #5671 from maxGimeno/CGAL_IO-Add_missing-deprecated_functions-maxGimeno
...
CGAL_IO: Add missing fallbacks
# Conflicts:
# BGL/include/CGAL/boost/graph/IO/INP.h
# Point_set_processing_3/include/CGAL/IO/write_xyz_points.h
2021-05-18 18:13:38 +02:00
Maxime Gimeno
cf69d32269
add missing const in read_OFF
2021-05-12 11:40:20 +02:00
Maxime Gimeno
9acf3d4b19
Add missing fallbacks for IO functions and result_of
2021-05-07 12:50:51 +02:00
Maxime Gimeno
23be65772d
remove useless overload
2021-05-06 12:32:45 +02:00
Maxime Gimeno
cd7b635abd
Also Fix Surface_mesh
2021-05-06 10:53:58 +02:00
Sébastien Loriot
56025fb5f9
fix release number of depreciation
2021-05-04 14:38:47 +02:00
Sébastien Loriot
fb6f703b55
IO namespace for files in IO directories
2021-05-04 14:36:06 +02:00
Laurent Rineau
a72fdb7b3c
Merge pull request #5352 from lrineau/CGAL-fix_CGAL_IO-GF
...
Fixes after the PR "CGAL I/O
2021-02-18 15:23:43 +01:00
Laurent Rineau
c5ba414c72
Merge pull request #5336 from maxGimeno/GraphicsView-Use_opengl_4_1_context-maxGImeno
...
Graphics_view: Upgrade glsl version in basic_viewer_shaders
2021-02-05 16:12:42 +01:00
Laurent Rineau
b134ed8246
Merge pull request #5336 from maxGimeno/GraphicsView-Use_opengl_4_1_context-maxGImeno
...
Graphics_view: Upgrade glsl version in basic_viewer_shaders
2021-02-05 16:07:32 +01:00
Maxime Gimeno
2dac31f36f
Clean-up and fix doc
2021-02-05 14:14:11 +01:00
Maxime Gimeno
7bf9c14f72
Factorization
2021-01-28 10:01:52 +01:00
Maxime Gimeno
41c823c083
replace default value of stream precision
2021-01-27 15:44:02 +01:00
Maxime Gimeno
a85cf6ed52
Move the include in the ifdef
2021-01-26 09:45:18 +01:00
Laurent Rineau
27deb7ce2d
Fix a typo from a copy-paste in deprecated `write_PLY`
2021-01-14 16:27:56 +01:00
Maxime Gimeno
04753381e5
Rename file and add ::Qt
2021-01-12 13:22:34 +01:00
Maxime Gimeno
95192d6d4b
factorize context initialization
2021-01-12 13:08:58 +01:00
Maxime Gimeno
2a212bb2a8
Upgrade non-compatibility sahders in Basic_viewer to glsl 150 and add a context creation before the creation of the QApp in draw_xxx examples
2021-01-07 13:06:40 +01:00
Maxime Gimeno
7cfb944afb
Fixes
2020-11-19 12:11:51 +01:00
Maxime Gimeno
c4e488ac14
fix unused vpm
2020-11-18 10:26:57 +01:00
Maxime Gimeno
3b70343590
Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno
2020-11-16 16:19:43 +01:00
Sébastien Loriot
88967b928d
really clear the mesh
2020-10-21 10:51:12 +02:00
Sébastien Loriot
5a6333f014
Merge remote-tracking branch 'cgal/master'
2020-10-20 13:42:46 +02:00
Laurent Rineau
216d066285
Merge remote-tracking branch 'cgal/master' into Surface_mesh_reuse_garbage-GF
2020-10-16 14:01:58 +02:00
Sébastien Loriot
254500a4f7
typo
2020-10-15 11:31:49 +02:00
Sébastien Loriot
2cabe688e3
do not remove and readd permanent property maps
2020-10-14 18:03:17 +02:00
Sébastien Loriot
e116cb5d46
rename function
2020-10-14 18:03:17 +02:00
Sébastien Loriot
7d48af6689
split clear(bool) in clear() and remove_all_simplices()
2020-10-14 18:03:17 +02:00
Sébastien Loriot
b132ba82c9
add an option to not remove properties after clear()
2020-10-14 18:03:17 +02:00
Mael Rouxel-Labbé
0583a4862e
Add precision support to Geomview streams
2020-10-14 15:32:27 +02:00
Mael Rouxel-Labbé
6e34fa93ef
Fix extra '!' breaking logic in OFF writing
2020-10-13 18:13:33 +02:00
Mael Rouxel-Labbé
f55ef7dd50
Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno
2020-10-09 18:36:17 +02:00
Maxime Gimeno
43a49605e0
Fix conflicts
2020-10-05 13:20:40 +02:00
Sébastien Loriot
4e0fc267af
Merge pull request #4715 from afabri/BGL-test_face-GF
...
BGL: Add a function to check if add_face() can be called successfully
2020-10-02 15:24:45 +02:00
Sebastien Loriot
10ba34719e
Merge pull request #4728 from sloriot/PMP-cc_cleanup
...
Clean in connected components
2020-10-02 15:20:53 +02:00
Mael Rouxel-Labbé
8682f9bafb
Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno
2020-08-24 11:45:17 +02:00
Sébastien Loriot
e893ac1178
cosmetic changes
2020-08-18 10:06:51 +02:00
Mael Rouxel-Labbé
c14198a992
IO doc fixes
2020-08-04 17:55:21 +02:00
Mael Rouxel-Labbé
00ca0211e1
IO documentation fixes
2020-08-04 15:47:56 +02:00