Commit Graph

1620 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 131242bb80 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_5.3-GF 2021-10-12 09:29:23 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Sébastien Loriot cff3cdb40e Merge remote-tracking branch 'cgal/5.2.x-branch' into HEAD 2021-08-12 10:23:57 +02:00
Mael Rouxel-Labbé 3fcae5244d Add a few more tests 2021-07-19 15:58:10 +02:00
Sébastien Loriot bdec4360d3 Merge remote-tracking branch 'cgal/5.2.x-branch' 2021-06-25 10:05:19 +02:00
Sébastien Loriot dfcdb4c05b Merge remote-tracking branch 'cgal/5.1.x-branch' into HEAD 2021-06-25 10:02:58 +02:00
Andreas Fabri 1948cf304f Fix (unintendedly) skipping the next point after erasure of a constraint point
In 'it = set.erase(it)', it is already the next element, so the ++it
of the loop makes the algorithm skip an element, which might have had
to be removed if it also didn't have a corresponding triangulation vertex.
2021-06-15 14:21:35 +02:00
Mael Rouxel-Labbé 84a15ad4f9 Align Triangulation_2 User/Reference Manual with other Tr packages (use plural) 2021-06-05 14:53:46 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Sébastien Loriot fb6f703b55 IO namespace for files in IO directories 2021-05-04 14:36:06 +02:00
Mael 8226666398
Merge branch 'master' into Triangulation_on_sphere_2-GF 2021-04-17 11:22:30 +02:00
Sebastien Loriot b7323389c7
Merge pull request #5622 from maxGimeno/CMake-Update_versions_in_scripts-maxGimeno
Update maximum cmake versions
2021-04-17 10:58:14 +02:00
Maxime Gimeno c49152359c update max version of cmake and announce the new minimal in CHANGE.md 2021-04-15 15:08:54 +02:00
Maxime Gimeno 17602e589e Merge remote-tracking branch 'cgal/master' into CGAL-clang_tidy__nullptr_on_Mesh_2-GF 2021-04-07 09:17:51 +02:00
Mael Rouxel-Labbé 18c943e7b2 Add ToS2 user manual 2021-03-24 10:56:14 +01:00
Mael Rouxel-Labbé ede18b776c Merge remote-tracking branch 'cgal/master' into Triangulation_on_sphere_2-GF 2021-03-18 10:42:52 +01:00
Laurent Rineau 3ab3b10d47 Merge pull request #5247 from MaelRL/SDG-Fix_doc-GF
Doc improvements for TDS-related classes
2021-03-03 17:38:18 +01:00
Laurent Rineau cb8e564ac7 Merge pull request #5349 from afabri/Polyline_simplification-simplify_overlaps-GF
2D Polyline simplification: Also simplify overlapping vertex sequences
2021-03-03 17:35:27 +01:00
Laurent Rineau b1d78a909f Merge pull request #5433 from sloriot/CGAL-last_bind
Remove last bind
2021-03-03 17:32:59 +01:00
Laurent Rineau 6f8f36462f Merge pull request #5433 from sloriot/CGAL-last_bind
Remove last bind
2021-03-03 17:10:13 +01:00
Mael Rouxel-Labbé 5efa544734 Merge remote-tracking branch 'cgal/master' into SDG-Fix_doc-GF 2021-02-22 17:19:40 +01:00
Maxime Gimeno 765cbe3729 Example pass 2021-02-19 12:23:18 +01:00
Laurent Rineau 1a040c8552
Merge pull request #4749 from danston/Polygon_mesh_processing-triangulate_hole_with_cdt2-danston 2021-02-19 07:59:59 +01:00
Laurent Rineau 8fc88a9463 Merge pull request #5409 from lrineau/Triangulation_3-fix__move__semantic__of__Triangulation_hierarchy_3-GF
Fix the move-semantic of Triangulation_hierarchy_3
2021-02-18 15:19:11 +01:00
Laurent Rineau fa1a355751 Merge branch '5.1.x-branch' into 5.2.x-branch 2021-02-18 15:19:05 +01:00
Laurent Rineau 0539b1ab3a Merge pull request #5409 from lrineau/Triangulation_3-fix__move__semantic__of__Triangulation_hierarchy_3-GF
Fix the move-semantic of Triangulation_hierarchy_3
2021-02-18 15:18:00 +01:00
Maxime Gimeno d5811d0a41 clang-tidy on tests 2021-02-18 15:15:12 +01:00
Sébastien Loriot 4bb0406240 do not include boost/bind.hpp (shouldn't be used anymore) + fix remaining bind
(nasty using namespace boost!)
2021-02-12 15:35:19 +01:00
Laurent Rineau 3bd7181ff3 Merge pull request #5244 from afabri/Triangulation_2-Intersect_use_variant-GF
Nef_3, Triangulation_2:  Change the result type of the Intersect_2 functor
2021-02-05 16:12:58 +01:00
Laurent Rineau c5ba414c72 Merge pull request #5336 from maxGimeno/GraphicsView-Use_opengl_4_1_context-maxGImeno
Graphics_view: Upgrade glsl version in basic_viewer_shaders
2021-02-05 16:12:42 +01:00
Laurent Rineau b134ed8246 Merge pull request #5336 from maxGimeno/GraphicsView-Use_opengl_4_1_context-maxGImeno
Graphics_view: Upgrade glsl version in basic_viewer_shaders
2021-02-05 16:07:32 +01:00
Laurent Rineau 5380ffd257 Merge pull request #5336 from maxGimeno/GraphicsView-Use_opengl_4_1_context-maxGImeno
Graphics_view: Upgrade glsl version in basic_viewer_shaders
2021-02-05 16:05:55 +01:00
Laurent Rineau b8bb3ffc09 Apply on triangulation_hierarchy_2 the same fix as in 3D 2021-02-04 09:21:36 +01:00
Laurent Rineau cbc73a8fc4 Add the testsuite for Triangulation_2, factorize it with T_3
I have added the file
`Testsuite/include/CGAL/Testsuite/Triangulation_23/test_move_semantic.h`
so that is can be reused in the tests for `Triangulation_2` and
`Triangulation_3`.

So far, the tests in `test_delaunay_hierarchy_2.cpp` fail...
2021-02-03 15:52:55 +01:00
Mael Rouxel-Labbé dc1d1dfbfa Doc fixes after Round 3
https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Triangulation_on_sphere_2/3rd_round
2021-02-03 10:55:34 +01:00
Andreas Fabri a5f7516f60 Merge remote-tracking branch 'cgal/master' into Polyline_simplification-simplify_overlaps-GF 2021-02-01 13:04:03 +00:00
Mael Rouxel-Labbé df32032470 Misc doc fixes 2021-02-01 12:32:50 +01:00
Mael Rouxel-Labbé a30486a486 Implement + document ranges 2021-01-31 12:03:10 +01:00
Mael Rouxel-Labbé 1e7b9863cb Merge remote-tracking branch 'cgal/master' into Triangulation_on_sphere_2-GF 2021-01-28 17:48:09 +01:00
Maxime Gimeno a85cf6ed52 Move the include in the ifdef 2021-01-26 09:45:18 +01:00
Mael Rouxel-Labbé 1f45360d7a Merge remote-tracking branch 'cgal/master' into SDG-Fix_doc-GF 2021-01-26 09:05:24 +01:00
Dmitry Anisimov f7abb6c343
Merge branch 'master' into Polygon_mesh_processing-triangulate_hole_with_cdt2-danston 2021-01-14 17:23:24 +01:00
Dmitry Anisimov c657451934
Merge branch 'master' into Polygon_mesh_processing-triangulate_hole_with_cdt2-danston 2021-01-14 10:38:51 +01:00
Andreas Fabri 105b93b35a Now it should work with overlapping polylines 2021-01-14 08:51:39 +00:00
Andreas Fabri 44260a88fc Store vertex handles in the MPQ and have a map from Vertex_handle to Vertices_in_constaint_iterator 2021-01-13 20:56:34 +00:00
Maxime Gimeno 04753381e5 Rename file and add ::Qt 2021-01-12 13:22:34 +01:00
Maxime Gimeno 95192d6d4b factorize context initialization 2021-01-12 13:08:58 +01:00
Maxime Gimeno 3d1c41fd14 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2021-01-07 15:05:28 +01:00
Maxime Gimeno 2a212bb2a8 Upgrade non-compatibility sahders in Basic_viewer to glsl 150 and add a context creation before the creation of the QApp in draw_xxx examples 2021-01-07 13:06:40 +01:00
Maxime Gimeno 02eb3648ad Try something else 2021-01-07 11:43:13 +01:00