songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
79,409 Commits 3 Branches 156 Tags 974 MiB
Commit Graph

2690 Commits

Author SHA1 Message Date
Jane Tournois d826147256 remove TriangleAccessor from polyhedral_mesh_complex 2017-08-03 17:15:43 +02:00
Jane Tournois 56cab9458c remove extra typename 2017-08-03 16:09:52 +02:00
Jane Tournois 0c2999da30 use forward declaration include 2017-08-03 16:09:52 +02:00
Jane Tournois 77896f38fe use the AABB_tree internal to Side_of_triangle_mesh 
this avoids incompatibility issues,
and simplifies the code in Polyhedral_mesh_domain_3
 2017-08-03 16:09:52 +02:00
Jane Tournois 862300b609 remove extra * 
and improve indentation
 2017-08-03 16:09:52 +02:00
Jane Tournois ee8eda8a16 TriangleAccessor is not needed anymore 2017-08-03 16:09:52 +02:00
Jane Tournois 9e388204e8 use Side_of_triangle_mesh in Polyhedral_mesh_domain_3 2017-08-03 16:09:52 +02:00
Maxime Gimeno 95dfae314b Rename file 2017-08-02 16:26:53 +02:00
Laurent Rineau 917781929b Merge pull request #2279 from janetournois/Polyhedron_demo_-add_mesh_surface_w_border_in_closed_domain-GF 
Qualify call of is_empty() as CentOS6-CXX11 sees an ambiguity with struct std::is_empty
 2017-07-25 18:17:10 +02:00
Laurent Rineau 0ec094d1e0 Bug-fix: fix a bug that could lead to a size close to 0 
The bug and the fix are known for six weeks (found while working on
another project):

> commit 15d1f864c4bb68cc9e267c3be3610296e5fa9212
> Author: Laurent Rineau <laurent.rineau@cgal.org>
> Date:   Fri Feb 17 12:17:18 2017 +0100
>
>     Refactoring of Sizing_field_with_aabb_tree (API breakage too)

but we forgot to include the fix in CGAL.
 2017-07-21 17:29:29 +02:00
Laurent Rineau 99bfe4b200 Fix debug code, after the BGLization 2017-07-21 17:18:51 +02:00
Laurent Rineau 5f198bca9c Bug-fix: fix a bug that could lead to a size close to 0 
The bug and the fix are known for six weeks (found while working on
another project):

> commit 15d1f864c4bb68cc9e267c3be3610296e5fa9212
> Author: Laurent Rineau <laurent.rineau@cgal.org>
> Date:   Fri Feb 17 12:17:18 2017 +0100
>
>     Refactoring of Sizing_field_with_aabb_tree (API breakage too)

but we forgot to include the fix in CGAL.
 2017-07-21 16:49:40 +02:00
Laurent Rineau 1f4ee1d07a Reorganize the binary I/O tests 
Skip the reading of the existing binary file, for
  - 32bits platforms (actually any non-64bits platform),
  - and big endian platforms.
... because we know the binary file is incompatible (for the moment).
 2017-07-19 10:46:35 +02:00
Laurent Rineau 2b79306e2d Fix a compilation error 
```
/usr/bin/c++   -DCGAL_TEST_SUITE -DCGAL_USE_GMP -DCGAL_USE_MPFR -DCGAL_USE_ZLIB -I/home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/../../../AABB_tree/include -I/home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/../../include -I/home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3 -I/home/cgal_tester/build/src/cmake/platforms/CentOS7/include -I/mnt/testsuite/include  -Wall -frounding-math   -o CMakeFiles/test_c3t3_io.dir/test_c3t3_io.cpp.o -c /home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/test_c3t3_io.cpp
In file included from /usr/include/boost/assert.hpp:50:0,
                 from /usr/include/boost/archive/archive_exception.hpp:20,
                 from /usr/include/boost/multi_index/detail/index_node_base.hpp:21,
                 from /usr/include/boost/multi_index/detail/node_type.hpp:23,
                 from /usr/include/boost/multi_index/detail/index_base.hpp:21,
                 from /usr/include/boost/multi_index/detail/base_type.hpp:21,
                 from /usr/include/boost/multi_index_container.hpp:33,
                 from /usr/include/boost/bimap/detail/bimap_core.hpp:34,
                 from /usr/include/boost/bimap/bimap.hpp:61,
                 from /mnt/testsuite/include/CGAL/Mesh_complex_3_in_triangulation_3.h:39,
                 from /home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/test_c3t3_io.cpp:4:
/home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/test_c3t3_io.cpp: In member function 'bool Test_c3t3_io<Mesh_domain>::operator()(const char*) const':
/home/cgal_tester/build/src/cmake/platforms/CentOS7/test/Mesh_3/test_c3t3_io.cpp:387:43: error: 'type name' declared as function returning a function
     assert(CGAL::Get_io_signature<C3t3>()() ==
                                           ^
```
 2017-07-19 10:45:44 +02:00
Laurent Rineau 2ef17adaf0 Extend the test to compare with reference files 
That way, if the format changes, the test will detect the change.
 2017-07-18 15:53:21 +02:00
Laurent Rineau caa90ff5b5 Update the test to check that the signature does not change 2017-07-18 14:40:37 +02:00
Laurent Rineau aa85aea097 Fix io_signature for Mesh_3 (since the weighted point rework) 2017-07-18 14:40:10 +02:00
Laurent Rineau ceec6140ba Merge pull request #1884 from lrineau/Mesh_3-Polyhedral_complex_mesh_domain_3-GF 
New class of MeshDomainWithFeatures_3, from a polyhedral complex
 2017-07-17 16:28:27 +02:00
Laurent Rineau 78f1988747 Merge pull request #2247 from lrineau/Surface_mesher-cleanup_after_Weighted_point_3-lrineau 
Surface mesher: cleanup files after the move to Weighted_point_3
 2017-07-17 12:24:03 +02:00
Laurent Rineau 871bba21f6 Merge pull request #2212 from MaelRL/Periodic_3_Regular_triangulation_3-APelle 
Add periodic regular triangulations
 2017-07-17 12:23:54 +02:00
Andreas Fabri b138cc7f9e Qualify call as CentOS6-CXX11 sees an ambiguity with struct std::is_empty 2017-07-17 11:11:42 +02:00
Laurent Rineau ef2f6cd9a8 Remove remaining use of <CGAL/Weighted_point.h> 2017-07-11 13:35:41 +02:00
Jane Tournois 0ca00822dc fix warnings 
about comparison signed/unsigned
 2017-07-07 11:54:24 +02:00
Jane Tournois 433d154329 variable used only in verbose mode 2017-07-07 11:27:21 +02:00
Jane Tournois 400edd0886 this can't be tested when Surface_patch_index is not only an integer 2017-07-07 11:23:59 +02:00
Jane Tournois b7597d90f7 rt.insert() takes a weighted point 
fix compilation error
 2017-07-07 10:56:17 +02:00
Jane Tournois ca20cea4f2 fix compilation errors after rebase 2017-07-07 10:19:08 +02:00
Laurent Rineau 30b102dde6 Add missing `typename` keywords 2017-07-07 10:15:10 +02:00
Andreas Fabri 5dbe78d1ec Remove typdef 2017-07-07 10:15:10 +02:00
Jane Tournois 63d793575d typos in the doc 2017-07-07 10:15:10 +02:00
Jane Tournois b47a4eec3e Partially Revert "allow not to protect borders and sharp features in a polyhedral complex" 
This reverts commit 087c6ab1f388febb8823c66eb9d05b9229a4af93.

We now use a const_cast to solve the problem of the reverted commit
 2017-07-07 10:15:10 +02:00
Jane Tournois 7b95cee121 add figures 2017-07-07 10:15:10 +02:00
Jane Tournois 8a36efa436 allow not to protect borders and sharp features in a polyhedral complex 
we overload construct_initial_points_object() to fill internal data structures
of Polyhedral_complex_mesh_domain_3 in case they have not been initialized yet

there were a lot of constness issues to be solved, and most internal data
structures had to be made mutable.
It seems to be a better choice and exposing a non-const mesh domain in the
outer functions as init_c3t3() for example
 2017-07-07 10:15:10 +02:00
Jane Tournois 974eba05a2 add doc to the user manual 
figures have not been added yet
 2017-07-07 10:15:10 +02:00
Jane Tournois b49bd34349 document the class, and set visible or not what should be 2017-07-07 10:15:10 +02:00
Jane Tournois 6692154562 doc : fix compilation, and add group 2017-07-07 10:15:10 +02:00
Jane Tournois a525881b0d very first version of the documentation of the Polyhedral_complex example 2017-07-07 10:15:10 +02:00
Jane Tournois 63cc93d15d change some private to protected, and add a constructor 
to be able to use the methods in a derived class
 2017-07-07 10:15:10 +02:00
Jane Tournois 3a78b2171e detect features in polyhedral complex example 2017-07-07 10:15:10 +02:00
Jane Tournois b3c9fd5aac add a test for meshing polyhedral complex 
test internal functions for smarter initialization too
 2017-07-07 10:15:10 +02:00
Jane Tournois 0a1f3ce326 use the typedef Polyhedron_type 2017-07-07 10:15:10 +02:00
Jane Tournois db634d317e deal with duplicated points 
in some configurations where the input is non-manifold at a vertex,
there might be duplicated points.
When this happens, we want to merge the incident surface patches
to preserve meshing with the topology criterion from not terminating
 2017-07-07 10:15:10 +02:00
Jane Tournois 06434bda1a fix add_vertices_to_c3t3_on_patch_without_feature_edges(C3t3& c3t3) 
the implementation was incomplete
 2017-07-07 10:15:10 +02:00
Jane Tournois 8d54b6f970 remove functions that have become useless 
because we do not restrict to cuboid-like domains,
we can use is_sharp, detect_sharp_edges, and detect_border_edges
from Detect_features_in_polyhedra instead of these specific implementations
 2017-07-07 10:15:10 +02:00
Jane Tournois 9fc794ec14 add missing ref 2017-07-07 10:15:10 +02:00
Jane Tournois 82da7a8f61 write detect_borders() and detect_features() 
as done in CGAL::Polyhedral_mesh_domain_with_features_3
 2017-07-07 10:15:10 +02:00
Jane Tournois 80e3ce68dd do not detect sharp features in constructor 
and do not consider that sharp edges have to be on the bbox
 2017-07-07 10:15:10 +02:00
Jane Tournois 675f54334b add comments 2017-07-07 10:15:10 +02:00
Jane Tournois 46d31b6f48 fix compilation for visual studio 
msvc 2013 fails to match IGT with the local IGT, and mismatches
with the one from the Base class.

this commit is enough to help it match types
 2017-07-07 10:15:10 +02:00
Laurent Rineau 87d7824afc Include the license checking header 2017-07-07 10:15:10 +02:00
Laurent Rineau abc6c0697f Fix the stupid name lookup bug from Visual C++ 
```
...\include\CGAL/Polyhedral_complex_mesh_domain_3.h(283): error C2248: 'CGAL::Polyhedral_mesh_domain_3<Polyhedron,IGT,TriangleAccessor,CGAL::Tag_true,CGAL::Tag_true>::IGT': cannot access private typedef declared in class 'CGAL::Polyhedral_mesh_domain_3<Polyhedron,IGT,TriangleAccessor,CGAL::Tag_true,CGAL::Tag_true>'
        with
        [
            Polyhedron=CGAL::Polyhedron_3<K,CGAL::Mesh_3::Mesh_polyhedron_items<int>,CGAL::HalfedgeDS_default,std::allocator<int>>,
            IGT=K,
            TriangleAccessor=CGAL::Triangle_accessor_3<CGAL::Polyhedron_3<K,CGAL::Mesh_3::Mesh_polyhedron_items<int>,CGAL::HalfedgeDS_default,std::allocator<int>>,K>
        ]
...\include\CGAL/Polyhedral_mesh_domain_3.h(169): note: see declaration of 'CGAL::Polyhedral_mesh_domain_3<Polyhedron,IGT,TriangleAccessor,CGAL::Tag_true,CGAL::Tag_true>::IGT'
        with
        [
            Polyhedron=CGAL::Polyhedron_3<K,CGAL::Mesh_3::Mesh_polyhedron_items<int>,CGAL::HalfedgeDS_default,std::allocator<int>>,
            IGT=K,
            TriangleAccessor=CGAL::Triangle_accessor_3<CGAL::Polyhedron_3<K,CGAL::Mesh_3::Mesh_polyhedron_items<int>,CGAL::HalfedgeDS_default,std::allocator<int>>,K>
        ]
```
 2017-07-07 10:15:10 +02:00
Laurent Rineau c2a55b2476 Fix a compilation error without C++11 
In C++03, `std::pair` is not an aggregate.
 2017-07-07 10:15:10 +02:00
Laurent Rineau afa62cbb40 First draft of a documentation for Polyhedral_complex_mesh_domain_3 2017-07-07 10:15:10 +02:00
Laurent Rineau c4fea992cb Add an example and a class: Polyhedral_complex_mesh_domain_3 2017-07-07 10:15:10 +02:00
Maxime Gimeno 2e5b2d5d84 Fix mesh_3_plugin with SM 2017-07-05 16:59:11 +02:00
Mael Rouxel-Labbé 5ef4ed6083 Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle 
Based on master
 2017-07-03 16:12:14 +02:00
Laurent Rineau d878561809 Merge pull request #2102 from afabri/Kernel_Weighted_point_without_conversion-GF 
Remove implicit conversions between points and weighted points
 2017-07-03 12:08:57 +02:00
Mael Rouxel-Labbé ce8f3ff2d9 Fixed unused variable warning 2017-06-28 10:17:14 +02:00
Mael Rouxel-Labbé 044deb6c7e Replaced boost_static_assert with cgal_static_assert and used () guards 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé aed94b400b Renamed Compact_mesh_cell_base_3's circumcenter_ to weighted_circumcenter_ 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 1f14a66d94 Renamed uses of invalidate_circumcenter() in accordance with the modified concept 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé a68423f4c8 Adapted the documentation to the new concept RegTrCellBaseWithWeightedCircumcenter 
- MeshCellBase_3 loses "invalidate_circumcenter" and refines the new concept
- Reg_tr_cell_base_with_weighted_circumcenter_3 is a model of the new concept
 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé d2fe610870 Fixed Robust_weighted_[...]_traits offering a weighted API for squared_radius_3 
This is artifically creating implicit conversions, which we are removing
 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé fd7ae58de6 Fixed point / weighted_point usage 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 03e646679f MeshVertexBase_3 must refine RegularTriangulationVertexBase_3 
and not TriangulationVertexBase_3
 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 7e92f1ae9e Cosmetic changes to MeshCellBase_3 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 9c044c00eb Fixed the concept MeshCellBase_3 
The surface center is not of type Tr::Point, but Tr::Bare_point.
Added to changes.html
 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé ddf8384769 Removed obsolete class Creator_weighted_point_3.h 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 2d2eb22f98 Fixed boost/core/is_same.hpp > boost/type_traits/is_same.hpp 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 614293f673 Forgot compact_mesh_cell_base in f2a308d 
That is, making cell_bases models of the concept RegularTriangulationCellBase_3
 2017-06-28 10:16:23 +02:00
Jane Tournois 130e65db97 really use the GT given as a parameter 
When the geom_traits given as parameter of `circumcenter` and/or
`weighted_circumcenter` was deriving from the cell base GT
(first template parameter), the gt was up-casted to the
cell base GT, and the function construct_circumcenter_3_object()
(or construct_weighted_circumcenter_3_object()) not
called on the right geom traits type --> possibly missing
the actual input of the function (the robust_circumcenter_traits in Mesh_3)

we add a static assert to check at compile time that point types are the same
 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 1860ee4d04 Fixed abusive class member initialization 2017-06-28 10:16:23 +02:00
Jane Tournois 110316570c really use the GT given as a parameter 
When the geom_traits given as parameter of `circumcenter` and/or
`weighted_circumcenter` was deriving from the cell base GT
(first template parameter), the gt was up-casted to the
cell base GT, and the function construct_circumcenter_3_object()
(or construct_weighted_circumcenter_3_object()) not
called on the right geom traits type --> possibly missing
the actual input of the function (the robust_circumcenter_traits in Mesh_3)

we add a static assert to check at compile time that both geom traits
are compatible
 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 9fbf2720ce Annihilated Regular_triangulation_euclidean_traits_23 across all packages 
Left a little bit alive in the tests and in the Triangulation_23/doc
 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé 5716601d01 Fixed various Bare_point / Weighted_point usage across Mesh_3 
Hopefully, this is the last batch
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé b0b1e5ceaf Moved facet dual computation functions from Mesh_3 to Regular_triangulation_3 
... and improved them and gave them more overloads
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 1db071e3ee Moved up the force_exact test to avoid computing useless determinants 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 1043965fe8 Removed useless includes 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé befccc1acc Cleaned uses of obsolete traits class Regular_triangulation_euclidean_traits 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 026058a20d Removed useless semicolon 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé bf37f6580d Fixed using Weighted_point_creator to construct weighted point 
This class is obsolete; kernel functors should be used.
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé cc8d0da913 Fixed (almost all) default constructed traits in Mesh_3 
Also fixed constructing points/weighted_points not through the traits and
uses of point().point()
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 234c2bf973 Fixed (remaining) Bare_point / Weighted_point wrong usages across Mesh_3 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé eee6df0b76 Removed Bare_point definition from Mesh_3's Robust_weighted_...etc..._traits 
It is not for the traits to define Bare_point. It is defined in the regular
triangulation.

This commit breaks stuff, but it'll be fixed in the following commits.
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé fd2e681afc Removed useless semicolon 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 754cc3dbe0 Minor doc improvement 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé d0e86aa386 Fixed compilation issues resulting from the removal of WP->P implicit conversion 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 7edd988ed9 Consistently grab the Bare_point typedef from the triangulation 
instead of the geometric traits
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 902aa3c045 Fixed missing typedef 
and removed some warnings due to unused typedefs
 2017-06-28 10:14:35 +02:00
Jane Tournois 6ddda349ad remove useless variables 2017-06-28 10:14:35 +02:00
Jane Tournois 0a14e77f40 remove extra reference 
this was leading to (fp == p), and no way to move back to the original
position of v0
 2017-06-28 10:14:35 +02:00
Jane Tournois 31806e471b return type should be Bare_point 2017-06-28 10:14:35 +02:00
Jane Tournois 726c84b742 fix one more Bare_point 2017-06-28 10:14:35 +02:00
Jane Tournois 223e3a20b6 make constructors of Weighted_point explicit 
and fix compilation errors
 2017-06-28 10:14:35 +02:00
Andreas Fabri 60fa986e1f make the Polyhedron demo mesh_3_plugin work 2017-06-28 10:14:35 +02:00
Jane Tournois 442e7f00f0 avoid using wp.point(), use Construct_point_3 instead 2017-06-28 10:14:35 +02:00
Jane Tournois ae4449782d remove hybrid operators, that use Bare points and Weighted points in an ambiguous manner 
this commit only fixes the testsuite of Mesh_3
 2017-06-28 10:14:35 +02:00
Andreas Fabri c68bd75b6b Now also the examples compile 2017-06-28 10:14:35 +02:00
Andreas Fabri 780e01dc90 WIP: test_meshing_polyhedron_with_features compiles and crashes in odt 2017-06-28 10:14:35 +02:00
Andreas Fabri e2abe11309 Consistently use Bare_point and Weighted_point 2017-06-28 10:14:35 +02:00
Andreas Fabri 787d46ffb8 Disable Point_3(const Weighted_point_3&) 2017-06-28 10:14:35 +02:00
Jane Tournois 6cc02867d0 add functionality to make mesh_3_plugin 
it is now able to mesh surfaces with border inside a closed polyhedral domain

`empty()` yields an ambiguity with the function available in Interval_traits.h,
so we need to rename `empty()` to `is_empty()`
 2017-06-22 16:17:24 +02:00
Jane Tournois 58380c0888 use empty() BGL helper function to fix compilation 2017-06-20 17:33:48 +02:00
Laurent Rineau 07ed1e08a3 Merge pull request #2143 from afabri/Mesh_3-mesh_polyhedral_domain_with_surface_inside-GF 
Mesh_3: Add an example (polyhedron inside a bouding polyhedron) in the User Manual
 2017-06-16 12:07:13 +02:00
Laurent Rineau 8693ab4d1d Merge pull request #2152 from lrineau/Mesh_3-small_fixes-GF 
Mesh 3: small fixes
 2017-06-16 12:06:41 +02:00
Mael Rouxel-Labbé 3c42724e22 Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle 
Based on Kernel_Weighted_point_without...
  @ 41e7520b3e
 2017-06-15 15:07:53 +02:00
Mael Rouxel-Labbé a9e25ec619 Renamed Compact_mesh_cell_base_3's circumcenter_ to weighted_circumcenter_ 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 9cc17dc935 Renamed uses of invalidate_circumcenter() in accordance with the modified concept 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 6e3f07a72d Adapted the documentation to the new concept RegTrCellBaseWithWeightedCircumcenter 
- MeshCellBase_3 loses "invalidate_circumcenter" and refines the new concept
- Reg_tr_cell_base_with_weighted_circumcenter_3 is a model of the new concept
 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé f33fc2a456 Fixed Robust_weighted_[...]_traits offering a weighted API for squared_radius_3 
This is artifically creating implicit conversions, which we are removing
 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 222248548c Fixed point / weighted_point usage 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé eb4340fe96 MeshVertexBase_3 must refine RegularTriangulationVertexBase_3 
and not TriangulationVertexBase_3
 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé ba8314c36e Cosmetic changes to MeshCellBase_3 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 174701d161 Fixed the concept MeshCellBase_3 
The surface center is not of type Tr::Point, but Tr::Bare_point.
Added to changes.html
 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé f93fc58cae Removed obsolete class Creator_weighted_point_3.h 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé fa6be567e5 Fixed boost/core/is_same.hpp > boost/type_traits/is_same.hpp 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé d22eaa2ce5 Forgot compact_mesh_cell_base in f2a308d 
That is, making cell_bases models of the concept RegularTriangulationCellBase_3
 2017-06-15 10:34:15 +02:00
Jane Tournois dae940b0fd really use the GT given as a parameter 
When the geom_traits given as parameter of `circumcenter` and/or
`weighted_circumcenter` was deriving from the cell base GT
(first template parameter), the gt was up-casted to the
cell base GT, and the function construct_circumcenter_3_object()
(or construct_weighted_circumcenter_3_object()) not
called on the right geom traits type --> possibly missing
the actual input of the function (the robust_circumcenter_traits in Mesh_3)

we add a static assert to check at compile time that point types are the same
 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 9d53db0c54 Fixed abusive class member initialization 2017-06-15 10:34:15 +02:00
Jane Tournois e399530d69 really use the GT given as a parameter 
When the geom_traits given as parameter of `circumcenter` and/or
`weighted_circumcenter` was deriving from the cell base GT
(first template parameter), the gt was up-casted to the
cell base GT, and the function construct_circumcenter_3_object()
(or construct_weighted_circumcenter_3_object()) not
called on the right geom traits type --> possibly missing
the actual input of the function (the robust_circumcenter_traits in Mesh_3)

we add a static assert to check at compile time that both geom traits
are compatible
 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 451f084021 Annihilated Regular_triangulation_euclidean_traits_23 across all packages 
Left a little bit alive in the tests and in the Triangulation_23/doc
 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé b5dadc0c95 Fixed various Bare_point / Weighted_point usage across Mesh_3 
Hopefully, this is the last batch
 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé a4503e7edc Moved facet dual computation functions from Mesh_3 to Regular_triangulation_3 
... and improved them and gave them more overloads
 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 9518646be4 Moved up the force_exact test to avoid computing useless determinants 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 0a91dac5ed Removed useless includes 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé cb70dfb644 Cleaned uses of obsolete traits class Regular_triangulation_euclidean_traits 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 417057b6fe Removed useless semicolon 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 5bb794a590 Fixed using Weighted_point_creator to construct weighted point 
This class is obsolete; kernel functors should be used.
 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé ce5660acbd Fixed (almost all) default constructed traits in Mesh_3 
Also fixed constructing points/weighted_points not through the traits and
uses of point().point()
 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 96e053211e Fixed (remaining) Bare_point / Weighted_point wrong usages across Mesh_3 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 78ea055735 Removed Bare_point definition from Mesh_3's Robust_weighted_...etc..._traits 
It is not for the traits to define Bare_point. It is defined in the regular
triangulation.

This commit breaks stuff, but it'll be fixed in the following commits.
 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 24994be80d Removed useless semicolon 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé d3a75a191c Minor doc improvement 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 67b0924ee0 Fixed compilation issues resulting from the removal of WP->P implicit conversion 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé 5db27d88d2 Consistently grab the Bare_point typedef from the triangulation 
instead of the geometric traits
 2017-06-15 10:32:03 +02:00
Mael Rouxel-Labbé f7592fbbdd Fixed missing typedef 
and removed some warnings due to unused typedefs
 2017-06-15 10:32:03 +02:00
Jane Tournois 85e87d4f59 remove useless variables 2017-06-15 10:32:03 +02:00
Jane Tournois a7b92113c7 remove extra reference 
this was leading to (fp == p), and no way to move back to the original
position of v0
 2017-06-15 10:32:03 +02:00
Jane Tournois 04b2f4ea25 return type should be Bare_point 2017-06-15 10:32:03 +02:00
Jane Tournois 4db6afd2aa fix one more Bare_point 2017-06-15 10:32:03 +02:00
Jane Tournois 9d4b697503 make constructors of Weighted_point explicit 
and fix compilation errors
 2017-06-15 10:32:03 +02:00
Andreas Fabri 42509e2a1f make the Polyhedron demo mesh_3_plugin work 2017-06-15 10:32:03 +02:00
Jane Tournois ea970f5aa5 avoid using wp.point(), use Construct_point_3 instead 2017-06-15 10:29:26 +02:00
Jane Tournois 5180389e3a remove hybrid operators, that use Bare points and Weighted points in an ambiguous manner 
this commit only fixes the testsuite of Mesh_3
 2017-06-15 10:29:26 +02:00
Andreas Fabri 3f4286068c Now also the examples compile 2017-06-15 10:29:26 +02:00
Andreas Fabri 58c8d7cb1a WIP: test_meshing_polyhedron_with_features compiles and crashes in odt 2017-06-15 10:29:26 +02:00
Andreas Fabri 5a090c26a4 Consistently use Bare_point and Weighted_point 2017-06-15 10:29:26 +02:00
Andreas Fabri 80224bf2c8 Disable Point_3(const Weighted_point_3&) 2017-06-15 10:29:26 +02:00
Maxime Gimeno bd45c39ef3 Fix warnings 2017-06-14 09:32:13 +02:00
Laurent Rineau f6b8ad199d More the "compatibility" specializations after the others 2017-06-12 16:45:07 +02:00
Laurent Rineau f87f78f5ed cleanup 2017-06-09 16:05:30 +02:00
Andreas Fabri ecad0cd4ea resize image 2017-06-06 15:36:40 +02:00
Andreas Fabri df25680911 Improve doc 2017-06-06 13:54:24 +02:00
Laurent Rineau ffa9d59e5e Fix polyhedral mesh domain in untested cases 2017-06-02 17:57:08 +02:00
Laurent Rineau b537432884 fix permissions 2017-06-02 17:02:38 +02:00
Mael Rouxel-Labbé 5df733c3af Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle 
Based on Kernel_Weighted_point_without...
  @ 3e43409d01
 2017-06-02 16:28:17 +02:00
Maxime Gimeno f61a0e39f6 Fix missing set include 2017-06-02 15:34:15 +02:00
Mael Rouxel-Labbé 0b2255baff Renamed Compact_mesh_cell_base_3's circumcenter_ to weighted_circumcenter_ 2017-06-01 11:26:50 +02:00
Mael Rouxel-Labbé a8379e65f9 Renamed uses of invalidate_circumcenter() in accordance with the modified concept 2017-06-01 11:26:05 +02:00
Mael Rouxel-Labbé d8dfeec94b Adapted the documentation to the new concept RegTrCellBaseWithWeightedCircumcenter 
- MeshCellBase_3 loses "invalidate_circumcenter" and refines the new concept
- Reg_tr_cell_base_with_weighted_circumcenter_3 is a model of the new concept
 2017-06-01 11:23:04 +02:00
Maxime Gimeno 54d5825855 Replace unexisting headers 2017-06-01 09:41:28 +02:00
Andreas Fabri 518c6cc1f4 Fix the demo 2017-05-31 21:16:00 +02:00
Andreas Fabri e77f1d4d78 Fix the demo 2017-05-31 19:50:02 +02:00
Andreas Fabri ac30f40f79 Move Mesh_3 specific properties to Mesh_3 2017-05-31 16:14:31 +02:00
Andreas Fabri d6816a7368 Move Mesh_3 specific properties to Mesh_3 2017-05-31 16:08:26 +02:00
Andreas Fabri 0c8ddd3e28 Delete cheese-box-bug.off 2017-05-31 10:34:32 +02:00
Andreas Fabri 1c2a21f743 Add an example for a polyhedral domain with a surface inside 2017-05-31 10:25:44 +02:00
Laurent Rineau f8a1017db8 Remove the parallelism 2017-05-31 10:22:16 +02:00
Laurent Rineau 73e35f2ff8 Do not use optimizers 2017-05-31 09:49:26 +02:00
Laurent Rineau 05699de667 Output to both .mesh and binary files 2017-05-31 09:49:26 +02:00
Andreas Fabri a0a4611e0f add data set 2017-05-31 09:49:26 +02:00
Andreas Fabri acc98c8cc5 two data/cheese.off data/cheese-box-bug.off has an assrtion of non-overlapping spheres 2017-05-31 09:49:26 +02:00
Mael Rouxel-Labbé 9fd7d90ffd Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle 
Based on Kernel_Weighted_point_without...
  @ 95c71de2e5
 2017-05-30 16:13:34 +02:00
Mael Rouxel-Labbé f4f1ca6c91 Fixed Robust_weighted_[...]_traits offering a weighted API for squared_radius_3 
This is artifically creating implicit conversions, which we are removing
 2017-05-30 15:22:54 +02:00
Maxime Gimeno b0de6bcbaa Fix permissions for data-sets 2017-05-29 13:24:09 +02:00
Maxime Gimeno e686ec592d Fixes 2017-05-29 13:24:08 +02:00
Maxime Gimeno fcc081f95d make mesh_3_plugin work with surface_mesh. 
Find why topoogy(int) is declared twice.
 2017-05-29 13:24:07 +02:00
Laurent Rineau 7d34fc5dbd Add compatibility: support when Patch_id is Tag_true/Tag_false 2017-05-29 13:24:07 +02:00
Laurent Rineau 2c2ad9ff6d Move properties from <CGAL/Mesh_polyhedron_3.h>... 
... to `<CGAL/boost/graph/PMP_properties_Polyhedron_3.h>`.
 2017-05-29 13:24:06 +02:00
Maxime Gimeno 9a3dde95ba Fix missing headers and definitions, SFINAE problems and ambiguous specialisation. 2017-05-29 13:24:06 +02:00
Andreas Fabri 5e7a5d656c Clean up the examples again; Add an example for two polyhedra 2017-05-29 13:24:06 +02:00
Andreas Fabri 0f28155729 I had to change Detect_features_in_polyhedra as the property map must be retrieved for the polyhedron passed to a function 2017-05-29 13:24:05 +02:00
Andreas Fabri e18f7037cf Add timer 2017-05-29 13:24:03 +02:00
Maxime Gimeno 5db694c154 polyhedral domain with features works for Surface_mesh and cheese.off (Polyhedron does no longer :( 
Conflicts:
	Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
	Surface_mesh/include/CGAL/boost/graph/PMP_properties_Surface_mesh.h
 2017-05-29 13:22:37 +02:00
Andreas Fabri 7bd5016c6d bglize and add property maps. polyhedral domain with features works almost for Surface_mesh 2017-05-29 13:22:37 +02:00
Maxime Gimeno 451af8f3ef bglize and add property maps. polyhedral domain with features works almost for Surface_mesh 
Conflicts:
	Mesh_3/include/CGAL/Mesh_polyhedron_3.h
	Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
	Surface_mesh/include/CGAL/boost/graph/PMP_properties_Surface_mesh.h
 2017-05-29 13:22:37 +02:00
Andreas Fabri 5a302c805d Make make_mesh_3() work for Surface_mesh 2017-05-29 13:22:37 +02:00
Maxime Gimeno b122889723 Make the Detect_sharp_edges_plugin work with a SM_item 
- finished the BGL-ization of Detect_features_in_polyhedra.h
- added a feature edges visualization to the SM_item.

Conflicts:
	Polyhedron/demo/Polyhedron/Plugins/Mesh_3/CMakeLists.txt
	Polyhedron/demo/Polyhedron/Plugins/PMP/CMakeLists.txt
	Polyhedron/demo/Polyhedron/Plugins/PMP/Detect_sharp_edges_plugin.cpp
	Polyhedron/demo/Polyhedron/Scene_surface_mesh_item.h
 2017-05-29 13:22:36 +02:00
Maxime Gimeno 8b9eae7f44 Fix rebase 2017-05-29 13:22:35 +02:00
Laurent Rineau d50e391577 Move properties from <CGAL/Mesh_polyhedron_3.h>... 
...to `<CGAL/boost/graph/PMP_properties_Polyhedron_3.h>`.

Conflicts:
	Mesh_3/include/CGAL/Mesh_polyhedron_3.h
 2017-05-29 13:20:41 +02:00
Maxime Gimeno d88dad8bef Clean-up and warning fix. 
- Use constructor of sm descriptors instead of static_casts.
 2017-05-29 13:20:41 +02:00
Maxime Gimeno 5e630f5c48 Move Detect_feature_edges to PMP 2017-05-29 13:20:40 +02:00
Maxime Gimeno 880b6e21a2 Fixes and Clean-up. 
- Move the new properties in a file in PMP and remove them from the namespace boost.
- Move the surface mesh properties from properties_Surface_mesh.h to Scene_surface_mesh_item.h
 2017-05-29 13:20:39 +02:00
Andreas Fabri a33e423d2e Add property maps to Mesh_polyhedron_3::type 2017-05-29 13:20:38 +02:00
Maxime Gimeno 7a3c096c72 fix detect_features 2017-05-29 13:20:38 +02:00
Maxime Gimeno 6b2a44c75e Link only with the right library in CMakeLists.txt 2017-05-29 13:20:36 +02:00
Andreas Fabri c8bc628c90 WIP: make the selection plugin work for Surface_mesh 2017-05-29 13:20:33 +02:00
Mael Rouxel-Labbé 1059dcb78f Fixed bad merge 2017-05-24 14:08:00 +02:00
Mael Rouxel-Labbé 5354134469 Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle 2017-05-24 12:18:49 +02:00
Mael Rouxel-Labbé 598244b1a5 Fixed point / weighted_point usage 2017-05-22 14:15:58 +02:00