songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
74,597 Commits 3 Branches 156 Tags 974 MiB
Commit Graph

1373 Commits

Author SHA1 Message Date
Maxime Gimeno 2e5b2d5d84 Fix mesh_3_plugin with SM 2017-07-05 16:59:11 +02:00
Laurent Rineau d878561809 Merge pull request #2102 from afabri/Kernel_Weighted_point_without_conversion-GF 
Remove implicit conversions between points and weighted points
 2017-07-03 12:08:57 +02:00
Mael Rouxel-Labbé ce8f3ff2d9 Fixed unused variable warning 2017-06-28 10:17:14 +02:00
Mael Rouxel-Labbé 044deb6c7e Replaced boost_static_assert with cgal_static_assert and used () guards 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé aed94b400b Renamed Compact_mesh_cell_base_3's circumcenter_ to weighted_circumcenter_ 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 1f14a66d94 Renamed uses of invalidate_circumcenter() in accordance with the modified concept 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé d2fe610870 Fixed Robust_weighted_[...]_traits offering a weighted API for squared_radius_3 
This is artifically creating implicit conversions, which we are removing
 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé fd7ae58de6 Fixed point / weighted_point usage 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé ddf8384769 Removed obsolete class Creator_weighted_point_3.h 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 2d2eb22f98 Fixed boost/core/is_same.hpp > boost/type_traits/is_same.hpp 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 614293f673 Forgot compact_mesh_cell_base in f2a308d 
That is, making cell_bases models of the concept RegularTriangulationCellBase_3
 2017-06-28 10:16:23 +02:00
Jane Tournois 130e65db97 really use the GT given as a parameter 
When the geom_traits given as parameter of `circumcenter` and/or
`weighted_circumcenter` was deriving from the cell base GT
(first template parameter), the gt was up-casted to the
cell base GT, and the function construct_circumcenter_3_object()
(or construct_weighted_circumcenter_3_object()) not
called on the right geom traits type --> possibly missing
the actual input of the function (the robust_circumcenter_traits in Mesh_3)

we add a static assert to check at compile time that point types are the same
 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 1860ee4d04 Fixed abusive class member initialization 2017-06-28 10:16:23 +02:00
Jane Tournois 110316570c really use the GT given as a parameter 
When the geom_traits given as parameter of `circumcenter` and/or
`weighted_circumcenter` was deriving from the cell base GT
(first template parameter), the gt was up-casted to the
cell base GT, and the function construct_circumcenter_3_object()
(or construct_weighted_circumcenter_3_object()) not
called on the right geom traits type --> possibly missing
the actual input of the function (the robust_circumcenter_traits in Mesh_3)

we add a static assert to check at compile time that both geom traits
are compatible
 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 5716601d01 Fixed various Bare_point / Weighted_point usage across Mesh_3 
Hopefully, this is the last batch
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé b0b1e5ceaf Moved facet dual computation functions from Mesh_3 to Regular_triangulation_3 
... and improved them and gave them more overloads
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 1db071e3ee Moved up the force_exact test to avoid computing useless determinants 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 1043965fe8 Removed useless includes 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé befccc1acc Cleaned uses of obsolete traits class Regular_triangulation_euclidean_traits 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 026058a20d Removed useless semicolon 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé cc8d0da913 Fixed (almost all) default constructed traits in Mesh_3 
Also fixed constructing points/weighted_points not through the traits and
uses of point().point()
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 234c2bf973 Fixed (remaining) Bare_point / Weighted_point wrong usages across Mesh_3 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé eee6df0b76 Removed Bare_point definition from Mesh_3's Robust_weighted_...etc..._traits 
It is not for the traits to define Bare_point. It is defined in the regular
triangulation.

This commit breaks stuff, but it'll be fixed in the following commits.
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé fd2e681afc Removed useless semicolon 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 754cc3dbe0 Minor doc improvement 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé d0e86aa386 Fixed compilation issues resulting from the removal of WP->P implicit conversion 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 7edd988ed9 Consistently grab the Bare_point typedef from the triangulation 
instead of the geometric traits
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 902aa3c045 Fixed missing typedef 
and removed some warnings due to unused typedefs
 2017-06-28 10:14:35 +02:00
Jane Tournois 6ddda349ad remove useless variables 2017-06-28 10:14:35 +02:00
Jane Tournois 0a14e77f40 remove extra reference 
this was leading to (fp == p), and no way to move back to the original
position of v0
 2017-06-28 10:14:35 +02:00
Jane Tournois 31806e471b return type should be Bare_point 2017-06-28 10:14:35 +02:00
Jane Tournois 726c84b742 fix one more Bare_point 2017-06-28 10:14:35 +02:00
Jane Tournois 223e3a20b6 make constructors of Weighted_point explicit 
and fix compilation errors
 2017-06-28 10:14:35 +02:00
Andreas Fabri 60fa986e1f make the Polyhedron demo mesh_3_plugin work 2017-06-28 10:14:35 +02:00
Jane Tournois 442e7f00f0 avoid using wp.point(), use Construct_point_3 instead 2017-06-28 10:14:35 +02:00
Jane Tournois ae4449782d remove hybrid operators, that use Bare points and Weighted points in an ambiguous manner 
this commit only fixes the testsuite of Mesh_3
 2017-06-28 10:14:35 +02:00
Andreas Fabri c68bd75b6b Now also the examples compile 2017-06-28 10:14:35 +02:00
Andreas Fabri 780e01dc90 WIP: test_meshing_polyhedron_with_features compiles and crashes in odt 2017-06-28 10:14:35 +02:00
Andreas Fabri e2abe11309 Consistently use Bare_point and Weighted_point 2017-06-28 10:14:35 +02:00
Andreas Fabri 787d46ffb8 Disable Point_3(const Weighted_point_3&) 2017-06-28 10:14:35 +02:00
Jane Tournois 6cc02867d0 add functionality to make mesh_3_plugin 
it is now able to mesh surfaces with border inside a closed polyhedral domain

`empty()` yields an ambiguity with the function available in Interval_traits.h,
so we need to rename `empty()` to `is_empty()`
 2017-06-22 16:17:24 +02:00
Jane Tournois 58380c0888 use empty() BGL helper function to fix compilation 2017-06-20 17:33:48 +02:00
Laurent Rineau 8693ab4d1d Merge pull request #2152 from lrineau/Mesh_3-small_fixes-GF 
Mesh 3: small fixes
 2017-06-16 12:06:41 +02:00
Maxime Gimeno bd45c39ef3 Fix warnings 2017-06-14 09:32:13 +02:00
Laurent Rineau f6b8ad199d More the "compatibility" specializations after the others 2017-06-12 16:45:07 +02:00
Laurent Rineau ffa9d59e5e Fix polyhedral mesh domain in untested cases 2017-06-02 17:57:08 +02:00
Maxime Gimeno f61a0e39f6 Fix missing set include 2017-06-02 15:34:15 +02:00
Andreas Fabri 518c6cc1f4 Fix the demo 2017-05-31 21:16:00 +02:00
Andreas Fabri e77f1d4d78 Fix the demo 2017-05-31 19:50:02 +02:00
Andreas Fabri ac30f40f79 Move Mesh_3 specific properties to Mesh_3 2017-05-31 16:14:31 +02:00