Commit Graph

2446 Commits

Author SHA1 Message Date
Guillaume Damiand 219ea871d7 copy the parts of gsoc2024-basic_viewer_glfw-tgrillon that concern only the qt basic viewer 2025-04-17 15:55:54 +02:00
Sébastien Loriot c5ab9f9adc Merge remote-tracking branch 'cgal/6.0.x-branch' into cgal/master 2025-04-10 18:19:14 +02:00
Sébastien Loriot d5a2d332eb Merge remote-tracking branch 'cgal/5.6.x-branch' into cgal/6.0.x-branch 2025-04-10 18:12:06 +02:00
Sébastien Loriot cc77715588 Merge pull request #6849 from JulyCode/gsoc2022-isosurface
Isosurfacing_3 (new package)
2025-04-03 21:41:22 +02:00
Sébastien Loriot bb3e3ab06b init pointers of subtraits 2025-04-03 15:38:56 +02:00
Mael Rouxel-Labbé e38e29f279 dont > don't 2025-03-28 20:52:22 +01:00
Mael Rouxel-Labbé 7970fb99e7 later > latter 2025-03-28 20:41:37 +01:00
Mael Rouxel-Labbé 691fd789f9 Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2025-03-24 21:34:55 +01:00
Sébastien Loriot cf301c4d22 Merge pull request #8786 from efifogel/Aos_2-fixes-efif
Fixed do_intersect() of curves (provided by Edkirito).
2025-03-24 11:51:09 +01:00
Sébastien Loriot e463bcaec1 Merge pull request #8713 from efifogel/Aos_2-traits_concept-efif
Aos 2 traits concept efif
2025-03-24 11:45:17 +01:00
Sebastien Loriot 5451674075
Aos 2 dcel extension efif (#8710)
## Summary of Changes

The changes fix a bug in the extensions of vertex and halfedge types of
the DCEL when used to instantiate Arrangement_with_history_2 or similar
arrangement classes that derive from Arrangement_2.
Typically, only the face type is extended or all the 3 types (vertex,
halfedge, and face) are extended, and for such extensions we have
dedicated class templates. The bug shows up when trying to extend any
other subset of the 3 types, and apparently, this hasn't been used much
with Arrangement_with_history_2.

## Release Management

* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): NA
* Feature/Small Feature (if any): NA
* Link to compiled documentation: NA
* License and copyright ownership: TAU
2025-03-17 09:11:49 +01:00
Efi Fogel b0ca5f2789 Fixed do_intersect() of curves (provided by Edkirito). 2025-03-15 12:04:27 +02:00
Efi Fogel 40646af54e Added missing const to some traits operators 2025-02-18 17:40:01 +02:00
Efi Fogel 39192337bd Fixed extending DCEL records for arrangements with history (and similar derivations of Arrangement_2). 2025-01-22 12:43:33 +02:00
Efi Fogel 5706cbd85f Cleaned up 2025-01-22 12:43:19 +02:00
Efi Fogel 19954c5d73 Fixed compiler complain about missing return value 2025-01-22 12:37:35 +02:00
Efi Fogel 669d83b469 Merge branch 'master' into Aos_2-traits_concept-efif 2025-01-21 21:30:42 +02:00
Sebastien Loriot 76321c4be1
Aos 2 fixes efif (#8666)
## Fixed the Landmark point-location strategy of the Aos_2 package, so
that it can be applied to arrangements on a sphere.

The title says it all.
I slightly changed one paragraph in the user manual. 
Here is the new version:

The arrangement attached to the landmark strategy must be either (i) an
instance of the `Arrangement_2]<Geom,Dcel>` class template, where the
`Traits` parameter is substituted by a geometry-traits class that models
the `ArrangementLandmarkTraits_2` concept, or (ii) an instance of the
`Arrangement_on_surface_2<GeomTraits,TopolTraits>` class template, where
the `GeometryTraits` is similarly substituted; see Section The Landmark
Concept for details about this concept.

## Release Management

* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): NA
* Feature/Small Feature (if any): NA
* Link to compiled documentation: Changed one paragraph; see above.
* License and copyright ownership: TAU
2025-01-20 10:05:42 +01:00
Efi Fogel f6b935401e Further pacify msvc; replaced auto with actual type (Inner_ccb_const_iterator) 2025-01-16 19:05:22 +02:00
Efi Fogel de7c24ad03 Pacify msvc; replaced auto with actual type (Isolated_vertex_const_iterator) 2025-01-09 20:34:12 +02:00
Efi Fogel df1179889c Made the Base type public and fixed the Approximate_2 operator that operates on x-monotone curves 2024-12-30 00:57:16 +02:00
albert-github 18de530a00 Add missing closing grouping commands
For consistency also updated Arrangement_on_surface_2/include/CGAL/Arr_conic_traits_2.h
2024-12-26 11:06:24 +01:00
albert-github aaa6adb7c1 In a number of cases the command `@{` (or `\{`) is not closed by a corresponding closing command (`@}`). For the `\=name` command this is apparently not necessary but it is better to have corresponding open and close commands.
(also corrected a split in a line that I noticed in Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/Arr_conic_traits_2.h)
2024-12-25 15:09:57 +01:00
Efi Fogel 98b1fd8063 Removed erroneous and useless construct 2024-12-18 17:25:02 +02:00
Efi Fogel 8570eb2cfa Merge branch 'master' into Aos_2-fixes-efif 2024-12-17 21:48:30 +02:00
Sébastien Loriot b32558b87e Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2024-12-16 11:47:34 +01:00
albert-github ad4c681782 Spelling correction
Spelling correction
2024-12-04 14:19:02 +01:00
Efi Fogel 54a05c2a1f Fixed for arrangement on sphere; cleaned up. 2024-11-16 22:12:56 +02:00
Efi Fogel 8e5b107abc Specifically used "unsigned long long" to store the flags. 2024-11-14 12:08:46 +02:00
Efi Fogel ddeaeb497a Cleaned up 2024-11-13 18:35:18 +02:00
Efi Fogel 462532edab Fixed tense on manual of functions 2024-11-13 03:51:10 +02:00
Efi Fogel 85667b524d Fixed typo 2024-11-13 03:25:54 +02:00
Efi Fogel 7819ffa00b Merge branch 'Aos_2-metadata_traits_decorators-efif' of github.com:efifogel/cgal into Aos_2-metadata_traits_decorators-efif 2024-11-12 15:31:11 +02:00
Efi Fogel f9213fafdd Basic fixes 2024-11-12 15:30:50 +02:00
Sébastien Loriot 982ca628e2 remove tabs 2024-11-12 13:57:53 +01:00
Efi Fogel 661b7185f1 Fixed comments: added code-escape and latex-escape symbols. 2024-11-10 12:31:22 +02:00
Efi Fogel bb16c9b1e8 Fixed typos (pointed out by Sebstien) 2024-11-07 19:21:40 +02:00
Efi Fogel 5a672aadbc Fixed return type 2024-11-06 17:29:21 +02:00
Efi Fogel c9f343eb50 Merge branch 'master' into Aos_2-metadata_traits_decorators-efif 2024-11-06 17:29:09 +02:00
Sébastien Loriot 3d2d1782cd Merge remote-tracking branch 'cgal/6.0.x-branch' 2024-11-05 17:09:53 +01:00
Sebastien Loriot 317700680e
Fixed the code that computes intersection (#8525)
Fixed the code that computes intersections in the polycurve traits
(Arr_polycurve_traits_2).

## Summary of Changes

The code of the Intersection_2 functor was developed from scratch.
The old code only supported polylines (by mistake), that is, chains of
segments.
The new code supports intersections of chains of any type of sub-curves.
It turns out that the new code is ~15% more efficient.
While at it, I replaced 'typedef' statements with modern 'using'
statements.

## Release Management

Apparently, there is no "CHANGES.md" file yet for 6.1, so I'll add an
entry that informs about this fix after it is introduced (to 'master'
and 'master' is merged to this branch.)

* Affected package(s): Arrangement_on_surface_2
* Issue(s) solved (if any): fix #8468
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership: TAU
2024-11-05 17:09:09 +01:00
Sébastien Loriot b10841c72b Merge pull request #8532 from afabri/CGAL-duplicateLines-GF
Duplicate Lines
2024-10-21 19:18:02 +02:00
Sébastien Loriot 7c4badc67c Merge pull request #8501 from afabri/CGAL-assert-GF
assert() ->  CGAL::assertion()
2024-10-21 19:17:21 +02:00
Sébastien Loriot ba70570ba4 Merge pull request #8492 from afabri/AoS-mix_pre_post_conditions-GF
Arrangements:  Unify mix of pre and post condition macros
2024-10-21 19:15:57 +02:00
Sébastien Loriot 1937666efe Merge pull request #8477 from efifogel/Aos_2-polygeodesic-efif
Poly-geodesic arc Handling
2024-10-18 18:01:20 +02:00
Sebastien Loriot ef659a464b
fix typo
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2024-10-15 09:29:48 +02:00
Sven Oesau a06002ab2b Merge remote-tracking branch 'cgal/master' into gsoc2022-isosurface 2024-10-14 14:42:46 +02:00
Andreas Fabri 2e4cff1586 Change _check_pt_arcno_and_coprimality(q, -1, c); 2024-10-09 17:17:26 +01:00
Efi Fogel a1a29ee05e Added a comment 2024-10-08 10:59:17 +03:00
Efi Fogel aab1897b7d Fixed the code that computes intersection 2024-10-07 17:38:19 +03:00