Commit Graph

2446 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 984a541006 Fix usages of 'th `th 2024-01-23 21:50:04 +01:00
Efi Fogel 6d0e371848 Merge branch 'master' into Aos_2-fixes-efif 2024-01-15 15:50:23 +02:00
Guillaume Damiand 3bc56024d3 Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2024-01-11 14:08:05 +01:00
Efi Fogel 8a886ea334 Merge branch 'master' into Aos_2-fixes-efif 2024-01-08 18:30:43 +02:00
Efi Fogel 13b22abd4f Merge branch 'master' into gsoc2023-aos_sphere_demo-denizdiktas 2024-01-08 16:27:52 +02:00
Sébastien Loriot c35a1b15d1 add missing license include directives 2024-01-04 13:45:39 +01:00
Sébastien Loriot e7c26349f2 move header in a package to GPL 2024-01-04 13:36:34 +01:00
Guillaume Damiand d3bbe0dd70 cast in two steps 2023-12-28 09:04:12 +01:00
Guillaume Damiand ca296d548a the cast must be into std::size_t 2023-12-28 08:46:59 +01:00
Sebastien Loriot e3249bd908 fix warning 2023-12-27 13:58:36 +01:00
Sebastien Loriot caecbe29c7
Replace boost::mpl (#7813)
- `boost::mpl::if_` --> `std::conditional`
- `boost::enable_if` -> `std::enable_if`
- `boost::mpl::and_` -> `&&`
- `boost::mpl::or_` -> `||`
- `boost::constant::bool_` -> `std::bool_constant`
- ...
2023-12-26 17:33:36 +01:00
Efi Fogel 6b90164b55 Fixed the types used in all arrangement observers 2023-12-20 22:09:34 +02:00
Efi Fogel c6a21e9f98 Fixed the definition of the memebrs before_assign(arr) before_attach(arr) of all observers (derived from Aos_observer) 2023-12-14 21:17:29 +02:00
Efi Fogel 615850c4a6 Cleaned up 2023-12-13 13:41:51 +02:00
Efi Fogel 92e2a7da2d Eliminated the error-prone c-style casting of the arrangement that occurs when using observers; renamed Arr_observer => Aos_observer, and introduced Arr_observer for backward compatibility. 2023-12-12 02:54:19 +02:00
Efi Fogel 5544ff4893 Eliminated the error-prone c-style casting of the arrangement object that occurs when using observers. 2023-12-12 01:50:26 +02:00
Efi Fogel 1e4e614975 Merge branch 'Aos_2-fixes-efif' of github.com:efifogel/cgal into Aos_2-fixes-efif 2023-12-11 13:24:01 +02:00
Guillaume Damiand f8364752e0 draw arrangement: use gs_options 2023-12-04 18:05:40 +01:00
Guillaume Damiand 046fa81d68 draw arrangement 2023-12-04 16:59:46 +01:00
Sébastien Loriot 30bdbab524 fix warnings 2023-11-27 13:20:38 +01:00
Efi Fogel aefededa4b Made Curve_halfedges public, as we enable iterating over such types 2023-11-21 17:27:39 +02:00
Efi Fogel 826f60c4be Introduced Arr_dcel and fixed Arr_default_dcel 2023-11-15 18:54:21 +02:00
Sébastien Loriot 2f104a6f76 replace boost::mpl::not_ 2023-11-10 16:38:24 +01:00
Sébastien Loriot 4344c3cc27 replace boost::mpl::or_ 2023-11-10 16:34:19 +01:00
Sébastien Loriot 2277013d84 replace boost::mpl::and_ 2023-11-10 16:19:26 +01:00
Efi Fogel a850c34460 Fixed Are_mergable_2 functor; add code that tests whether the equal operator (operator==) is applicable to the data that extends the curve 2023-11-09 15:09:19 +02:00
Sébastien Loriot 3176178224 fix compilation issues 2023-11-06 11:43:29 +01:00
Efi Fogel 51500440ea Added missing 'conct' qualifier 2023-11-01 18:13:11 +02:00
Guillaume Damiand 126b9360c9 Remove _qt from Basic viewer name 2023-10-24 08:27:18 +02:00
Efi Fogel 2e32820dd3 ixed parameter types if interface functions 2023-10-23 16:07:57 +03:00
Guillaume Damiand 1c6b1e4a12 Basic_viewer_qt is no more templated 2023-10-23 01:35:11 +02:00
Guillaume Damiand 6daa2a0c3b Graphics_scene is no more templated 2023-10-23 01:30:57 +02:00
Guillaume Damiand cbe7ef2b40 Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2023-10-22 17:18:04 +02:00
Guillaume Damiand a5ee74cb66 Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2023-09-29 08:36:37 +02:00
Guillaume Damiand 9f22d67ed0 Rename Graphic_storage in Graphics_scene (Andreas and Sebastien review) 2023-09-28 12:49:00 +02:00
Guillaume Damiand fd115bd321 Rename Graphic_storare into Graphics_scene (Andreas and Sebastien review) 2023-09-28 11:06:53 +02:00
Laurent Rineau 1d29a75c9a iformat/oformat are in CGAL::IO
The calls without the `IO::` namespace are deprecated.
2023-09-25 16:09:41 +02:00
Sébastien Loriot 8700394122 boost::mpl::if_ -> std::conditional 2023-09-24 22:57:20 +02:00
Efi Fogel 5df7ed208d Merge branch 'master' into gsoc2023-aos_sphere_demo-denizdiktas 2023-09-20 12:46:33 +03:00
Laurent Rineau aa09a28df8 Merge remote-tracking branch 'cgal/master' into STL_extension-Fix_Prevent_deref-GF 2023-09-19 16:22:49 +02:00
Efi Fogel 12c8decd21 Merge remote-tracking branch 'cgal/master' into gsoc2023-aos_sphere_demo-denizdiktas 2023-08-30 15:57:19 +03:00
Efi Fogel ea46c6f282 Pacify msvc17: explicitly name the (non-const) iterator type 2023-08-28 16:24:03 +03:00
Guillaume Damiand 467e55f10d Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2023-08-28 14:38:58 +02:00
Efi Fogel aba2d147f8 Merge remote-tracking branch 'cgal/master' into Aos_2-fixes-efif 2023-08-22 13:41:57 +03:00
Efi Fogel 51fc8aa18d Removed unused variable 2023-08-18 13:38:34 +03:00
Efi Fogel de459faa76 Fixed the Approximate_2::operator() that returns a sequence of points that approximate a curve; in particular, respected the l2r parameter. 2023-08-18 13:35:00 +03:00
Efi Fogel 7b00717eab Fixed comment 2023-08-18 12:49:32 +03:00
Sébastien Loriot d6c04e3b8a do not use ref wrapper 2023-08-16 09:17:58 +02:00
Sébastien Loriot f1f6126f1c add missing IO namespace 2023-08-16 09:11:30 +02:00
Sébastien Loriot eada3ee8ca Merge branch 'master' into 'sloriot/CGAL-using_c++17_stl' 2023-08-14 14:19:25 +02:00
Efi Fogel 0762a30400 Fixed is_intersection_valid_impl() and added test case 2023-08-10 21:38:52 +03:00
Efi Fogel ada39fdfae Cleaned up and dispatched is_intersection_valid_impl() properly 2023-08-09 19:10:16 +03:00
Efi Fogel afa58a9426 Cleaned up 2023-08-09 17:46:35 +03:00
Efi Fogel 46c4246570 Cleaned up 2023-08-09 17:37:01 +03:00
Efi Fogel a9625eb17c Enhanced drawing---added support for arrangement on spheres indiced by geodesic arcs 2023-08-09 14:03:14 +03:00
Efi Fogel 6b62d1d9b4 Introduced is_intersection_valid() to check the validity of a new intersection point. Perhaps, a similar fix is required for validity of overlapping intersections 2023-08-09 10:48:54 +03:00
Sébastien Loriot 6b24eed462 try resolving ambiguity 2023-08-09 08:46:34 +02:00
Sébastien Loriot 3cef94d401 make the output iterator movable
restore changes in Arr_polycurve_traits_2
2023-08-04 22:12:58 +02:00
Sébastien Loriot 89fd91e354 fix argt demo
changes in Arrangement_on_surface_2/include/CGAL/Arr_polycurve_traits_2.h
should be undo
2023-08-04 16:57:13 +02:00
albert-github 40c7765ffb Spelling corrections
Corrections based on review
2023-07-30 17:54:10 +02:00
albert-github 1cce66c343 Spelling corrections
Spelling corrections `a e...` -> `an e...`
2023-07-30 12:59:17 +02:00
Laurent Rineau 4a2c7a668d Merge pull request #7571 from albert-github/feature/issue_7454
issue #7454 Consistency of BigO notations
2023-07-12 15:29:56 +02:00
Sébastien Loriot b66afab814 Merge remote-tracking branch 'sloriot/CGAL-using_c++17_stl' into HEAD 2023-07-05 11:29:35 +02:00
albert-github b3af96caa1 issue #7454 Consistency of BigO notations
Create `cgalBigO` marco and used it.
(`The macro `cgalBigOLarge` is for special situations where we need bigger round brackets)
2023-07-04 16:23:14 +02:00
Sébastien Loriot a32483d885 use iformat 2023-06-29 18:09:18 +02:00
Sébastien Loriot d91d010ee7 add missing includes 2023-06-29 18:07:48 +02:00
Sébastien Loriot e759fb46fa remove usage of old Object API 2023-06-29 12:57:53 +02:00
Sébastien Loriot f8323e7df8 use std API 2023-06-29 10:52:25 +02:00
Sébastien Loriot 9526dc8661 use oformat 2023-06-29 10:49:26 +02:00
Andreas Fabri 5e0e0216ff Remove blank in front of point ending a comment 2023-06-28 12:48:48 +01:00
Guillaume Damiand fe23441eab Merge master 2023-06-26 14:42:33 +02:00
Sébastien Loriot dfc386d65b Merge branch 'master' into HEAD 2023-06-22 14:05:45 +02:00
Sébastien Loriot fb2f2c6642 remove Object from Minkowski_sum_2 2023-06-20 19:11:00 +02:00
Sébastien Loriot 76f16d7c38 use std::get_if, get()->value() and remove CGAL::Object usage in Envelope
changes in arrangement based packages
2023-06-20 18:32:13 +02:00
Sébastien Loriot 0ee31a5d4f remove extra parenthesis 2023-06-19 19:17:49 +02:00
Sébastien Loriot f936680600 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 18:48:39 +02:00
Sébastien Loriot f240a47451 boost::get -> std::get_if 2023-06-15 11:34:14 +02:00
Sébastien Loriot cb840ac84b boost::optional::get -> std::optional::value 2023-06-15 11:34:14 +02:00
Sébastien Loriot 9cdfe70abb Merge remote-tracking branch 'sloriot/CGAL-toward_6.0' 2023-06-15 11:34:09 +02:00
Sébastien Loriot edc317d771 variant::which() => variant::index() + typos 2023-06-15 10:57:10 +02:00
Sébastien Loriot 9a0bdb5d96 boost::variant ---> std::variant 2023-06-15 10:57:10 +02:00
Sébastien Loriot 604dcdc435 boost::optional => std::optional 2023-06-15 10:57:09 +02:00
Sébastien Loriot bbc4d08ee0 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 10:47:07 +02:00
Sébastien Loriot c8a88b9014 remove CGAL_static_assertion* 2023-06-15 10:42:10 +02:00
Efi Fogel 7ffda351d2 reverted back commented out statement 2023-06-11 17:36:59 +03:00
Efi Fogel ce02ab6632 Added support for drawing an arrangement on a sphere induced by geodesic arcs 2023-06-07 11:41:56 +03:00
Efi Fogel 3ade612d49 Merge branch 'gsoc2023-aos_sphere_demo-denizdiktas' of github.com:CGAL/cgal-public-dev into gsoc2023-aos_sphere_demo-denizdiktas 2023-06-03 15:43:55 +03:00
denizdiktas 81d4592766 style corrections 2023-06-02 12:24:21 +03:00
Efi Fogel 0477dfe2f3 Removed unnecessary (actually erroneous) member function definitions 2023-06-02 11:15:06 +03:00
denizdiktas 34b9a7d356 Removed std::vector from the algorithm, now outputting the approximation points directly to the output iterator. 2023-06-01 13:09:41 +03:00
denizdiktas fc9c993a23 Added std:: in front of math functions 2023-06-01 11:39:43 +03:00
denizdiktas 7a447d661a Code clean-up and style corrections 2023-06-01 11:33:58 +03:00
denizdiktas 01e6057017 Fixed approximation of arcs with theta>PI: atan2 was returning negative value, so I added 2*PI to make it in the range [0,2*PI) 2023-05-30 17:44:25 +03:00
denizdiktas 910e0437a0 changed the error type in the approximation function from double to Approximate_number_type 2023-05-30 15:40:31 +03:00
denizdiktas a079b5d572 Initial implementation of the approximation-function inside Approximate_2 2023-05-30 15:33:54 +03:00
Efi Fogel 2159476dc4 Fixed Approxinate_2::operator()(const Point_2&) 2023-05-29 17:44:16 +03:00
Efi Fogel facc5926e6 Fixed dependencies. (Moved Arr_extended_direction_3 definition to the front.) 2023-05-27 22:54:43 +03:00
Efi Fogel 9720911727 Ops (Approximate_point_2) 2023-05-26 18:33:25 +03:00
Efi Fogel f9b9591f04 Fixed some approximate operators 2023-05-26 18:32:12 +03:00
Laurent Rineau 9bafd13b00 Merge pull request #6721 from efifogel/Aos_2-conics-efif
Resurect The Conic Traits
2023-05-11 16:55:35 +02:00
Efi Fogel c1c1a51b6a Merge branch 'Aos_2-conics-efif' into gsoc2023-aos_sphere_demo-denizdiktas 2023-05-10 11:55:41 +03:00
Sébastien Loriot 1c277cdb06 fix warnings 2023-05-09 18:38:16 +02:00
Efi Fogel 92bc3de2de Fixed Approximate_2 for the geodesic traits. Fixed unused formal variables. 2023-05-05 18:43:10 +03:00
Efi Fogel 141731ec79 Fixed Approximate_2 2023-05-02 09:58:18 +03:00
Sébastien Loriot c1294a0eaa boost::integral_constant ---> std::integral_constant 2023-04-29 09:42:15 +02:00
Efi Fogel f6db4a6d94 Fixed argument to draw_point_imp1() 2023-04-27 14:02:29 +03:00
Efi Fogel ef7b62119b Add member operator() to Approximate() for point and segment approximation and used it to remove the compile-time-dispatching all together in the drawing function 2023-04-27 13:31:10 +03:00
Efi Fogel 3f65c37eda Implemented and alternative for compile time dispatching, which might work with MSVC 14. 2023-04-26 19:32:43 +03:00
Sébastien Loriot b039040f73 boost::is_convertible -> std::is_convertible 2023-04-23 22:37:07 +02:00
Sébastien Loriot a88af6c0c6 boost::array -> std::array 2023-04-23 22:37:07 +02:00
Sébastien Loriot 8b3acae1c7 boost::remove_reference -> std::remove_reference 2023-04-23 22:36:59 +02:00
Laurent Rineau ae3e2b6287 Merge pull request #7323 from efifogel/Aos_2-fixes-efif
Arrangement_on_surface_2 fixes
2023-03-31 11:10:52 +02:00
Andreas Fabri ef54ecb82c Fix Minkowski_sum_2 2023-03-22 15:28:15 +01:00
Efi Fogel 204cf9f815 Commented out unused variables 2023-03-21 09:58:28 +02:00
Efi Fogel eff6474fcf Added a parameter pack to the constructor and passed it to the underlying traits; disabled copy constructor. 2023-03-14 14:21:46 +01:00
Efi Fogel 22d35af320 Replaced copy-constructor of traits with simple conversion 2023-03-14 14:21:46 +01:00
Efi Fogel 11de0a7c79 Properly set the data of extended records using setters (set_data()) 2023-03-14 14:21:46 +01:00
Efi Fogel 6699397eb5 Added a parameter pack to the constructor and passed it to the underlying traits; Called are_mergeable_2 only if the base supports it. 2023-03-14 14:21:45 +01:00
Efi Fogel ec15089353 Fixed handling unbounded curves that are both infinite on the left and infinite at the top 2023-03-14 14:21:45 +01:00
Andreas Fabri 1c00c6490e Fix arrangement demo 2023-03-10 14:41:30 +00:00
Andreas Fabri a714a6f5db Fix Surface_sweep 2023-03-07 12:56:46 +00:00
Efi Fogel 2a8100bff6 Removed unused variables; Fixed color_generator parameter passing; pacified msvc 2023-02-22 14:49:49 +02:00
Efi Fogel b0b080e65e Replaced use of boost::hana with c++14 features to implement compile-time dispatching 2023-02-15 18:40:04 +02:00
Efi Fogel ccdb5a0b54 Merge remote-tracking branch 'cgal/master' into Aos_2-conics-efif 2023-02-15 14:36:44 +02:00
Andreas Fabri 50621a4258 reactivate code 2023-02-10 08:23:53 +00:00
Efi Fogel 6705b15fdb Added color generator; improved internal API 2023-02-09 01:03:33 +02:00
Andreas Fabri 2184d22c52 WIP [scip ci] 2023-02-07 21:18:31 +00:00
Andreas Fabri fb71e3937e Add numerator() and denominator() 2023-02-07 15:42:49 +00:00
albert-github 0ea013ea12 Spelling corrections
Some spelling corrections.
2023-02-03 12:07:03 +01:00
Sebastien Loriot 384377eda3
typo 2023-01-17 10:02:22 +01:00
albert-github 9c2f8ff60e Spelling correction in respect to function / variable names
As indicated in #7041 (Spelling corrections) theer were still some open corrections in respect to variables / functions, these have been addressed heer.
2023-01-13 18:51:28 +01:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Laurent Rineau 67b5c791e9 Merge pull request #7075 from MaelRL/CGAL-Fix_some_links-GF
Update some links + https
2022-12-05 12:22:06 +01:00
Mael Rouxel-Labbé b5c21e1f5d Http -> https + update some dead links 2022-11-23 18:54:37 +01:00
albert-github 9d709b12e5 spelling corrections
After review
2022-11-21 10:40:28 +01:00
albert-github 781f9a2943 spelling corrections
After review:
- outputhing -> outputting
- neighbour -> neighbor
2022-11-17 10:25:10 +01:00
albert-github 3674c937f7 spelling corrections
Some spelling corrections (Directories starting with `M`-` N`),
some backward work
some forward work
2022-11-15 15:21:01 +01:00
albert-github 45478184de spelling corrections
Some spelling corrections (Directories starting with `E`-` L`),
some backward work
some forward work
2022-11-15 13:39:40 +01:00
albert-github 014c06fd19 spelling corrections
Some spelling corrections (Directories starting with `A`)
2022-11-14 15:32:47 +01:00
Efi Fogel 9d905ec276 Merge remote-tracking branch 'cgal/master' into Aos_2-fixes-efif 2022-11-02 22:27:17 +02:00
Efi Fogel 03285a42cf Replaced std::uniform_int_distribution<unsigned char> with std::uniform_int_distribution<int> to pacify MSVC 2022-10-19 01:30:38 +03:00
Sébastien Loriot 215b2ea5c4 add missing config include 2022-10-18 18:06:29 +02:00
Sébastien Loriot ade16fc7d7 fix warnings 2022-10-17 14:12:41 +02:00
Sébastien Loriot b6bdac2847 add workaround to use boost hana with MSVC 2022-10-17 11:23:22 +02:00
Sébastien Loriot e1c7254ffb fix conversion warnings 2022-10-17 10:30:42 +02:00
Sébastien Loriot d8fb80551c fix warnings 2022-10-13 13:48:16 +02:00
Sébastien Loriot 8ab29c50b2 fix header 2022-10-13 13:42:10 +02:00
Efi Fogel 2639ef203f Used CGAL_PI 2022-09-28 12:20:25 +03:00
Efi Fogel c01b6b95ee Used boost::math::constants::pi<double>() instead of M_PI macro. 2022-09-28 11:19:16 +03:00
Efi Fogel fb36bde045 Declared an isolated-vertex iterator to pacify MSVC. Without it the implicit conversion from the iterator to the corresponding handle fails! 2022-09-28 10:59:25 +03:00