Commit Graph

1831 Commits

Author SHA1 Message Date
Andreas Fabri 404cf8f0c2 Projection_traits_xy_3: Enable structural filtering 2023-01-09 11:13:29 +00:00
Mael Rouxel-Labbé e6226e9fa3 Fix links to CGAL::Null_vector 2023-01-09 11:07:12 +01:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Mael 6538b22e06
Merge branch 'master' into CGAL-Clean_CMakeLists.txt-GF 2022-12-05 16:03:41 +01:00
Laurent Rineau e8ec440859 Merge branch 'master' into Kernel-Compare_distance_3_RT_FT__always_Filtered_predicate_RT_FT-GF
# Conflicts:
#	STL_Extension/doc/STL_Extension/CGAL/Concurrent_compact_container.h
2022-12-05 14:51:31 +01:00
Laurent Rineau 861ce1deed Merge pull request #7078 from MaelRL/Kernel_23-Fix_missing_CP3_overload-GF
Fix the Kernel concept being weaker than TriangulationTraits_23 requirements
2022-12-05 12:22:01 +01:00
Laurent Rineau 802d648f04 Merge pull request #7078 from MaelRL/Kernel_23-Fix_missing_CP3_overload-GF
Fix the Kernel concept being weaker than TriangulationTraits_23 requirements
2022-12-05 11:57:14 +01:00
Mael da0b13699c
Merge branch 'master' into Kernel-Compare_distance_3_RT_FT__always_Filtered_predicate_RT_FT-GF 2022-12-02 23:19:29 +01:00
Mael 2b44e11fb5
Apply suggestions from @albert-github & @afabri 2022-11-24 13:10:22 +01:00
Mael Rouxel-Labbé 3b640e5e0a Fix the Kernel concept being weaker than TriangulationTraits_23 requirements 2022-11-23 21:30:31 +01:00
Laurent Rineau bf114a4509 Remove CGAL_EPICK_SINGLE_PRECISION 2022-11-22 16:13:35 +01:00
Mael Rouxel-Labbé 4bb2d13272 Rephrase comment 2022-11-22 12:36:07 +01:00
albert-github 45478184de spelling corrections
Some spelling corrections (Directories starting with `E`-` L`),
some backward work
some forward work
2022-11-15 13:39:40 +01:00
Laurent Rineau fa83872f81 Remove the trailing white space I added by error 2022-11-08 16:02:17 +01:00
Laurent Rineau a6050f4bb3 Fix the comment 2022-11-08 15:57:53 +01:00
Laurent Rineau 7d250c5a2c Fix the testsuite for Homogenous 2022-11-08 15:18:31 +01:00
Laurent Rineau 92d8d1c805 Merge remote-tracking branch 'cgal/master' into CGAL-allow_Epick_with_float-GF
# Conflicts:
#	Mesh_3/test/Mesh_3/test_meshing_3D_image.cpp
2022-11-08 12:11:06 +01:00
Laurent Rineau 51a5ce0c44 Test Simple_precision_epick
... and adapt the code of the testsuite. In particular, there are lots
of cases of inexact constructions that are compared to exact results.
2022-11-08 12:08:58 +01:00
Laurent Rineau 3933d0bec8 Fix a 16 years old todo
Sylvain Pion, wrote in August 2006:
> FIXME : Use Qrt<> here

At that time `Qrt` stood for `Qualified_result_of` (sic, maybe it was
named "qualified result type" at a time).

Now that we can use C++14, we have `decltype(auto)` instead.
2022-11-08 12:07:14 +01:00
Laurent Rineau 3600173ed4 Missing includes, for users of Epick
(even if those headers are probably already included elsewhere)
2022-11-08 12:01:44 +01:00
Laurent Rineau b56a79eacf Compute_[abcd]_[23] return references
That simplifies the code, and is more correct.
2022-11-08 11:06:44 +01:00
Laurent Rineau cb0ad7f509 Use template aliases to factorize code 2022-11-08 11:04:38 +01:00
Laurent Rineau 21f60772a1 Do not enable CGAL_KERNEL_23_TEST_RT_FT_PREDICATE_FLAGS by default 2022-11-07 15:46:13 +01:00
Laurent Rineau 2b41ebaaaa Remove last remnant of C++17 if constexpr 2022-11-07 15:45:58 +01:00
Laurent Rineau 1c5454dcbe Add Converting_construction to Simple_precision_epick
The difficulty is to detect/define which constructions are "trivial"
and must not be wrapped into `Converting_construction`. Otherwise the
use of `Cartesian_converter`, that uses trivial constructions itself,
can lead to loops and infinite call stacks.
2022-10-28 12:07:58 +02:00
Laurent Rineau c685810119 Add Construct_point_on_3(Line_3), for efficiency 2022-10-28 12:07:58 +02:00
Sébastien Loriot 0cac6a9da8 Merge remote-tracking branch 'sloriot/PMP-decimation' into PMP-decimation 2022-10-25 14:55:57 +02:00
Laurent Rineau a46a6db2bb Allow to use test_RT_or_FT_predicates with ninja, and ctest 2022-10-14 12:15:48 +02:00
Mael Rouxel-Labbé f83b970461 Add a comment explaining the purpose of atomic_compilation_test.cpp 2022-10-13 21:24:05 +02:00
Laurent Rineau 3745073df6 Fix a compilation error 2022-10-13 18:25:58 +02:00
Mael Rouxel-Labbé 73de5e49f4 Remove unnecessary include 2022-10-12 21:32:30 +02:00
Mael Rouxel-Labbé 296d9e5cc0 Update RTFT test 2022-10-12 21:28:40 +02:00
Mael Rouxel-Labbé 2c23a6d5c5 Revert back to wrapping result_type to distinguish FT-necessary operator()s 2022-10-12 21:24:59 +02:00
Laurent Rineau 026049cf8e Switch to Epick-with-float using a new macro
If  `CGAL_EPICK_SINGLE_PRECISION` is defined, then the number type
of `CGAL::Epick` is `float` instead of `double`.
2022-10-10 16:15:01 +02:00
Laurent Rineau 0e823324c9 Allow to use an Epick-like kernel with float as FT 2022-10-10 15:49:17 +02:00
Sven Oesau 2c9b5ed528 more tests only for exact kernels in Kernel_23 2022-10-01 16:07:03 +02:00
albert-github 680e144ad1 issue 6891 Kernel_23: inconsistent documentation
Made preconditions in the C++ form.
2022-09-29 18:08:53 +02:00
Laurent Rineau 9d40a225ff
Update Kernel_23/test/Kernel_23/Filtered_cartesian.cpp 2022-09-23 15:32:52 +02:00
Andreas Fabri d3fca65ae5 CGAL: No longer per package assertions 2022-09-23 12:49:40 +01:00
Mael Rouxel-Labbé f417495a0e Handle deleted functions in RT/FT test 2022-09-23 11:35:29 +02:00
Mael Rouxel-Labbé d0fe75e908 Add missing FT_necessary tags 2022-09-23 11:35:12 +02:00
Mael Rouxel-Labbé ae30bcf819 Remove obsolete RT/FT tests 2022-09-22 12:25:25 +02:00
Mael Rouxel-Labbé c93e33c731 Misc minor cleaning/improvements to RT|FT kernel test 2022-09-22 12:06:09 +02:00
Mael Rouxel-Labbé 873cc884b5 Get rid of _RT / _RT_FT kernel interface macros 2022-09-22 12:03:25 +02:00
Mael Rouxel-Labbé 214e072959 Switch from RT_sufficient to FT_necessary 2022-09-22 12:02:53 +02:00
Mael Rouxel-Labbé 01af5bce52 Add an automatic test to detect correct presence/absence of RT_sufficient 2022-09-21 15:03:09 +02:00
Laurent Rineau 04a7b31a07 WIP: test one predicate with a set of arguments with RT 2022-09-15 16:06:28 +02:00
Laurent Rineau a267cee598 Avoid one intermediate call to the global (non-internal) function 2022-09-15 16:05:35 +02:00
Laurent Rineau 36c0a779d7 WIP: how to detect the arity of a predicate 2022-09-14 15:10:49 +02:00
Laurent Rineau f52298a8c5 WIP: try to always use Filtered_predicate_RT_FT 2022-09-08 17:30:14 +02:00
Laurent Rineau 03b1501508 Merge branch 'Kernel-Compare_distance_3_RT_FT-GF' into Kernel-Compare_distance_3_RT_FT__new_proposal-GF 2022-09-07 14:49:45 +02:00
Laurent Rineau dcca65b740 Spelling typo 2022-09-07 14:48:45 +02:00
Laurent Rineau 4b660d9ec9 Another proposal for Filtered_predicate_RT_FT
Instead of having the return type wrapped in a `Needs_FT` tag,
not the call operator overloads that can be called with `RT` are
"tagged" by adding a last argument of type `RT_sufficient` with a
default value.
2022-09-07 11:10:13 +02:00
Mael Rouxel-Labbé 9b265fddf8 Uniformize REQUIRED / QUIET usage:
Following this:
- CGAL: always REQUIRED
- CGAL component: COMPONENT / OPTIONAL_COMPONENT (never QUIET)
- required 3rd party: (not QUIET) + message(NOTICE "") on NOT_FOUND
- optional 3rd party: QUIET + message(STATUS "") except for Polyhedron/demo
- 3rd party components: COMPONENT / OPTIONAL_COMPONENT
                        (QUIET depending on required or optional 3rd party)
2022-09-06 16:24:27 +02:00
Laurent Rineau 7c92341be7 Introduce CGAL_Kernel_pred_RT_or_FT
This commit introduces a new kind of predicate in
`<CGAL/Kernel/interface_macros.h>`. In addition to
  - `CGAL_kernel_pred` for predicates,
  - `CGAL_Kernel_pred_RT` for predicates that can be implemented using a
    ring-type,

now there is also:
  - `CGAL_Kernel_pred_RT_or_FT` for predicates with multiple overloads of
    `operator()`, some needing a field type and other needing a ring type
    (without the division operator).

The C++ code can discriminate between the two cases with a special wrapper
for the return type: `CGAL::Needs_FT<result_type` instead of `result_type`
(defined in `<CGAL/tags.h>`.

In `<CGAL/Filtered_predicate.h>`, in addition to the usual class template
 `Filtered_predicate`, there is now also `Filtered_predicate_RT_FT` that
 takes three predicates as template parameters instead of two:
  - the exact predicate with an ring-type,
  - the exact predicate with a field-type,
  - the approximate predicate (with `Interval_nt` as number-type).

For the moment, only `Compare_distance_3` in
`<CGAL/Cartesian/function_objects.h>` is using the new
`Filtered_predicate_RT_FT`.

Before this commit, the file
`Kernel_23/test/Kernel_23/include/CGAL/_test_new_3.h` was testing
`Compare_distance_3` only with three points or for points. This commit adds:
  - a test with `Point_3, Point_3, Segment_3`, and
  - a test with `Line_3, Point_3, Point_3`, that actually needs a field type
    with its current implementation.

In the test `Kernel_23/test/Kernel_23/Filtered_cartesian.cpp`, the macro
`CGAL_NO_MPZF_DIVISION_OPERATOR` is defined, to remove the division operator
from `CGAL::Mpzf`. `CGAL::Mpzf` is a ring-type, even with its `operator/`
(because that `operator/` can only compute exact divisions), but with
`CGAL_NO_MPZF_DIVISION_OPERATOR` defined, that is now checked by the compiler.
2022-09-02 11:31:47 +02:00
Sébastien Loriot 861588abe1 Merge 'sloriot/CGAL-std_type_traits' into master 2022-08-03 20:19:51 +02:00
Sébastien Loriot 1e857506c1 Merge remote-tracking branch 'cgal/5.5.x-branch' 2022-07-12 18:22:02 +02:00
Sébastien Loriot 12795ba29c Merge remote-tracking branch 'cgal/5.4.x-branch' into HEAD 2022-07-12 18:21:16 +02:00
Sébastien Loriot 45b5fd43f8 fix more warnings 2022-07-12 18:18:34 +02:00
Mael Rouxel-Labbé d07434708a Merge remote-tracking branch 'cgal/master' into CH2-Fix_bykat-GF 2022-07-11 09:39:45 +02:00
Mael Rouxel-Labbé 384cddadec Fix some result_types in projection traits 2022-07-05 10:11:44 +02:00
Mael Rouxel-Labbé 711d64674a Less_signed_... --> Compare_signed_... in CH3 adapters 2022-07-02 17:19:48 +02:00
Laurent Rineau 561cc66264 Backport the patch of pull request #6602 from lrineau/Triangulation_2-fix_cdt_2-GF
Try to fix CDT_2 with inexact construction of intersections
2022-06-29 12:30:35 +02:00
Laurent Rineau e1195a4229 Make public Exact_kernel and related types 2022-06-17 16:37:56 +02:00
Sébastien Loriot 5872413f37 remove boost is_same headers 2022-06-10 08:48:53 +02:00
Sébastien Loriot 3fa436459d BOOST_MPL_ASSERT -> static_assert 2022-06-10 08:46:01 +02:00
Sébastien Loriot ac8b6d4731 boost::is_same --> std::is_same 2022-06-10 08:18:20 +02:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
Sébastien Loriot 47d6b3a240 add barycenter functor 2022-06-05 19:06:23 +02:00
Laurent Rineau 258dd55c03 Make it work with the projection traits 2022-06-02 16:17:26 +02:00
Laurent Rineau 575f7a42fe Move exact_intersection_point back to CT_2 2022-06-01 20:31:22 +02:00
Laurent Rineau ffe675423f Merge branch 'master' into Triangulation_2-fix_cdt_2-GF 2022-06-01 15:15:18 +02:00
Laurent Rineau 53b4878a94 Use exact FT instead of exact Kernel 2022-05-31 18:09:00 +02:00
Laurent Rineau feaf6a4ca2 Add Kernel::Construct_exact_intersection_point_2 2022-05-31 16:40:34 +02:00
Sébastien Loriot ebf9fb025a Merge remote-tracking branch 'cgal/5.4.x-branch' 2022-05-26 18:13:59 +02:00
Sébastien Loriot f29015ef1c please intel 2019 compiler 2022-05-25 00:22:24 +02:00
Sébastien Loriot 2b547ec58a Merge remote-tracking branch 'cgal/5.4.x-branch' 2022-05-13 17:26:04 +02:00
Sebastien Loriot 978d83a349
Merge pull request #6573 from sloriot/CGAL-pedantic_warnings
Fix pedantic warnings
2022-05-13 15:55:26 +02:00
Sebastien Loriot 269a391fa0
Merge pull request #6558 from lrineau/Installation-remove_wd4503-GF
CMake script updates: version of CMake and /wd4503 is only for MSVC 2015
2022-05-13 15:53:36 +02:00
Sebastien Loriot a9d03ba945
Merge pull request #6508 from albert-github/feature/bug_documentation_code
Documentation update in respect to code fragments
2022-05-13 15:49:24 +02:00
Sébastien Loriot 6486844750 fix pedantic warnings 2022-05-10 11:30:39 +02:00
Andreas Fabri 46d1aea329 Convex_hull_3: Use K::Boolean and not bool 2022-05-09 15:30:26 +01:00
Laurent Rineau 2288225448 Massive update of CMake policies to version 3.23 2022-05-06 09:34:35 +02:00
Laurent Rineau 97e99cbc22 Merge pull request #6487 from afabri/Filtered_kernel-fix_depth_bug-GF
Kernel_23: Fix depth() in Epeck
2022-04-27 16:32:08 +02:00
Laurent Rineau 288456950d Merge pull request #6488 from sloriot/ICC-workaround
Workaround issue with intel compiler
2022-04-27 16:32:06 +02:00
Laurent Rineau 1538fdbbbb Merge pull request #6488 from sloriot/ICC-workaround
Workaround issue with intel compiler
2022-04-27 16:30:53 +02:00
albert-github 461dba692d Documentation update in respect to code fragments
Update of documentation in respect of code fragments
- making code fragments work in footnotes
- placing some words in in code tags
- completing some words to code tags
- removing some `#` as they are not necessary
- don't show obfuscation code in email
2022-04-21 17:56:14 +02:00
Andreas Fabri 4b63716376 Add test file 2022-04-20 15:09:06 +01:00
Andreas Fabri 7dc7443e45 Add test of depth() 2022-04-20 12:48:28 +01:00
Sébastien Loriot cca0a1942f workaround issue with intel compiler
Cartesian_kernel/include/CGAL/Cartesian/Line_3.h(38): error: incomplete type is not allowed
      Point_3 first;
              ^
2022-04-12 16:14:39 +02:00
Andreas Fabri 9023aaa542 More code for ORIGIN 2022-04-07 10:39:01 +01:00
Laurent Rineau 9b39561825 Merge pull request #6399 from afabri/Kernel_23-overload_for_origin-GF
Kernel_23: Add Orientation_3::operator()(Origin,Point_3,Point_3,Point_3)
2022-03-30 09:23:32 +02:00
Sébastien Loriot 3a03201ff1 Merge pull request #6338 from MaelRL/PMP-Orient_PS_with_PS-GF
Add orient_triangle_soup_with_reference_triangle_soup()
2022-03-30 08:03:29 +02:00
Sébastien Loriot b9a14a447f Merge pull request #6426 from afabri/Kernel_23-Call_function_objects-GF
Kernel_23: Call function objects from CGAL::Segment_3
2022-03-29 17:47:06 +02:00
Sébastien Loriot 5e894656f5 Merge pull request #6422 from afabri/Nef_3-avoid_needless_tests-GF
Nef_3: Avoid needless tests
2022-03-29 17:46:42 +02:00
Sébastien Loriot 99f0598f3e Merge pull request #6378 from GilesBathgate/Nef_3-performance_sphere_circle-GilesBathgate
Nef_3: Sphere circle constructors.
2022-03-29 17:45:52 +02:00
Andreas Fabri 6251262a0a Merge branch 'Kernel_23-overload_for_origin-GF' into Nef_3-performance_sphere_circle-GilesBathgate 2022-03-18 12:46:20 +01:00
Andreas Fabri 71bba3e226 Add Plane_3 constructor with Origin/Vector_3 2022-03-17 22:35:09 +01:00
Andreas Fabri d39c7742f1 Kernel_23: Call function objects from CGAL::Segment_3 2022-03-17 12:14:43 +01:00
Andreas Fabri 6c66626cba int -> std::size_t 2022-03-16 08:01:56 +01:00
Mael Rouxel-Labbé 8d95d22a9e Tiny indentation fix 2022-03-15 00:46:39 +01:00
Giles Bathgate 8445780e09 Merge remote-tracking branch 'afabri/Kernel_23-overload_for_origin-GF' into Nef_3-performance_sphere_circle-GilesBathgate 2022-03-14 21:44:36 +00:00
Andreas Fabri c3ba0ab4a2 Fix the test code 2022-03-14 10:27:33 +01:00
Andreas Fabri 04fa75eb84 Use auto 2022-03-11 09:12:17 +00:00
Andreas Fabri 6e4483a7d0 The same for Construct_orthogonal_vector_3 2022-03-10 14:18:48 +00:00
Andreas Fabri f01e24c75b Add Orientation_3::operator()(Origin,Point_3,Point_3,Point_3) 2022-03-10 10:55:44 +00:00
Laurent Rineau 82bef3fc90 Merge pull request #6392 from CGAL/CGAL-doc_inter_do_inter
better reference Kernel intersection functions
2022-03-10 11:05:21 +01:00
Sébastien Loriot 943a506526 better reference Kernel intersection functions 2022-03-08 15:52:14 +01:00
Marc Glisse 7d4b9de66b
Consistent count in the doc
We already say 5 a few lines below.
2022-02-28 16:14:34 +01:00
Laurent Rineau f9c05a0ba1 Merge pull request #6253 from afabri/P2T2-assert-GF
CGAL:   In testcode do not use CGAL_assertion  but assert
2022-02-02 16:38:22 +01:00
Sébastien Loriot cd7b4ad610 WS 2022-01-28 16:56:21 +01:00
Sébastien Loriot 0da6999ee9 add missing test header 2022-01-28 16:44:04 +01:00
Sébastien Loriot d16dfc381e add Compare_angle_3 functor in the Kernel 2022-01-27 19:43:21 +01:00
Sébastien Loriot d228e994cf predicate requires only RT 2022-01-27 18:29:39 +01:00
Laurent Rineau a5a5a43205
Merge pull request #6120 from MaelRL/Kernel_23-Converter_fundamental_types-GF 2022-01-24 11:07:34 +01:00
Andreas Fabri e388c898cd Deal with Kernel_23 2022-01-18 16:39:43 +00:00
Sébastien Loriot ad686a61f7 fix conversion warning and remove useless test (producing a warning) 2022-01-18 09:30:41 +01:00
Mael Rouxel-Labbé 08f9cfb192 Update tests 2021-12-17 12:23:54 +01:00
Andreas Fabri 98debb9a33 Add to dependencies 2021-12-10 07:49:22 +00:00
Andreas Fabri 22db199519 Add \cgalModels 2021-12-08 14:51:12 +00:00
Andreas Fabri 49e086700e Fix links 2021-12-08 07:25:51 +00:00
Mael Rouxel-Labbé ea42eaea5d More tests 2021-12-03 16:49:50 +01:00
Laurent Rineau df777080ff Merge pull request #6102 from afabri/Kernel_23-Non_zero_dimension_3-GF
Kernel_23: Add NonZeroDimension_3
2021-11-18 14:02:07 +01:00
Mael Rouxel-Labbé 1774ad885f More converter tests 2021-11-16 16:39:20 +01:00
Mael Rouxel-Labbé a294ac30ed Tiny addition to converter tests 2021-11-12 10:51:40 +01:00
Mael Rouxel-Labbé 9f1fef3408 Add a test 2021-11-10 16:24:22 +01:00
Sébastien Loriot ab48f63e30 update latest cmake version tested 2021-11-09 10:58:47 +01:00
Sébastien Loriot 58181afcdb remove useless include directives 2021-11-09 10:16:12 +01:00
Andreas Fabri a24229a6b2 Use homogeneous coordinates 2021-11-04 15:46:45 +01:00
Andreas Fabri b079bec43d Document the Model 2021-11-03 21:52:42 +01:00
Andreas Fabri 4da8f4f5b2 Document the Model 2021-11-03 21:48:38 +01:00
Andreas Fabri 4b979cbfa7
Update Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2021-11-03 21:41:35 +01:00
Andreas Fabri d0ed65838e Fix interface_macros 2021-11-03 17:39:21 +01:00
Andreas Fabri 7cb53ab8ef Change to NonZeroCoordinateIndex 2021-11-03 17:30:26 +01:00
Andreas Fabri 727878e965 Make operator public 2021-11-01 16:58:59 +01:00
Andreas Fabri 9b11a6a382
Update Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2021-11-01 16:23:19 +01:00
Andreas Fabri 6913384dfe Document NonZeroDimension_3 2021-10-31 19:52:33 +01:00
Laurent Rineau 1fb32e70b4 Merge pull request #5978 from janetournois/Mesh_2-add_predicate_for_lloyd-jtournois
Mesh 2 and Kernel - add predicate oriented_side_2(segment, triangle)
2021-10-27 17:20:28 +02:00
Mael Rouxel-Labbé e424356ffa Add Construct_projected_point_3(P3, P3) + correct parameter order
Not a kernel requirement
2021-09-28 15:34:51 +02:00
Jane Tournois 2fbff6360c doc : add "model of" 2021-09-21 10:26:23 +02:00
Jane Tournois be2f8457d3 add Oriented_side_2 to Projection_traits_3 (for use in the demo) 2021-09-10 17:29:27 +02:00
Jane Tournois 9a56423274 document line orientation 2021-09-10 14:19:56 +02:00
Jane Tournois 99d944ef32 add doc for new predicate oriented_side_2(segment, triangle) 2021-09-10 11:58:15 +02:00
Mael Rouxel-Labbé 8a92d51601 Merge branch 'Distance_3-Add_Tri_Tri-GF-old' into Distance_3-Add_Tri_Tri-GF 2021-09-02 17:26:44 +02:00
Sebastien Loriot e5279db7fb
Merge pull request #5777 from MaelRL/AABB-Dont_call_global_do_intersect-GF
Misc fixes for Intersections_3 + related
2021-09-02 15:44:53 +02:00
Sébastien Loriot dacbd186d1 accomodate changes of internal -> Pkg/internal 2021-08-30 12:35:34 +02:00
Sébastien Loriot 4454c5b3ed Merge remote-tracking branch 'cgal/master' into T2-Document_projection_traits_3-maxGimeno 2021-08-30 12:25:51 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Mael Rouxel-Labbé 1cbcc39370 Rename example to avoid conflicts 2021-08-26 11:15:36 +02:00
Mael Rouxel-Labbé 71d88536b8 Fix doc 2021-08-26 11:08:28 +02:00
Dmitry Anisimov 650fc04303 Merge remote-tracking branch 'origin/master' into Barycentric_coordinates_2-danston 2021-08-13 11:34:58 +02:00
Sebastien Loriot 8d8afe6870
Merge pull request #5737 from danston/Weights-new_package-danston
[Feature] Weights New Package
2021-08-12 10:48:03 +02:00
Sebastien Loriot 92d90a4a11
Merge pull request #5667 from afabri/Kernel-compare_slopes-GF
Kernel: Add compare_slope with 4 points
2021-08-12 10:12:26 +02:00
Maxime Gimeno f7df517f57 Merge remote-tracking branch 'cgal/master' into T2-Document_projection_traits_3-maxGimeno 2021-08-09 09:14:23 +02:00
Dmitry Anisimov 76050b2595 Merge remote-tracking branch 'origin/master' into Barycentric_coordinates_2-danston 2021-08-04 15:52:02 +02:00
Mael 5a30c321b8
Misc cleaning 2021-08-04 15:42:04 +02:00
Dmitry Anisimov 50157a7479 Merge remote-tracking branch 'origin/master' into Weights-new_package-danston 2021-08-04 15:12:04 +02:00
Andreas Fabri 2c1ad28853 Add the documentation of the global function 2021-07-28 12:18:26 +02:00
Laurent Rineau 04b690b099 Merge pull request #5736 from danston/Kernel_23-add_centroid_2_and_determinant_2-danston
Projection Traits With Centroid 2 and Determinant 2
2021-07-27 16:25:09 +02:00
Marc Glisse e7357ac003 Merge remote-tracking branch 'cgal/master' into mt-glisse
several PRs in Filtered_kernel conflicted with this :-(
2021-07-19 14:53:27 +02:00
Sebastien Loriot 40f507a1f1
Merge pull request #5800 from MaelRL/SS-Doc_fixes-GF
Harmonization of some IO stream documentation
2021-07-19 07:56:48 +02:00
Maxime Gimeno 83b69b5a98 Merge remote-tracking branch 'cgal/master' into T2-Document_projection_traits_3-maxGimeno 2021-07-08 11:33:42 +02:00
Laurent Rineau 529add28d3 Merge pull request #5538 from Dig-Doug/bbox-size
Bbox size helpers
2021-07-07 14:37:41 +02:00
Laurent Rineau 0f906ae606 Merge pull request #5545 from Dig-Doug/segment-midpoint
Segment_2/Segment_3 midpoint()
2021-07-07 14:37:38 +02:00
Dmitry Anisimov 22a08d06b7 added missing projection traits in ref manual 2021-07-01 11:36:21 +02:00
Dmitry Anisimov 9fe1c947ca removed tmp modifs 2021-06-29 13:31:56 +02:00
Dmitry Anisimov ca661e3eb7 added weights concept dependency to Kernel_23 2021-06-24 17:03:28 +02:00
Mael Rouxel-Labbé 78ff9185b3 Harmonize ASCII usage across all packages 2021-06-23 23:34:32 +02:00
Mael Rouxel-Labbé 084a1efe2d Merge remote-tracking branch 'cgal/master' into Distance_3-Add_Tri_Tri-GF 2021-06-23 22:30:03 +02:00
Mael Rouxel-Labbé 8de38803d4 Fix indentation 2021-06-23 17:40:15 +02:00
Dmitry Anisimov e6d3534d67 Merge remote-tracking branch 'origin/master' into Kernel_23-add_centroid_2_and_determinant_2-danston 2021-05-28 14:45:31 +02:00
Dmitry Anisimov 001da6cc21 Merge remote-tracking branch 'origin/master' into Weights-new_package-danston 2021-05-28 14:27:02 +02:00
Laurent Rineau 8fa0f55ac7
Merge branch 'master' into mt-glisse 2021-05-27 10:27:38 +02:00
Maxime Gimeno 2d5f91f763 Merge remote-tracking branch 'cgal/master' into T2-Document_projection_traits_3-maxGimeno 2021-05-27 09:06:59 +02:00
Marc Glisse 099fd7cb52 Move-construct kernel objects
This saves a Handle copy in Lazy_construction
2021-05-27 00:41:14 +02:00
Andreas Fabri 3ded9e10d0 Add unit test 2021-05-24 10:08:17 +02:00
Andreas Fabri ea647297b9 Kernel_23: Fix Non_zero_dimension 2021-05-22 16:21:49 +02:00
Dmitry Anisimov 8d6c8bda6e fixed typos and tested 2021-05-20 18:01:31 +02:00
Dmitry Anisimov cf7cba9f08 added embed for centroid object + tests 2021-05-20 17:44:53 +02:00
Dmitry Anisimov 9357545031 added construct_centroid_2 and compute_determinant_2 objects to the projection classes 2021-05-20 17:31:52 +02:00
Maxime Gimeno 75db0292f6 Rename internal classes 2021-05-19 09:25:13 +02:00
Laurent Rineau 4a2f016f6a Merge pull request #5617 from afabri/Nef_3-translation-GF
Nef_3: Add Aff_transformation_3::is_translation()
2021-05-18 18:14:17 +02:00
Maxime Gimeno 3795c5236a Changes after review 2021-05-18 10:16:24 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Andreas Fabri 431c0713b3 remove trailing whitespace 2021-05-03 16:37:16 +02:00
Andreas Fabri b2bb10710c untabify 2021-05-01 17:10:22 +02:00
Andreas Fabri 4e1ebec30a untabify 2021-05-01 17:04:52 +02:00
Andreas Fabri 20d1629e1b Add compare_slope with 4 points 2021-04-30 17:39:57 +02:00
Laurent Rineau c091c7f86e Merge pull request #5532 from lrineau/Kernel_23-Do_interesect__without_division-GF
Remove operator/ from CGAL::Mpzf and implement Do_intersect_3 with RT only (without division)
2021-04-28 15:24:15 +02:00
Andreas Fabri c238e9dab5 Merge remote-tracking branch 'cgal/master' into Nef_3-translation-GF 2021-04-27 15:23:56 +01:00
Andreas Fabri c7e4eaca7e fix doc 2021-04-23 11:50:26 +01:00
Andreas Fabri e73b8de89f Add the 2D stuff. In homogeneous add Scaling_repH3 2021-04-22 21:17:24 +01:00
Andreas Fabri d3b26a60cb The free function must call the functor 2021-04-22 17:35:27 +01:00
Andreas Fabri a8d15183ce So glad to have a native speaker on board 2021-04-22 13:57:26 +01:00
Andreas Fabri 7485e3887b Improve documentation and the example that performs affine transformations 2021-04-22 13:43:07 +01:00
Andreas Fabri 8a446d1778 Document is_scaling() and is_translation() 2021-04-22 08:49:52 +01:00
Sebastien Loriot b8bc56ca12
Merge pull request #4421 from MaelRL/Triangulation_on_sphere_2-GF
new package: Triangulation on the sphere
2021-04-21 15:24:45 +02:00
Sebastien Loriot 5b253ad2fc
Merge pull request #4099 from sloriot/CGAL-epeck_pts_cmp
Speed up comparison of points
2021-04-21 15:24:11 +02:00
Andreas Fabri 35fc3c7d2d Add missing implementations for Homogeneous. Fix the test for Filtered_cartesian as it has become more exact now 2021-04-20 09:04:23 +01:00
Mael 8226666398
Merge branch 'master' into Triangulation_on_sphere_2-GF 2021-04-17 11:22:30 +02:00
Sebastien Loriot 6d63fcc465
Merge pull request #5585 from afabri/Kernel_23-rational_rotation-GF
Kernel_23: Remove local reference in rational_rotation.h
2021-04-17 11:21:14 +02:00
Sebastien Loriot b7323389c7
Merge pull request #5622 from maxGimeno/CMake-Update_versions_in_scripts-maxGimeno
Update maximum cmake versions
2021-04-17 10:58:14 +02:00
Sebastien Loriot 0c6404d1bc
Merge pull request #5596 from sloriot/Doc-precompiled_demos
Add doc for precompiled demos
2021-04-17 10:57:02 +02:00
Maxime Gimeno c49152359c update max version of cmake and announce the new minimal in CHANGE.md 2021-04-15 15:08:54 +02:00
Mael Rouxel-Labbé fba303341f Merge remote-tracking branch 'cgal/master' into Distance_3-Add_Tri_Tri-GF 2021-04-12 15:33:14 +02:00
Sébastien Loriot 350b9172c5 replace %CGAL by \cgal (but in titles) 2021-04-11 14:52:01 +02:00
Sébastien Loriot 68dc09b3d9 optimize filter failures
cmp_epeck_points.cpp runtime goes from 23s. to 5s.

based on mglisse suggestion
2021-04-10 07:12:25 +02:00
Sébastien Loriot 51490546c1 move to benchmark 2021-04-10 07:05:50 +02:00
Andreas Fabri 5aecb82f7b Construct points where inf !=sup for the intervals 2021-04-10 07:01:52 +02:00
Andreas Fabri 56106ae42b Add a test (which so far does not show any difference 2021-04-10 07:01:52 +02:00
Andreas Fabri e661acaccb I should buy glasses -- and run the testsuite locally 2021-04-07 12:21:02 +01:00
Maxime Gimeno 17602e589e Merge remote-tracking branch 'cgal/master' into CGAL-clang_tidy__nullptr_on_Mesh_2-GF 2021-04-07 09:17:51 +02:00
Laurent Rineau 1b54449dc5 Merge pull request #4878 from danston/Kernels-decltypes-danston
Improve decltype/result_of/invoke_result
2021-04-06 15:13:21 +02:00
Laurent Rineau de704d8bb9 Merge pull request #5522 from afabri/Nef_3-accelerate_do_intersect_internally-GF
Nef_3: Do not test has_on for a point where we know that it will be true
2021-04-06 15:13:07 +02:00
Laurent Rineau 0f61f96c80 Merge pull request #5556 from MaelRL/Kernel_23-Dont_recompute_normal_in_proj_point-GF
Fix inconsistency in normal computation in robust projection code
2021-04-06 15:12:53 +02:00
Andreas Fabri 7dc015e7de Kernel_23: Remove local reference 2021-04-06 09:33:44 +01:00
Andreas Fabri 7ebdd07a4c Add <RT> to rank as expression templates don't match 2021-03-30 14:28:55 +01:00
Andreas Fabri 6c7f05e0be rank written by Sebastien 2021-03-29 16:03:06 +01:00
Sébastien Loriot c70c0a511f use initialized vector 2021-03-29 09:14:23 +02:00
Mael Rouxel-Labbé 48bb925b65 Fix inconsistency in robust projection code
If the triangle/plane is degenerate, the case is handled separately.
If we know the plane is not degenerate, the normal should not
be recomputed in a different manner, which might lead
to a null normal and some issues down the line.
2021-03-26 10:41:30 +01:00
Mael Rouxel-Labbé 28377db261 Add T3/T3 to the supported CGAL::squared_distance combinations 2021-03-25 11:08:46 +01:00
Andreas Fabri e0b410e2e6 int -> result_type 2021-03-24 16:03:51 +01:00
Laurent Rineau 21755b1123 Merge pull request #5245 from GilesBathgate/create-assertions-fix
Allow -DNDEBUG and CGAL_nnn_assertions at the same time
2021-03-24 15:05:41 +01:00
Andreas Fabri a28a7cd44a Return directly 2021-03-23 17:11:26 +01:00
Andreas Fabri e98198178f Add the functor Non_zero_dimension_3 to the Kernel 2021-03-23 15:45:54 +01:00
Doug Roeper 6e4be92b5e
Adds a CGAL::midpoint() implementation for Segments. 2021-03-22 09:11:23 -04:00
Doug Roeper 69779ebf80
Adds some helpers to calculate the span of a Bbox in each dimension. 2021-03-22 06:37:29 -04:00
Andreas Fabri 45909e6d76 Let's fix it step by step, beginning with Do_intersect_3 2021-03-22 09:01:56 +01:00
Mael Rouxel-Labbé 8501639635 Add missing space 2021-03-19 17:28:27 +01:00
Maxime Gimeno bd933ad308 rename doc file 2021-03-19 13:10:34 +01:00
Maxime Gimeno 735567531b RENAME 2021-03-19 12:00:08 +01:00
Andreas Fabri be39ec02fa Add a solve that 'returns' the denominator instead of making the division 2021-03-18 14:18:11 +01:00
Laurent Rineau b32250242a CGAL_Kernel_pred_RT for Do_intersect_2 and Do_intersect_3
The code is not ready for that. A lot of overloads of
`Do_interesect_[23]` are implemented by calling the equivalent
overloads from `Intersect_23` (that requires division of coordinates).
2021-03-17 11:34:08 +01:00
Dmitry Anisimov 5235fd6d2c moved min/max definitions of Segment_2/3 inside the class 2021-03-15 10:50:14 +01:00
Dmitry Anisimov 00c185b028
Merge branch 'master' into Kernels-decltypes-danston 2021-03-12 12:06:20 +01:00
Maxime Gimeno c2628c16e1 change licenses 2021-03-10 15:16:29 +01:00
Maxime Gimeno 82d2258f0b Merge remote-tracking branch 'cgal/master' into T2-Document_projection_traits_3-maxGimeno 2021-03-10 15:10:20 +01:00
Maxime Gimeno 6c82c4b09d Add misisng files 2021-03-10 15:06:53 +01:00
Maxime Gimeno 93e060591c Move the traits class in Kernel_23 2021-03-10 14:44:56 +01:00
Maxime Gimeno d2ba62aa21 Fixes in concepts and addition of missing functors for complyance to PolygonTraits_2. 2021-03-10 12:25:24 +01:00
Laurent Rineau f1e550fdd2 Merge pull request #5363 from sloriot/Kernel-Oriented_side_extra_operator
Add an extra operator to have an exact plane
2021-03-03 17:33:20 +01:00
Laurent Rineau b1d78a909f Merge pull request #5433 from sloriot/CGAL-last_bind
Remove last bind
2021-03-03 17:32:59 +01:00
Laurent Rineau 0baa38fe31 Merge pull request #5465 from afabri/Distance_3-Tetrahedron_Point-GF
Distance_3: Add Point_3/Tetrahedron_3
2021-03-03 17:29:41 +01:00
Laurent Rineau ea7fa2dada Merge pull request #5480 from afabri/Filtered_kernel-Document_functor_for_Envelope-GF
Kernel_23:  Rename internal function and functor
2021-03-03 17:21:35 +01:00
Andreas Fabri d5a5b20ce8 Make it clear that the functor is not part of the Kernel concept 2021-02-19 20:23:20 +00:00
Laurent Rineau 216560554e Merge pull request #5112 from sloriot/Kernel_23-bisector_sqrt
Allow an inexact version of bisector when no sqrt is available.
2021-02-18 15:26:51 +01:00
Laurent Rineau bb36a410f8 Merge pull request #5112 from sloriot/Kernel_23-bisector_sqrt
Allow an inexact version of bisector when no sqrt is available.
2021-02-18 15:18:11 +01:00
Maxime Gimeno d5811d0a41 clang-tidy on tests 2021-02-18 15:15:12 +01:00
Andreas Fabri 18f7f91c3c Add test; remove the word 'constant' in the documenation 2021-02-17 14:41:41 +00:00
Maxime Gimeno 1f5a847856 Apply reviewer's modifications 2021-02-17 12:36:39 +01:00
Andreas Fabri 6186a2acf3 Add doc 2021-02-16 16:26:45 +00:00
Sébastien Loriot 4bb0406240 do not include boost/bind.hpp (shouldn't be used anymore) + fix remaining bind
(nasty using namespace boost!)
2021-02-12 15:35:19 +01:00
Dmitry Anisimov 3f4c1c4628 moved point/vertex/[] definitions of Segment_2/3 inside the class 2021-02-12 11:31:03 +01:00
Dmitry Anisimov 2718072e0f projection traits removed result_of 2021-02-10 10:20:21 +01:00
Dmitry Anisimov 81d9556707 Merge remote-tracking branch 'upstream/master' into Kernels-decltypes-danston 2021-02-10 10:06:45 +01:00
Dmitry Anisimov af3f6dd07f fixed warnings with Intersect_3 and result_of 2021-02-09 17:30:06 +01:00
Laurent Rineau 3bd7181ff3 Merge pull request #5244 from afabri/Triangulation_2-Intersect_use_variant-GF
Nef_3, Triangulation_2:  Change the result type of the Intersect_2 functor
2021-02-05 16:12:58 +01:00
Sébastien Loriot d4b6a55a68 remove unused typedefs 2021-02-01 09:36:47 +01:00
Sébastien Loriot 0199c5794c remove doc from concept that applies only to current models 2021-02-01 09:36:30 +01:00
Sébastien Loriot 107567e809 add an extra operator to have an exact plane 2021-01-15 15:38:28 +01:00
Maxime Gimeno 2255f8e8ea Merge remote-tracking branch 'cgal/master' into CMake-modernization-maxGimeno 2021-01-13 14:34:09 +01:00
Andreas Fabri 695ff0f3b3 Fix doc of Projection_traits_xy_3 2021-01-05 15:39:06 +00:00
Dmitry Anisimov 3127190bcf marc's review 2020-12-08 12:48:04 +01:00
Andreas Fabri 7314f83ac8 Fixes after comments by Laurent and Marc 2020-12-07 12:41:15 +00:00
Giles Bathgate 5a36ff89b5 Drop NDEBUG it is already visible through CGAL_NO_ASSERTIONS 2020-12-04 19:42:21 +00:00
Andreas Fabri 2e24249f13 Triangulation_2: Change the result type of the Intersect_2 functor 2020-12-04 16:44:22 +00:00
Andreas Fabri f246c4abf8 merge 2020-11-13 16:26:57 +00:00
Sébastien Loriot a4b0f88d41 test all now 2020-10-29 16:08:47 +01:00
Maxime Gimeno 2ad4c16b6e Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-10-26 15:00:53 +01:00
Sebastien Loriot e685203cc6
a -> an 2020-10-26 11:08:56 +01:00
Sébastien Loriot 80af4b3e74 be more permissive for bisector with a FT with sqrt 2020-10-26 09:17:01 +01:00
Andreas Fabri 5791bc1400 fix do_intersect for 3 planes 2020-10-20 14:55:52 +01:00
Sébastien Loriot 209bee81b3 Merge remote-tracking branch 'cgal/5.1.x-branch' into master 2020-10-20 13:35:25 +02:00
Sébastien Loriot 335ac3d5dd Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch' 2020-10-20 13:32:03 +02:00
Sébastien Loriot e5019d04e6 Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-10-20 13:27:26 +02:00
Maxime Gimeno bebd60c12b Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-10-20 09:53:54 +02:00
Sébastien Loriot 87b8f66e14 update from master 2020-10-20 09:19:13 +02:00
Andreas Fabri fefbc4bc1a Add funcion intersection_point for Line/Plane 2020-10-20 09:17:15 +02:00
Andreas Fabri eafad68789 Add a function that only constructs a point intersection for 3 planes 2020-10-20 09:17:15 +02:00
Andreas Fabri 46698620e3 Hack for a fix of do_intersect(Plane_3,Plane_3,Plane_3) 2020-10-20 09:17:15 +02:00
Mael Rouxel-Labbé 5a27f1b8de Test affine transformation of weighted points 2020-10-16 16:23:55 +02:00
Thomas Lin Pedersen 38e46d853c move braces 2020-10-16 16:10:48 +02:00
Thomas Lin Pedersen f856e13964 move bracers 2020-10-16 16:10:35 +02:00
Laurent Rineau 51f11605c0 Merge pull request #5022 from janetournois/Intersections_3-fix_do_intersect_3planes-GF
Intersections_3 - fix do_intersect(Plane_3, Plane_3, Plane_3)
2020-10-16 13:41:19 +02:00
Maxime Gimeno 107c4350d0 remove all /src directories 2020-10-14 11:22:49 +02:00
Jane Tournois f005bd40a4 Merge branch 'Intersections_3-fix_do_intersect_3planes-GF' into Intersections_3-fix_do_intersect_3planes-master-GF
# Conflicts:
#	Filtered_kernel/include/CGAL/internal/Static_filters/Do_intersect_3.h
2020-10-06 17:30:29 +02:00
Jane Tournois 9b50f58433 add do_intersect(plane, plane, plane) to the doc of linear kernel 2020-10-06 17:20:23 +02:00
Sebastien Loriot 9ce3e3a3c1
Merge pull request #5024 from janetournois/Installation-remove_msvc_bug_macro-GF
Installation - matching bug is fixed in MSVC >= 2015
2020-10-02 15:13:15 +02:00
Sébastien Loriot 090b82e762 Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch' 2020-10-02 15:08:56 +02:00
Maxime Gimeno e169490c78 Replace fix for Point_2(Origin) 2020-09-30 10:03:30 +02:00
Maxime Gimeno 8c5725a1d0 Fix missing constructor in kernel example 2020-09-30 08:59:06 +02:00
Jane Tournois 5c8df6672a remove CGAL_CFG_MATCHING_BUG_ variants
the "matching bug" of msvc has been fixed since at least vs 2015
2020-09-25 14:25:14 +02:00
Dmitry Anisimov 371db977c8 better kernel checker 2020-08-20 14:12:16 +02:00
Maxime Gimeno 9c15f2c9dc Use FeatureSummary in the demo, and remove CGAL_FOUND 2020-08-04 12:46:17 +02:00
Laurent Rineau 09b52ce69f Add test/Kernel_23/test_approximate_dihedral_angle_3.cpp 2020-08-03 16:55:25 +02:00
Dmitry Anisimov 209513dc56 fixed docs + a few code improvements 2020-07-31 15:58:38 +02:00
Dmitry Anisimov ad813b4cb0 further removed result_of and result 2020-07-30 16:19:02 +02:00
Dmitry Anisimov 4248a8a9f7 lazy and type mapper result_of fix 2020-07-23 16:00:06 +02:00
Dmitry Anisimov eb2f7e5b90 kernel_23 doc typo fixes 2020-07-22 14:24:56 +02:00
Laurent Rineau 2e8a59d570 Merge branch 'releases/CGAL-4.14-branch' into releases/CGAL-5.0-branch 2020-07-21 15:25:54 +02:00