Commit Graph

193 Commits

Author SHA1 Message Date
Laurent Rineau d07dc0daad remove the lambda expression
maybe solve that issue:
```
    21>C:\CGAL_ROOT\CGAL-6.1-Ic-155\include\CGAL/Conforming_constrained_Delaunay_triangulation_vertex_data_3.h(82,1): error C2888: '==::<lambda_f8bc645280bb56be32d0268df7c48762>': symbol cannot be defined within namespace 'CGAL' [C:\CGAL_ROOT\CGAL-6.1-Ic-155\cmake\platforms\MSVC-2019-Community-Release\test\Constrained_triangulation_3_Examples\ccdt_3_preprocessing.vcxproj]
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-155/Constrained_triangulation_3_Examples/TestReport_Christo_MSVC-2019-Community-Release.gz
2025-05-16 16:33:03 +02:00
Laurent Rineau 8e398f0aa2 (max) 2025-05-14 10:38:12 +02:00
Laurent Rineau 2035e0c312 refactoring 2025-05-13 17:32:31 +02:00
Sébastien Loriot fba1b5068e be consistant 2025-05-13 15:24:36 +02:00
Sébastien Loriot dca12bcd6b simplify patch id copies 2025-05-13 15:12:59 +02:00
Sébastien Loriot 2887ee0a36 reuse existing map 2025-05-13 14:49:30 +02:00
Sébastien Loriot d6146730a8 fix condition 2025-05-13 13:51:19 +02:00
Sébastien Loriot 57524e12e4 fix rw_points type and construction 2025-05-13 13:43:30 +02:00
Sébastien Loriot e4bd0348a4 avoid precondition checking after creating the mesh from a soup 2025-05-13 13:42:25 +02:00
Laurent Rineau 89966ea79b fix `polygon_id_to_sm_face_map`
The name was wrong, because one needs actually the mapping in two sides.
2025-05-13 12:33:01 +02:00
Sébastien Loriot 9b6bf75b11 missing call to orient soup 2025-05-13 11:43:49 +02:00
Sébastien Loriot 317b64d705 add a macro to reduce dependencies 2025-05-13 11:32:31 +02:00
Sébastien Loriot f40c64ba13 rename np 2025-05-13 11:26:47 +02:00
Sébastien Loriot 0064ea9f3e add missing precondition check for soup + always assert in debug 2025-05-13 11:20:26 +02:00
Sébastien Loriot 6879158e32 typo 2025-05-12 17:50:47 +02:00
Sébastien Loriot 0aba404db4 workaround anchor issues by adding subgroups to disambiguate overloads 2025-05-12 17:47:53 +02:00
Jane Tournois ebd9ecab58 documentation of check_preconditions, the new NP 2025-05-12 15:47:42 +02:00
Jane Tournois 270c507ce7 v0 of add named parameter check_preconditions()
optional parameter, to check a priori that preconditions are satisfied
2025-05-12 15:14:08 +02:00
Jane Tournois ca1a5982b6 add an example with self-intersections and autorefinement 2025-05-12 12:12:32 +02:00
Jane Tournois b70e78f22b document CGAL::IO::write_MEDIT 2025-05-12 10:52:19 +02:00
Jane Tournois 0c3b8b8b11 workaround static_assert for msvc <= 2019 2025-05-12 09:52:51 +02:00
Laurent Rineau 3409d4c974 fix warnings 2025-05-11 23:00:33 +02:00
Laurent Rineau 7c2537b62a merge issue 2025-05-09 16:16:24 +02:00
Laurent Rineau e3190d62db other fixes for MSVC 2017 2025-05-09 16:14:18 +02:00
Jane Tournois 0830299bbf Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-05-09 16:04:33 +02:00
Jane Tournois 697101bf8e fix remeshing example and test
add edge_is_constrained_map to convert_to_triangulation_3()
similarly to what is done with a C3T3
2025-05-09 16:04:19 +02:00
Laurent Rineau c388b62f3b fixes for msvc 2017 2025-05-09 16:04:05 +02:00
Laurent Rineau a8fb8c5981 fix compilation of cdt_3_plugin 2025-05-09 15:29:01 +02:00
Jane Tournois e3a7e453fe fix compilation with CCDT_cb 2025-05-09 14:35:18 +02:00
Jane Tournois 7180a85762 remove from CCDT_Cb/Vb everything that is needed by Simplicial_Cb/Vb
to separate the needs of different packages
all the needed info is available in ccdt_data() in CCDT_Cb/Vb
2025-05-07 22:42:25 +02:00
Laurent Rineau 774ef98ed6 fix the second constructor in 2D case, and amend the test 2025-05-06 17:01:01 +02:00
Laurent Rineau 0f296df8a7 deal with 2D inputs 2025-05-06 13:09:42 +02:00
Laurent Rineau b394cfd319 add does_polygon_soup_self_intersect
undocumented for now
2025-05-06 13:08:18 +02:00
Laurent Rineau a9469fc688 document that the triangulation must be 3D 2025-05-05 15:47:18 +02:00
Jane Tournois 0575a1e579 write the full documentation only once in the function templates
and add links to it
This avoids future divergence between the 2 versions, and makes things more
clear for the reader
2025-05-05 12:34:52 +02:00
Jane Tournois c3831eef9c wip review Mael
- expose nothing from cell_data and vertex_data
- add const ref
- doc
2025-05-02 16:17:55 +02:00
Jane Tournois 65edb3d613 move sync_vertex_type_with_dimension_and_index() to a lambda function
to avoid undocumented functions in the vertex base
2025-05-02 15:11:32 +02:00
Jane Tournois b9fd8a3b8e rename Base_with_time_stamp to Triangulation_simplex_base_with_time_stamp 2025-05-02 14:44:36 +02:00
Laurent Rineau e31144344f another fix, so that it works as well on Linux 2025-05-02 14:23:31 +02:00
Laurent Rineau d6ae7c9686 MSVC 2019 does not have std::basic_format_string
See https://github.com/microsoft/STL/pull/3074 implemented later in Sept 2022.
2025-05-02 10:57:56 +02:00
Laurent Rineau d47c44f7f3 fix when Qt6 is not available 2025-05-02 09:56:56 +02:00
Laurent Rineau 108cf8e44f fix ws 2025-04-30 17:33:57 +02:00
Laurent Rineau b190978599 fix the static assertions
... by using Boost containers instead of those from the STL.
2025-04-30 11:32:18 +02:00
Laurent Rineau 0ec75e54ee Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into pr/lrineau/8186 2025-04-29 17:41:39 +02:00
Laurent Rineau 1c4e24621c fix the assertions about nothrow_movable in CDT_3
using Boost implementation of `unordered_map` instead of the std:: version.
2025-04-29 17:41:30 +02:00
Jane Tournois da73a5db7f fix type name 2025-04-29 15:58:08 +02:00
Laurent Rineau 9f38c6887f fix doc 2025-04-29 15:47:47 +02:00
Laurent Rineau 958d50eb20 more debug message 2025-04-29 15:47:41 +02:00
Jane Tournois c95bcb5cb7 wip review Mael 2025-04-29 15:17:54 +02:00
Laurent Rineau 89752983f7 protect debug messages with the flag debug_missing_region() 2025-04-29 13:40:44 +02:00
Laurent Rineau 13f8e779e0 fix unused variable 2025-04-28 21:00:52 +02:00
Laurent Rineau c0abf42c57 add CGAL::draw for CCDT_3 2025-04-28 17:07:54 +02:00
Laurent Rineau 58bc7b1a76 always use `auto` for the traits functors 2025-04-28 17:07:54 +02:00
Sébastien Loriot 946472addd fix license checking headers 2025-04-24 20:32:59 +02:00
Laurent Rineau c3bf6f945b Andreas is right: it should be `int` 2025-04-24 12:57:51 +02:00
Laurent Rineau 17c749f44f face_patch_map for polygon soups 2025-04-24 12:56:33 +02:00
Andreas Fabri 4055ff4f94 Replace std_size_t with CDT_3_signed_index 2025-04-11 12:00:47 +01:00
Andreas Fabri 235a9426bb Use CDT_3_signed_index 2025-04-11 10:15:03 +01:00
Andreas Fabri fed7f0bf0d Conditional #include 2025-04-11 09:55:33 +01:00
Sébastien Loriot 261e80f029 add explicit CXX20 2025-04-11 10:49:56 +02:00
Andreas Fabri eeb4decd2a Use named parameter helper 2025-04-11 10:46:23 +02:00
Andreas Fabri 14cfb4d104 Use std::function to avoid VC2017 error 2025-04-11 08:48:37 +01:00
Andreas Fabri 63b8eb9e30 Change anchors 2025-04-08 10:25:22 +01:00
Andreas Fabri 9009ed5c8d clang does not fully support <concepts> 2025-04-08 09:51:18 +01:00
Jane Tournois 620ae7d697 remove tab 2025-04-03 14:12:26 +02:00
Jane Tournois f2d0b189cc typo & todo 2025-04-03 12:54:41 +02:00
Jane Tournois 68b6b6f001 explicitely add default type for Tr, and a public typedef for Triangulation
the default type was already there but hidden in a fwd declaration

+ document convert_to_triangulation_3()
2025-04-03 12:11:49 +02:00
Laurent Rineau cbad336cad fix issue #8811 2025-04-02 18:40:24 +02:00
Laurent Rineau 4e9ecde5e1 merge my work into cgal/Triangulation_3-CDT_3-lrineau 2025-04-02 15:19:41 +02:00
Laurent Rineau fc6e62861f change the way to compute the default CDT type 2025-04-02 15:10:59 +02:00
Jane Tournois 8873d24b44 add missing CGAL:: (compilation error in external project) 2025-04-01 15:36:15 +02:00
Laurent Rineau 398df2bf2a improve Conforming_constrained_Delaunay_triangulation_cell_base_3 2025-03-31 10:09:45 +02:00
Laurent Rineau f0cae98d57 remove unused named parameters pack 2025-03-29 01:53:21 +01:00
Laurent Rineau b6cb3b380c fix indentation 2025-03-27 10:50:59 +01:00
Laurent Rineau b4db567119 rename Constraint_id (because that name refers to 2D constraints) 2025-03-27 10:50:58 +01:00
Sébastien Loriot f52a6b843b fix some warnings 2025-03-20 20:37:00 +01:00
Jane Tournois 493b78a6d7 rename functions, remove useless duplicate, and order switch/case by vertex dim 2025-03-17 13:07:56 +01:00
Jane Tournois fcb637bff5 prepare triangulation for tetrahedral_isotropic_remeshing() 2025-03-14 14:48:42 +01:00
Sébastien Loriot c65ed45431 fix warning and avoid a copy 2025-02-14 14:11:02 +01:00
Sébastien Loriot c443bbb0cb temporarily disable the static_assert's 2025-02-13 15:38:34 +01:00
Sébastien Loriot 9c7bb82e5d relates and groups are somehow incompatible as the doc is then supposed
to be move in the class
2025-02-13 10:43:44 +01:00
Sébastien Loriot bedd092f67 workaround doc issues 2025-02-13 10:18:48 +01:00
Laurent Rineau 9572c603d5 fix the static assertions about nothrow-movable
```
/mnt/testsuite/include/CGAL/Conforming_constrained_Delaunay_triangulation_3.h:543:23: error: static assertion failed
  543 |   static_assert(CGAL::is_nothrow_movable_v<CDT_3_impl>);
      |                 ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
2025-02-12 13:53:18 +01:00
Laurent Rineau 87e979160f min/max issues 2025-02-12 13:38:49 +01:00
Laurent Rineau 39102f0449 more check of the use of `<format>` 2025-02-12 11:45:10 +01:00
Laurent Rineau a2571bbab8 Merge remote-tracking branch 'lrineau/CGAL-followup_PR_8170-lrineau' into Triangulation_3-CDT_3-lrineau 2025-02-11 18:26:52 +01:00
Laurent Rineau cc6a40564b improve read_polygon_mesh_for_cdt_3
I have added comments on the block of code that triangulates the polygon on-the-fly
2024-12-06 16:07:31 +01:00
Laurent Rineau 05d9329502 add an explicit return section (discussion with Andreas) 2024-12-06 16:05:05 +01:00
Laurent Rineau ce7e271800 add a ref to does_triangle_soup_self_intersect (suggested by Mael) 2024-12-06 16:04:27 +01:00
Laurent Rineau 49b6ced8cc commit Jane's suggestion of wording
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2024-12-05 16:35:37 +01:00
Laurent Rineau b54b80f412 fix and improvement during peer-review with Jane 2024-12-05 16:13:16 +01:00
Laurent Rineau ed2e57e262 factorize a paragraph to an \include[doc] 2024-12-04 11:19:24 +01:00
Laurent Rineau 915c17dbb2 more changes after Jane's review 2024-12-03 23:36:31 +01:00
Laurent Rineau 385725f157 update the documentation of CDT_3 free functions
Jane approved the changes after a quick look.

The corresponding update for the class constructors will follow soon.
2024-12-02 14:53:35 +01:00
Laurent Rineau b7b465f47d apply Jane's suggestions in the PR review 2024-11-25 12:59:02 +01:00
Laurent Rineau 6ec771816e Better --debug_input_faces (dump polygon files) 2024-11-22 17:41:40 +01:00
Laurent Rineau b855f5237d typo in variable names 2024-11-20 15:48:29 +01:00
Laurent Rineau c5b94332fd detect self-intersecting inputs 2024-11-20 15:26:47 +01:00
Laurent Rineau d1c8d2ea10 fix trailing spaces 2024-11-12 13:06:01 +01:00
Laurent Rineau 6ab501ab48 add new debug code 2024-11-04 13:56:12 +01:00