Commit Graph

100 Commits

Author SHA1 Message Date
Sébastien Loriot ab1983a066 another missing tuple 2025-02-06 09:09:47 +01:00
Sébastien Loriot 6f65025259 use std tuple 2025-02-05 16:54:18 +01:00
Sébastien Loriot 107f3696dc boost::tie -> std::tie 2025-01-24 14:20:00 +01:00
Sebastien Loriot 601046fde7
Poisson reconstruction - experiments and speedup using parallel Mesh_3 (#7891)
## Summary of Changes

_Describe what your pull request changes to CGAL (this can be skipped if
it solves an issue already in the tracker or if it is a Feature or Small
Feature submitted to the CGAL Wiki)._

## Release Management

* Affected package(s):
* Issue(s) solved (if any): fix #0000, fix #0000,...
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership:
2024-10-14 16:19:06 +02:00
albert-github dd02af92a2 issue #8515 Spelling mistakes found checking `en-GB` to `en-US`
Spelling corrections, `en-GB` -> `en-US`
2024-10-05 11:28:29 +02:00
Jane Tournois 28041d0e9f Merge remote-tracking branch 'cgal/master' into Poisson-use_parallel_mesh_3-GF
# Conflicts:
#	Installation/CHANGES.md
#	Poisson_surface_reconstruction_3/examples/Poisson_surface_reconstruction_3/poisson_reconstruction_example.cpp
#	Poisson_surface_reconstruction_3/include/CGAL/Poisson_reconstruction_function.h
#	Poisson_surface_reconstruction_3/test/Poisson_surface_reconstruction_3/CMakeLists.txt
2024-06-27 11:13:27 +02:00
Laurent Rineau 1b534cd347 Merge pull request #8248 from sloriot/CGAL-deprecate_Surface_mesher
deprecate Surface_mesher package
2024-06-12 10:06:14 +02:00
Laurent Rineau bc31d6f1a3 fix copyright notice
[skip ci]
2024-06-07 15:53:50 +02:00
Laurent Rineau b12a016cc6 cleanup comments
[skip ci]
2024-06-07 15:50:29 +02:00
Laurent Rineau 11448d704a fix the comment 2024-06-06 12:53:40 +02:00
Laurent Rineau eb1c10516a rename/move internal headers 2024-06-06 12:27:34 +02:00
Laurent Rineau bef9f25cac fix poisson_surface_reconstruction_delaunay
Now it uses Mesh_3 (in sequential) instead of Surface_mesher.
2024-06-05 20:06:37 +02:00
Laurent Rineau 693206c242 fix the UBSAN error
```
include/CGAL/Poisson_reconstruction_function.h:263:70: runtime error: reference binding to null pointer of type 'struct value_type'
```
2024-06-05 18:50:17 +02:00
Laurent Rineau 7173974ec3 repair the poisson reconstruction plugin 2024-06-05 18:50:17 +02:00
albert-github 36c8b7589d Spelling corrections
Last batch (for now) of spelling corrections in doxygen and normal comments
2024-05-31 19:05:34 +02:00
Laurent Rineau 5a628ec88a Merge pull request #7881 from afabri/Poisson-enable_structural_filtering-GF
Poisson Surface Reconstruction: Enable Structural Filtering
2023-12-11 13:56:08 +01:00
Andreas Fabri 74bcf248b3 const& 2023-12-01 07:16:53 +00:00
Mael Rouxel-Labbé 3df5e76199 Use enumerable_thread_specific rather than a static hint value
With a static hint and re-initialization in the constructor,
we could still get issues if someone did something like:

Poisson poisson_1(...);
Poisson poisson_2(...)
mesh(poisson_1);
mesh(poisson_2); // problem: the static hint points to a cell of T1
2023-11-28 11:10:38 +01:00
Mael Rouxel-Labbé e9e3287e63 Fix location hint potentially carrying over to the next reconstruction 2023-11-27 17:20:22 +01:00
Mael Rouxel-Labbé bcb872f384 Simplify hint mechanism
It is threadsafe, but it still isn't optimal within each thread:
when computing a refinement point for Mesh_3, the oracle will
be successively asked about points that are close by, but when
we switch from one dichotomy to the next, the hint is likely
terrible.
2023-11-27 17:17:35 +01:00
Sébastien Loriot 36379f42f4 WIP try with thread local static variable 2023-11-27 11:47:26 +01:00
Andreas Fabri b3cbbd2a78 Poisson Surface Reconstruction: Enable Structural Filtering 2023-11-23 15:28:08 +00:00
Andreas Fabri 25e597ac79 Poisson Surface Reconstruction: Enable Structural Filtering 2023-11-23 15:22:20 +00:00
albert-github 301728a8a9 issue #7395 Improvement of layout of model relations
- Completed the cgalModels part
2023-07-09 12:43:36 +02:00
Sébastien Loriot b039040f73 boost::is_convertible -> std::is_convertible 2023-04-23 22:37:07 +02:00
Sébastien Loriot a88af6c0c6 boost::array -> std::array 2023-04-23 22:37:07 +02:00
albert-github eed54a0ae5 spelling corrections
Some spelling corrections (Directories starting with `O`-`S` , first part),
some backward work
some forward work
2022-11-15 18:45:39 +01:00
albert-github 45478184de spelling corrections
Some spelling corrections (Directories starting with `E`-` L`),
some backward work
some forward work
2022-11-15 13:39:40 +01:00
Andreas Fabri c04dceb71d Merge master 2022-10-14 14:40:58 +01:00
Andreas Fabri ce65fa9833 Remove comment snippet in an internal function 2022-09-28 11:53:10 +01:00
Andreas Fabri d3fca65ae5 CGAL: No longer per package assertions 2022-09-23 12:49:40 +01:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
albert-github 47f0eb43d1 Poisson_surface_reconstruction_3: unknown command `@commentheading`
Found the warning:
```
output_surface_facets_to_triangle_soup.h:29: warning: Found unknown command '@commentheading'
```

Command is superflouous as the `tparam` command will provide the relevant header..
2022-05-26 19:06:01 +02:00
Andreas Fabri 3ad94a7393 Use \pre 2022-05-17 12:04:52 +01:00
Andreas Fabri 4968d218b5 Fix doxygen warnings 2022-05-17 10:31:07 +01:00
Mael Rouxel-Labbé 19162905eb Clean and factorize robust circumcenter filtered traits 2022-04-04 11:33:27 +02:00
Stéphane Laurent f43c55f66f fixed a typo in the intro of 'Scale-Space Surface Reconstruction' and fixed #6220 2022-01-13 09:43:22 +01:00
Andreas Fabri 3b7754f796 CGAL_TRACE() -> CGAL_TRACE_STREAM 2021-09-23 17:00:10 +02:00
Sébastien Loriot 1faa0e2992 replace internal use of boost::shared_ptr by std::shared_ptr 2021-04-28 10:55:26 +02:00
Laurent Rineau 21755b1123 Merge pull request #5245 from GilesBathgate/create-assertions-fix
Allow -DNDEBUG and CGAL_nnn_assertions at the same time
2021-03-24 15:05:41 +01:00
Simon Giraudot 848aa7d8ab Fix compatibility of Poisson with Simple_cartesian<float> 2021-02-08 10:16:59 +01:00
Simon Giraudot 0f556c05b6 Fix compatibility of Poisson with Simple_cartesian<double> 2021-02-08 09:53:14 +01:00
Giles Bathgate 5a36ff89b5 Drop NDEBUG it is already visible through CGAL_NO_ASSERTIONS 2020-12-04 19:42:21 +00:00
Laurent Rineau d6e94ee38d Merge pull request #5035 from sgiraudot/Poisson_reconstruction-Fix_thread_safety-GF
Poisson Reconstruction: Fix thread safety
2020-10-29 10:51:19 +01:00
Simon Giraudot 3e0fde9683 Improve thread-safety structures from review 2020-09-29 15:56:13 +02:00
Simon Giraudot c005b37e2d Thread safe cell hint 2020-09-29 14:03:22 +02:00
Simon Giraudot 07b6cb75c7 thread safe cached barycentric coordinates 2020-09-29 14:02:34 +02:00
Simon Giraudot 6b2dad145a Remove trailing whitespace 2020-04-01 07:59:15 +02:00
Simon Giraudot 0409e2b48d Fix iterator determinism in Poisson 2020-03-30 15:47:45 +02:00
Sébastien Loriot 2e180ac589 extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:29:44 +01:00