Commit Graph

944 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Mael Rouxel-Labbé fd12c73cba Enhance tests 2021-09-15 14:59:40 +02:00
Sébastien Loriot 000b03b595 follow up of #5889
cherry-picking for autorefinement
2021-09-06 18:44:07 +02:00
Sébastien Loriot 9dc3f84d73 try to workaround non-determinism 2021-08-03 14:25:50 +02:00
Sébastien Loriot 10ed1a058e add more tests 2021-07-29 17:22:37 +02:00
Sébastien Loriot 743a5fc29e add split case with a plane containing border edges 2021-07-29 13:21:16 +02:00
Laurent Rineau 1ac4c2903a Merge pull request #5589 from MaelRL/Number_types-Fix_approx_sqrt_mpq-GF
Fix approximate_sqrt return types
2021-05-18 17:32:26 +02:00
Laurent Rineau 49aff67985 Merge pull request #5689 from janetournois/PMP-isotropic_remeshing_fixes-jtournois
PMP::isotropic_remeshing - fixes about "isolated constraints"

# Conflicts:
#	Polygon_mesh_processing/test/Polygon_mesh_processing/CMakeLists.txt
2021-05-18 17:31:55 +02:00
Jane Tournois 14385aaf15 add a test with isolated constraints, on and away from mesh borders 2021-05-06 17:48:39 +02:00
Mael Rouxel-Labbé c489b7ffa5 Add missing Coercion_traits specialization for custom FT in PMP test 2021-04-20 15:59:29 +02:00
Mael Rouxel-Labbé abe1f6e577 Misc cleaning 2021-02-22 16:51:35 +01:00
Mael Rouxel-Labbé 1b01b67c86 Added a test for zipping-based boundary cycle stitching 2021-02-08 15:54:52 +01:00
Sébastien Loriot f4935dc199 Merge branch 'CGAL-Eigen3_support-5.1' 2021-01-15 10:54:02 +01:00
Sébastien Loriot eecb00534e fix macro name to be consistent with find_package 2021-01-15 10:43:34 +01:00
Laurent Rineau f612716d34 Merge pull request #5263 from MaelRL/PMP-Fix_remove_degenerate_edges_mutated_loop-GF
Fix multiples calls to degenerate_edges() with an invalid input range
2020-12-16 17:47:50 +01:00
Mael Rouxel-Labbé 56ac58de41 Fix size conversion warning 2020-12-15 16:13:13 +01:00
Maxime Gimeno 8e23d5c482 Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-11-10 09:00:41 +01:00
Laurent Rineau b248867e91
Merge pull request #5141 from maxGimeno/Demo-Fix-clipping_plugin-maxGimeno 2020-11-09 17:10:24 +01:00
Maxime Gimeno cc00d293df Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-11-06 09:37:18 +01:00
Maxime Gimeno 37fa8fd635 Add missing test data 2020-11-06 08:28:42 +01:00
Maxime Gimeno 0ed4a3ef66 Replace CGAL_assertion by assert 2020-11-05 08:55:12 +01:00
Laurent Rineau 3f5e9bad29 Merge pull request #5124 from sloriot/PMP-simplify_polyline
Add experimental non-documented function to simplify a 3D polyline
2020-11-04 20:45:59 +01:00
Maxime Gimeno bb9e72afc9 Add tests 2020-11-04 14:14:09 +01:00
Maxime Gimeno 1c00bf6847 Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-10-29 15:09:16 +01:00
Sébastien Loriot 61174c8359 fix for collinear cycle + update tests 2020-10-28 10:11:34 +01:00
Sébastien Loriot 7309b09169 add function to simplify a 3D polyline (closed or open) with approximation guarantees 2020-10-27 19:12:20 +01:00
Sébastien Loriot 1da8e2b0e0 update test 2020-10-26 14:37:04 +01:00
Maxime Gimeno bebd60c12b Merge remote-tracking branch 'cgal/master' into Cmake_improvements-maxGimeno 2020-10-20 09:53:54 +02:00
Mael Rouxel-Labbé bdf2473338 Merge remote-tracking branch 'cgal/master' into PMP-Local_stitch_borders-GF 2020-10-09 18:01:09 +02:00
Laurent Rineau dda9cb605d Merge pull request #5041 from sloriot/PMP-ceres_eigen
Ceres requires Eigen
2020-10-09 17:45:23 +02:00
Laurent Rineau 1633429bdd Merge pull request #5011 from MaelRL/PMP-Repair_degeneracies_fixes-5.0-GF
Degeneracy removal: fix removing upcoming elements while iterating
2020-10-09 17:34:44 +02:00
Laurent Rineau 40338b2a23 Merge pull request #5012 from MaelRL/PMP-Repair_degeneracies_fixes-5.1-GF
PMP: Degeneracy removal fixes
2020-10-09 16:50:29 +02:00
Laurent Rineau 7f59a3bec7 Merge pull request #5041 from sloriot/PMP-ceres_eigen
Ceres requires Eigen
2020-10-09 16:50:27 +02:00
Mael 0cc1f01f82
Merge branch 'master' into PMP-Local_stitch_borders-GF 2020-10-02 15:39:05 +02:00
Sebastien Loriot 10ba34719e
Merge pull request #4728 from sloriot/PMP-cc_cleanup
Clean in connected components
2020-10-02 15:20:53 +02:00
Sébastien Loriot d35543e1b8 Ceres requires eigen 2020-09-30 16:27:47 +02:00
Mael Rouxel-Labbé 4367d7304e Also test degeneracy removal with EPECK 2020-09-22 16:59:13 +02:00
Mael Rouxel-Labbé 0b3143ea5c Also test degenerate element removal with EPECK 2020-09-22 15:31:03 +02:00
Mael Rouxel-Labbé f39863e801 Merge remote-tracking branch 'cgal/master' into PMP-Local_stitch_borders-GF 2020-09-22 10:57:18 +02:00
Mael Rouxel-Labbé 6c1baed013 Add missing header includes 2020-09-22 10:55:27 +02:00
Sébastien Loriot 40f297e3e3 more conversion warnings
unsigned is hardcoded in boost
2020-08-17 17:10:12 +02:00
Sébastien Loriot 9e3345f68f Update from master 2020-08-12 16:05:45 +02:00
Maxime Gimeno 9c15f2c9dc Use FeatureSummary in the demo, and remove CGAL_FOUND 2020-08-04 12:46:17 +02:00
Laurent Rineau ae0c9fbeac Merge pull request #4884 from MaelRL/PMP-fix_polygon_soup_simplification-GF
Fix and simplify polygon soup repairing subfunction "simplify_polygon"
2020-07-31 15:52:53 +02:00
Laurent Rineau 6411035d7f Merge pull request #4884 from MaelRL/PMP-fix_polygon_soup_simplification-GF
Fix and simplify polygon soup repairing subfunction "simplify_polygon"
2020-07-31 15:52:02 +02:00
Mael Rouxel-Labbé 9d820d64cb Add more tests for repair_polygon_soup 2020-07-28 10:14:31 +02:00
Mael Rouxel-Labbé e16ef7d2f5 Merge remote-tracking branch 'cgal/master' into PMP-Local_stitch_borders-GF 2020-07-03 09:54:56 +02:00
Sébastien Loriot 035b8786b9 remove tws 2020-06-22 09:53:13 +02:00
Sébastien Loriot fd72d53d5f test do_not_modify 2020-06-16 16:15:09 +02:00