Maxime Gimeno
3c875e8a18
WIP review
2019-10-04 15:30:52 +02:00
Maxime Gimeno
b9d33c7ffa
Fix Conflicts
2019-06-25 13:25:57 +02:00
Maxime Gimeno
89b35a5b17
Add missing case for Pl / Cub
2019-06-25 13:15:51 +02:00
Laurent Rineau
55c9a175b5
Merge branch 'releases/CGAL-4.13-branch' into releases/CGAL-4.14-branch
2019-06-21 10:34:18 +02:00
bryantcurto
056e846e0d
Fixed do_intersect() ambiguity.
...
Occurs when compiling with clang
2019-06-21 10:33:46 +02:00
Laurent Rineau
53ba851c89
Merge pull request #3990 from bryantcurto/patch-1
...
do_intersect() Ambiguity
2019-06-20 14:21:05 +02:00
Maxime Gimeno
d9b09ef001
Clean-up loop
2019-06-17 15:54:25 +02:00
Maxime Gimeno
e58b4475e7
clean-up
2019-06-17 15:24:43 +02:00
Maxime Gimeno
3e5d3acb2f
Replace the virtual helper class with a CRTP pattern to avoid the virtual methods.
2019-06-17 15:17:58 +02:00
Maxime Gimeno
6f2930acac
Add missing license headers
2019-06-14 13:19:06 +02:00
Maxime Gimeno
a9facfc574
Add misisng intersections for bbox_3
2019-06-13 10:31:20 +02:00
Maxime Gimeno
c391e0e876
add Cub_tr as a Lazy implementation. Remains only Bbo intersections for the 3D
2019-06-13 10:27:16 +02:00
Maxime Gimeno
5e9891ea75
Tet / tr
2019-06-13 10:27:17 +02:00
Maxime Gimeno
38bf604b4a
Add intersections for Tet/plane
2019-06-13 10:27:16 +02:00
Maxime Gimeno
abeb0cf52d
Add intersection Ray_3 / Tetrahedron_3
2019-06-13 10:27:00 +02:00
Maxime Gimeno
107e4e2abd
Add intersection Ray_3 / Tetrahedron_3
2019-06-13 10:26:28 +02:00
Maxime Gimeno
9cb1173a41
Add intersection Tetrahedron_3 / Segment_3
2019-06-13 10:26:28 +02:00
Maxime Gimeno
469ed5396b
Add Tet / line intersections
2019-06-13 10:26:28 +02:00
Maxime Gimeno
119ca0dff8
Add Intersection between Bbox_3 and Bbox_3
2019-06-13 10:26:28 +02:00
bryantcurto
39bceb093c
Fixed do_intersect() ambiguity.
...
Occurs when compiling with clang
2019-06-07 11:57:19 -04:00
Andreas Fabri
4581f1b7a8
Morte replacements
2019-06-05 08:39:55 +02:00
Laurent Rineau
90782d4b7f
Revert the merge of two pull-requests that target CGAL-4.14-branch
...
- Revert "Merge pull request #3857 from MaelRL/CGAL-Fix_duplicate_non_manifold_vertices-GF"
- Revert "Merge pull request #3898 from lrineau/Mesh_3-stop_during_protection-lrineau"
2019-05-14 17:50:45 +02:00
Laurent Rineau
4d3671024d
Merge pull request #3855 from sgiraudot/Intersections_3-Fix_almost_collinear_segments_bug-GF
...
Intersections_3: Fix almost collinear segment bug
# Conflicts:
# Intersections_3/include/CGAL/Intersections_3/internal/intersection_3_1_impl.h
2019-05-06 15:45:41 +02:00
Laurent Rineau
3586946e96
Merge pull request #3855 from sgiraudot/Intersections_3-Fix_almost_collinear_segments_bug-GF
...
Intersections_3: Fix almost collinear segment bug
2019-05-06 15:26:49 +02:00
Simon Giraudot
258179a707
Prevent construction of line with NaN coordinates
2019-04-30 11:23:47 +02:00
Sébastien Loriot
1d908c1c0b
remove code for CGAL_INTERSECTION_VERSION 1
2019-03-29 13:28:32 +01:00
Laurent Rineau
9c426075b6
Optimized version of do_intersect with Tetrahedron_3 and something
...
The optimization is to delay the switch to the exact number type as
much as possible.
I was not able to find a good benchmark showing the improvement,
though. Maybe because the `do_intersect(Bbox_3, Triangle_3)` is not
optimized the same way.
2019-02-11 13:31:40 +01:00
Andreas Fabri
e58de4baa1
cleanup
2018-12-03 12:52:06 +01:00
Andreas Fabri
aac8ac4e6b
Some changes after Sebastien's review
2018-11-29 15:58:34 +01:00
Sébastien Loriot
057f4eafe7
fix warning + cosmetic changes
2018-11-02 14:17:16 +01:00
Andreas Fabri
d868969a07
Add tests
2018-05-30 15:58:04 +01:00
Andreas Fabri
93d19591da
To intersect a Circle_2 means to intersect the boundary
2018-05-30 15:24:50 +01:00
Andreas Fabri
a82b920b97
Include <CGAL/double.h>
2018-05-23 09:47:42 +01:00
Andreas Fabri
2f8515067c
Add #include for CGAL::abs()
2018-05-22 10:51:39 +01:00
Andreas Fabri
9bfbd567d5
Remove CGAL_NO_INTERSECTION_FUNCTION and functions doing nothing
2018-05-17 14:30:30 +01:00
Andreas Fabri
162241066b
Remove CGAL_NO_INTERSECTION_FUNCTION and functions doing nothing
2018-05-17 11:52:58 +01:00
Andreas Fabri
e1eacead95
Add #includes of kernel object types
2018-05-09 12:20:11 +01:00
Andreas Fabri
e65eba0301
Add #includes
2018-05-04 09:00:09 +02:00
Andreas Fabri
8abfad66ab
inline
2018-05-04 09:00:08 +02:00
Andreas Fabri
92dcb7ca48
Reorganize header files
2018-05-04 09:00:08 +02:00
Andreas Fabri
4111e3e20c
Reorganize header files
2018-05-04 09:00:07 +02:00
Andreas Fabri
09c7fe1103
move purely internal files
2018-05-04 08:57:57 +02:00
Andreas Fabri
ffb13b07d6
Remove some functions added by Maxime
2018-05-04 08:57:57 +02:00
Andreas Fabri
0d3ac75518
Introduce namespace Intersections
2018-05-04 08:57:56 +02:00
Andreas Fabri
78b90d2614
Fix bugs revealed with g++
2018-05-04 08:57:56 +02:00
Andreas Fabri
77f5a4e556
Remove typename; Comment after #endif
2018-05-04 08:57:56 +02:00
Sébastien Loriot
72cdc05152
fix headers
2018-05-04 08:57:56 +02:00
Andreas Fabri
12a5cd9f82
Add the remaining missing functions
2018-05-04 08:57:55 +02:00
Andreas Fabri
5d5f4d0a3d
split header files
2018-05-04 08:57:55 +02:00
Andreas Fabri
702eafafdc
Add Iso_cuboid / Sphere
2018-05-04 08:57:54 +02:00
Andreas Fabri
7dd25721f7
Add do_intersect(Bbox_3, Iso_cuboid_3)
2018-05-04 08:57:53 +02:00
Andreas Fabri
42762b7efb
Add do_intersect(Iso_cuboid_3, Plane_3/Triangle_3)
2018-05-04 08:57:53 +02:00
Andreas Fabri
e783228551
Share code between Iso_cuboid_3/BBox_3 for do_intersect with Ray_3 Nd Segment_3 to profit from static filter
2018-05-04 08:57:52 +02:00
Maxime Gimeno
318e7a7d12
Add missing overloads for Point_3 intersections
2018-05-04 08:56:05 +02:00
Laurent Rineau
a2bfde2c06
Merge pull request #2869 from afabri/CGAL-fallthrough-GF
...
Intersections_3: Deal with fallthrough warnings
2018-03-02 16:32:57 +01:00
Andreas Fabri
d3027734ca
fix indentation
2018-02-23 19:07:36 +00:00
Andreas Fabri
ae1923aa2e
Deal with Triangle_Line and Triangle_Ray
2018-02-22 17:31:23 +00:00
Laurent Rineau
78e7060525
Merge pull request #2712 from afabri/CGAL-VC+warnlevel_4-GF
...
Deal with VC++ warnings of level /W4
2018-02-19 14:27:06 +01:00
Andreas Fabri
1170433885
Comment what default means
2018-02-09 14:23:40 +00:00
Andreas Fabri
6f79d2c6f0
fix typo
2018-02-08 15:30:25 +00:00
Andreas Fabri
fbc1a9b1d3
Replace last case with default and remove fallthrough
2018-02-08 15:11:48 +00:00
Andreas Fabri
e9c652d63f
Add several fallthrough
2018-02-08 15:03:39 +00:00
Andreas Fabri
2e14ff9f04
Kernel
2018-01-17 19:59:11 +00:00
Andreas Fabri
7675141f2b
AABB_tree
2018-01-17 19:43:47 +00:00
Andreas Fabri
38b2e57b11
PMP
2018-01-17 17:59:35 +00:00
Sébastien Loriot
0698f79aff
add SPDX identifier for files under the LGPL-3+ license
2017-11-12 10:17:50 +01:00
Laurent Rineau
c826500c7d
Merge pull request #1551 from mglisse/Number_types-gmpxx_coercion-glisse
...
Misc GMPXX fixes
2016-10-20 09:47:39 +02:00
Andreas Fabri
9cd1b0fd62
We declare the third case default so that there is no fallthrough warning
2016-10-17 13:57:39 +02:00
Laurent Rineau
b14da4c496
Merge pull request #1568 from lrineau/Intersection-fix_inter_plane_seg-lrineau
...
Fix a bug in Intersect_3()(Plane_3, Segment_3)
2016-10-17 10:01:21 +02:00
Marc Glisse
030d81e3f7
Fixes for FT=mpq_class.
...
In particular, the constructor from std::string is explicit.
test_nef_3_io_EPEC is still broken because of that.
2016-10-14 00:37:11 +02:00
Laurent Rineau
afb8d3693d
Fix a bug in Intersect_3()(Plane_3, Segment_3)
...
That bug has been detected by a warning:
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.10-Ic-16/Intersections_3/TestReport_lrineau_Ubuntu-latest-GCC6-CXX1z.gz
```
/mnt/testsuite/include/CGAL/Intersections_3/intersection_3_1_impl.h: In function 'typename CGAL::Intersection_traits<K, typename K::Plane_3, typename K::Segment_3>::result_type CGAL::internal::intersection(const typename K::Plane_3&, const typename K::Segment_3&, const K&) [with K = CGAL::Simple_cartesian<CGAL::Gmpq>]':
/mnt/testsuite/include/CGAL/Intersections_3/intersection_3_1_impl.h:1105:13: warning: this statement may fall through [-Wimplicit-fallthrough]
}
^
/mnt/testsuite/include/CGAL/Intersections_3/intersection_3_1_impl.h:1107:9: note: here
case ON_NEGATIVE_SIDE:
^~~~
/mnt/testsuite/include/CGAL/Intersections_3/intersection_3_1_impl.h:1071:9: warning: this statement may fall through [-Wimplicit-fallthrough]
switch (target_side) {
^~~~~~
/mnt/testsuite/include/CGAL/Intersections_3/intersection_3_1_impl.h:1090:5: note: here
case ON_NEGATIVE_SIDE:
^~~~
```
Now, the incorrect fallthrough is replaced by the return of the empty
set.
2016-10-12 11:20:07 +02:00
Laurent Rineau
51f5697d3d
Add missing #include
2016-09-30 15:23:14 +02:00
Andreas Fabri
1f989622e7
replace \code with real examples
2015-02-09 10:54:24 +01:00
Laurent Rineau
e965b6293e
Fix compilation errors with C++11 and Boost-1.56
...
Use *explicit* conversions to `bool`, for boost::shared_ptr and
boost::optional.
2015-01-14 14:47:29 +01:00
Laurent Rineau
be079cb5a3
Fix compilation with Boost-1.56 and later
...
In Boost-1.56 and later, with C++11, boost::optional::operator bool() is
explicit.
2015-01-13 16:21:04 +01:00
Laurent Rineau
f85c7e34e1
Bug fix proposed by Jean-Philippe Pons
2014-06-20 16:34:34 +02:00
Laurent Rineau
cabf490132
Fix includes
2014-06-20 16:34:22 +02:00
Laurent Rineau
ad798d8390
Rename variables
2014-06-20 16:33:01 +02:00
Andreas Fabri
fa4697ba59
Add a cheap test, namely if one of the two points of segment or ray is in the bbox
...
make_mesh_3 without mesh optimizer, and criteria only on facets, is 2-4
faster on data sets like fandisk, rocker-arm.off, cheese.off
2013-12-20 17:07:12 +01:00
Sébastien Loriot
61dfe46ab9
fix regression in the Triangle_3-Triangle_3 intersection computation
...
this has been introduced when rewriting the code for the removal
of Object
2013-11-28 17:19:52 +01:00
Sébastien Loriot
e1b3a2d582
fix incorrect else
2013-09-25 18:09:42 +02:00
Andreas Fabri
6c547e5663
Mainly added includes
2013-09-13 22:24:30 +02:00
Sébastien Loriot
a19023e2ef
Merge branch 'General-fix_warning-sloriot'
...
Successfully tested in 4.3-Ic-73
2013-06-27 08:38:30 +02:00
Sébastien Loriot
7dcfef5a53
Merge branch 'Polyhedron-demo_header_cleanup_and_new_plugins-sloriot'
...
Successfully tested in CGAL-4.3-Ic-68
approved by the Release Manager
2013-06-24 12:30:25 +02:00
Sébastien Loriot
bff4e98d01
fix warnings mainly coming from the merge of the replace object feature branch
2013-06-24 08:44:47 +02:00
Sébastien Loriot
496d75c256
update licenses that were incorrect after merging replace object feature branch
2013-06-21 15:06:17 +02:00
Sébastien Loriot
3d23a59a73
Merge branch 'inside_polyhedron_test-GF'
...
Conflicts:
Polyhedron/demo/Polyhedron/CMakeLists.txt
2013-06-20 16:34:02 +02:00
iyaz
43c8084ceb
Merge branch 'inside_polyhedron_test-GF-old' into inside_polyhedron_test-GF
...
Conflicts:
.gitattributes
2013-06-11 17:56:31 +03:00
Sébastien Loriot
88cc2621a1
Result is no longer used
2013-05-23 09:12:52 +02:00
Sébastien Loriot
14429d2b8e
fix compilation errors
2013-03-14 18:32:14 +01:00
Sébastien Loriot
f97d6b8bd9
s/boost::result_of/cpp11::result_of/g
2013-03-14 10:38:13 +01:00
Sébastien Loriot
d6905c61be
Merge branch 'Kernel-replace_object-pmoeller-old' into Kernel-replace_object-pmoeller
...
Conflicts:
AABB_tree/include/CGAL/AABB_tree.h
Circular_kernel_2/include/CGAL/Circular_kernel_2/internal_functions_on_line_arc_2.h
Intersections_3/include/CGAL/Intersections_3/intersection_3_1_impl.h
Kernel_23/doc/Kernel_23/CGAL/intersections.h
Kernel_23/doc/Kernel_23/Concepts/FunctionObjectConcepts.h
STL_Extension/doc/STL_Extension/CGAL/iterator.h
2013-03-14 10:29:31 +01:00
Laurent Rineau
2d8da664a3
Merge branch 'CGAL-fix_warnings-gdamiand'
...
Conflicts:
.gitignore
Skin_surface_3/examples/Skin_surface_3/CMakeLists.txt
2013-02-22 13:02:37 +01:00
Sébastien Loriot
0a0d1c1c5d
fix conversion warning
2013-02-15 07:20:28 +01:00
Sébastien Loriot
32cd27f1d1
using coercions traits to determine a common type
...
in case FT is float, we need double as coercion_type
2013-02-14 10:20:35 +01:00
Sébastien Loriot
1ca5410df0
a plane is not a point!
2013-02-09 16:22:51 +01:00
Sébastien Loriot
0b21facc96
we must use the construction object
2013-02-08 09:26:16 +01:00
Philipp Möller
03151d7bb7
intersection_return now also uses result_of
2012-12-10 17:20:36 +01:00
Philipp Möller
81b8604c76
Move Circular intersection results from the traits to result_of
2012-12-10 15:56:09 +01:00
Philipp Möller
4c02c6d1d6
Remove unused variable
2012-12-07 18:00:46 +01:00