Commit Graph

359 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé f744b2fbec Fix placement of [[deprecated]] in old stop predicate aliases 2022-11-08 14:54:19 +01:00
Mael 7a0fbcffd2
Apply fixes from @sloriot
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2022-11-07 14:03:54 +01:00
Mael Rouxel-Labbé 837573119d Fix include guard names 2022-11-02 13:55:32 +01:00
Mael Rouxel-Labbé ba3a0d7d22 Replace SMS::Count_* stop predicates with new Edge/Face_count_* stop predicates 2022-11-02 13:46:45 +01:00
Mael Rouxel-Labbé 23bccfe1aa Remove obsolete (and wrong) comments 2022-11-02 11:03:41 +01:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
Mael Rouxel-Labbé 522a88b6bd Include config.h to get CGAL_DEPRECATED 2022-04-08 11:10:20 +02:00
Mael Rouxel-Labbé 776cfd6c90 Do not use diamond inheritance since policies can be inherited by modifiers
Modifiers such as Constrained_placement --> the initialization is broken
because the diamond inheritance was implemented using a virtual base

Simply use a common base class.
2022-03-31 23:24:20 +02:00
Sébastien Loriot 763c5e99f4 Merge pull request #6190 from MaelRL/gsoc2021-Surface_mesh_simplification-probabilistic-komaromy
Probabilistic surface mesh simplification
2022-03-30 08:05:20 +02:00
Mael Rouxel-Labbé e2aa7d2718 Fix warnings 2022-03-22 14:35:42 +01:00
Mael Rouxel-Labbé 9f359fc903 Add missing include 2022-03-15 00:13:25 +01:00
Mael Rouxel-Labbé 34c91aba5f Merge remote-tracking branch 'cgal/master' into gsoc2021-Surface_mesh_simplification-probabilistic-komaromy 2022-03-14 20:55:23 +01:00
Mael Rouxel-Labbé 56a3e64a16 Move GH calculators to internal namespace 2022-03-14 20:51:57 +01:00
Mael Rouxel-Labbé 0f8437c236 Deprecate GarlandHeckbert_policies
Use GarlandHeckbert_plane_policies and others
2022-03-14 20:50:29 +01:00
G Yuvan Shankar 45193b1487 Replaced boost::tuple with std::tuple 2022-03-10 10:50:06 +05:30
Sébastien Loriot 4328179c18 add missing include statement 2022-01-26 11:23:46 +01:00
Sébastien Loriot f04cf17d26 fix assertion 2022-01-26 10:47:05 +01:00
Laurent Rineau 3df4df43fc Merge pull request #5639 from maxGimeno/PMP-Example_of_new_mp_function-maxGimeno
Global clean-up of Named Parameters
2022-01-17 15:34:45 +01:00
Sébastien Loriot c5f78e6a9e fix warning 2022-01-13 10:16:47 +01:00
Sébastien Loriot c169c41240 Merge remote-tracking branch 'maxGimeno/PMP-Example_of_new_mp_function-maxGimeno' into HEAD 2022-01-12 13:33:49 +01:00
Sébastien Loriot 75b03e6c0a use_default_values() -> default_values() 2022-01-10 18:36:37 +01:00
Sébastien Loriot 6d3176e061 move Named_parameters class in STL_extension
helpers stay in BGL because it depends on BGL tags
2022-01-07 15:12:22 +01:00
Sébastien Loriot b04a5f9124 remove overloads with default parameters 2022-01-04 16:14:49 +01:00
Mael Rouxel-Labbé c54526d91d Re-add GH_policies.h as simple dispatcher to all specific implementations 2021-12-23 17:47:37 +01:00
Mael Rouxel-Labbé e28a459c14 Misc cleaning 2021-12-23 17:43:51 +01:00
Mael Rouxel-Labbé d964ca4e48 Naming consistency 2021-12-22 12:39:53 +01:00
Mael Rouxel-Labbé b342e11967 Refactor + improvements for Garland Heckbert methods 2021-12-22 12:03:11 +01:00
Mael Rouxel-Labbé a1b00f9206 Copy property maps 2021-12-22 12:02:53 +01:00
Mael Rouxel-Labbé fb59f96f8d Clean code 2021-12-21 10:46:59 +01:00
Mael Rouxel-Labbé 64b2056d74 Merge remote-tracking branch 'cgal/master' into gsoc2021-Surface_mesh_simplification-probabilistic-komaromy 2021-12-20 12:46:52 +01:00
Sebastien Loriot bd6408a772
Apply suggestions from code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2021-12-17 10:17:13 +01:00
Sébastien Loriot b9e2dc625a add relaxed order as parameter 2021-11-30 17:49:58 +01:00
Sébastien Loriot c61fdb831b remove the handle
it is not needed as the id map is used to store handles
2021-11-30 13:49:39 +01:00
Sébastien Loriot 9543deb304 Merge pull request #6046 from MaelRL/PM-Fix_pmaps_reference_types_master-GF
Various fixes for property maps (master)
2021-10-29 17:40:15 +02:00
Laurent Rineau 393abddc64 Merge pull request #6042 from sloriot/SMS-expensive_macros
Hide expensive assertions behind _expensive_ macros
2021-10-29 16:46:48 +02:00
Laurent Rineau 40771841ca Merge pull request #6074 from sloriot/SMS-GH_deg_faces
Workaround degenerate faces
2021-10-29 16:46:30 +02:00
Sébastien Loriot 72b8f75f48 workaround degenerate faces 2021-10-21 11:21:04 +02:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Sébastien Loriot 75e6e4500f hide expensive assertions behind _expensive_ macros 2021-10-11 11:57:24 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Julian Komaromy 3879874387 remove TODOs 2021-08-20 11:35:33 +02:00
Julian Komaromy 55166781e3 remove unused file 2021-08-20 11:35:20 +02:00
Julian Komaromy 390e73d1ba clean up property maps 2021-08-20 11:35:06 +02:00
Julian Komaromy 7744b38afe fix calculating row instead of col 2021-08-03 14:49:10 +02:00
Julian Komaromy 61eca278e6 remove unused files 2021-08-02 16:38:02 +02:00
Julian Komaromy e2054ad648 triangle policies use functions 2021-08-02 16:35:15 +02:00
Julian Komaromy dccb3ddd5f change classic plane to use functions 2021-08-02 15:53:42 +02:00
Julian Komaromy 6bcbe45a6f switch prob plane to use functions 2021-08-02 15:37:39 +02:00
Julian Komaromy 8d16ff5a03 gather quadrics in one file 2021-08-02 12:21:04 +02:00
Julian Komaromy 78f0b75ce5 add missing include 2021-07-26 16:39:15 +02:00