Commit Graph

115 Commits

Author SHA1 Message Date
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Sébastien Loriot d3b13fb11c Merge branch 'cgal/5.5.x-branch' 2022-12-05 19:00:39 +01:00
Sébastien Loriot 0fb05d1480 fix warning 2022-11-15 20:04:23 +01:00
albert-github eed54a0ae5 spelling corrections
Some spelling corrections (Directories starting with `O`-`S` , first part),
some backward work
some forward work
2022-11-15 18:45:39 +01:00
Jane Tournois 38fd07dfc4 differentiate has_normal_map() between const and non-const point set 2022-11-08 10:24:43 +01:00
Jane Tournois 826b2a19c4 Merge branch 'PSP-fix_has_normal_map-GF' of https://github.com/janetournois/cgal into PSP-fix_has_normal_map-GF 2022-11-07 13:15:55 +00:00
Jane Tournois 32486e4be8 precise default normal 2022-11-07 14:14:30 +01:00
Jane Tournois a24c6ac84c
Apply suggestions from Mael's code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2022-11-07 14:13:18 +01:00
Sebastien Loriot 1a226ed877
Restore [revious API 2022-11-07 10:41:22 +01:00
Jane Tournois 9ed334bcf9 now normal_map is always valid
since it is created before it's used, when not available
2022-11-04 14:27:09 +01:00
Jane Tournois dcf0ea09b3 create normal_map when not already created before usage 2022-11-04 14:12:52 +01:00
Jane Tournois 0ee5493f02 revert unintended change 2022-10-25 12:53:39 +02:00
Jane Tournois e99f442830 NP_helper::has_normal_map should not always return true
look for a normal_map in the point set, and in the named parameters

# Conflicts:
#	BGL/include/CGAL/boost/graph/named_params_helper.h
#	Point_set_processing_3/include/CGAL/jet_estimate_normals.h
2022-10-25 12:12:29 +02:00
Andreas Fabri 1c28b3df45 Point_set_3: Fix typos in the reference manual page 2022-10-24 15:15:50 +01:00
Mael Rouxel-Labbé b24959c688 Add a typedef to make NP helpers work with Point_set_3 2022-04-04 11:33:27 +02:00
Andreas Fabri 440a8dfb7b Fix file name 2022-02-03 08:41:04 +00:00
Andreas Fabri 735752bec9 Do the remaining changes after Laurent's check 2022-02-03 08:02:11 +00:00
Sébastien Loriot 6d3176e061 move Named_parameters class in STL_extension
helpers stay in BGL because it depends on BGL tags
2022-01-07 15:12:22 +01:00
Sébastien Loriot f7c8e4919a add static function to check for the presence of a normal map 2022-01-07 13:10:29 +01:00
Sébastien Loriot 5f1803489b replaces overloads with default NamedParameters for Point_set_processing_3
+enhancement of the NP for Point_set_processing_3
2022-01-06 15:11:23 +01:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Laurent Rineau 412881645c Merge pull request #5369 from sgiraudot/Point_set_3-Fix_broken_properties_and_types-GF
[Point Set 3] Fix broken properties and types
2021-02-18 15:23:28 +01:00
Simon Giraudot d257d999fb Fix function properties_and_types() 2021-01-18 15:49:55 +01:00
Mael Rouxel-Labbé 0d66e19361 IO documentation fixes
See @sloriot's review:

https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Polgyon_soup_mesh_IO/2nd_round/Answer_to_review

(+ some commits before and after this one)
2020-07-24 17:06:00 +02:00
Mael Rouxel-Labbé 26355e2e32 Uniformize capital / third person usage of \brief 2020-06-25 15:13:47 +02:00
Mael Rouxel-Labbé e09eb39a80 Misc cleaning 2020-06-21 11:39:14 +02:00
Mael Rouxel-Labbé 07017616ec Organize Point_set_3 I/O + various fixes along the way 2020-06-19 15:34:49 +02:00
Mael Rouxel-Labbé 038869cab9 Merge remote-tracking branch 'cgal/master' into CGAL-Improve_NP_doc_presentation-GF 2020-05-12 15:12:21 +02:00
Sébastien Loriot 157bdbda08 Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-04-22 13:26:52 +02:00
Simon Giraudot 589eb8c01f Fix warnings with float kernel 2020-04-16 09:23:40 +02:00
Mael Rouxel-Labbé 16092f53d6 Update doc about NPs 2020-04-05 17:56:11 +02:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Sébastien Loriot 590612a563 run the script to remove tabs and trailing whitespaces 2020-03-26 13:25:16 +01:00
Laurent Rineau 57779dd5c6 Merge pull request #4437 from sgiraudot/Point_set_3-Fix_missing_copy_constructor-GF
Point_set_3: add missing copy constructor
2020-01-15 17:31:52 +01:00
Simon Giraudot e728b74ad6 Point_set_3: add missing copy constructor 2019-12-30 16:42:05 +01:00
Sébastien Loriot 254d60f642 First pass on removing license notice in header for GPL files 2019-10-19 15:23:19 +02:00
Sébastien Loriot 7356421d80 introduce Commercial license SPDX tag 2019-10-19 12:15:19 +02:00
Sébastien Loriot 9bd9c68b83 update LGPL[23]+ and GPL[23]+ SPDX tags
ack -l --no-svg "SPDX-License-Identifier: GPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-3.0+/SPDX-License-Identifier: GPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-3.0+/SPDX-License-Identifier: LGPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: GPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-2.0+/SPDX-License-Identifier: GPL-2.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-2.0+/SPDX-License-Identifier: LGPL-2.0-or-later/"
2019-10-18 21:57:54 +02:00
Sébastien Loriot 25a05e9f4c Merge branch 'CGAL-named_function_parameters-4.14' into master
Conflicts resolved by hand
2019-07-28 23:46:43 +02:00
Sébastien Loriot 2f81a21523 Merge 'CGAL-named_function_parameters' for 4.13-branch into 4.14-branch
Conflicts resolved by hand
2019-07-28 22:30:13 +02:00
Sébastien Loriot 560c77f567 rename named function parameter class 2019-07-15 06:25:02 +02:00
Sébastien Loriot 983645a51a match @{ and @} 2019-07-05 21:49:46 +02:00
Andreas Fabri e2d19b0c8d Replace NULL and Nullptr_t with nullptr and nullptr_t 2019-06-04 23:45:44 +02:00
Laurent Rineau 90782d4b7f Revert the merge of two pull-requests that target CGAL-4.14-branch
- Revert "Merge pull request #3857 from MaelRL/CGAL-Fix_duplicate_non_manifold_vertices-GF"
- Revert "Merge pull request #3898 from lrineau/Mesh_3-stop_during_protection-lrineau"
2019-05-14 17:50:45 +02:00
Laurent Rineau f5836b2206 Merge branch 'releases/CGAL-4.13-branch' 2019-03-07 14:31:16 +01:00
Sébastien Loriot 3887a21429 add missing text for brief of advanced class/type/function/concept 2019-03-05 08:01:17 +01:00
Simon Giraudot 458e1c7b80 Update with change of ref tag 2019-02-07 11:36:05 +01:00
Simon Giraudot 8c0417b6c5 Document garbage_size() properly 2019-02-07 11:36:04 +01:00
Simon Giraudot 1b7a2eb2c5 Replace cancel_removal() by cancel_removals() 2019-02-07 11:36:04 +01:00