Commit Graph

101743 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 3be8469277 Move build into 'internal' namespace 2022-07-04 11:41:44 +02:00
Mael Rouxel-Labbé d934a0465f Test range of array faces in repair_polygon_soup() 2022-07-04 11:41:44 +02:00
Mael Rouxel-Labbé 1d47a29224 Add an overload of repair_polygon_soup for array-based soups
which does not call functions that are meaningless for ranges
of fixed size faces
2022-07-04 11:41:44 +02:00
Mael Rouxel-Labbé a691eeff97 Rewrite merge_duplicate_points_in_polygon_soup() without container.insert(...) 2022-07-04 11:41:44 +02:00
Niklas Hambüchen c53ae08deb Spatial_searching: unsigned int -> size_t for vector copy 2022-07-04 11:38:14 +02:00
Sébastien Loriot 1e364e5516 rename macros 2022-07-04 11:26:49 +02:00
Sébastien Loriot 49ca357d49 Merge remote-tracking branch 'cgal/5.5.x-branch' 2022-07-04 10:53:00 +02:00
Sébastien Loriot a4e53600c1 Merge remote-tracking branch 'cgal/5.4.x-branch' 2022-07-04 10:52:16 +02:00
Sebastien Loriot d218b32cf9
Merge pull request #6639 from sloriot/PMP-clip_deg_faces
Handle deg faces in clip with allow_self_intersections
2022-07-04 10:48:30 +02:00
Sebastien Loriot ee683224fe
Merge pull request #6674 from afabri/Polyhedron-accelerate_delete_items-GF
Polyhedron_3:  Accelerate removal of many items
2022-07-04 10:48:19 +02:00
Sebastien Loriot 6d6791456a
Merge pull request #6711 from sloriot/CGAL-constexpr
Add some constexpr for constant functions
2022-07-04 10:48:08 +02:00
Sebastien Loriot 696ec4f21a
Merge pull request #6695 from afabri/Surface_mesh_segmentation-leak-GF
Surface_mesh_segmentation: fix the memory leak
2022-07-04 10:47:29 +02:00
Sebastien Loriot 31010b0820
Merge pull request #6707 from sloriot/NT-fix_fwd_dcl
Fix forward declaration living in the wrong namespace
2022-07-04 10:47:16 +02:00
Sebastien Loriot b0a4263eb6
Merge pull request #6713 from sloriot/PMP-radf_no_nm_vertices
Avoid creating border non-manifold vertices
2022-07-04 10:47:04 +02:00
Guillaume Damiand 1d9280afae Update basic viewer to set camera mode ealier (following Efi issue). TODO: test if this solves the bug. 2022-07-04 10:04:20 +02:00
Efi Fogel 28f3f28144 Fixed a small bug in Is_between_cw_2 2022-07-04 09:03:28 +03:00
Efi Fogel 17906d39aa Fixed spelling in comment 2022-07-04 09:01:40 +03:00
Efi Fogel 5c40db8591 Implemented Compare_y_at_x_2 functor in the adapter; it takes boundary conditions into consideration. 2022-07-03 19:39:20 +03:00
Efi Fogel b390c0e3db Fixed typo in comment 2022-07-03 19:38:23 +03:00
Efi Fogel ed27ca760e Fixed spelling typo. 2022-07-03 19:37:39 +03:00
Mael Rouxel-Labbé 1c19734490 Add missing header include 2022-07-02 18:02:44 +02:00
Mael Rouxel-Labbé 711d64674a Less_signed_... --> Compare_signed_... in CH3 adapters 2022-07-02 17:19:48 +02:00
Mael Rouxel-Labbé 75441da5ed Remove a disable_warning.h 2022-07-01 23:49:57 +02:00
Mael Rouxel-Labbé 2e330b1342 Improve CH2 tests 2022-07-01 23:49:31 +02:00
Mael Rouxel-Labbé e4e52c8391 Misc doc cleaning 2022-07-01 23:46:10 +02:00
Laurent Rineau 4c5b5843e3 sed -i -e 's/egrep/grep -E/g' 2022-07-01 16:19:36 +02:00
Laurent Rineau 15238156b9 Merge pull request #6725 from albert-github/feature/bug_SMDS_3_link
SMDS_3 Incorrect link
2022-07-01 15:20:50 +02:00
Laurent Rineau b002d3898a Merge pull request #6730 from afabri/Orthtree_memory_leak-GF
Orthtree: Fix in test code
2022-07-01 15:20:48 +02:00
Mael Rouxel-Labbé 13b4060644 Fix eddy/bykat returning collinear vertices on the hull
In these two algorithms, points farthest from a line must be found.
In case of multiple points at the same distance, an "extremity"
of this set of points must be returned.

This was properly documented in the Less_signed_distance_to_line_2
functor of the ConvexHullTraits_2 concept:

[ ... ]
The predicate must provide a total order compatible with convexity,
<I>i.e.</I>, for any line segment \f$ s\f$ one of the endpoints
of \f$ s\f$ is the smallest point among the points on \f$ s\f$,
with respect to the order given by `Less_signed_distance_to_line_2`.
[ ... ]

And specific models did respect this requirement. However, the kernel
is supposed to also be a model of ConvexHullTraits_2, but
Kernel_23::LessSignedDistanceToLine_2 does not require this, and
the models (EPICK, Simple_Cartesian, etc.) do not implement it.
Hence, if a kernel was used as geometric traits for 2D Convex Hull
algorithms, one might not get the expected extreme point when
there are multiple points at the same distance to a line at some
point in the algorithm.

The algorithm recovered, but this created extra points on the hull.

Fixing the functor in the kernel would create an inconsistency
with Kernel_23::Compare_signed_distance_to_line_2, so instead
this commit changes the concept and the code to require
providing Compare_signed_distance_to_line_2 and then uses Less_xy
in the code in case of EQUAL return (that is actually how it was
done in the Convex_hull_2-specific versions of the ConvexHullTraits_2
model).
2022-07-01 13:35:59 +02:00
Andreas Fabri efddc4ae84 Orthtree: Fix in test code 2022-06-30 15:57:21 +01:00
Mael Rouxel-Labbé 93c47ec702 Use cmp_signed_dist_to_directionC2 for Compare_signed_distance_to_line_2 2022-06-30 16:23:09 +02:00
Mael Rouxel-Labbé 2b245d870e Remove long-deprecated Convex_hull_2 projection traits 2022-06-30 15:20:23 +02:00
Mael Rouxel-Labbé 96e565777f Remove useless "using namespace boost" (boost::bind was replaced with lambdas) 2022-06-30 09:32:45 +02:00
Mael Rouxel-Labbé 6b6bfaae4f Fix CH3 doc links within CH2 2022-06-30 09:31:19 +02:00
Sébastien Loriot b411e262f8 add missing const 2022-06-30 09:22:44 +02:00
Sébastien Loriot 10903485c5 rename typedef 2022-06-30 09:19:31 +02:00
Laurent Rineau 821e3ba71f Merge branch '5.5.x-branch'
# Conflicts:
#	Installation/include/CGAL/version.h
#	Installation/lib/cmake/CGAL/CGALConfigVersion.cmake
2022-06-29 14:55:06 +02:00
Laurent Rineau 10f5fa4f1e Prepare CGAL-5.5 2022-06-29 14:52:29 +02:00
Laurent Rineau cc4e10143e updated crontab (automated commit) 2022-06-29 14:42:36 +02:00
Sébastien Loriot 96d2f9ec5e unused variable 2022-06-29 13:10:20 +02:00
Laurent Rineau bfe3ce2fcf Merge pull request #6602 from lrineau/Triangulation_2-fix_cdt_2-GF
Try to fix CDT_2 with inexact construction of intersections
2022-06-29 12:32:26 +02:00
Laurent Rineau 3069ec8385 Merge branch '5.5.x-branch' into Triangulation_2-fix_cdt_2-GF 2022-06-29 12:31:08 +02:00
Laurent Rineau 561cc66264 Backport the patch of pull request #6602 from lrineau/Triangulation_2-fix_cdt_2-GF
Try to fix CDT_2 with inexact construction of intersections
2022-06-29 12:30:35 +02:00
albert-github 5b31fc4579 SMDS_3 Incorrect link
We get the warning:
```
SMDS_3/include/CGAL/tetrahedron_soup_to_triangulation_3.h:210: warning: unable to resolve link to 'polygon_soup_to_polygon_mesh()' for \link command
```

see also:
- https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-5.6-Ic-16/logs_master/SMDS_3.log
- https://github.com/CGAL/cgal/pull/6645
2022-06-29 12:21:07 +02:00
Sébastien Loriot 9634d9321a add missing off 2022-06-29 11:29:12 +02:00
Sébastien Loriot 707b45cb5b Merge remote-tracking branch 'cgal/5.5.x-branch' 2022-06-29 10:48:00 +02:00
Sébastien Loriot f1f201b542 Merge remote-tracking branch 'cgal/5.4.x-branch' into HEAD 2022-06-29 10:47:14 +02:00
Sébastien Loriot 373deccfb6 constexpr function requires even parameters to be LiteralType 2022-06-29 10:36:34 +02:00
Laurent Rineau 42e993c7da Merge pull request #6587 from afabri/PMP-triangle-GF
PMP::Add function triangle(face_descriptor, tmesh)
2022-06-29 09:52:19 +02:00
Laurent Rineau 686535da79 Merge pull request #6645 from albert-github/feature/bug_symbol_resolver
Corrections for more strict doxygen symbol resolver
2022-06-29 09:52:17 +02:00