Commit Graph

85276 Commits

Author SHA1 Message Date
Laurent Rineau f47b7bb7ab Merge pull request #3668 from afabri/PSP-example_with_less_points-GF
PSP: Reduce the size of the data set in an example
2019-02-13 15:38:28 +01:00
Laurent Rineau 82dd2b5cda Merge pull request #3669 from afabri/Triangulation_2-maybe_not_intialized-GF
Triangulation_2: Initialize to avoid warning
2019-02-13 15:38:25 +01:00
Laurent Rineau b367aabffd Merge pull request #3670 from afabri/Periodic_T3-initialize_Point_3-GF
Periodic_3_triangulation_3 demo: Initialize Point_3
2019-02-13 15:38:22 +01:00
Laurent Rineau 346e5e3b66 Merge pull request #3671 from sloriot/PMP-fix_autoref_with_garbage
Use only initialized values
2019-02-13 15:38:19 +01:00
Laurent Rineau 03ed66d894 Merge pull request #3673 from lrineau/AABB_tree-triangulation_3_cell_primitive-GF
New undocumented AABB primitive: cells of a 3D triangulation
2019-02-13 15:38:16 +01:00
Laurent Rineau db91d861a8 Merge pull request #3674 from afabri/Mesh_3-no_parallel_sliver_exudation-GF
Mesh_3: Disable parallel sliver exudation in VC++ debug in the testsuite
2019-02-13 15:38:13 +01:00
Laurent Rineau 2fa9206735 Merge pull request #3675 from sloriot/Doc-fix_nav_tree_hack
fix navtree hack
2019-02-13 15:38:10 +01:00
Laurent Rineau 5d9c45ac20 Merge pull request #3639 from sgiraudot/OTR-Fix_copy_star-GF
OTR: Fix validity of triangulation
2019-02-13 15:36:35 +01:00
Laurent Rineau 3e9d7b90b0 Merge pull request #3675 from sloriot/Doc-fix_nav_tree_hack
fix navtree hack
2019-02-13 15:36:33 +01:00
Maxime Gimeno bfa12738a6 Une CGAL_assume(false) for the default 2019-02-13 15:18:32 +01:00
Maxime Gimeno c6fe1f50b4 Use the Locate_type 2019-02-13 14:04:39 +01:00
Maxime Gimeno 959d65a5ee Also fix a warning in kernel 2019-02-13 13:45:16 +01:00
Maxime Gimeno 8144b7001f static_cast count() as int to avoid warnings with some versions of ipe that make count() a std::size_t. 2019-02-13 11:12:25 +01:00
Maxime Gimeno 90b6c43cde Toggle the flying ball by default. 2019-02-13 10:19:13 +01:00
Laurent Rineau 27f082a3b0
Merge pull request #3677 from maxGimeno/Travis-Update_to_xenial-GF
Travis add missing dep to qt5 sql
2019-02-13 09:10:00 +00:00
Maxime Gimeno b7fbac9bea Fix crash in p3t3_demo when inserting point and drawing conflicts. 2019-02-13 10:04:13 +01:00
Andreas Fabri 7fc2b8e80e Initialize data member; remove mutable 2019-02-12 17:29:30 +01:00
Sébastien Loriot 0f9f217f50 add an important note for first_intersection 2019-02-12 16:10:41 +01:00
Maxime Gimeno ca4f5e12ed Merge remote-tracking branch 'cgal/master' into Periodic_4_hyperbolic_triangulation_2-IIordanov 2019-02-12 15:58:49 +01:00
Maxime Gimeno b97ed0bc29 add libqt5sql5-sqlite to the dependencies for p3t3 demo 2019-02-12 14:54:08 +01:00
Laurent Rineau d94a9d139a Add a new test
This test verifies that `Polyhedral_mesh_domain_with_features_3` can
be used without calling `detect_features()`, with both `Polyhedron_3`
and `Surface_mesh`.
2019-02-12 14:38:51 +01:00
Laurent Rineau 24bccaa8ff Initialize the face_patch_id_t pmap before adding to the AABB tree 2019-02-12 14:38:01 +01:00
Laurent Rineau ef48d053ad Revert that patch, that breaks the testsuite 2019-02-12 14:26:24 +01:00
Andreas Fabri 6ce4122908 More places where we have to disable parallel exudation 2019-02-12 13:42:29 +01:00
Maxime Gimeno 8541cf453b Initialize maps for all stored polyhedra in domain constructors. 2019-02-12 12:34:30 +01:00
Maxime GIMENO 73a22a8655 Remove QGLViewer from travis (#3676) 2019-02-12 11:06:29 +00:00
Maxime GIMENO d884aaadea Travis: Upgrade travis to xenial (#3666)
Upgrade travis to xenial
2019-02-12 08:23:09 +00:00
Laurent Rineau 1c6b15a49e
Commit my version 2019-02-11 15:36:25 +00:00
Sébastien Loriot d6cb114940 fix navtree hack
in recent doxygen version hash is always '#' making our check failing
The fix is to fallback to default used later one
2019-02-11 16:35:03 +01:00
Andreas Fabri 616fb5dd51 Mesh_3: Disable parallel sliver exudation in VC++ debug in the testsuite 2019-02-11 16:06:34 +01:00
Andreas Fabri 14663ea7b4 A circular_arc constructed from 3 points is not _full 2019-02-11 15:22:17 +01:00
Andreas Fabri d8bef63907 Do not initialize in the default constructor of circular_arc_3 2019-02-11 14:58:18 +01:00
Laurent Rineau 896d5a7bd9 Quiet a warning [-Wmaybe-uninitialized]
```
[ 50%] Building CXX object CMakeFiles/test_exact_offset.dir/test_exact_offset.cpp.o
/usr/local/bin/c++  -DCGAL_TEST_SUITE=1 -DCGAL_USE_CORE=1 -DCGAL_USE_GMP -DCGAL_USE_MPFR -isystem /usr/include/x86_64-linux-gnu -I/home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2 -I/home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/include -I/mnt/testsuite/include  -DDONT_USE_BOOST_PROGRAM_OPTIONS -Wall -Wextra -O3 -DCGAL_NDEBUG -frounding-math   -Wall -frounding-math -o CMakeFiles/test_exact_offset.dir/test_exact_offset.cpp.o -c /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2/test_exact_offset.cpp
In file included from /mnt/testsuite/include/CGAL/Cartesian/Weighted_point_2.h:29,
                 from /mnt/testsuite/include/CGAL/Cartesian/Cartesian_base.h:34,
                 from /mnt/testsuite/include/CGAL/Cartesian.h:29,
                 from /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2/test_exact_offset.cpp:16:
/mnt/testsuite/include/CGAL/Handle_for.h: In function 'OutputIterator CGAL::partition_approx_convex_2(InputIterator, InputIterator, OutputIterator, const Traits&) [with InputIterator = __gnu_cxx::__normal_iterator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >*, std::vector<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >, std::allocator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> > > > >; Traits = CGAL::Partition_traits_2<Rat_kernel>; OutputIterator = std::back_insert_iterator<std::__cxx11::list<CGAL::Polygon_2<Rat_kernel, std::__cxx11::list<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >, std::allocator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> > > > >, std::allocator<CGAL::Polygon_2<Rat_kernel, std::__cxx11::list<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> >, std::allocator<CGAL::Point_2<CGAL::Cartesian<CORE::BigRat> > > > > > > >]':
/mnt/testsuite/include/CGAL/Handle_for.h:313:12: warning: '*((void*)& target +40)' may be used uninitialized in this function [-Wmaybe-uninitialized]
  313 |     return *(h.Ptr());
In file included from /mnt/testsuite/include/CGAL/partition_2.h:30,
                 from /mnt/testsuite/include/CGAL/Minkowski_sum_2/Decomposition_strategy_adapter.h:31,
                 from /mnt/testsuite/include/CGAL/Polygon_convex_decomposition_2.h:27,
                 from /home/cgal_tester/build/src/cmake/platforms/Ubuntu-latest-GCC6-Release/test/Minkowski_sum_2/test_exact_offset.cpp:22:
/mnt/testsuite/include/CGAL/Partition_2/partition_approx_convex_2.h:173:23: note: '*((void*)& target +40)' was declared here
  173 |    Circulator source, target, before_s, after_s;
      |                       ^~~~~~
```

It seems sufficient to declare the variables at a smaller
scope. Strange...
2019-02-11 14:50:50 +01:00
Laurent Rineau 0241fdc3eb Compatibility with both Point_3 and Weighted_point_3 2019-02-11 13:46:06 +01:00
Laurent Rineau 9c426075b6 Optimized version of do_intersect with Tetrahedron_3 and something
The optimization is to delay the switch to the exact number type as
much as possible.

I was not able to find a good benchmark showing the improvement,
though. Maybe because the `do_intersect(Bbox_3, Triangle_3)` is not
optimized the same way.
2019-02-11 13:31:40 +01:00
Laurent Rineau d216131c79 New undocumented AABB primitive: cells of a 3D triangulation
The `Scene_c3t3_item` from our 3D demos now uses an AABB tree of
cells, instead of an AABB tree of triangles. That divides the number
of primitives by 4, and save times:

Before:
```
C3t3 facets AABB tree built in 22.010006904602051 wall-clock seconds
Scene_c3t3_item_priv::computeIntersections in 0.50893402099609375 wall-clock seconds
```

After:
```
C3t3 cells AABB tree built in 13.072829008102417 wall-clock seconds
Scene_c3t3_item_priv::computeIntersections in 0.41458892822265625 wall-clock seconds
```

The gain seems mostly in the construction of the tree (40% saved), and
the gain on the queries seems lower (about 20%).
2019-02-11 13:22:11 +01:00
Maxime Gimeno c650f26c23 Fix OFF reader to detect sooner the flux errors. 2019-02-11 12:45:27 +01:00
Andreas Fabri 507ebe1b83 Let's give it another try? 2019-02-11 10:43:12 +01:00
Maxime Gimeno fecc589b4c Move restoreoverridecursor() 2019-02-11 10:25:47 +01:00
Maxime Gimeno c7a77e1a97 Fix typo 2019-02-11 10:15:24 +01:00
Maxime Gimeno f146d099ac Fix selection_files loading 2019-02-11 10:14:29 +01:00
Andreas Fabri 6853a9202d Fix Algebraic_kernel 2019-02-11 10:10:37 +01:00
Maxime Gimeno d76c163807 Fix the Final Fixes 2019-02-11 09:39:26 +01:00
Iordan Iordanov 5731a61554 added failsafe check to remove(): if cycles of length 2 are created, the operation is canceled and the triangulation is restored to its previous state 2019-02-10 22:42:51 +01:00
Iordan Iordanov 025f2a94a5 a few modifications to removal test files (removed unnecessary iteration and assertion that can be false) 2019-02-10 22:38:56 +01:00
Andreas Fabri de77dbd5eb cleanup 2019-02-08 16:49:58 +01:00
Andreas Fabri ce5472de15 Don't test on two files but on random points again 2019-02-08 16:39:42 +01:00
Maxime Gimeno e679c824af Make the deletion of an item faster 2019-02-08 16:32:03 +01:00
Maxime Gimeno f5f2ebfb51 Force Fusion style for colored button so they are displayed on all platforms. 2019-02-08 14:26:02 +01:00
Maxime Gimeno aad63b61ff Remove "as Surface_mesh" 2019-02-08 13:14:36 +01:00