Commit Graph

2980 Commits

Author SHA1 Message Date
Andreas Fabri 5b08570345
Update Mesh_3/include/CGAL/Polyhedral_mesh_domain_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:57:41 +02:00
Andreas Fabri 21b9f6dfb5
Update Mesh_3/include/CGAL/Mesh_cell_criteria_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:57:09 +02:00
Andreas Fabri 1963697d84
Update Mesh_3/include/CGAL/Mesh_cell_criteria_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:56:32 +02:00
Andreas Fabri 7bc4b30501
Update Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:52:13 +02:00
Andreas Fabri 54fbebf2b6
Update Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:51:38 +02:00
Andreas Fabri 7f20c6b773
Update Mesh_3/include/CGAL/Polyhedral_mesh_domain_with_features_3.h
Co-authored-by: Jane Tournois <janetournois@users.noreply.github.com>
2023-07-27 11:51:13 +02:00
Laurent Rineau a746283359 Merge pull request #7552 from MaelRL/Mesh_3-PMD_init_bug_fixes-GF
Fix initialisation issues in Mesh_3
2023-07-26 17:34:33 +02:00
Laurent Rineau 820b1c5609 Merge pull request #7552 from MaelRL/Mesh_3-PMD_init_bug_fixes-GF
Fix initialisation issues in Mesh_3
2023-07-26 17:30:40 +02:00
Mael Rouxel-Labbé 1f258bc84d Fix initialization failing if the ray's source is on the domain
This is a band aid fix, a proper fix is to rework the full initilization
pipeline. This is the purpose of the following pull request:
https://github.com/CGAL/cgal/pull/7606
2023-07-19 12:46:13 +02:00
Mael Rouxel-Labbé 0d3458504b Add some debug code 2023-07-12 10:47:17 +02:00
Mael Rouxel-Labbé 49bb14b6d2 Fix not rescaling some balls in 2D protection with non-zero minimal weight
The code break'd but did not restart if a special ball was encountered
2023-07-12 10:03:14 +02:00
Mael Rouxel-Labbé 6f65ecf246 Check the cached Boolean before doing more complex geometrical checks 2023-07-12 09:44:03 +02:00
albert-github 301728a8a9 issue #7395 Improvement of layout of model relations
- Completed the cgalModels part
2023-07-09 12:43:36 +02:00
Sébastien Loriot b66afab814 Merge remote-tracking branch 'sloriot/CGAL-using_c++17_stl' into HEAD 2023-07-05 11:29:35 +02:00
Sébastien Loriot 68813c5c63 Merge pull request #7403 from sloriot/CGAL-replace_boost_by_std
Replace boost by std
2023-07-05 11:08:36 +02:00
Sébastien Loriot 62f22e9a6c use oformat for optional 2023-06-29 10:43:56 +02:00
Mael Rouxel-Labbé 39c0a9fb33 Fix returning no intersection for a ray with spawn in a triangle 2023-06-26 17:15:49 +02:00
Mael Rouxel-Labbé 308ee5c967 Minor debug readability improvements 2023-06-26 17:10:58 +02:00
Mael Rouxel-Labbé fbecb18f49 Fix bad comparison 2023-06-26 17:10:06 +02:00
Andreas Fabri 28dbd6b8ee allow -> enable 2023-06-24 10:37:39 +01:00
Andreas Fabri 0f4f903f60 merge cgal/master 2023-06-24 10:24:15 +01:00
Sébastien Loriot dfc386d65b Merge branch 'master' into HEAD 2023-06-22 14:05:45 +02:00
Laurent Rineau 4afd96e95d Merge pull request #7527 from janetournois/Mesh_3-fix_weighted_image_oracle-jtournois
Mesh_3 for weighted images - fix translated labeled image case
2023-06-22 11:59:29 +02:00
Laurent Rineau 63398aa5a0 Merge pull request #7527 from janetournois/Mesh_3-fix_weighted_image_oracle-jtournois
Mesh_3 for weighted images - fix translated labeled image case
2023-06-22 11:58:45 +02:00
Sébastien Loriot 0ee31a5d4f remove extra parenthesis 2023-06-19 19:17:49 +02:00
Sébastien Loriot f936680600 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 18:48:39 +02:00
Jane Tournois c9b04ebc97 apply input image translation to image with weights wrapper 2023-06-15 15:05:39 +02:00
Sébastien Loriot bdfa15c08f fixes after merge 2023-06-15 11:34:14 +02:00
Sébastien Loriot 9cdfe70abb Merge remote-tracking branch 'sloriot/CGAL-toward_6.0' 2023-06-15 11:34:09 +02:00
Sébastien Loriot bbc48b2c7e more fixes
use Mesh_3::internal::get_index
std::dynamic_point_cast
std::get_if
2023-06-15 10:57:10 +02:00
Sébastien Loriot 56499e017d do not use API that did not go into the standard 2023-06-15 10:57:10 +02:00
Sébastien Loriot 9a0bdb5d96 boost::variant ---> std::variant 2023-06-15 10:57:10 +02:00
Sébastien Loriot 604dcdc435 boost::optional => std::optional 2023-06-15 10:57:09 +02:00
Sébastien Loriot bbc4d08ee0 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 10:47:07 +02:00
Sébastien Loriot c8a88b9014 remove CGAL_static_assertion* 2023-06-15 10:42:10 +02:00
Sébastien Loriot e54408370b remove CGAL_CXX17 macro
... and no longer used macros
2023-06-15 10:41:56 +02:00
Mael Rouxel-Labbé cab9751987 Merge remote-tracking branch 'cgal/master' into Mesh_3-doc_fixes-GF 2023-05-31 11:30:19 +02:00
Sebastien Loriot b1b02d64fe
P3M3: Non-cubic domains, fixes, improvements (#7062)
## Summary of Changes

- Add a dummy point generator that is agnostic to the periodic domain's
geometry, allowing P3M3 to handle non-cubic domain.
- Add an example of P3M3 running on polyhedral domains.
- Fix a few issues in SMDS_3's tet soup reading relating to
non-manifoldness + general IO code speed improvements.
- Fix a few issues in P3M3's medit output and always duplicate facets to
reduce the quantity of non-manifoldness occurences.
- Fix an issue with including Mesh_3 headers before P3M3's.
- Fix periodic point projection (for Mesh_3 optimizers) badly computing
the projection direction
- Robustify a handful of P3M3 functions that were using intermediate
constructions rather than the <Point, Offset> API (which uses filtered
predicates and thus yields proper robustness)
- Misc minor code cleaning / modernization

ToDo:
- [x] Check if some medit IO issues are fixed
- [x] Add non-manifoldness flag to read_MEDIT
- [x] Fix value of orthosphere_radius_threshold
- [x] Check calls of insert_dummy_points() (use generic)
- [x] Check doc of P3M3 about cubic domains requirement

Not done:
- [ ] Fix sharp features for periodic polyhedral domains (problems due
to changing weights creating cover change...). Code:
https://gist.github.com/MaelRL/357c52dc04e16a162f13a3c6860a1398; WIP
diff: https://gist.github.com/MaelRL/f98809964acffbacb6d3f42793e2654e

## Release Management

* Affected package(s): `Mesh_3`,  `P3M3`, `P3T3`, `SMDS3`
* Issue(s) solved (if any): Fix #6997, Fix #7214
* Feature/Small Feature (if any): TODO
* License and copyright ownership: no change
2023-05-30 19:13:45 +02:00
Mael Rouxel-Labbé b3fe07a51d Remove deprecated labeled mesh domains 2023-05-26 13:47:15 +02:00
Mael Rouxel-Labbé 97097f1f04 misc fixes 2023-05-26 13:19:19 +02:00
Mael Rouxel-Labbé 525338eec2 Haronize Gt/GT/etc. 2023-05-26 12:52:35 +02:00
Mael Rouxel-Labbé c3873374ce Carry the template parameter (as it should be if it were actually in use)
It is in fact CGAL::Default and unused everywhere, but it's clearer
this way.
2023-05-25 14:56:46 +02:00
Mael Rouxel-Labbé 13f8044027 Remove more (needless) doc appearances of TriangleAccessor 2023-05-25 14:56:16 +02:00
Mael Rouxel-Labbé bc45a00194 Undocument TriangleAccessor_3 and CGAL::Triangle_accessor_3 as they are unused 2023-05-25 12:08:01 +02:00
Andreas Fabri 0c29013c3d Polish 2023-05-23 09:58:41 +01:00
Andreas Fabri 79ce772e71 various 2023-05-22 18:46:09 +01:00
Andreas Fabri 95f150a16c various 2023-05-22 16:51:33 +01:00
Andreas Fabri 585dc0f424 various 2023-05-22 13:36:24 +01:00
Andreas Fabri 710219ed6d various 2023-05-22 13:12:46 +01:00
Andreas Fabri 1b4d4e0eb0 various 2023-05-22 12:49:33 +01:00
Andreas Fabri b1137e9d83 various 2023-05-22 12:19:44 +01:00
Andreas Fabri 9f241c89c5 rename template parameters 2023-05-19 18:42:56 +01:00
Andreas Fabri bf79ecd8ad fixes 2023-05-17 21:05:29 +01:00
Andreas Fabri a827d9ab67 fixes 2023-05-17 11:11:25 +01:00
Andreas Fabri 3ca05f4918 fixes 2023-05-17 09:28:25 +01:00
Andreas Fabri b6531a76d1 fixes 2023-05-16 16:22:48 +01:00
Andreas Fabri fdcdd1a9eb fixes 2023-05-16 12:50:07 +01:00
Andreas Fabri 90773e8806 fixes 2023-05-16 12:41:17 +01:00
Andreas Fabri e9583a69d0 fixes 2023-05-16 12:38:50 +01:00
Andreas Fabri 26369cb81b fixes 2023-05-16 12:33:14 +01:00
Andreas Fabri cec7c3dccc Fix some warnings 2023-05-16 11:57:32 +01:00
Andreas Fabri b3e2beddb4 merge cgal/master 2023-05-16 10:02:36 +01:00
Andreas Fabri f1780e39dd Mesh_3: Move doxygen into header file 2023-05-16 09:32:15 +01:00
Andreas Fabri 7171de7b03 Mesh_3: Move doxygen into header file 2023-05-15 21:59:09 +01:00
Andreas Fabri a940523882 Mesh_3: Move doxygen into header file 2023-05-15 15:52:35 +01:00
Jane Tournois 73a7d4ff09 Merge remote-tracking branch 'cgal/master' into Mesh_3-min_size-jtournois
# Conflicts:
#	Installation/CHANGES.md
#	Polyhedron/demo/Polyhedron/Plugins/Mesh_3/Mesh_3_plugin.cpp
#	STL_Extension/include/CGAL/STL_Extension/internal/parameters_interface.h
2023-05-05 09:17:33 +02:00
Mael 532b82cb9b
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-05-04 17:28:47 +02:00
Laurent Rineau 628d8ae43d Merge pull request #7307 from janetournois/Mesh_3-sizing_field_with_aabb_tree-GF
Mesh_3 - Document Sizing_field_with_aabb_tree
2023-05-04 17:22:59 +02:00
Laurent Rineau c2e24424d3 Merge pull request #7415 from janetournois/Mesh_3-triple_lines_with_sqrt-jtournois
Mesh_3 triple lines detection robustness
2023-05-04 17:22:46 +02:00
Laurent Rineau d2bc415a15 Merge pull request #6950 from lrineau/CGAL-allow_Epick_with_float-GF
Simple_precision_epick: an Epick-like kernel with float as FT
2023-05-04 16:37:17 +02:00
Laurent Rineau 1449281db9 Merge pull request #7264 from MaelRL/SLS-Weighted_skeleton-GF
Weighted straight line skeletons
2023-05-04 16:37:12 +02:00
Sébastien Loriot e0eac4f388 Merge remote-tracking branch 'cgal/master' into HEAD 2023-05-03 18:37:09 +02:00
Jane Tournois 75806c2497 add local macro for sqrt(17)
and const split_point to make sure the same point is used twice
2023-05-02 12:39:46 +02:00
Jane Tournois dad3407b11 add local macro for sqrt(65) 2023-05-02 11:40:47 +02:00
Jane Tournois 5d0adfda43 avoid conflict with max macro on msvc 2023-05-02 10:12:57 +02:00
Jane Tournois 2f88b29cda replace multiple std::sqrt by macros
with more than 17 digits in case we have number types bigger than double
2023-04-28 17:54:07 +02:00
Jane Tournois ce738685e1 replace approximate values for sqrt(2) and similar 2023-04-28 16:12:26 +02:00
Jane Tournois b014f5ab45 fix template parameter
without that, the template parameter is 'int', deducted from third argument '0'
2023-04-25 15:45:36 +02:00
Jane Tournois b76f640a41 Merge branch 'Mesh_3-edge_min_size-GF' into Mesh_3-min_size-jtournois
# Conflicts:
#	Mesh_3/test/Mesh_3/CMakeLists.txt
#	Polyhedron/demo/Polyhedron/Plugins/Mesh_3/Meshing_dialog.ui
2023-04-24 13:59:48 +02:00
Jane Tournois e30ccd2cc5 Merge branch 'Mesh_3-add_minimal_size_criterion_new-jtournois' into Mesh_3-min_size-jtournois 2023-04-24 12:56:40 +01:00
Sébastien Loriot 2f7d150531 boost::begin/end/empty/size -> std::begin/end/empty/size 2023-04-23 23:01:35 +02:00
Sébastien Loriot cf45dd3d5b boost::is_base_of -> std::is_base_of 2023-04-23 22:37:07 +02:00
Sébastien Loriot b039040f73 boost::is_convertible -> std::is_convertible 2023-04-23 22:37:07 +02:00
Sébastien Loriot 9ed6c7acdc remove useless include 2023-04-23 22:37:07 +02:00
Sébastien Loriot e82d970d19 boost::next -> std::next 2023-04-23 22:37:07 +02:00
Sébastien Loriot 99619dc634 boost::prior -> std::prev 2023-04-23 22:37:07 +02:00
Sébastien Loriot 8b3acae1c7 boost::remove_reference -> std::remove_reference 2023-04-23 22:36:59 +02:00
Sébastien Loriot fa301554ce boost::remove_v -> std::remove_cv_t 2023-04-23 19:13:56 +02:00
Sébastien Loriot 61834d5a26 boost::remove_const -> std::remove_const_t 2023-04-23 19:07:54 +02:00
Sébastien Loriot fc034c6a5d boost::unit -> std::uint 2023-04-23 18:40:39 +02:00
Jane Tournois 4be918b51b it's forbidden to compare (size_t < 0) 2023-04-18 17:10:41 +02:00
Laurent Rineau 2559bb6778
Update Mesh_criteria_3.h (the note) 2023-04-17 16:35:01 +02:00
Jane Tournois 7e97a91a34 improve doc
# Conflicts:
#	Mesh_3/include/CGAL/Mesh_3/C3T3_helpers.h
2023-04-17 14:34:34 +02:00
Mael Rouxel-Labbé 1a5826f11a Merge remote-tracking branch 'cgal/master' into SLS-Weighted_skeleton-GF 2023-04-17 12:48:30 +02:00
Sébastien Loriot 9f33e64643 avoid warning 2023-04-12 09:00:24 +02:00
Laurent Rineau e5a2513921 Merge pull request #7359 from janetournois/Mesh_3-exude_mesh_3_np-jtournois
Mesh_3 - fix default parameters of `CGAL::exude_mesh_3(c3t3)`
2023-04-11 14:19:00 +02:00
Jane Tournois 662534e8f3 fix template type
avoid using "0" type, int, that would make a data corruption inside
the modified image
2023-04-07 15:52:47 +02:00
Jane Tournois 7eb9a5a0cc Merge remote-tracking branch 'cgal/master' into Mesh_3-triple_line_extraction_and_weights-GF
# Conflicts:
#	Mesh_3/include/CGAL/Labeled_mesh_domain_3.h
2023-04-07 15:11:30 +02:00
Jane Tournois e34cd8d938 doc 2023-04-07 14:54:29 +02:00
Laurent Rineau 1dce90ee79 Merge remote-tracking branch 'cgal/master' into CGAL-allow_Epick_with_float-GF 2023-04-07 10:59:51 +02:00