Commit Graph

74 Commits

Author SHA1 Message Date
Laurent Rineau a126f2173e Use is_certain to avoid throwing exceptions 2019-05-22 15:21:50 +02:00
Laurent Rineau 0861367169 Replace the planes by a vector+point
The idea with those planes is a sort of pre-computation of minors of
the determinant of the orientation of `(p,q,r,s)`, with `(p,q,r)`
fixed. But the three minors are only the coordinates `(a,b,c)` of the
plane defined by `(p,q,r)`, and the coordinate `d` is the determinant
of the orientation of `(p,q,r,O)` where `O` is the origin of the
Euclidean plane. We do not want to compute that `d`!

So, instead of computing planes, one computes only the normal
`(a,b,c)` of the plan `(p,q,r)`, and a stores it with `p`. That allows
to compute the determinant of `orientation(p,q,r,s)` once `s` is
known.
2019-05-22 12:06:40 +02:00
Sébastien Loriot 885cc02c62 fix activation of local static filters 2018-10-01 10:31:21 +02:00
Sebastien Loriot 327f7d8fbd
Merge branch 'master' into convex_hull_function 2018-07-19 10:21:26 +02:00
Maxime Gimeno 2f319d332e Remove init_iterators. It works without and like this there is no need to change the traits 2018-07-16 09:58:15 +02:00
Sébastien Loriot 0037edc529 use statically filtered predicate 2018-07-13 16:56:16 +02:00
Sébastien Loriot d3a8a07df3 do not use negative side
change plane's orientation instead
2018-07-13 16:47:11 +02:00
Maxime Gimeno c945d27dc2 Fix Convex_hull_3 so it becomes minimal. 2018-07-12 16:49:27 +02:00
Maxime Gimeno 276871d708 Update and clean up the doc 2018-07-03 10:46:15 +02:00
Maxime Gimeno f3dd3ba1c0 Document adapter traits. 2018-06-27 10:27:19 +02:00
Maxime Gimeno 4662cbdd96 Revert "Fix initialization of overload with polyhedorn"
This reverts commit 6e39f1aa05.
2018-06-27 08:55:48 +02:00
Maxime Gimeno a8314d0f0f Fix static_assertion 2018-06-26 16:23:57 +02:00
Maxime Gimeno 6e39f1aa05 Fix initialization of overload with polyhedorn 2018-06-26 12:45:13 +02:00
Maxime Gimeno 58bc2faeff Add overload without traits and clean-up test. 2018-06-20 11:21:41 +02:00
Maxime Gimeno 91c704b7ca doc 2018-06-20 11:17:38 +02:00
Sébastien Loriot c527fa4bcf simplify wrapper around Has_on_positive_side_3
add a specialization for the new traits
2018-06-20 11:16:35 +02:00
Maxime Gimeno d6450f397a WIP extreme_vertices :
- disabled the filtered_predicates for now
2018-06-20 11:16:35 +02:00
Maxime Gimeno 69392fc32f WIP adapter_traits 2018-06-20 11:16:35 +02:00
Sébastien Loriot 202a0ce9e6 clean up 2018-06-07 10:28:56 +02:00
Konstantinos Katrioplas be4dfe77ac handle convex hull functionality for up to 3 points to a mutable graph and to an output iterator 2018-06-07 10:28:55 +02:00
Konstantinos Katrioplas ec000ea312 function overload for convex_hull_3 which returns a list of points instead of a polyhedron 2018-06-07 10:28:32 +02:00
Andreas Fabri 76ccc9ab6f Convex_hull_3: Remove dependency on package Polyhedron 2018-03-28 14:59:22 +01:00
Andreas Fabri c493359b62 Convex_hull_3 2018-01-18 10:11:33 +00:00
Laurent Rineau 1c2e9df8cf Merge branch 'releases/CGAL-4.11-branch' 2017-12-19 16:29:10 +01:00
Laurent Rineau c4a7adcd5b Merge pull request #2688 from lrineau/Convex_hull_3-fix_quickhull_in_coplanar_case-GF
Fix Convex_hull_3 quickhull, with coplanar point
2017-12-19 16:17:29 +01:00
Laurent Rineau 22d5a5b884 Fix Convex_hull_3 quickhull, with coplanar point
`CGAL::convex_hull_3` documents that the output is a triangulation
polyhedron. That is true... but for coplanar input points! In case of
coplanar input point, the output before this patch was a polyhedron with a
single polygonal face. The patch triangulates the face using a pivot point
and Euler operations.
2017-12-15 10:45:25 +01:00
Sébastien Loriot ee57fc2d6c add SPDX identifier for files under the GPL-3+ license 2017-11-12 10:17:51 +01:00
Laurent Rineau e61409f770 Merge pull request #2321 from sloriot/CH3-fix_tetra_orientation
fix the orientation of convex hull polyhedron of 4 points
2017-07-31 16:50:48 +02:00
Sébastien Loriot 04ab1fd268 fix the orientation of the generated polyhedron in case of 4 non-coplanar points 2017-07-31 10:40:51 +02:00
Laurent Rineau aff2a7a899 Merge pull request #2287 from maxGimeno/Fix_GCC8_warnings-GF
Fix new -Wcatch-value warnings (gcc>=8.0)
2017-07-25 18:17:42 +02:00
Maxime Gimeno 96f7b0f138 Fix catch value warnings 2017-07-21 11:27:14 +02:00
Andreas Fabri 0cce789437 Add examples for using 3D convex hull functions with open mesh. And fix a bug in convex hull code 2017-07-19 12:25:31 +02:00
Laurent Rineau 1a2f617d89 Merge pull request #1843 from afabri/BGL_accelerate_copy_face_graph-GF
Accelerate copy_face_graph
2017-02-08 17:32:47 +01:00
Andreas Fabri 8d1db09275 The vertices must set_face() 2017-02-07 10:51:24 +01:00
Sébastien Loriot 50510c05ea add include directive for license of all GPL header files
done using:
ack-grep "^GPL" */package_info/*/license.txt -l | awk -F "/" '{print $1}' > /tmp/gpl_packages
for i in `cat /tmp/gpl_packages | \
          grep -v Operations_on_polyhedra | \
          grep -v Algebraic_kernel_for_circles | \
          grep -v Algebraic_kernel_for_spheres | \
          grep -v Polyhedron_IO`;
do
  echo $i
  python Scripts/developer_scripts/add_license_in_pkg_header.py $i
done
python Scripts/developer_scripts/add_license_in_pkg_header.py Operations_on_polyhedra Polygon_mesh_processing
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_circles Circular_kernel_2
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_spheres Circular_kernel_3
python Scripts/developer_scripts/add_license_in_pkg_header.py Polyhedron_IO Polyhedron
2017-01-19 15:20:25 +01:00
Sébastien Loriot 1258b7fae4 use BGL function instead of member function 2016-12-29 12:01:47 +01:00
Sébastien Loriot 31e5739a03 forward polyhedron type to the default traits 2016-12-29 12:00:42 +01:00
Andreas Fabri 9ee11501ac Changes after the review by Sebastien 2016-11-30 10:03:00 +01:00
Andreas Fabri 332ae157f6 make halfspace_itersectios work with FaceGraph 2016-11-27 20:28:44 +01:00
Andreas Fabri 6c9d30d5bc Go back from unordered_map to map. This fixes the testuite, but what is wrong with unorered_map??? 2016-11-27 11:21:08 +01:00
Andreas Fabri e9bb53f13a polish + map -> unordered_map 2016-11-25 14:34:19 +01:00
Andreas Fabri ed838bf943 Fix a bug also in 4.9, with 3 collinear points 2016-11-24 14:24:11 +01:00
Andreas Fabri 54987251de Add typename 2016-11-24 08:30:36 +01:00
Andreas Fabri 1e87967cba bug fix 2016-11-23 11:52:10 +01:00
Andreas Fabri e26e60dd6c Add Default to Convex_hull_graph_traits_3; BGLize some code 2016-11-22 12:27:18 +01:00
Andreas Fabri 32b1fb1c90 reserve 2016-11-19 08:02:59 +01:00
Andreas Fabri b14a99cdf8 unused typedef 2016-11-18 20:39:10 +01:00
Andreas Fabri e4d2a7f2e1 fixes for bugs spotted by g++ 2016-11-18 17:56:24 +01:00
Andreas Fabri 0bcafc536f use copy_face_graph() so that we produce also a Surface_mesh 2016-11-18 10:35:26 +01:00
Andreas Fabri 1e2ff1131e assert -> CGAL_assertion 2015-08-27 16:51:55 +02:00