Commit Graph

229 Commits

Author SHA1 Message Date
Sébastien Loriot 590612a563 run the script to remove tabs and trailing whitespaces 2020-03-26 13:25:16 +01:00
Mael eebaf7fb4d
Tiny rephrasing 2020-01-31 11:16:50 +01:00
Mael Rouxel-Labbé bb35aacb4d Fix some const correctness in SMSP 2020-01-31 11:07:33 +01:00
Maxime Gimeno 6dccde35ef Fix c++11 errors 2020-01-13 16:20:51 +01:00
Laurent Rineau 7acfdff7d5
SMSP: fix border and robustness issues (#3977)
SMSP: fix border and robustness issues

Co-authored-by: Maxime GIMENO <maxime.gimeno@gmail.com>
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2019-10-18 14:24:42 +02:00
Mael Rouxel-Labbé df6568f733 Fix bad copy paste 2019-10-16 09:35:48 +02:00
Mael Rouxel-Labbé e4e63e087b Remove leftover expensive assertion 2019-10-16 09:33:33 +02:00
Mael Rouxel-Labbé 09e563c73f Fix a "potentially uninitialized" warning 2019-10-16 09:33:29 +02:00
Mael 1637608b9a
Remove accidentally committed debug code 2019-10-14 09:03:33 +02:00
Mael Rouxel-Labbé 90d4bbb871 Use traits' functors rather than global functions 2019-10-11 14:30:26 +02:00
Mael Rouxel-Labbé 9eb7852753 Enable robustness tricks by default 2019-10-11 12:02:58 +02:00
Mael Rouxel-Labbé 87b605a68b Fix always propagating on the right as soon as the node is not a source 2019-10-11 12:02:17 +02:00
Mael Rouxel-Labbé e6c788efbd Fix indentation 2019-10-11 09:29:58 +02:00
Mael Rouxel-Labbé b32dd4b5de Add more robust code for two predicates, disabled behind a macro for now 2019-10-11 09:26:17 +02:00
Mael Rouxel-Labbé 53bb36f4d7 Fix debug code compilation 2019-10-11 09:25:10 +02:00
Mael Rouxel-Labbé 7e5f6293f3 Clean debug code 2019-10-10 14:54:35 +02:00
Mael Rouxel-Labbé deb18df291 Remove ineffective pruning filter
This filter was added by me recently, it's not part of the initial code.
It will be so rare it's not worth clunking up the code.
2019-10-10 14:45:25 +02:00
Mael Rouxel-Labbé a6215abf0e Fix sometimes comparing distances with a NULL occupier 2019-10-10 14:44:13 +02:00
Mael Rouxel-Labbé 90f787c111 Use `Compare_relative_intersection_along_segment_2` once again to compare rays
The tiny detail that makes it necessary to do all these complicated shenanigans
is that the two 2D segments are not necessarily living in a common unfolding
2019-10-10 14:40:15 +02:00
Mael Rouxel-Labbé 6b40368c87 Fix namespace and regroup children members together 2019-10-10 14:38:59 +02:00
Mael Rouxel-Labbé c2b3d9e5d8 Add some debug code 2019-10-10 14:22:23 +02:00
Mael Rouxel-Labbé c611285eb5 Simplify orientation calls 2019-10-10 14:13:30 +02:00
Mael Rouxel-Labbé df5d200033 Regroup class members 2019-10-10 14:13:30 +02:00
Mael Rouxel-Labbé a718adea69 Fix namespace usage 2019-10-10 14:13:29 +02:00
Mael Rouxel-Labbé d307df36ea Improve readability (no 250+ char lines) 2019-10-10 14:13:29 +02:00
Mael Rouxel-Labbé 930fbb3280 Add some const correctness + avoid a lot of useless copies 2019-10-10 14:13:29 +02:00
Mael Rouxel-Labbé e63d20cf22 Uniformize namespaces 2019-10-10 14:13:29 +02:00
Mael Rouxel-Labbé 7b887e79ea Add some pruning in case of equal times (node == occupier time)
Probably doesn't happen very often though...
2019-10-10 14:13:29 +02:00
Mael Rouxel-Labbé 77749bb031 Fix some more overzeralous pruning
Similar to commit cda7c5f299, you cannot
just prune and not propagate if times are equal because nothing guarantees
that the first cone to reach a given vertex is the cone that will yield
the shortest path.
2019-10-10 14:13:29 +02:00
Mael Rouxel-Labbé 315d257d98 Tiny misc improvements 2019-10-10 14:13:29 +02:00
Mael Rouxel-Labbé cda7c5f299 Fix sometimes pruning entire branches that are valid
An example can be see in this issue: https://github.com/CGAL/cgal/issues/3993.
This configuration:
- we leave from a vertex v0 and want to reach v1
- a (useful) cone gets split by a vertex v2
- v3 is such that v0v2 = v2v3 and v1 is on the left of the line
- we first reach v3 from the right
- when we reach v3 from the left, with a cone that also contains v1, this cone
  is discarded because we have already reached v3 from the right and the time
  is not better (it's equal). Thus we can't reach v1 with the direct cone
  from v1.

Other artificial configurations can be constructed noting that the case
of identical source-ray target for both nodes where not really handled.
2019-10-03 15:03:01 +02:00
Mael Rouxel-Labbé 7676dca96a Minor code improvements 2019-10-03 13:15:51 +02:00
Mael Rouxel-Labbé 244ad1dd27 Move CGAL::internal into CGAL::SMSP::internal 2019-10-03 11:22:21 +02:00
Mael Rouxel-Labbé cf900da30d Don't assume you can build a FT from a double
Only change /include because we know what kernels we are manipulating in tests
2019-10-03 11:22:21 +02:00
Maxime Gimeno de81a0cc73 fix warning 2019-10-03 11:22:21 +02:00
Maxime Gimeno f4aa864410 Fix warnings 2019-10-03 11:22:21 +02:00
Sébastien Loriot 051f94c4e2 fix and add test that was not in the cmake script 2019-10-03 11:22:21 +02:00
Sébastien Loriot 2681115133 add new test with boundary vertices 2019-10-03 11:22:21 +02:00
Sébastien Loriot 8e27665ba9 init the halfedge of a border vertex to point in a face 2019-10-03 11:22:14 +02:00
Laurent Rineau 90782d4b7f Revert the merge of two pull-requests that target CGAL-4.14-branch
- Revert "Merge pull request #3857 from MaelRL/CGAL-Fix_duplicate_non_manifold_vertices-GF"
- Revert "Merge pull request #3898 from lrineau/Mesh_3-stop_during_protection-lrineau"
2019-05-14 17:50:45 +02:00
Laurent Rineau 8e872081fc Merge pull request #3898 from lrineau/Mesh_3-stop_during_protection-lrineau
Mesh_3 `Protect_edges_sizing_field`: handle the `stop` Boolean

# Conflicts:
#	.travis/build_package.sh
#	Installation/cmake/modules/CGALConfig_binary.cmake.in
#	Installation/cmake/modules/CGALConfig_install.cmake.in
#	Installation/cmake/modules/CGAL_SetupCGAL_CoreDependencies.cmake
#	Installation/lib/cmake/CGAL/CGALConfig.cmake
#	Polygon_mesh_processing/include/CGAL/Polygon_mesh_slicer.h
#	Polyhedron/demo/Polyhedron/Plugins/Classification/CMakeLists.txt
#	Polyhedron/demo/Polyhedron/Plugins/Mesh_3/CMakeLists.txt
2019-05-14 16:18:24 +02:00
Laurent Rineau 870ff45168 Merge pull request #3886 from lrineau/CGAL-Adapt_to_Boost_1.70-GF
Adapt to Boost 1.70
2019-05-07 15:48:03 +02:00
Laurent Rineau b7631f19b5 Fix Ridges_3 and SM_shortest_path with Boost 1.70 2019-05-06 10:11:18 +02:00
albert-github 1dd7473818 Correction of links
Correction of redirected links and links that moved to another place.
2019-04-11 21:37:05 +02:00
Sébastien Loriot 59bc453b42 first batch of replacement for level 1 in classified ref man
command used:
grep -l  "##" */doc/*/PackageDescription.txt | xargs  sed -i  -E 's/\#\#\s*([[:print:]]+[[:alnum:]])\s*\#\#\s*$/\\cgalCRPSection{\1}/'
2019-02-14 10:32:39 +01:00
Laurent Rineau daa1493e98
Merge pull request #3452 from afabri/Heat_method_3-GF
New package: Heat Method
2019-01-18 16:50:01 +01:00
Laurent Rineau 6ffd76a87e Merge pull request #2792 from afabri/Intersections_3-Add_missing_do_intersect-GF
Intersections_3:  Add missing do_intersect() overloads
2019-01-18 16:37:54 +01:00
Maxime Gimeno 2a49dfcb05 Fix conflict 2019-01-11 09:47:34 +01:00
Andreas Fabri 586b185b64 Changes after Guillaume's review 2018-12-21 11:50:27 +01:00
Sébastien Loriot 3a1516e940 add missing Reference and uniformize ref man group declaration 2018-11-20 13:47:16 +01:00