songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
104,719 Commits 3 Branches 156 Tags 958 MiB
Commit Graph

343 Commits

Author SHA1 Message Date
albert-github b3af96caa1 issue #7454 Consistency of BigO notations 
Create `cgalBigO` marco and used it.
(`The macro `cgalBigOLarge` is for special situations where we need bigger round brackets)
 2023-07-04 16:23:14 +02:00
Laurent Rineau 5f8930db8c Merge branch '5.5.x-branch' 
# Conflicts:
#	Convex_hull_2/test/Convex_hull_2/ch_test_CH.cpp
#	Convex_hull_2/test/Convex_hull_2/ch_test_SC.cpp
#	Convex_hull_2/test/Convex_hull_2/ch_test_SH.cpp
#	Convex_hull_2/test/Convex_hull_2/ch_test_SS.cpp
#	Straight_skeleton_2/include/CGAL/constructions/Straight_skeleton_cons_ftC2.h
#	Straight_skeleton_2/include/CGAL/predicates/Straight_skeleton_pred_ftC2.h
 2023-01-27 21:16:14 +01:00
Laurent Rineau 2d73c60bda Merge pull request #7152 from afabri/Convex_hull_2-keep_collinear-GF 
Convex_hull_2: Use of 2D Delaunay
 2023-01-27 21:02:11 +01:00
Laurent Rineau 8d7c9685dd Merge pull request #7146 from afabri/CH-do_not_test_non_exact_NT-GF 
Convex_hull_2: Do not assert without exact predicates
 2023-01-27 20:52:13 +01:00
Andreas Fabri c6fe1586c1 Convex_hull_2: Use of 2D Delaunay 2023-01-02 16:33:45 +00:00
Andreas Fabri bd6c5ca9b7 Convex_hull_2: Do not assert without exact predicates 2022-12-23 16:18:04 +00:00
albert-github 7a62583efa spelling corrections 
Some spelling corrections (Directories starting with `C`)
 2022-11-14 19:14:33 +01:00
Andreas Fabri 469a0362b5 Take Laurent's review into account 2022-10-14 11:34:34 +01:00
Andreas Fabri dc531cbaa9 Convex_hull_2 2022-09-27 08:40:26 +01:00
Mael Rouxel-Labbé d2b9b5728f Remove unused typedef/variables 2022-07-05 09:46:30 +02:00
Mael Rouxel-Labbé 87d09b6763 Add test for EPICK 2022-07-05 09:42:05 +02:00
Mael Rouxel-Labbé 1c19734490 Add missing header include 2022-07-02 18:02:44 +02:00
Mael Rouxel-Labbé 75441da5ed Remove a disable_warning.h 2022-07-01 23:49:57 +02:00
Mael Rouxel-Labbé 2e330b1342 Improve CH2 tests 2022-07-01 23:49:31 +02:00
Mael Rouxel-Labbé e4e52c8391 Misc doc cleaning 2022-07-01 23:46:10 +02:00
Mael Rouxel-Labbé 13b4060644 Fix eddy/bykat returning collinear vertices on the hull 
In these two algorithms, points farthest from a line must be found.
In case of multiple points at the same distance, an "extremity"
of this set of points must be returned.

This was properly documented in the Less_signed_distance_to_line_2
functor of the ConvexHullTraits_2 concept:

[ ... ]
The predicate must provide a total order compatible with convexity,
<I>i.e.</I>, for any line segment \f$ s\f$ one of the endpoints
of \f$ s\f$ is the smallest point among the points on \f$ s\f$,
with respect to the order given by `Less_signed_distance_to_line_2`.
[ ... ]

And specific models did respect this requirement. However, the kernel
is supposed to also be a model of ConvexHullTraits_2, but
Kernel_23::LessSignedDistanceToLine_2 does not require this, and
the models (EPICK, Simple_Cartesian, etc.) do not implement it.
Hence, if a kernel was used as geometric traits for 2D Convex Hull
algorithms, one might not get the expected extreme point when
there are multiple points at the same distance to a line at some
point in the algorithm.

The algorithm recovered, but this created extra points on the hull.

Fixing the functor in the kernel would create an inconsistency
with Kernel_23::Compare_signed_distance_to_line_2, so instead
this commit changes the concept and the code to require
providing Compare_signed_distance_to_line_2 and then uses Less_xy
in the code in case of EQUAL return (that is actually how it was
done in the Convex_hull_2-specific versions of the ConvexHullTraits_2
model).
 2022-07-01 13:35:59 +02:00
Mael Rouxel-Labbé 2b245d870e Remove long-deprecated Convex_hull_2 projection traits 2022-06-30 15:20:23 +02:00
Mael Rouxel-Labbé 96e565777f Remove useless "using namespace boost" (boost::bind was replaced with lambdas) 2022-06-30 09:32:45 +02:00
Mael Rouxel-Labbé 6b6bfaae4f Fix CH3 doc links within CH2 2022-06-30 09:31:19 +02:00
Laurent Rineau 2288225448 Massive update of CMake policies to version 3.23 2022-05-06 09:34:35 +02:00
albert-github 611d7f1e46 Remove redundant HTML type of anchor 
Remove redundant HTML type of anchor, the anchor is not used and night give problems in the future (especially with https://github.com/doxygen/doxygen/pull/9204)
 2022-03-13 12:16:05 +01:00
Sébastien Loriot ab48f63e30 update latest cmake version tested 2021-11-09 10:58:47 +01:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Maxime Gimeno c49152359c update max version of cmake and announce the new minimal in CHANGE.md 2021-04-15 15:08:54 +02:00
Laurent Rineau 21755b1123 Merge pull request #5245 from GilesBathgate/create-assertions-fix 
Allow -DNDEBUG and CGAL_nnn_assertions at the same time
 2021-03-24 15:05:41 +01:00
Sébastien Loriot 4bb0406240 do not include boost/bind.hpp (shouldn't be used anymore) + fix remaining bind 
(nasty using namespace boost!)
 2021-02-12 15:35:19 +01:00
Sébastien Loriot e49fd1e732 deref it once 2021-01-29 18:04:19 +01:00
Andreas Fabri 51086d5678 When using a reference for the functor we must generate a new functor in the for loop 2021-01-28 17:12:26 +00:00
Sébastien Loriot c4ad713b9e replace bind in Convex_hull_2 2021-01-06 12:59:11 +01:00
Giles Bathgate 5a36ff89b5 Drop NDEBUG it is already visible through CGAL_NO_ASSERTIONS 2020-12-04 19:42:21 +00:00
Maxime Gimeno 9c15f2c9dc Use FeatureSummary in the demo, and remove CGAL_FOUND 2020-08-04 12:46:17 +02:00
Laurent Rineau 319383c963 Revert "Merge pull request #4519 from lrineau/Kernel_23-Epeck_objects_in_Compact_container-lrineau_gdamiand" 
This reverts commit bcab082f82, reversing
changes made to 2d3e126450.
 2020-05-20 09:47:58 +02:00
Sebastien Loriot bcab082f82
Merge pull request #4519 from lrineau/Kernel_23-Epeck_objects_in_Compact_container-lrineau_gdamiand 
Enable the use of Lazy objects in Compact_container
 2020-04-29 13:56:59 +02:00
Sébastien Loriot 97e46accad extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:26:37 +01:00
Sébastien Loriot 34ce87be56 Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:26:15 +01:00
Sébastien Loriot 9f2eafd06e extra run of the script to remove tabs and trailing whitespaces 2020-03-26 19:17:02 +01:00
Sébastien Loriot 35b83deffd Update branch from master after trailing whitespaces and tabs removal 2020-03-26 19:16:25 +01:00
Sébastien Loriot 8bb22d5b2c extra run of the script to remove tabs and trailing whitespaces 
right after the merge of the 5.0 release branch

+ manual fix of the files (indentation was changed in the meantime):
   * Spatial_sorting/include/CGAL/Multiscale_sort.h
   * Spatial_sorting/test/Spatial_sorting/test_multiscale.cpp
 2020-03-26 14:26:59 +01:00
Sébastien Loriot 8b153fb495 Merge branch 'cgal/releases/CGAL-5.0-branch' 
whitespace+tab removal, merged with option -Xignore-space-change
 2020-03-26 14:22:32 +01:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces 
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
 2020-03-26 14:16:06 +01:00
Sébastien Loriot 0a46621dc6 Merge branch 'cgal/releases/CGAL-4.14-branch' 
whitespace+tab removal, merged with option -Xignore-all-space
 2020-03-26 13:28:46 +01:00
Sébastien Loriot 590612a563 run the script to remove tabs and trailing whitespaces 2020-03-26 13:25:16 +01:00
Mael Rouxel-Labbé afb5abe61a Kernel is not a model of ConvexHullTraits_3 (but Extreme_points_... is) 
K::Traits_xy/xz/yz_3 does not exist
 2020-03-24 16:06:03 +01:00
Guillaume Damiand f3bb8f1100 Bug fix 2020-03-18 08:36:07 +01:00
Sébastien Loriot cccaeaebdb fix iterator type required 2020-01-15 17:44:01 +01:00
Laurent Rineau 15d9e1f0ff Restore the alphabetical order of `dependencies` files 2019-10-31 14:41:37 +01:00
Sébastien Loriot 52164b1fba First pass on removing license notice in header for LGPL files 2019-10-19 15:40:30 +02:00
Sébastien Loriot 254d60f642 First pass on removing license notice in header for GPL files 2019-10-19 15:23:19 +02:00
Sébastien Loriot 7356421d80 introduce Commercial license SPDX tag 2019-10-19 12:15:19 +02:00