Commit Graph

252 Commits

Author SHA1 Message Date
Laurent Rineau 22d5a5b884 Fix Convex_hull_3 quickhull, with coplanar point
`CGAL::convex_hull_3` documents that the output is a triangulation
polyhedron. That is true... but for coplanar input points! In case of
coplanar input point, the output before this patch was a polyhedron with a
single polygonal face. The patch triangulates the face using a pivot point
and Euler operations.
2017-12-15 10:45:25 +01:00
Sébastien Loriot 9dd6684627 use only add_vertex function described in the concept 2017-12-06 16:42:06 +01:00
Sébastien Loriot ee57fc2d6c add SPDX identifier for files under the GPL-3+ license 2017-11-12 10:17:51 +01:00
Laurent Rineau e61409f770 Merge pull request #2321 from sloriot/CH3-fix_tetra_orientation
fix the orientation of convex hull polyhedron of 4 points
2017-07-31 16:50:48 +02:00
Sébastien Loriot 04ab1fd268 fix the orientation of the generated polyhedron in case of 4 non-coplanar points 2017-07-31 10:40:51 +02:00
Laurent Rineau aff2a7a899 Merge pull request #2287 from maxGimeno/Fix_GCC8_warnings-GF
Fix new -Wcatch-value warnings (gcc>=8.0)
2017-07-25 18:17:42 +02:00
Maxime Gimeno 96f7b0f138 Fix catch value warnings 2017-07-21 11:27:14 +02:00
Andreas Fabri 0cce789437 Add examples for using 3D convex hull functions with open mesh. And fix a bug in convex hull code 2017-07-19 12:25:31 +02:00
Laurent Rineau 1a2f617d89 Merge pull request #1843 from afabri/BGL_accelerate_copy_face_graph-GF
Accelerate copy_face_graph
2017-02-08 17:32:47 +01:00
Andreas Fabri 8d1db09275 The vertices must set_face() 2017-02-07 10:51:24 +01:00
Sébastien Loriot 50510c05ea add include directive for license of all GPL header files
done using:
ack-grep "^GPL" */package_info/*/license.txt -l | awk -F "/" '{print $1}' > /tmp/gpl_packages
for i in `cat /tmp/gpl_packages | \
          grep -v Operations_on_polyhedra | \
          grep -v Algebraic_kernel_for_circles | \
          grep -v Algebraic_kernel_for_spheres | \
          grep -v Polyhedron_IO`;
do
  echo $i
  python Scripts/developer_scripts/add_license_in_pkg_header.py $i
done
python Scripts/developer_scripts/add_license_in_pkg_header.py Operations_on_polyhedra Polygon_mesh_processing
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_circles Circular_kernel_2
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_spheres Circular_kernel_3
python Scripts/developer_scripts/add_license_in_pkg_header.py Polyhedron_IO Polyhedron
2017-01-19 15:20:25 +01:00
Sébastien Loriot abdf04ad3c add deprecation warning 2016-12-29 12:09:05 +01:00
Sébastien Loriot 1258b7fae4 use BGL function instead of member function 2016-12-29 12:01:47 +01:00
Sébastien Loriot 31e5739a03 forward polyhedron type to the default traits 2016-12-29 12:00:42 +01:00
Andreas Fabri e24a7f6c3d Convex_hull_3: Put a class in the namspace CGAL 2016-12-09 17:39:44 +01:00
Andreas Fabri 466995a31b Add typedef for Polyhedron_3 2016-11-30 11:56:52 +01:00
Andreas Fabri 9ee11501ac Changes after the review by Sebastien 2016-11-30 10:03:00 +01:00
Andreas Fabri 394f9c5b2f polish 2016-11-28 08:32:30 +01:00
Andreas Fabri 332ae157f6 make halfspace_itersectios work with FaceGraph 2016-11-27 20:28:44 +01:00
Andreas Fabri 6c9d30d5bc Go back from unordered_map to map. This fixes the testuite, but what is wrong with unorered_map??? 2016-11-27 11:21:08 +01:00
Andreas Fabri 10df561578 Cannot assign to a reference 2016-11-25 16:58:03 +01:00
Laurent Rineau 873e83a429 try to fix compilation errors 2016-11-25 16:51:45 +01:00
Andreas Fabri e9bb53f13a polish + map -> unordered_map 2016-11-25 14:34:19 +01:00
Andreas Fabri ad85e5ecd7 Fix include guards 2016-11-25 06:36:52 +01:00
Andreas Fabri ed838bf943 Fix a bug also in 4.9, with 3 collinear points 2016-11-24 14:24:11 +01:00
Andreas Fabri 54987251de Add typename 2016-11-24 08:30:36 +01:00
Andreas Fabri b13f541ca4 Merge branch 'Convex_hull_3-FaceGraph-GF' of github.com:afabri/cgal into Convex_hull_3-FaceGraph-GF 2016-11-23 11:57:08 +01:00
Andreas Fabri 1e87967cba bug fix 2016-11-23 11:52:10 +01:00
Laurent Rineau 7af20f34a9 Fix compilation with GNU/g++ 2016-11-22 14:56:37 +01:00
Andreas Fabri e26e60dd6c Add Default to Convex_hull_graph_traits_3; BGLize some code 2016-11-22 12:27:18 +01:00
Andreas Fabri 4d4db0cd70 Move star_to_face_graph() to Triangulation_3 2016-11-21 17:51:41 +01:00
Andreas Fabri 698e0941ea Make polyhedral surface a template parameter 2016-11-21 08:35:01 +01:00
Andreas Fabri 32b1fb1c90 reserve 2016-11-19 08:02:59 +01:00
Andreas Fabri b14a99cdf8 unused typedef 2016-11-18 20:39:10 +01:00
Andreas Fabri e4d2a7f2e1 fixes for bugs spotted by g++ 2016-11-18 17:56:24 +01:00
Andreas Fabri 63dfd4f992 check_convexity for FaceGraph 2016-11-18 16:47:53 +01:00
Andreas Fabri ac56f8c059 fix index 2016-11-18 15:13:31 +01:00
Andreas Fabri e4d1b68178 simplifications 2016-11-18 13:08:33 +01:00
Andreas Fabri dacc7ee841 remove code deprecated with 4.6 2016-11-18 11:13:16 +01:00
Andreas Fabri 0bcafc536f use copy_face_graph() so that we produce also a Surface_mesh 2016-11-18 10:35:26 +01:00
Andreas Fabri 1e2ff1131e assert -> CGAL_assertion 2015-08-27 16:51:55 +02:00
Sébastien Loriot cb479491d5 Merge remote-tracking branch 'cgal/releases/CGAL-4.6-branch' 2015-07-24 16:09:13 +02:00
Sébastien Loriot f3f73d10a1 fix halfspace intersection for a kernel with exact constructions 2015-07-23 09:13:41 +02:00
Sébastien Loriot 1699dc8b48 do a check on a construction only if a kernel with exact constructions is used 2015-06-05 11:02:33 +02:00
Sébastien Loriot 52a61708e1 prevent a construction and handle case of collinear points 2015-06-05 10:59:41 +02:00
Sébastien Loriot f1bbc9d170 use Exact_field_selector instead of hardcoded types 2015-05-15 10:27:34 +02:00
Sébastien Loriot 8c3f8a9e8e update description 2015-05-15 10:19:10 +02:00
Sébastien Loriot 46c2727ea9 add assertions to ensure the origin is on the negative side of the input planes 2015-05-15 10:15:26 +02:00
Sébastien Loriot 50c8db347b factorize the call to the convex hull of the dual 2015-05-15 10:09:09 +02:00
Sébastien Loriot 6554279e9a fix the test for the dimension of the affine hull of the dual points 2015-05-12 10:21:53 +02:00
Sébastien Loriot 8bd72701a1 fix warning 2015-05-12 09:31:48 +02:00
Sébastien Loriot 06be9cf705 bug-fix: fix the orientation of the convex polyhedron 2015-05-11 22:37:29 +02:00
Sébastien Loriot 274bdd6357 bug-fix: always find a point interior even in release mode
assertions are deactivated in release mode
2015-05-11 22:06:13 +02:00
Sébastien Loriot 877dba1dfa simplify check 2015-05-11 21:49:08 +02:00
Sébastien Loriot c3694ea631 fix iterator type 2015-05-11 21:21:29 +02:00
Sébastien Loriot ebfcedce38 fix the way to specify the point inside the intersection of halfspaces 2015-05-11 17:52:53 +02:00
Sébastien Loriot ac42ed4f66 deprecate 3D incremental convex hull 2015-02-12 09:43:29 +01:00
Laurent Rineau e965b6293e Fix compilation errors with C++11 and Boost-1.56
Use *explicit* conversions to `bool`, for boost::shared_ptr and
boost::optional.
2015-01-14 14:47:29 +01:00
Sébastien Loriot aa3feae736 Remove no longer needed predicates/constructions
follow up of 90ee311ba9
2015-01-09 12:27:23 +01:00
Sébastien Loriot 4f46679435 Merge branch 'releases/CGAL-4.5-branch' 2015-01-09 12:23:06 +01:00
Sébastien Loriot b7caf33fbd filter the predicates in Convex_hull_traits_3 if requested 2015-01-09 12:20:14 +01:00
Sébastien Loriot 90ee311ba9 fix the detection of the projection plane to compute a 2D chull
The previous version was using a construction.
    The concept and models become simpler.
2015-01-09 12:14:56 +01:00
Sébastien Loriot cecd1464d9 Merge remote-tracking branch 'gsoc/gsoc2014-Convex_hull_3_dual-jmeyron'
Add functions to compute the finite intersection of halfspaces
  See Features/Small_Features/Halfspace_intersection

Tested in 4.6-Ic-76
Approved by the release manager
2014-12-16 11:44:55 +01:00
Jocelyn MEYRON 59c31c9570 fix errors on tests and fix warnings 2014-11-13 15:05:24 +01:00
Sébastien Loriot f822c6516c rename a variable to avoid confusion
trivial bugfix for master
2014-11-12 15:58:28 +01:00
Sébastien Loriot ad03c97cbe remove warning 2014-11-12 09:18:03 +01:00
Jocelyn MEYRON b452d5a7e1 use boost::optional for the computation (or not) of an interior point 2014-11-11 15:51:20 +01:00
Sébastien Loriot 1bb886e9dc remove warnings 2014-11-06 08:25:19 +01:00
Sébastien Loriot 8f9a9e1a38 import files for intersection of halfspaces from gsoc2014-VCM_3-jmeyron@4a7fd6c 2014-11-05 16:54:33 +01:00
Sébastien Loriot 7b05330a75 fix the concept ConvexHullTraits_3 in the case of coplanar points 2014-06-10 22:42:50 +02:00
Sébastien Loriot 00519e23bc remove unused types 2014-05-19 18:52:23 +02:00
Sébastien Loriot 7df5600896 add missing projection traits requirements in the CH_3 traits concept 2014-05-19 18:31:48 +02:00
Sébastien Loriot 82f753cc8a use the point type from the traits 2014-05-19 11:03:29 +02:00
Sébastien Loriot 319ca016f7 be more selective before using the statically filtered predicate
a sufficient requirement is that the point type of the traits
is the point type of the kernel
2014-05-19 10:17:50 +02:00
Andreas Fabri 6c547e5663 Mainly added includes 2013-09-13 22:24:30 +02:00
Sébastien Loriot 7baa997ce1 Merge branch 'Filtered_kernel-ring-glisse'
This branch adds an additional way to filter predicates that are only doing
operations using a ring number type. In case of failure, a RT is used rather
than an FT which speeds things up.

Successfully tested in CGAL-4.3Ic-37
2013-05-23 11:15:32 +02:00
Andreas Fabri 13bac84716 less warnings in various packages 2013-02-01 10:27:07 +01:00
Andreas Fabri a444286b39 one less warning in Convex_hull_3 2013-01-30 18:14:00 +01:00
Marc Glisse 571f370e28 Rename Exact_type_selector to Exact_field_selector. 2012-12-24 12:20:13 +01:00
Philipp Möller 71ea8e6e22 Minimal boost includes
Replace type_traits.hpp and utility.hpp with the respective
fine-grained includes.
2012-12-14 18:13:59 +01:00
Laurent Rineau db194534c7 First big patch to fix -Wunused-local-typedefs
-Wunused-local-typedefs is a new warning flag of gcc-4.7, and it will enabled
 by -Wall since gcc-4.8 (not yet released).

The fix is a big set of removals of unused typedefs (or comments, or moves,
depending on the context).
2012-08-01 13:29:16 +00:00
Laurent Rineau 8f59fd9592 Turn QPL into LGPLv3+ 2012-01-13 16:33:35 +00:00
Andreas Fabri 9add62dca1 Change copyright, as it was a copy/paste/adapt 2011-10-01 07:48:08 +00:00
Laurent Rineau 369498d1e5 Cancel revision 64607. There had been a problem with the branch.
| ------------------------------------------------------------------------
  | r64607 | efif | 2011-07-05 17:27:04 +0200 (Tue, 05 Jul 2011) | 1 line
  | 
  | Merged feature-branch Aos_2-new_functors-tau into next
  | ------------------------------------------------------------------------
2011-07-06 11:11:58 +00:00
Andreas Fabri 3596bbe9af No longer use Convex_hull_projective traits classes 2011-04-06 07:43:38 +00:00
Andreas Fabri 0e70d936a2 No longer use deprecated Convex_hull_projection_traits classes 2011-04-06 07:42:40 +00:00
Sébastien Loriot d980c59d8d Convex_hull_3 bug-fix:
compute equations of the facets of the polyhedron  representing
 the convex hull of a set of 3D points.
2011-04-06 07:19:36 +00:00
Andreas Fabri 2ce33d0505 Move hash map access outside the loop 2011-01-05 11:05:06 +00:00
Andreas Fabri 0bf400b620 Replace copy/clear with splice operation in order to transfer acomplete list into another one 2011-01-05 11:03:21 +00:00
Andreas Fabri c7feb6cc0c int -> size_type/std::size_t 2010-06-21 16:47:25 +00:00
Sébastien Loriot 52317dd49f add python script (replace_CGAL_NAMESPACE.py) to replace CGAL_BEGIN_NAMESPACE and CGAL_END_NAMESPACE
by namespace CGAL { and } //namespace CGAL. in all .h and .cpp files
in a directory.
Apply it to all packages in the trunk
Remove macro definition from the config.h file.
2010-06-09 07:37:13 +00:00
Sylvain Pion 85dc12f2a7 Remove empty lines at beginning and end of files
(apply Scripts/developer_scripts/remove_empty_lines.pl).
2010-02-01 12:55:28 +00:00
Andreas Fabri faa063d065 call list::size() only once 2009-09-03 13:58:12 +00:00
Andreas Fabri b56188ae08 Keep at least one point 2009-09-03 07:29:25 +00:00
Andreas Fabri 3ba02f28bb Fix a bug that happens when the first and last point are identical 2009-09-02 16:33:18 +00:00
Sylvain Pion 79864c0c8e Remove Arity_tag. 2008-07-22 12:29:01 +00:00
Michael Hoffmann 542d69b351 Use boost::bind instead of CGAL::bind_1. 2008-06-20 08:47:12 +00:00
Sylvain Pion 487b5a53b1 remove BORLAND workaround, we don't support it anymore, and the workaround is even probably suboptimal 2007-02-28 19:28:09 +00:00
Ron Wein 7bafa95157 Fixed the include files. 2006-06-05 11:07:27 +00:00
Laurent Saboret db6a8f948c Change CVS keywords to SVN style 2006-02-16 14:30:13 +00:00
Laurent Saboret 1aad55d4cb Change CVS keywords to SVN style 2006-02-14 10:08:15 +00:00
Laurent Saboret 8aa23e17ec Move packages to trunk root 2006-02-14 08:58:14 +00:00