songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
99,694 Commits 3 Branches 156 Tags 962 MiB
Commit Graph

216 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé a846a1e19c Remove long-deprecated convex_hull_3_to_polyhedron_3() 
Use convex_hull_3_to_face_graph()
 2020-03-10 14:20:17 +01:00
Mael Rouxel-Labbé 8446ef1073 Clean #include's 2020-03-10 13:48:30 +01:00
Mael Rouxel-Labbé 1db10135a6 Change namespaces from internal::Convex_hull_3 to Convex_hull_3::internal 
On-going uniformization work
 2020-03-10 13:47:50 +01:00
Maxime Gimeno a357a90b1f Changes after review 2020-02-10 15:49:54 +01:00
Maxime Gimeno fa14310c41 Add a test 2020-01-31 16:00:42 +01:00
Maxime Gimeno 2d72069c15 Add an overload of Convex_hull_3 for graphs 2020-01-31 14:28:17 +01:00
Sébastien Loriot 254d60f642 First pass on removing license notice in header for GPL files 2019-10-19 15:23:19 +02:00
Sébastien Loriot 7356421d80 introduce Commercial license SPDX tag 2019-10-19 12:15:19 +02:00
Sébastien Loriot 9bd9c68b83 update LGPL[23]+ and GPL[23]+ SPDX tags 
ack -l --no-svg "SPDX-License-Identifier: GPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-3.0+/SPDX-License-Identifier: GPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-3.0+/SPDX-License-Identifier: LGPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: GPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-2.0+/SPDX-License-Identifier: GPL-2.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-2.0+/SPDX-License-Identifier: LGPL-2.0-or-later/"
 2019-10-18 21:57:54 +02:00
Mael Rouxel-Labbé 7a5486962d Merge branch 'PMP-Locate-GF-old' into PMP-Locate-GF 2019-06-20 14:49:25 +02:00
Laurent Rineau 8535a3c03c Merge branch 'releases/CGAL-4.14-branch' 
# Conflicts:
#	Apollonius_graph_2/include/CGAL/Apollonius_graph_2/Apollonius_graph_2_impl.h
#	Convex_hull_3/include/CGAL/convex_hull_3.h
#	Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Corefinement/face_graph_utils.h
#	Polyhedron/demo/Polyhedron/Plugins/Mesh_3/Mesh_3_plugin_cgal_code.cpp
#	Stream_support/include/CGAL/IO/Color.h
 2019-06-20 14:20:37 +02:00
Mael Rouxel-Labbé 7f6cb0411c Merge branch 'PMP-Locate-GF-old' into PMP-Locate-GF 2019-06-18 08:20:16 +02:00
Andreas Fabri 4581f1b7a8 Morte replacements 2019-06-05 08:39:55 +02:00
Laurent Rineau 5dc823d509 Merge branch 'releases/CGAL-4.14-branch' 2019-05-23 08:49:56 +02:00
Andreas Fabri d6801852cc Merge branch 'Kernel_23-Epick_without_interval-GF' of github.com:lrineau/cgal into Kernel_23-Epick_without_interval-GF 2019-05-22 15:24:46 +02:00
Laurent Rineau a126f2173e Use is_certain to avoid throwing exceptions 2019-05-22 15:21:50 +02:00
Andreas Fabri fc7c51bec5 Merge remote-tracking branch 'lrineau/Convex_hull_3-fix_Convex_hull_traits_3_default_of_third_arg-GF' into Kernel_23-Epick_without_interval-GF 2019-05-22 12:46:04 +02:00
Laurent Rineau 0861367169 Replace the planes by a vector+point 
The idea with those planes is a sort of pre-computation of minors of
the determinant of the orientation of `(p,q,r,s)`, with `(p,q,r)`
fixed. But the three minors are only the coordinates `(a,b,c)` of the
plane defined by `(p,q,r)`, and the coordinate `d` is the determinant
of the orientation of `(p,q,r,O)` where `O` is the origin of the
Euclidean plane. We do not want to compute that `d`!

So, instead of computing planes, one computes only the normal
`(a,b,c)` of the plan `(p,q,r)`, and a stores it with `p`. That allows
to compute the determinant of `orientation(p,q,r,s)` once `s` is
known.
 2019-05-22 12:06:40 +02:00
Laurent Rineau 03202d874f Fix the default of 3rd template parameter of Convex_hull_traits_3 
The documentation of `convex_hull_3` says that, if the kernel is "like
`Epick`", then the default traits class of `convex_hull_3` is
`Convex_hull_traits_3`.

But that is wrong, because `Convex_hull_traits_3` is documented with
only two template parameters, and if the kernel is "like `Epick`", the
third argument is `CGAL::Tag_true`, whereas the default of that
parameter is `CGAL::Tag_false`. If users want to write explicitly the
traits in the call to `convex_hull_3`, they cannot know that there is
a third parameters, and that it must be `Tag_true`.

This commit fixes the default of that third argument.
 2019-05-17 16:44:14 +02:00
Mael 0efaed2095
Merge branch 'master' into PMP-Locate-GF 2019-05-06 15:57:09 +02:00
Mael Rouxel-Labbé 9cba48acfe Fixed TDS graph traits implementation and factorized some parts with other T2 GT 2019-04-29 13:22:45 +02:00
Sébastien Loriot 564a6c72f4 Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2019-04-23 10:46:32 +02:00
Sébastien Loriot e54c24f0a4 correct forwarding of projection traits 2019-04-15 16:58:22 +02:00
Sébastien Loriot ce126b87c6 remove cpp11::copy_n, cpp11::prev, and cpp11::next and use std instead 2019-03-29 13:28:32 +01:00
Sébastien Loriot d60f5645aa replace BOOST_FOREACH by c++ ranged-based for loop 
some of the command used for the replacement:
ack --cpp  BOOST_FOREACH -l  | xargs sed -i -E "s/BOOST_FOREACH\(([a-zA-Z_:&0-9]+)\s(\w+)\,/for(\1 \2 :/"
ack --cpp  BOOST_FOREACH -l  | xargs sed -i -E "s/BOOST_FOREACH\((const [a-zA-Z_:&0-9]+)\s(\w+)\,/for(\1 \2 :/"
ack --cpp  BOOST_FOREACH -l  | xargs sed -i -E "s/BOOST_FOREACH\((const typename [a-zA-Z_:&0-9]+)\s(\w+)\,/for(\1 \2 :/"
ack --cpp  BOOST_FOREACH -l  | xargs sed -i -E "s/BOOST_FOREACH\((typename [<>a-zA-Z_:&0-9]+)\s(\w+)\,/for(\1 \2 :/"
ack "boost/foreach.hpp" -l --cpp | xargs sed -i '/boost\/foreach.hpp>/d'
 2019-03-29 13:22:15 +01:00
Laurent Rineau a0d23abd32 Merge pull request #3357 from afabri/Convex_hull_3-use_static_filters-GF 
Convex_hull_3: Fix so that static filters are used
 2018-10-08 15:13:22 +02:00
Laurent Rineau ac9b71951b Merge pull request #3357 from afabri/Convex_hull_3-use_static_filters-GF 
Convex_hull_3: Fix so that static filters are used
 2018-10-08 15:11:46 +02:00
Sébastien Loriot 885cc02c62 fix activation of local static filters 2018-10-01 10:31:21 +02:00
Andreas Fabri a88438e07d Fix so that static filters are used 2018-09-29 08:22:42 +02:00
Sebastien Loriot 327f7d8fbd
Merge branch 'master' into convex_hull_function 2018-07-19 10:21:26 +02:00
Maxime Gimeno 2f319d332e Remove init_iterators. It works without and like this there is no need to change the traits 2018-07-16 09:58:15 +02:00
Sébastien Loriot 0037edc529 use statically filtered predicate 2018-07-13 16:56:16 +02:00
Sébastien Loriot d3a8a07df3 do not use negative side 
change plane's orientation instead
 2018-07-13 16:47:11 +02:00
Maxime Gimeno c945d27dc2 Fix Convex_hull_3 so it becomes minimal. 2018-07-12 16:49:27 +02:00
Maxime Gimeno eb10e59623 Fix and more clean-up of the doc 2018-07-03 11:39:33 +02:00
Maxime Gimeno 276871d708 Update and clean up the doc 2018-07-03 10:46:15 +02:00
Maxime Gimeno f3dd3ba1c0 Document adapter traits. 2018-06-27 10:27:19 +02:00
Maxime Gimeno 4662cbdd96 Revert "Fix initialization of overload with polyhedorn" 
This reverts commit 6e39f1aa05.
 2018-06-27 08:55:48 +02:00
Maxime Gimeno a5b6e6a576 Revert "Add missing Comparison predicates to Convex_hull_dual_traits_3" 
This reverts commit d93ac04702.
 2018-06-27 08:55:38 +02:00
Maxime Gimeno a8314d0f0f Fix static_assertion 2018-06-26 16:23:57 +02:00
Maxime Gimeno 79b1a1bbbf add misisng license include directive 2018-06-26 14:44:18 +02:00
Maxime Gimeno d93ac04702 Add missing Comparison predicates to Convex_hull_dual_traits_3 2018-06-26 14:42:33 +02:00
Maxime Gimeno 6e39f1aa05 Fix initialization of overload with polyhedorn 2018-06-26 12:45:13 +02:00
Maxime Gimeno 9d30fc2c98 add missing construct_objects to Convex_hull_traits_dual 2018-06-22 11:57:58 +02:00
Maxime Gimeno 58bc2faeff Add overload without traits and clean-up test. 2018-06-20 11:21:41 +02:00
Maxime Gimeno 91c704b7ca doc 2018-06-20 11:17:38 +02:00
Maxime Gimeno f1b14bd216 Do some factorization in the traits 2018-06-20 11:16:35 +02:00
Sébastien Loriot c527fa4bcf simplify wrapper around Has_on_positive_side_3 
add a specialization for the new traits
 2018-06-20 11:16:35 +02:00
Maxime Gimeno d6450f397a WIP extreme_vertices : 
- disabled the filtered_predicates for now
 2018-06-20 11:16:35 +02:00
Maxime Gimeno 69392fc32f WIP adapter_traits 2018-06-20 11:16:35 +02:00
Sébastien Loriot 202a0ce9e6 clean up 2018-06-07 10:28:56 +02:00
Konstantinos Katrioplas be4dfe77ac handle convex hull functionality for up to 3 points to a mutable graph and to an output iterator 2018-06-07 10:28:55 +02:00
Konstantinos Katrioplas ec000ea312 function overload for convex_hull_3 which returns a list of points instead of a polyhedron 2018-06-07 10:28:32 +02:00
Andreas Fabri 643aaf2dcf Fix voronoi_covariance_3 and HalfedgeDS_vector 2018-03-29 11:44:25 +02:00
Andreas Fabri 4a4c77cbf1 Cleanup. And tell in the manual that the user has to include the header of the Polygon_mesh type 2018-03-28 17:23:06 +01:00
Andreas Fabri 76ccc9ab6f Convex_hull_3: Remove dependency on package Polyhedron 2018-03-28 14:59:22 +01:00
Laurent Rineau 78e7060525 Merge pull request #2712 from afabri/CGAL-VC+warnlevel_4-GF 
Deal with VC++ warnings of level /W4
 2018-02-19 14:27:06 +01:00
Maxime Gimeno 7fa4b380d2 fixes in includes logic. 2018-02-02 12:08:05 +01:00
Andreas Fabri c493359b62 Convex_hull_3 2018-01-18 10:11:33 +00:00
Andreas Fabri e34529aa9a PSP 2018-01-17 21:17:51 +00:00
Laurent Rineau 1c2e9df8cf Merge branch 'releases/CGAL-4.11-branch' 2017-12-19 16:29:10 +01:00
Laurent Rineau 5181cd7474 Merge branch 'releases/CGAL-4.10-branch' into releases/CGAL-4.11-branch 
# Conflicts:
#	Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/measure.h
 2017-12-19 16:19:22 +01:00
Laurent Rineau c4a7adcd5b Merge pull request #2688 from lrineau/Convex_hull_3-fix_quickhull_in_coplanar_case-GF 
Fix Convex_hull_3 quickhull, with coplanar point
 2017-12-19 16:17:29 +01:00
Laurent Rineau 03913cca16 Merge pull request #2660 from sloriot/CH3-official_add_vertex 
Use documented API
 2017-12-19 16:13:26 +01:00
Laurent Rineau 22d5a5b884 Fix Convex_hull_3 quickhull, with coplanar point 
`CGAL::convex_hull_3` documents that the output is a triangulation
polyhedron. That is true... but for coplanar input points! In case of
coplanar input point, the output before this patch was a polyhedron with a
single polygonal face. The patch triangulates the face using a pivot point
and Euler operations.
 2017-12-15 10:45:25 +01:00
Sébastien Loriot 9dd6684627 use only add_vertex function described in the concept 2017-12-06 16:42:06 +01:00
Sébastien Loriot ee57fc2d6c add SPDX identifier for files under the GPL-3+ license 2017-11-12 10:17:51 +01:00
Laurent Rineau e61409f770 Merge pull request #2321 from sloriot/CH3-fix_tetra_orientation 
fix the orientation of convex hull polyhedron of 4 points
 2017-07-31 16:50:48 +02:00
Sébastien Loriot 04ab1fd268 fix the orientation of the generated polyhedron in case of 4 non-coplanar points 2017-07-31 10:40:51 +02:00
Laurent Rineau aff2a7a899 Merge pull request #2287 from maxGimeno/Fix_GCC8_warnings-GF 
Fix new -Wcatch-value warnings (gcc>=8.0)
 2017-07-25 18:17:42 +02:00
Maxime Gimeno 96f7b0f138 Fix catch value warnings 2017-07-21 11:27:14 +02:00
Andreas Fabri 0cce789437 Add examples for using 3D convex hull functions with open mesh. And fix a bug in convex hull code 2017-07-19 12:25:31 +02:00
Laurent Rineau 1a2f617d89 Merge pull request #1843 from afabri/BGL_accelerate_copy_face_graph-GF 
Accelerate copy_face_graph
 2017-02-08 17:32:47 +01:00
Andreas Fabri 8d1db09275 The vertices must set_face() 2017-02-07 10:51:24 +01:00
Sébastien Loriot 50510c05ea add include directive for license of all GPL header files 
done using:
ack-grep "^GPL" */package_info/*/license.txt -l | awk -F "/" '{print $1}' > /tmp/gpl_packages
for i in `cat /tmp/gpl_packages | \
          grep -v Operations_on_polyhedra | \
          grep -v Algebraic_kernel_for_circles | \
          grep -v Algebraic_kernel_for_spheres | \
          grep -v Polyhedron_IO`;
do
  echo $i
  python Scripts/developer_scripts/add_license_in_pkg_header.py $i
done
python Scripts/developer_scripts/add_license_in_pkg_header.py Operations_on_polyhedra Polygon_mesh_processing
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_circles Circular_kernel_2
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_spheres Circular_kernel_3
python Scripts/developer_scripts/add_license_in_pkg_header.py Polyhedron_IO Polyhedron
 2017-01-19 15:20:25 +01:00
Sébastien Loriot abdf04ad3c add deprecation warning 2016-12-29 12:09:05 +01:00
Sébastien Loriot 1258b7fae4 use BGL function instead of member function 2016-12-29 12:01:47 +01:00
Sébastien Loriot 31e5739a03 forward polyhedron type to the default traits 2016-12-29 12:00:42 +01:00
Andreas Fabri e24a7f6c3d Convex_hull_3: Put a class in the namspace CGAL 2016-12-09 17:39:44 +01:00
Andreas Fabri 466995a31b Add typedef for Polyhedron_3 2016-11-30 11:56:52 +01:00
Andreas Fabri 9ee11501ac Changes after the review by Sebastien 2016-11-30 10:03:00 +01:00
Andreas Fabri 394f9c5b2f polish 2016-11-28 08:32:30 +01:00
Andreas Fabri 332ae157f6 make halfspace_itersectios work with FaceGraph 2016-11-27 20:28:44 +01:00
Andreas Fabri 6c9d30d5bc Go back from unordered_map to map. This fixes the testuite, but what is wrong with unorered_map??? 2016-11-27 11:21:08 +01:00
Andreas Fabri 10df561578 Cannot assign to a reference 2016-11-25 16:58:03 +01:00
Laurent Rineau 873e83a429 try to fix compilation errors 2016-11-25 16:51:45 +01:00
Andreas Fabri e9bb53f13a polish + map -> unordered_map 2016-11-25 14:34:19 +01:00
Andreas Fabri ad85e5ecd7 Fix include guards 2016-11-25 06:36:52 +01:00
Andreas Fabri ed838bf943 Fix a bug also in 4.9, with 3 collinear points 2016-11-24 14:24:11 +01:00
Andreas Fabri 54987251de Add typename 2016-11-24 08:30:36 +01:00
Andreas Fabri b13f541ca4 Merge branch 'Convex_hull_3-FaceGraph-GF' of github.com:afabri/cgal into Convex_hull_3-FaceGraph-GF 2016-11-23 11:57:08 +01:00
Andreas Fabri 1e87967cba bug fix 2016-11-23 11:52:10 +01:00
Laurent Rineau 7af20f34a9 Fix compilation with GNU/g++ 2016-11-22 14:56:37 +01:00
Andreas Fabri e26e60dd6c Add Default to Convex_hull_graph_traits_3; BGLize some code 2016-11-22 12:27:18 +01:00
Andreas Fabri 4d4db0cd70 Move star_to_face_graph() to Triangulation_3 2016-11-21 17:51:41 +01:00
Andreas Fabri 698e0941ea Make polyhedral surface a template parameter 2016-11-21 08:35:01 +01:00
Andreas Fabri 32b1fb1c90 reserve 2016-11-19 08:02:59 +01:00
Andreas Fabri b14a99cdf8 unused typedef 2016-11-18 20:39:10 +01:00
Andreas Fabri e4d2a7f2e1 fixes for bugs spotted by g++ 2016-11-18 17:56:24 +01:00
Andreas Fabri 63dfd4f992 check_convexity for FaceGraph 2016-11-18 16:47:53 +01:00