Commit Graph

3351 Commits

Author SHA1 Message Date
Efi Fogel bc83b00a2e Cleaned up and deprecated Arr_segment_2::bbox(), which was left by mistake... 2020-11-04 15:55:04 +02:00
Simon Giraudot c02ffb762b Use 2 booleans instead of an enum 2020-10-21 13:31:21 +02:00
Simon Giraudot 0b70318c51 Merge remote-tracking branch 'mine/Polygon-Vertex_pair_iterator-GF' into Polygon-Vertex_pair_iterator-GF 2020-10-20 09:01:29 +02:00
Ahmed Essam ae8496fdfc Probably fixes warnings with Bezier and Rational traits 2020-10-14 07:11:07 +02:00
Ahmed Essam ae46209b2b Address compile errors with msvc2015 2020-10-06 16:00:04 -07:00
Ahmed Essam 29abb9c657 Small change 2020-10-06 19:41:17 +01:00
Ahmed Essam 614d7feb4f Fix bug with entering rational curves 2020-10-06 19:26:53 +01:00
Ahmed Essam 86e4235eee Fix warnings 2020-10-04 14:32:42 +01:00
Ahmed Essam 32093e6ea3 Merge branch 'master' of https://github.com/CGAL/cgal into gsoc2020-aos_demo-theartful 2020-10-03 20:55:38 +02:00
Ahmed Essam 1d3815f4ec Change things for better compilation speed 2020-10-03 20:35:50 +02:00
Sebastien Loriot 03ff1a667f
Merge pull request #4784 from efifogel/Aos_2-remove_object-efif
Aos_2: Change Make_x_monotone_2 return type from legacy CGAL::Object to boost::variant
2020-10-02 15:19:36 +02:00
Ahmed Essam 527d15eabe Fix division by zero bug 2020-10-01 16:10:20 +01:00
Ahmed Essam 72718bacac Fix bug with parsing polynomials of one dimension 2020-10-01 16:01:33 +01:00
Ahmed Essam 1ae6f3f495 Fix past the "beginning" bug
This caused assertion error in msvc debug mode while running the demo
2020-10-01 15:56:44 +01:00
Ahmed Essam aa2bc8d05f Fix msvc min/max conflict (hopefully for the last time!) 2020-10-01 19:40:54 +01:00
Ahmed Essam 1fb65b6ea8 Fix msvc warning 2020-10-01 18:35:00 +01:00
Simon Giraudot 4f0648d17b Use Point_2/Point_2 constructor so that it also works with Arr_non_caching_segment_traits 2020-10-01 08:54:47 +02:00
Simon Giraudot 1d3c289481 Fix outdated variable name 2020-09-30 15:41:05 +02:00
Ahmed Essam 945853fc34 Simplify last commit and potentially avoid missing return warning 2020-09-30 11:57:00 +02:00
Ahmed Essam 890787c518 msvc2015 doesn't treat static const int as constexpr 2020-09-30 11:48:39 +02:00
Ahmed Essam f2115d534b Fix min/max macro conflict 2020-09-30 10:53:02 +02:00
Ahmed Essam 9b97665d09 Remove unused include 2020-09-29 15:44:12 +02:00
Ahmed Essam f13532f27f Fix issue with constexpr functions having multiple returns in msvc2015 2020-09-29 15:39:57 +02:00
Ahmed Essam ab15a175b4 Fix windows min/max macro conflict 2020-09-29 15:23:02 +02:00
Jane Tournois 5c8df6672a remove CGAL_CFG_MATCHING_BUG_ variants
the "matching bug" of msvc has been fixed since at least vs 2015
2020-09-25 14:25:14 +02:00
Ahmed Essam 91912bd168 Use new envelope functions 2020-09-24 21:31:09 +02:00
Ahmed Essam b238db17ae Merge remote-tracking branch 'cgal/master' into gsoc2020-aos_demo-theartful 2020-09-24 20:46:06 +02:00
Ahmed Essam 885759ff05 Fix compilation error with msvc2017
Fixes the compilation error in x64_Cygwin-Windows10_MSVC2017-Debug-64bits
platform.
CXXFLAGS=/DWIN32 /D_WINDOWS /W3 /GR /EHsc -D_CRT_SECURE_NO_DEPRECATE
-D_SCL_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS
-D_SCL_SECURE_NO_WARNINGS
-D_SILENCE_CXX17_ADAPTOR_TYPEDEFS_DEPRECATION_WARNING /fp:strict
/fp:except- /wd4503 /bigobj /permissive- /std:c++17 /D_DEBUG /MDd /Ob0
/Od /RTC1
LDFLAGS=/machine:x64 /debug /INCREMENTAL
Curve_renderer_2.h(1753): error C2760: syntax error: unexpected token
'identifier', expected ')'
Produced the error locally and for some reason adding the extra parenthesis
fixed the problem. Most probably a bug with msvc2017 with these flags.
2020-09-23 18:19:24 -07:00
Ahmed Essam 738642c277 Remove useless guards 2020-09-23 18:12:43 -07:00
Ahmed Essam a59f2d6a51 Address problems in last test suite run
https://cgal.geometryfactory.com/CGAL/testsuite/results-5.2-Ic-11.shtml#Arrangement_on_surface_2_Demo
2020-09-23 11:01:43 -07:00
Efi Fogel a78da99764 Used the fh handle to eliminate the warning of unused 2020-09-23 14:28:49 +03:00
Efi Fogel 92801f4f8f Chenged back size_t to unsigned int (at some point all Multiplicity types should be defined as size_t) 2020-09-23 14:27:53 +03:00
Efi Fogel 3f1647345b Initialized m_is_directed_right in default constructor 2020-09-23 14:27:22 +03:00
Efi Fogel 70f5d0eede Removed redundant typedefs 2020-09-22 10:08:47 +03:00
Ahmed Essam a4530b825c Guard catching internal exception with CGAL_USE_CORE
Catching this exception is for debugging reasons + this is probably
a bug
2020-09-22 09:07:13 +02:00
Ahmed Essam 124c4c1ae8 Revert "Change CGAL_USE_CORE to CGAL_USE_Core"
This reverts commit 2f6e3e8732.
2020-09-22 09:04:59 +02:00
Ahmed Essam 2f6e3e8732 Change CGAL_USE_CORE to CGAL_USE_Core
made sure that the demo compiles with/without Core
2020-09-22 07:18:49 +02:00
Ahmed Essam a30658a4d3 Fix compilation errors & other changes 2020-09-21 09:42:15 +02:00
Ahmed Essam b6148a712b Fix unused var warning 2020-09-16 02:59:50 +02:00
Efi Fogel b41988aa70 Merge remote-tracking branch 'cgal/master' into Aos_2-remove_object-efif 2020-09-15 17:18:34 +03:00
Laurent Rineau 6cf203f5ca Merge pull request #4861 from sgiraudot/Arrangement_2-Small_enhancements-GF
Arrangement 2: Small Enhancements
2020-09-11 15:07:50 +02:00
Ahmed Essam 6d91abc9e8 Check if arr is model of ArrangementOpenBoundaryTraits instead of try and catch 2020-08-31 18:35:38 +02:00
Ahmed Essam 1cf11730a9 Fix focus for algebraic and rational curve input dialogs 2020-08-31 01:57:25 +02:00
Ahmed Essam b83437451e Bounding y-coordinate on the ends causes bugs as expected 2020-08-31 01:51:41 +02:00
Ahmed Essam c130770820 Fix bug with algebraic parser + with view navigation 2020-08-31 01:30:37 +02:00
Ahmed Essam 17bcc9696c Don't use bbox with segment/linear/polyline traits 2020-08-31 00:18:13 +02:00
Ahmed Essam b9a08d76d6 cleanups 2020-08-30 23:24:51 +02:00
Ahmed Essam bf57baf339 Make the demo work without CORE + other cleanups 2020-08-30 20:07:53 +02:00
Ahmed Essam acba1e4e5f Icons, about and bug fixes 2020-08-28 17:02:04 +02:00
Ahmed Essam afd3841b2c small changes 2020-08-27 04:36:27 +02:00