Efi Fogel
bc83b00a2e
Cleaned up and deprecated Arr_segment_2::bbox(), which was left by mistake...
2020-11-04 15:55:04 +02:00
Simon Giraudot
c02ffb762b
Use 2 booleans instead of an enum
2020-10-21 13:31:21 +02:00
Simon Giraudot
0b70318c51
Merge remote-tracking branch 'mine/Polygon-Vertex_pair_iterator-GF' into Polygon-Vertex_pair_iterator-GF
2020-10-20 09:01:29 +02:00
Ahmed Essam
32093e6ea3
Merge branch 'master' of https://github.com/CGAL/cgal into gsoc2020-aos_demo-theartful
2020-10-03 20:55:38 +02:00
Sebastien Loriot
03ff1a667f
Merge pull request #4784 from efifogel/Aos_2-remove_object-efif
...
Aos_2: Change Make_x_monotone_2 return type from legacy CGAL::Object to boost::variant
2020-10-02 15:19:36 +02:00
Ahmed Essam
1ae6f3f495
Fix past the "beginning" bug
...
This caused assertion error in msvc debug mode while running the demo
2020-10-01 15:56:44 +01:00
Ahmed Essam
aa2bc8d05f
Fix msvc min/max conflict (hopefully for the last time!)
2020-10-01 19:40:54 +01:00
Ahmed Essam
1fb65b6ea8
Fix msvc warning
2020-10-01 18:35:00 +01:00
Simon Giraudot
4f0648d17b
Use Point_2/Point_2 constructor so that it also works with Arr_non_caching_segment_traits
2020-10-01 08:54:47 +02:00
Simon Giraudot
1d3c289481
Fix outdated variable name
2020-09-30 15:41:05 +02:00
Ahmed Essam
f2115d534b
Fix min/max macro conflict
2020-09-30 10:53:02 +02:00
Jane Tournois
5c8df6672a
remove CGAL_CFG_MATCHING_BUG_ variants
...
the "matching bug" of msvc has been fixed since at least vs 2015
2020-09-25 14:25:14 +02:00
Ahmed Essam
b238db17ae
Merge remote-tracking branch 'cgal/master' into gsoc2020-aos_demo-theartful
2020-09-24 20:46:06 +02:00
Ahmed Essam
885759ff05
Fix compilation error with msvc2017
...
Fixes the compilation error in x64_Cygwin-Windows10_MSVC2017-Debug-64bits
platform.
CXXFLAGS=/DWIN32 /D_WINDOWS /W3 /GR /EHsc -D_CRT_SECURE_NO_DEPRECATE
-D_SCL_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS
-D_SCL_SECURE_NO_WARNINGS
-D_SILENCE_CXX17_ADAPTOR_TYPEDEFS_DEPRECATION_WARNING /fp:strict
/fp:except- /wd4503 /bigobj /permissive- /std:c++17 /D_DEBUG /MDd /Ob0
/Od /RTC1
LDFLAGS=/machine:x64 /debug /INCREMENTAL
Curve_renderer_2.h(1753): error C2760: syntax error: unexpected token
'identifier', expected ')'
Produced the error locally and for some reason adding the extra parenthesis
fixed the problem. Most probably a bug with msvc2017 with these flags.
2020-09-23 18:19:24 -07:00
Efi Fogel
92801f4f8f
Chenged back size_t to unsigned int (at some point all Multiplicity types should be defined as size_t)
2020-09-23 14:27:53 +03:00
Efi Fogel
3f1647345b
Initialized m_is_directed_right in default constructor
2020-09-23 14:27:22 +03:00
Efi Fogel
70f5d0eede
Removed redundant typedefs
2020-09-22 10:08:47 +03:00
Efi Fogel
b41988aa70
Merge remote-tracking branch 'cgal/master' into Aos_2-remove_object-efif
2020-09-15 17:18:34 +03:00
Laurent Rineau
6cf203f5ca
Merge pull request #4861 from sgiraudot/Arrangement_2-Small_enhancements-GF
...
Arrangement 2: Small Enhancements
2020-09-11 15:07:50 +02:00
Efi Fogel
23a02ff441
Pacify Windows msvc (definition of casting operator).
2020-08-25 11:48:20 +03:00
Efi Fogel
58fb204e97
Placed back the bbox() function. (Will be deprecated in a separate commit.)
2020-08-24 11:52:27 +03:00
Simon Giraudot
267e7316f1
Fix: compute orientation before checking if segment is vertical
2020-08-24 09:41:43 +02:00
Efi Fogel
b4e7a4ad02
Reverted the bbox computation optimization as it turns out it doesn't help
2020-08-22 21:04:40 +03:00
Efi Fogel
a857651c21
Optimized the bbox construction in do_bboxes_overlap()
2020-08-20 20:39:50 +03:00
Ahmed Essam
48e0fee7dd
Rebase fixes
2020-08-20 19:34:50 +02:00
Ahmed Essam
489499f081
Solve compiler warnings
2020-08-20 19:30:16 +02:00
Ahmed Essam
4e3c64f488
Fix some compiler warnings
2020-08-20 19:30:16 +02:00
Ahmed Essam
4bc9d2bff2
Add missing break
2020-08-20 19:30:16 +02:00
Ahmed Essam
087005d7c0
Fix warnings in algebraic traits
2020-08-20 19:30:16 +02:00
Ahmed Essam
78af28d4c5
Revert all changes outside the demo
2020-08-20 19:30:16 +02:00
Ahmed Essam
e1ea14b461
some update
2020-08-20 19:26:10 +02:00
Ahmed Essam
2f0a283139
Use new originator constructor
2020-08-20 19:26:10 +02:00
Ahmed Essam
4ee591f500
Intersection points can be due to 2 or more points
...
to reproduce this bug, try upper envelope operation on the arrangement
by Jeb
2020-08-20 19:26:10 +02:00
Ahmed Essam
8b78d0e790
Fix bug with self intersecting curves
2020-08-20 19:26:10 +02:00
Ahmed Essam
a2bc6227c3
Temporary change to be backward compatible with bezier serialization
2020-08-20 19:23:25 +02:00
Ahmed Essam
94ea08a2c4
Bezier serialization
2020-08-20 19:17:06 +02:00
Ahmed Essam
669b975f60
Unbounded faces, snapping and more!
2020-08-20 19:17:06 +02:00
Ahmed Essam
e026e0b435
Revert "Add Approximate_number_type to Arr_circular_arc_traits"
...
This reverts commit 7db9e267b3d7d11f4372e00b0b4329d4412b5eb4.
2020-08-20 19:17:05 +02:00
Ahmed Essam
6b85115679
Add Approximate_number_type to Arr_circular_arc_traits
2020-08-20 19:17:05 +02:00
Ahmed Essam
a19207b957
Clean up and big fixes
2020-08-20 19:17:05 +02:00
Ahmed Essam
ac72f408a0
Move EnvelopeCallback class implementation to cpp file
2020-08-20 19:17:05 +02:00
Efi Fogel
9d6d9929ec
Cleaned up. Moved some operations from the the curve (Arr_segment_2) to the traits and declared the former deprecated. Optimized further the Intersect_2 functor.
2020-08-20 19:53:52 +03:00
Simon Giraudot
3656be09c6
Only compute line if needed
2020-08-19 16:11:14 +02:00
Sébastien Loriot
ae62039df3
remove used variable
2020-08-18 14:10:16 +02:00
Efi Fogel
d309bdf2ca
Used ..._object() member function to obtain functor objects and cleaned up formatting.
2020-08-18 12:16:27 +03:00
Simon Giraudot
4f99fe893d
Use vertex pair iterator in GPS to avoid constructing Segment_2 objects
2020-08-13 15:37:33 +02:00
Ahmed Essam
3dc2804b9e
Move _inc_to_right != cv._inc_to_right assertion to its right location
2020-08-11 13:23:08 +02:00
Ahmed Essam
ff93e2b3bd
Curve params "s" and "t" are interchangeable with self intersections
2020-08-11 13:18:30 +02:00
Ahmed Essam
6d949cd14f
Fix bug with self intersecting bezier curves
2020-08-08 17:29:55 +02:00
Simon Giraudot
becb663e39
Use fast pool allocator
2020-07-21 11:46:25 +02:00