Commit Graph

402 Commits

Author SHA1 Message Date
Laurent Rineau e8457db212 Merge pull request #2486 from sgiraudot/Shape_detection-Fix_duplicate_indices-GF
Region Growing: fix badly initialized class_index (lead to duplicate indices)
2017-10-17 15:20:31 +02:00
Laurent Rineau 8f46324806 Merge pull request #2475 from sgiraudot/Fix_counting_iterator_warning_everywhere-GF
Fix counting iterator warnings
2017-10-11 19:15:15 +02:00
Simon Giraudot 5232df1ead Fix bug: badly initialized class_index (lead to duplicate indices) 2017-10-03 15:32:18 +02:00
Simon Giraudot 1e7b9ea027 Fix counting iterator warnings 2017-09-29 14:47:17 +02:00
Caedmon Irias 8690601d56 Cherry-pick pull request #2409 from SKURInc/master
avoid index out of range with large bitmap sizes

With large u and v, the product u * v exceeds the capacity of an int.  The result when coerced to size_t can be an out of range index into bitmap.
Avoid this by casting u and v to size_t before multiplying.
2017-09-15 16:27:38 +02:00
Caedmon Irias 19fa9bffc6 avoid index out of range with large bitmap sizes
With large u and v, the product u * v exceeds the capacity of an int.  The result when coerced to size_t can be an out of range index into bitmap.
Avoid this by casting u and v to size_t before multiplying.
2017-09-09 12:34:42 -07:00
Jane Tournois 93035b5a71 add pragmas to silent conversion warning from boost::counting_iterator on windows 32 bits
in boost/iterator/counting_iterator.hpp, the function
boost::number_distance::distance() converts an integer of the return type of
boost::detail::numeric_distance() (a 64 bits boost::intmax_t) into an integer
of `Difference` type (a 32 bits std::ptrdiff_t, prescribed in Region_growing.h)
2017-08-31 15:30:42 +02:00
Simon Giraudot 65c0a49e09 Fix Windows warning C4244 (counting_iterator diff type) 2017-08-28 09:59:22 +02:00
Simon Giraudot 335abd45dd Fix warnings 2017-08-14 09:58:33 +02:00
Simon Giraudot 3d53408682 Fix Doxygen warnings 2017-08-07 17:00:00 +02:00
Simon Giraudot bc3999f470 More warning fixes 2017-08-07 10:09:04 +02:00
Simon Giraudot f03469dc5e Fix error in example (bad argument handling) 2017-08-07 10:08:28 +02:00
Simon Giraudot dd7bebe3e9 Fix windows warning FT conversion 2017-08-07 09:59:17 +02:00
Simon Giraudot 3fbc15fa7e Warning fix: typename outside class 2017-08-07 09:55:18 +02:00
Simon Giraudot d521432fa5 Fix outdated CMakeLists 2017-08-07 09:49:53 +02:00
Simon Giraudot 77b3398439 Revert change of parameter's behavior (error prone) 2017-08-03 11:09:21 +02:00
Simon Giraudot b0f636530b Fix tests from shape detection 2017-08-03 09:02:51 +02:00
Simon Giraudot 82100d5c07 Add missing square_distance include 2017-08-02 14:57:55 +02:00
Simon Giraudot 2f8f10de44 Warning fix: unused variable 2017-08-01 16:59:23 +02:00
Simon Giraudot 6b9acabb41 Fix license problem 2017-08-01 15:49:56 +02:00
Simon Giraudot 7c20a93563 Make TBB optional only in examples 2017-08-01 15:49:56 +02:00
Simon Giraudot c66f3943a4 Fix subsection tag and name 2017-08-01 15:47:59 +02:00
Simon Giraudot 6177d34d74 Update doc from review 2017-08-01 15:47:58 +02:00
Simon Giraudot db7470ccd3 Add history section in doc 2017-08-01 15:47:58 +02:00
Simon Giraudot b6812f7f60 Update doc from review + some fixes 2017-08-01 15:47:58 +02:00
Simon Giraudot 5fdf497b08 Add figure for comparison RANSAC/region growing 2017-08-01 15:47:58 +02:00
Simon Giraudot 61a3d711d6 Add performance graph for region growing 2017-08-01 15:47:58 +02:00
Simon Giraudot f9a2547f9e Merge examples 2017-08-01 15:47:58 +02:00
Simon Giraudot d0e3e7761e Bugfix: use attribute of class to recall available points 2017-08-01 15:47:58 +02:00
Simon Giraudot 2938a6a702 Bugfix: compute PCA after enough points are found 2017-08-01 15:47:58 +02:00
Simon Giraudot 46862a2569 Fix broken link in doc 2017-08-01 15:47:58 +02:00
Simon Giraudot 4c99c7be33 Fix doc 2017-08-01 15:47:58 +02:00
Simon Giraudot be69b2bdd9 Update doc and API 2017-08-01 15:47:58 +02:00
Simon Giraudot 6a119fef11 Unify APIs of structuring and regularization 2017-08-01 15:47:58 +02:00
Simon Giraudot fd241cf918 Fix parameter in plane regularization 2017-08-01 15:45:38 +02:00
Simon Giraudot c1309bd35a Improve seed picking for region growing 2017-08-01 15:45:38 +02:00
Simon Giraudot 55d73a15fb Use Point_set_3 in example 2017-08-01 15:45:38 +02:00
Simon Giraudot a3b70e0fee Some fixes and improvements in Region growing 2017-08-01 15:45:38 +02:00
Simon Giraudot 7a2ee4bc02 Add Plane_range access in RANSAC 2017-08-01 15:45:38 +02:00
Simon Giraudot 47f42f63f1 Provide property maps to easily handle shape detection output 2017-08-01 15:45:37 +02:00
Simon Giraudot f3763c3456 Generalize plane regularization API 2017-08-01 15:45:37 +02:00
Simon Giraudot e717bccb39 New example for region growing 2017-08-01 15:45:06 +02:00
Simon Giraudot 1f439643f4 Add Region_growing as friend class of Shape_base 2017-08-01 15:45:06 +02:00
Simon Giraudot abda210b66 First version of region growing algorithm 2017-08-01 15:45:06 +02:00
Simon Giraudot b88deb3759 Rename Efficient_RANSAC_traits as Shape_detection_traits (same for concept) 2017-08-01 15:45:06 +02:00
Simon Giraudot 3fdcff513c Bugfix: do not keep track of if connected components were already computed or not 2017-06-20 14:04:07 +02:00
Andreas Fabri d9c634e63f Remove unused variables 2017-05-11 16:12:56 +02:00
Sébastien Loriot c360e025a1 Merge remote-tracking branch 'cgal/releases/CGAL-4.9-branch' into HEAD 2017-03-16 10:41:40 +01:00
Simon Giraudot 12e032c9e4 Bugfix in test: shape factory must be added when input is reset 2017-03-16 10:37:22 +01:00
Simon Giraudot 24ff167b72 Fix incomplete clear 2017-03-16 10:37:21 +01:00