Commit Graph

1783 Commits

Author SHA1 Message Date
Andreas Fabri 435e6d690f Fix typo (leading to a compilation error) 2022-02-22 08:11:51 +00:00
Andreas Fabri 740d34234f delete trailing whitespace 2022-02-18 15:42:31 +01:00
Andreas Fabri abe216b73d PSP: ofstream -> sstream 2022-02-18 15:42:29 +01:00
Laurent Rineau 5897f379ba Merge pull request #6133 from MaelRL/CGAL_IO-PWN_without_normals-GF
Minor improvements for OFF/XYZ point set IO
2021-12-20 18:06:41 +01:00
Mael Rouxel-Labbé dc06959eeb Test improvements 2021-12-16 14:51:01 +01:00
Mael Rouxel-Labbé ee1622e14a Don't write "NOFF" if there are no normals 2021-12-16 14:44:13 +01:00
Laurent Rineau 17a7d8cfbc Merge pull request #6130 from cjamin/patch-1
Bug fix: `remove_outliers` was removing ALL points when no outliers were found
2021-11-25 17:28:39 +01:00
Laurent Rineau c199795670 Merge pull request #6104 from sloriot/Property_map-fix_id_map_mutable
restore mutable property of the pmap
2021-11-18 12:27:23 +01:00
Mael Rouxel-Labbé 27f55f1dcf Fix previous syntax error fix 2021-11-17 09:46:29 +01:00
Mael Rouxel-Labbé 862f3ee4f9 Misc minor enhancements 2021-11-17 09:46:17 +01:00
Mael Rouxel-Labbé 25f5b91de5 Return a reading error for NOFF without normals 2021-11-17 09:41:52 +01:00
Clément Jamin 7f72142818
Remove trailing whitespaces 2021-11-16 17:15:46 +01:00
Clément Jamin c5d341b960
If no outliers are found, just return the original range 2021-11-16 16:06:30 +01:00
Clément Jamin ffe7a6909a
Improve `std::partition` predicate 2021-11-16 15:48:48 +01:00
Clément Jamin 597970b368
Bug fix: `remove_outliers` was removing ALL points when no outliers were found
Bug in current code: when no outliers are found, `f2r` is `sorted_points.end()`. So, `if (sit == f2r)` is never true, and `out` keeps its initial value, which is `points.begin()`.
2021-11-16 12:06:32 +01:00
Sébastien Loriot 4eb1464aed fix Identity_map mutability and fix CGAL code using it 2021-11-09 11:37:24 +01:00
Sébastien Loriot ab48f63e30 update latest cmake version tested 2021-11-09 10:58:47 +01:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Sébastien Loriot 1857a25d28 Merge remote-tracking branch 'cgal/master' into CGAL_data-moving_files 2021-10-06 13:50:31 +02:00
Sébastien Loriot b5e7d03634 fix runtime issues 2021-10-04 10:22:13 +02:00
Sébastien Loriot 8350dea94a char* -> std::string 2021-10-04 09:49:24 +02:00
Sébastien Loriot 47028cd184 automatically move data files in data dir + update paths
Done for OFF/OBJ/STL/XYZ/PWN/PLY
2021-10-04 09:42:49 +02:00
Sébastien Loriot d8cdba669b rename input 2021-10-04 09:32:03 +02:00
Laurent Rineau a36fbb85d8 Merge pull request #6018 from afabri/PSP-check_open_close-GF
Unset fail bit and add assertions about the state of a stream
2021-09-30 16:49:37 +02:00
Andreas Fabri b3a7a7dc69 untabify 2021-09-29 13:44:42 +01:00
Andreas Fabri 551ff77fb7 Do not open() and close() just one stream 2021-09-29 13:31:45 +01:00
Laurent Rineau 7fc986f581 Merge pull request #5992 from afabri/CGAL-safe_functions-GF
Deal with memset, memcpy, fscanf...    and their safe equivalents
2021-09-29 11:46:44 +02:00
Laurent Rineau ad79d37410 Merge pull request #6014 from MaelRL/CGAL-IO_Clarify_binary_text-GF
CGAL IO: Clarify binary warning
2021-09-29 11:46:30 +02:00
Andreas Fabri 716dcaf6c9
Apply suggestions from code review
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
2021-09-28 13:57:40 +02:00
Andreas Fabri 4d1f12d1e2 Unset fail bit and add assertions about the state of a stream 2021-09-28 10:41:50 +01:00
Mael Rouxel-Labbé 5578bf43ff Misc cleaning 2021-09-27 15:35:40 +02:00
Mael Rouxel-Labbé c8cc0747fa Clarify binary warning 2021-09-27 15:33:42 +02:00
Sébastien Loriot dc8f15271a expand * 2021-09-23 18:56:14 +02:00
Sébastien Loriot a038794489 missing semicolon 2021-09-23 18:55:57 +02:00
Sébastien Loriot bd345c7f83 remove .cmd files for examples 2021-09-23 18:54:46 +02:00
Andreas Fabri 3b7754f796 CGAL_TRACE() -> CGAL_TRACE_STREAM 2021-09-23 17:00:10 +02:00
Laurent Rineau e5ab9202f5 Merge pull request #4229 from gdamiand/CGAL_data-gdamiand
Regroup data: scripts and function updates
2021-09-23 16:14:11 +02:00
Sebastien Loriot 575939c64f
Merge pull request #5952 from sloriot/SS-remove_Polygon_dep
remove artificial dependency to Polygon
2021-09-10 17:40:20 +02:00
Mael Rouxel-Labbé 80c81a2c17 Fix typo 2021-09-08 15:54:32 +02:00
Sébastien Loriot f5d2fb28a2 remove artificial dependency to Polygon 2021-09-01 16:41:36 +02:00
Maxime Gimeno 499301c759 More fixes 2021-08-31 16:00:37 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Sebastien Loriot 8d00945943
Merge pull request #5655 from danston/PSP-libpointmatcher_enhancements-danston
[Small Feature] Support for libpointmatcher::GenericDescriptorOutlierFilter
2021-08-12 10:10:13 +02:00
Sébastien Loriot f153a1ed3e Merge remote-tracking branch 'cgal/master' into HEAD 2021-07-22 13:15:22 +02:00
Maxime Gimeno a3d1765ab4 Merge remote-tracking branch 'cgal/master' into CGAL-Clean_up_boost_versions-maxGimeno 2021-07-19 14:18:40 +02:00
Mael Rouxel-Labbé 78ff9185b3 Harmonize ASCII usage across all packages 2021-06-23 23:34:32 +02:00
Mael Rouxel-Labbé a34debc92b Uniformize os/is/s/i stream parameter name in Stream_support/io
+ remove extra backticks in NP doc
2021-06-23 23:32:06 +02:00
albert-github 2a54687e77 Correction of hyperlinks
The link checker gave a number of redirects and incorrect links.
- the redirects have been solved ass far as possible
- the incorrect links have been checked and corrected where possible, others  have been reported through issues;
2021-06-04 13:52:14 +02:00