Commit Graph

99713 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé b0c183fc3d Add missing typedef 2022-10-21 12:07:12 +02:00
Mael Rouxel-Labbé 82c0d0686e Add missing typedef 2022-10-21 11:23:45 +02:00
Mael Rouxel-Labbé 6a694366f0 Remove trailing whitespace 2022-10-21 10:34:13 +02:00
Mael Rouxel-Labbé 6a5f099f41 Add a test 2022-10-21 00:05:30 +02:00
Mael Rouxel-Labbé 0d00ad237b Remove needless normalization calls 2022-10-21 00:05:20 +02:00
Mael Rouxel-Labbé b9e7c2aa13 Misc minor fixes 2022-10-20 17:35:19 +02:00
Mael Rouxel-Labbé 0640470f5d Hide pmp_weights_deprecated.h behind CGAL_NO_DEPRECATED_CODE 2022-10-20 17:34:34 +02:00
Mael Rouxel-Labbé f4f6229c42 Weights examples/tests improvements 2022-10-20 17:34:02 +02:00
Mael Rouxel-Labbé 141f05abd2 Use num_halfedges instead of 2*num_edges 2022-10-20 17:32:53 +02:00
Mael Rouxel-Labbé 59f2021eaf Update Weights doc figure to use compatible notations 2022-10-20 17:32:20 +02:00
Mael Rouxel-Labbé dfe3ff5d60 Code clarifications 2022-10-20 17:31:22 +02:00
Mael Rouxel-Labbé ca93b406a2 Avoid needless length check (the weight functors already do it) 2022-10-20 17:31:01 +02:00
Mael Rouxel-Labbé 936b02b87e Fix order of points: the circulator is clockwise around the vertex 2022-10-20 17:30:18 +02:00
Mael Rouxel-Labbé b469a58df9 Fix compilation of alternate, unused iterative authalic initializers 2022-10-20 17:29:44 +02:00
Mael Rouxel-Labbé 010e24f4ff Fix weight calculator initialization in Surface mesh deformation 2022-10-20 17:28:42 +02:00
Mael Rouxel-Labbé 91336eb213 Use modern C++ 2022-10-20 17:28:00 +02:00
Mael Rouxel-Labbé 19f847a74b Fix API of cotan functor in shape smoothing 2022-10-20 17:27:39 +02:00
Mael Rouxel-Labbé 6cd5c24f70 Pass traits to the secure Vor-weighted cotan functor 2022-10-20 17:27:26 +02:00
Mael Rouxel-Labbé 7eb3002790 Avoid computing all angles if possible 2022-10-20 17:25:52 +02:00
Mael Rouxel-Labbé 670fec5e3c Fix issues in tangent_weight classes
- Edge_tangent_weight returns 0 if the halfedge is border
- if opp(h, mesh) is tangent, properly returns tan of the HALF angle
  and not tangent_3.
2022-10-20 17:24:40 +02:00
Mael Rouxel-Labbé 92ea84d672 Factorize cotangent_weight classes 2022-10-20 17:23:11 +02:00
Mael Rouxel-Labbé 9ab7e1ed7f Misc minor code cleaning 2022-10-20 17:21:43 +02:00
Mael Rouxel-Labbé 5f89766c5c Uniformize notations across the package + re-introduce documentation 2022-10-20 17:19:40 +02:00
Mael Rouxel-Labbé 15de97faf1 Re-organize internal functions and use usual APIs 2022-10-17 21:40:05 +02:00
Mael Rouxel-Labbé 72163bc009 Simply weight computations and use documentation variable names 2022-10-17 17:54:01 +02:00
Mael Rouxel-Labbé 85132eea04 More re-indentation 2022-10-17 17:02:29 +02:00
Mael Rouxel-Labbé 9a438b26c4 Use fewer 'auto's 2022-10-17 16:48:56 +02:00
Mael Rouxel-Labbé d20475f322 Add missing includes in Weights 2022-10-17 16:29:32 +02:00
Mael Rouxel-Labbé e0e0c4d54b Remove old doc (new one to be re-added directly on the functions) 2022-10-17 16:25:36 +02:00
Mael Rouxel-Labbé fd6745af62 Use a more standard indentation in Weights/include 2022-10-17 16:20:48 +02:00
Mael Rouxel-Labbé 2a679483b2 Fix ARAP post processing
The formula of weights is "- tan(theta / 2) / length", with:
 tan ( theta / 2 ) = sin ( theta ) / ( 1 + cos ( theta ) )
                   = ( 2 * A / |v1| * |v2| ) / ( 1 + v1 . v2 / |v1| * |v2| )
		   = 2 * A / ( |v1| * |v2| + v1 . v2 )

with A the _unsigned_ area.
2022-10-16 16:22:29 +02:00
Mael Rouxel-Labbé 2fe82ec9d9 Add an example for ARAP parameterization 2022-10-16 16:22:15 +02:00
Laurent Rineau adc5bd4677 Merge pull request #6864 from janetournois/Mesh_3-fix_weighted_images-GF
Mesh 3 - fix construction of weights image for labeled image input
2022-10-13 15:14:11 +02:00
Laurent Rineau ae8101d615 Merge pull request #6931 from MaelRL/PMP-remove_degen_fix_bad_removal-GF
Purge to-be-border halfedges from edges-to-collapse sets
2022-10-13 15:14:09 +02:00
Laurent Rineau 28e6e7249f 5.4.x-branch now targets CGAL-5.4.4 2022-10-12 15:28:35 +02:00
Laurent Rineau e5687eb69f Merge pull request #6918 from lcaraffa/Triangulation-is_valid-lc
Triangulation_d: fix invalid triangulation after I/O
2022-10-07 15:46:11 +02:00
Laurent Rineau 437dbf82a9 Merge pull request #6925 from MaelRL/OBB-Do_not_use_void_as_default-GF
Do not use `void` as default for the geometric traits if Eigen is not present
2022-10-07 15:46:08 +02:00
Laurent Rineau 7db002804c Merge pull request #6927 from lrineau/Mesh_3-fix_leaks-GF
Mesh_3: Fix a memory leak in the parallel code
2022-10-07 15:46:06 +02:00
Jane Tournois 9bb4fb4d15 protect debug code with macro
and remove default filename ""
2022-10-06 15:10:37 +02:00
Jane Tournois c64a0d8648 add more details about how to choose sigma 2022-10-06 10:44:26 +02:00
Sébastien Loriot d6d2188cc7 fix warning 2022-10-05 19:33:00 +02:00
Laurent Rineau ea35fa8f88 Fix autotest_cgal_with_ctest
That commit makes the CMake variables `CGAL_TEST_SUITE` (the new one)
and `RUNNING_CGAL_AUTO_TEST` (the legacy one) completely equivalent.
2022-10-05 15:06:02 +02:00
Mael Rouxel-Labbé 60d50a8b57 Fix not purging to-be-border halfedges from edges-to-collapse sets 2022-10-04 22:57:37 +02:00
Laurent Rineau 207a1e896b Merge pull request #6796 from janetournois/Mesh_3-compare_distance_performance_issue-jtournois
Mesh_3 speedup (filter failures in `Compare_distance_3(Point_3, Segment_3, Point_3)` )
2022-10-04 13:48:18 +02:00
Laurent Rineau de80833223 Merge pull request #6845 from sloriot/PMP-coref_open_mesh_case
PMP corefinement: Handle inconsistency with open mesh as input
2022-10-04 13:48:16 +02:00
Laurent Rineau fef4d1b43b Merge pull request #6863 from lrineau/Polyhedron-demo_fix_display_of_protecting_spheres-GF
Polyhedron demo - Fix the display of protecting balls (second version)
2022-10-04 13:48:13 +02:00
Laurent Rineau ff2bab36b0 Merge pull request #6867 from sloriot/PMP-collision_detection_copy
Add default copy constructor and operator=
2022-10-04 13:48:11 +02:00
Laurent Rineau b8b8d98281 Merge pull request #6872 from MaelRL/PMP-Fix_keep_LCC-GF
Fix dry-run of keep_largest_CCs dumping the wrong faces
2022-10-04 13:48:08 +02:00
Sébastien Loriot 29d543c9f4 remove tabs 2022-10-04 09:16:32 +02:00
Sébastien Loriot 96b205d9b0 add test from issue #5275 2022-10-03 18:55:44 +02:00