songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
105,214 Commits 3 Branches 156 Tags 959 MiB
Commit Graph

1214 Commits

Author SHA1 Message Date
Andreas Fabri 7e8b6678bc CGAL: Add namespace to models in concepts 2024-06-12 13:50:44 +01:00
Laurent Rineau ef8ae2ac36 Merge pull request #7814 from sloriot/P3T3-demo_fix 
Fix qhelpgenerator call
 2023-10-30 17:12:27 +01:00
Sébastien Loriot 2bdab8c731 removing extra unneeded lines 2023-10-26 08:54:40 +02:00
Sébastien Loriot 21ece823de remove instruction to generate files not used 2023-10-24 09:29:31 +02:00
Sebastien Loriot b1b02d64fe
P3M3: Non-cubic domains, fixes, improvements (#7062) 
## Summary of Changes

- Add a dummy point generator that is agnostic to the periodic domain's
geometry, allowing P3M3 to handle non-cubic domain.
- Add an example of P3M3 running on polyhedral domains.
- Fix a few issues in SMDS_3's tet soup reading relating to
non-manifoldness + general IO code speed improvements.
- Fix a few issues in P3M3's medit output and always duplicate facets to
reduce the quantity of non-manifoldness occurences.
- Fix an issue with including Mesh_3 headers before P3M3's.
- Fix periodic point projection (for Mesh_3 optimizers) badly computing
the projection direction
- Robustify a handful of P3M3 functions that were using intermediate
constructions rather than the <Point, Offset> API (which uses filtered
predicates and thus yields proper robustness)
- Misc minor code cleaning / modernization

ToDo:
- [x] Check if some medit IO issues are fixed
- [x] Add non-manifoldness flag to read_MEDIT
- [x] Fix value of orthosphere_radius_threshold
- [x] Check calls of insert_dummy_points() (use generic)
- [x] Check doc of P3M3 about cubic domains requirement

Not done:
- [ ] Fix sharp features for periodic polyhedral domains (problems due
to changing weights creating cover change...). Code:
https://gist.github.com/MaelRL/357c52dc04e16a162f13a3c6860a1398; WIP
diff: https://gist.github.com/MaelRL/f98809964acffbacb6d3f42793e2654e

## Release Management

* Affected package(s): `Mesh_3`,  `P3M3`, `P3T3`, `SMDS3`
* Issue(s) solved (if any): Fix #6997, Fix #7214
* Feature/Small Feature (if any): TODO
* License and copyright ownership: no change
 2023-05-30 19:13:45 +02:00
Mael Rouxel-Labbé 5656a7d11c Rework P3M3 snapping 
Can't guarantee that the double construction is correct, even by going
through an intermediate exact offset computation; so if there's an issue,
just snap the intermediate point to the domain (it should have been close
enough in the first place)

Remove all functions related to zealous snapping that are just to get
"nice" coordinates (and not 1e-17).
 2023-05-26 11:18:52 +02:00
Laurent Rineau d079559577 Merge pull request #7413 from lrineau/CGAL-fix-Qt5-CMake-GF 
Qt5::Svg is now only optional for CGAL_Qt5
 2023-05-11 16:55:28 +02:00
Mael 532b82cb9b
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-05-04 17:28:47 +02:00
Mael Rouxel-Labbé d8f4bc059d Fix conversion warnings 2023-05-03 12:24:23 +02:00
Mael Rouxel-Labbé d0f63f52c7 Fix wrong argument type in P3T3 offset's operator[] 2023-05-02 14:14:27 +02:00
Laurent Rineau fe5a36c08e fix all the CMakeLists.txt for Qt5 2023-04-27 17:27:37 +02:00
Mael Rouxel-Labbé c593b76a38 Fix conversion warnings 2023-04-19 12:49:35 +02:00
Mael Rouxel-Labbé 1a5826f11a Merge remote-tracking branch 'cgal/master' into SLS-Weighted_skeleton-GF 2023-04-17 12:48:30 +02:00
Jane Tournois 170f54f0c0 avoid conversion warnings 2023-04-13 17:18:35 +02:00
Mael Rouxel-Labbé 58cc66188e Fix point() for P3T3/P3DT3/P3RT3/P3M3 2023-03-23 23:47:58 +01:00
Mael Rouxel-Labbé cd0c81a98a Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-03-20 10:14:27 +01:00
Mael Rouxel-Labbé 85911f1b64 Merge remote-tracking branch 'cgal/master' into SLS-Weighted_skeleton-GF 2023-03-20 10:06:38 +01:00
Mael Rouxel-Labbé 442770188f Cube > cuboid in P3M3 doc 2023-03-17 14:43:43 +01:00
Mael Rouxel-Labbé 4f6846776a Fix conversion warning 2023-03-17 14:43:26 +01:00
albert-github 2d60f46985 issue #7231 Improvement of layout of refines relations. 
- Adjusted cgalRefines according to reviews
- Implemented it in all files
 2023-03-14 17:37:50 +01:00
Mael Rouxel-Labbé 9d9a51731a Fix typo 2023-02-09 23:27:01 +01:00
Mael Rouxel-Labbé a8d38e84af Fix warnings 2023-01-31 11:22:54 +01:00
Mael Rouxel-Labbé d9b6eb856b Further robustify periodic circumcenter computations 2023-01-30 17:14:33 +01:00
Mael 153c603209
Merge branch 'master' into CGAL-Clean_CMakeLists.txt-GF 2023-01-27 22:09:02 +01:00
Mael 8f703b54cb
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-01-27 21:48:32 +01:00
Mael Rouxel-Labbé d982e8e359 Reduce the runtime of dummy covering tests 
and actually test something...
 2023-01-23 11:49:39 +01:00
Mael Rouxel-Labbé fca313bba9 Fix compilation with homogeneous exact number types 2023-01-23 11:30:49 +01:00
Mael Rouxel-Labbé efa486ca1c Remove useless typedef 2023-01-23 11:30:14 +01:00
Mael Rouxel-Labbé 3f4ebb1e0e Remove unused variables 2023-01-02 13:54:14 +01:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Mael Rouxel-Labbé e1986b905e Fix some concept not matching actual requirements 2022-12-06 17:41:34 +01:00
Mael Rouxel-Labbé 2cdb9086dc Further robustify robust_canonicalize_point(): remove many constructions 2022-12-06 15:08:58 +01:00
Mael Rouxel-Labbé 6ab2a2f72c Add a macro to use a sparser dummy grid (can't be used with domain w/ features) 2022-12-06 14:50:17 +01:00
Mael Rouxel-Labbé c475f7de45 Add a comment to clarify that cells are destroyed when P3T3::remove rejects 2022-12-06 14:49:47 +01:00
Mael Rouxel-Labbé 28f672a5b4 Further robustification improvements to P3_mesh_triangulation_3: 
avoid canonicalization (i.e. construction) when possible
 2022-12-06 14:48:59 +01:00
Mael Rouxel-Labbé b115a680bf Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2022-12-06 09:47:46 +01:00
Mael 6538b22e06
Merge branch 'master' into CGAL-Clean_CMakeLists.txt-GF 2022-12-05 16:03:41 +01:00
Mael Rouxel-Labbé 7910d82c6c Misc minor changes 2022-12-01 12:34:50 +01:00
Mael Rouxel-Labbé c255b51b4b Generalize orthosphere radius threshold computation to non-cubic domains 2022-11-29 12:15:24 +01:00
Mael Rouxel-Labbé 0fdfec9ccb Same as 6021d5a9f1 for tr.point(Cell_handle, int) 2022-11-25 14:16:48 +01:00
Mael Rouxel-Labbé 6021d5a9f1 Fix making P3T3 an abstract class 2022-11-24 12:59:17 +01:00
Mael Rouxel-Labbé b5c21e1f5d Http -> https + update some dead links 2022-11-23 18:54:37 +01:00
Mael Rouxel-Labbé b10b84fb7f Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2022-11-18 16:47:07 +01:00
Mael Rouxel-Labbé a2b726de77 Add a test for the generic dummy point generator 2022-11-18 16:14:05 +01:00
Mael Rouxel-Labbé 9699035179 Add a dummy point generator that can handle non-cubic domains 2022-11-18 16:13:13 +01:00
Mael Rouxel-Labbé c7804eeca9 Add some precondition on offset values 2022-11-18 00:34:55 +01:00
Mael Rouxel-Labbé 1869294e50 Misc code improvements 2022-11-18 00:21:58 +01:00
Mael Rouxel-Labbé b434490de1 Add virtual functions point(VH) / point(CH, int) to the base P3T3 2022-11-18 00:19:24 +01:00
Mael Rouxel-Labbé c8a7b8864f Remove garbage in P3T3::move_point(): currently it is only remove + insert 2022-11-18 00:18:49 +01:00
Mael Rouxel-Labbé c682f8dc20 Add some comments 2022-11-18 00:17:22 +01:00