songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
105,214 Commits 3 Branches 156 Tags 958 MiB
Commit Graph

1092 Commits

Author SHA1 Message Date
Jane Tournois a8debb0d2d Revert "Fix sometimes creating holes in the C3T3" 
This reverts commit 06d272169f.

There may be an inconsistency between exact and inexact computations,
in the facet encroachment rule

This code was leading to a local infinite refinement loop during cells refinement
 2024-04-11 14:16:41 +02:00
Andreas Fabri 8f8280ce34 Add structural filtering to Robust circumcenter traits 2023-11-23 19:37:23 +00:00
Sébastien Loriot 9cefb1a481 fix out-of-bound warnings 2023-10-19 11:40:35 +02:00
Laurent Rineau 9bbebd4468 Merge pull request #7584 from sloriot/T3-fix_warnings 
fix unused variable warnings
 2023-07-12 15:23:47 +02:00
Sebastien Loriot 57b7edb6a3
Apply suggestions from code review 
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
 2023-07-12 10:41:44 +02:00
Sébastien Loriot 560186b432 fix one more warning 2023-07-10 13:25:38 +02:00
Sébastien Loriot 4e6fe0c561 fix unused variable warnings 2023-07-06 18:06:03 +02:00
Laurent Rineau 4b18c7208a fix warnings 2023-06-27 17:29:37 +02:00
Laurent Rineau 7e2e444825 Merge branch 'Triangulation_3-fix_simplex_traverser-GF' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6 2023-06-21 10:19:52 +02:00
Laurent Rineau 28ab0b7c3e another bug-fix 
Jane and I thought that case

  vertex-vertex with `ch_next != Cell_handle()`

was not possible. Let's patch that.
 2023-06-21 10:19:39 +02:00
Laurent Rineau d5f521c78c commit improvement to debugging code 2023-06-20 18:28:36 +02:00
Laurent Rineau 53d82e5007 Merge branch 'Triangulation_3-fix_simplex_traverser-GF' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6 2023-06-20 17:31:31 +02:00
Laurent Rineau 4a7f9269dc another bug fix?! 2023-06-20 17:31:13 +02:00
Laurent Rineau ad9efd0e18 Merge branch '5.6.x-branch' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6 
# Conflicts:
#	STL_Extension/include/CGAL/Base_with_time_stamp.h
#	Triangulation_3/include/CGAL/Triangulation_3/internal/Triangulation_segment_traverser_3_impl.h
#	Triangulation_3/test/Triangulation_3/CMakeLists.txt
 2023-06-20 16:03:30 +02:00
Laurent Rineau 367466c434 Merge branch '5.5.x-branch' into Triangulation_3-fix_simplex_traverser-GF 2023-06-20 14:48:05 +02:00
Laurent Rineau 4f94c70740 typos 2023-06-19 17:15:42 +02:00
Laurent Rineau 6edb602729 factorize code when cells are traversed 2023-06-19 17:11:19 +02:00
Laurent Rineau 14ff8c6af5 fix bugs 2023-06-19 17:06:10 +02:00
Laurent Rineau f193744e66 walk_to_next_3: reformat to indentation by 2 space 2023-06-16 18:35:14 +02:00
Laurent Rineau dcfd783953 change/fix some oddities in the code 2023-06-16 18:07:22 +02:00
Laurent Rineau 5a0c09d667 factorize/reformat the code 
The cases `chnext == {}` and `chnext != {}` were actually very
similar.
 2023-06-16 17:48:32 +02:00
Laurent Rineau 6b835a1799 use triangulation().tds().has_vertex to avoid dummies 2023-06-16 15:35:18 +02:00
Laurent Rineau 5c81b975ae triangulation() is now a reference 2023-06-16 15:33:02 +02:00
Laurent Rineau 80a4064350 chprev/chnext 2023-06-16 15:23:50 +02:00
Laurent Rineau 169985ea96 fix remaining cases even with permutations 
Now I am quite confident that the code is correct.
 2023-06-16 12:37:08 +02:00
Laurent Rineau 42f8b92c1d add comments 2023-06-16 11:50:35 +02:00
Laurent Rineau 8207105503 fix accidental use of std::optional (boost:: instead) 2023-06-15 18:07:52 +02:00
Laurent Rineau c7130e0c58 fix test case 131I 2023-06-15 16:41:07 +02:00
Laurent Rineau 4f20dc0f44 fix case 31 2023-06-15 15:50:51 +02:00
Laurent Rineau 9f4b8d5785 fix case I232 2023-06-15 13:16:28 +02:00
Laurent Rineau 00aa91967b `prev` then `cur` is more logic 2023-06-15 12:33:00 +02:00
Laurent Rineau e574a3a191 fix case 132I 2023-06-15 12:32:35 +02:00
Laurent Rineau 9cd8f0e8e1 fix case 12 2023-06-15 11:32:41 +02:00
Laurent Rineau b9eea8ec0d bug-fix test case 121 2023-06-14 21:12:15 +02:00
Laurent Rineau d5f5a6e2cd buf-fix for case 032I 2023-06-13 17:19:03 +02:00
Laurent Rineau 67b2d1c770 bug-fix of case "230 with bbox" 2023-06-12 18:06:40 +02:00
Laurent Rineau 5048eb960d bug-fix!! 
I have been working on that issue for a few days. Eventually I found
the bug.
 2023-06-12 16:45:16 +02:00
Laurent Rineau 5dceac54ef cosmetic changes 2023-06-12 16:43:51 +02:00
Laurent Rineau 01e22be3b6 Merge pull request #7496 from lrineau/Triangulation_3-fix_regular_with_TBB-GF 
Regular_triangulation_3: fix another race-condition
 2023-06-07 17:36:41 +02:00
Laurent Rineau 6ab1337951 Merge pull request #7496 from lrineau/Triangulation_3-fix_regular_with_TBB-GF 
Regular_triangulation_3: fix another race-condition
 2023-06-07 17:36:25 +02:00
Laurent Rineau 8cd8bc7b06 another fix of a race-condition 2023-06-04 20:49:02 +02:00
Sebastien Loriot b1b02d64fe
P3M3: Non-cubic domains, fixes, improvements (#7062) 
## Summary of Changes

- Add a dummy point generator that is agnostic to the periodic domain's
geometry, allowing P3M3 to handle non-cubic domain.
- Add an example of P3M3 running on polyhedral domains.
- Fix a few issues in SMDS_3's tet soup reading relating to
non-manifoldness + general IO code speed improvements.
- Fix a few issues in P3M3's medit output and always duplicate facets to
reduce the quantity of non-manifoldness occurences.
- Fix an issue with including Mesh_3 headers before P3M3's.
- Fix periodic point projection (for Mesh_3 optimizers) badly computing
the projection direction
- Robustify a handful of P3M3 functions that were using intermediate
constructions rather than the <Point, Offset> API (which uses filtered
predicates and thus yields proper robustness)
- Misc minor code cleaning / modernization

ToDo:
- [x] Check if some medit IO issues are fixed
- [x] Add non-manifoldness flag to read_MEDIT
- [x] Fix value of orthosphere_radius_threshold
- [x] Check calls of insert_dummy_points() (use generic)
- [x] Check doc of P3M3 about cubic domains requirement

Not done:
- [ ] Fix sharp features for periodic polyhedral domains (problems due
to changing weights creating cover change...). Code:
https://gist.github.com/MaelRL/357c52dc04e16a162f13a3c6860a1398; WIP
diff: https://gist.github.com/MaelRL/f98809964acffbacb6d3f42793e2654e

## Release Management

* Affected package(s): `Mesh_3`,  `P3M3`, `P3T3`, `SMDS3`
* Issue(s) solved (if any): Fix #6997, Fix #7214
* Feature/Small Feature (if any): TODO
* License and copyright ownership: no change
 2023-05-30 19:13:45 +02:00
Laurent Rineau 2d324a2f09 Merge branch '5.5.x-branch' 2023-05-19 18:27:20 +02:00
Laurent Rineau f09c70bb96 Merge branch '5.4.x-branch' into 5.5.x-branch 2023-05-19 18:26:49 +02:00
Jane Tournois c7f75a9030 wip fixes for simplex traverser 
* test_segment_simplex_traverser_3 first failing test is now "032"
* the geometric intersection test fails because of doubles
 2023-05-16 18:35:54 +02:00
Laurent Rineau 5a85381d4c remove a trailing whitespace 
This time I think I managed to fix my VS Code  Insiders settings to fix that
issue permanently.
 2023-05-16 16:13:05 +02:00
Laurent Rineau 97262bf0e9 Triangulation_3: fix a race-condition in regular 
The race condition is in the batch insertion of a range
of points, with or without info.
 2023-05-16 15:56:32 +02:00
Jane Tournois 4bf7c45c8b replace std::tuple Simplex with a struct 
and then avoid all std std::get<i>(simplex), hard to read
 2023-05-15 13:06:37 +02:00
Laurent Rineau 4e14700ab4 Remove cases of OUTSIDE_AFFINE_HULL 2023-05-12 16:57:25 +02:00
Jane Tournois 087492b72d replace dealing with OUTSIDE_AFFINE_HULL 
with tests on cell_iterator == end()
 2023-05-12 16:13:30 +02:00