b1b02d64fe
P3M3: Non-cubic domains, fixes, improvements ( #7062 )
...
## Summary of Changes
- Add a dummy point generator that is agnostic to the periodic domain's
geometry, allowing P3M3 to handle non-cubic domain.
- Add an example of P3M3 running on polyhedral domains.
- Fix a few issues in SMDS_3's tet soup reading relating to
non-manifoldness + general IO code speed improvements.
- Fix a few issues in P3M3's medit output and always duplicate facets to
reduce the quantity of non-manifoldness occurences.
- Fix an issue with including Mesh_3 headers before P3M3's.
- Fix periodic point projection (for Mesh_3 optimizers) badly computing
the projection direction
- Robustify a handful of P3M3 functions that were using intermediate
constructions rather than the <Point, Offset> API (which uses filtered
predicates and thus yields proper robustness)
- Misc minor code cleaning / modernization
ToDo:
- [x] Check if some medit IO issues are fixed
- [x] Add non-manifoldness flag to read_MEDIT
- [x] Fix value of orthosphere_radius_threshold
- [x] Check calls of insert_dummy_points() (use generic)
- [x] Check doc of P3M3 about cubic domains requirement
Not done:
- [ ] Fix sharp features for periodic polyhedral domains (problems due
to changing weights creating cover change...). Code:
https://gist.github.com/MaelRL/357c52dc04e16a162f13a3c6860a1398 ; WIP
diff: https://gist.github.com/MaelRL/f98809964acffbacb6d3f42793e2654e
## Release Management
* Affected package(s): `Mesh_3`, `P3M3`, `P3T3`, `SMDS3`
* Issue(s) solved (if any): Fix #6997 , Fix #7214
* Feature/Small Feature (if any): TODO
* License and copyright ownership: no change
2023-05-30 19:13:45 +02:00
fd847c2351
only test parallel if TBB is installed
2023-05-09 18:40:22 +02:00
a6224c75b4
fix compilation of new test after merge of master
...
and newly merged branch Mesh_3-sizing_field_with_aabb_tree-GF
2023-05-05 10:21:58 +02:00
73a7d4ff09
Merge remote-tracking branch 'cgal/master' into Mesh_3-min_size-jtournois
...
# Conflicts:
# Installation/CHANGES.md
# Polyhedron/demo/Polyhedron/Plugins/Mesh_3/Mesh_3_plugin.cpp
# STL_Extension/include/CGAL/STL_Extension/internal/parameters_interface.h
2023-05-05 09:17:33 +02:00
532b82cb9b
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF
2023-05-04 17:28:47 +02:00
628d8ae43d
Merge pull request #7307 from janetournois/Mesh_3-sizing_field_with_aabb_tree-GF
...
Mesh_3 - Document Sizing_field_with_aabb_tree
2023-05-04 17:22:59 +02:00
c2e24424d3
Merge pull request #7415 from janetournois/Mesh_3-triple_lines_with_sqrt-jtournois
...
Mesh_3 triple lines detection robustness
2023-05-04 17:22:46 +02:00
d2bc415a15
Merge pull request #6950 from lrineau/CGAL-allow_Epick_with_float-GF
...
Simple_precision_epick: an Epick-like kernel with float as FT
2023-05-04 16:37:17 +02:00
1449281db9
Merge pull request #7264 from MaelRL/SLS-Weighted_skeleton-GF
...
Weighted straight line skeletons
2023-05-04 16:37:12 +02:00
e0eac4f388
Merge remote-tracking branch 'cgal/master' into HEAD
2023-05-03 18:37:09 +02:00
75806c2497
add local macro for sqrt(17)
...
and const split_point to make sure the same point is used twice
2023-05-02 12:39:46 +02:00
dad3407b11
add local macro for sqrt(65)
2023-05-02 11:40:47 +02:00
5d0adfda43
avoid conflict with max macro on msvc
2023-05-02 10:12:57 +02:00
2f88b29cda
replace multiple std::sqrt by macros
...
with more than 17 digits in case we have number types bigger than double
2023-04-28 17:54:07 +02:00
ce738685e1
replace approximate values for sqrt(2) and similar
2023-04-28 16:12:26 +02:00
b014f5ab45
fix template parameter
...
without that, the template parameter is 'int', deducted from third argument '0'
2023-04-25 15:45:36 +02:00
b76f640a41
Merge branch 'Mesh_3-edge_min_size-GF' into Mesh_3-min_size-jtournois
...
# Conflicts:
# Mesh_3/test/Mesh_3/CMakeLists.txt
# Polyhedron/demo/Polyhedron/Plugins/Mesh_3/Meshing_dialog.ui
2023-04-24 13:59:48 +02:00
e30ccd2cc5
Merge branch 'Mesh_3-add_minimal_size_criterion_new-jtournois' into Mesh_3-min_size-jtournois
2023-04-24 12:56:40 +01:00
205236832e
Merge remote-tracking branch 'cgal/master' into CGAL-rename_ctest_test_names-GF
...
# Conflicts:
# Polyhedron/demo/Polyhedron/Plugins/PMP/CMakeLists.txt
2023-04-21 10:47:17 +02:00
4be918b51b
it's forbidden to compare (size_t < 0)
2023-04-18 17:10:41 +02:00
8e98895678
update concept MeshEdgeCriteria_3
2023-04-17 16:46:38 +02:00
2559bb6778
Update Mesh_criteria_3.h (the note)
2023-04-17 16:35:01 +02:00
1a5826f11a
Merge remote-tracking branch 'cgal/master' into SLS-Weighted_skeleton-GF
2023-04-17 12:48:30 +02:00
824976a003
Merge pull request #7236 from albert-github/feature/issue_7231
...
issue #7231 Improvement of layout of refines relations.
2023-04-17 10:14:01 +02:00
9e18cc6989
Unexpected backtick ( #7378 )
...
In the file: Arrangement_on_surface_2/index.html
we see:
```
The example below shows how to construct the same arrangement of five line segments built incrementally in Arrangement_on_surface_2/incremental_insertion.cpp` depicted in Figure 34.9 using the aggregate insertion
```
i.e. an unexpected backtick.
2023-04-12 09:55:42 +02:00
9f33e64643
avoid warning
2023-04-12 09:00:24 +02:00
8a0b21461d
Unexpected backtick
...
- Corrected some more redundant / missing backticks
- correctes a spelling error (Boolean_set_operations_2/doc/Boolean_set_operations_2/CGAL/Boolean_set_operations_2/Gps_default_dcel.h)
2023-04-11 17:38:37 +02:00
e5a2513921
Merge pull request #7359 from janetournois/Mesh_3-exude_mesh_3_np-jtournois
...
Mesh_3 - fix default parameters of `CGAL::exude_mesh_3(c3t3)`
2023-04-11 14:19:00 +02:00
662534e8f3
fix template type
...
avoid using "0" type, int, that would make a data corruption inside
the modified image
2023-04-07 15:52:47 +02:00
7eb9a5a0cc
Merge remote-tracking branch 'cgal/master' into Mesh_3-triple_line_extraction_and_weights-GF
...
# Conflicts:
# Mesh_3/include/CGAL/Labeled_mesh_domain_3.h
2023-04-07 15:11:30 +02:00
e34cd8d938
doc
2023-04-07 14:54:29 +02:00
1dce90ee79
Merge remote-tracking branch 'cgal/master' into CGAL-allow_Epick_with_float-GF
2023-04-07 10:59:51 +02:00
3e3f66f75d
Merge remote-tracking branch 'cgal/master' into Mesh_3-add_minimal_size_criterion_new-jtournois
...
# Conflicts:
# Polyhedron/demo/Polyhedron/Plugins/Mesh_3/Mesh_3_plugin.cpp
2023-04-06 12:04:47 +02:00
e4ec27fc5c
doc review
2023-04-03 11:29:26 +02:00
789a4c337d
add link and remove CGAL::
2023-04-03 11:18:06 +02:00
eb0fc7fa05
Merge remote-tracking branch 'cgal/master' into Mesh_3-sizing_field_with_aabb_tree-GF
...
# Conflicts:
# Mesh_3/include/CGAL/Sizing_field_with_aabb_tree.h
2023-03-31 15:43:23 +02:00
327527d666
Apply suggestions from code review
...
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2023-03-31 14:51:58 +02:00
6cd65d23b4
Merge pull request #7275 from lrineau/Mesh_3-improve__Sizing_field_with_aabb_tree-GF
...
Mesh_3: Improve Sizing_field_with_aabb_tree speed
2023-03-31 11:10:56 +02:00
281de129ed
Merge pull request #7280 from janetournois/Mesh_3-improve_initialization-jtournois
...
Mesh_3 - improve initialization when features are inserted
2023-03-31 11:10:54 +02:00
ed3a6f966f
Apply suggestions from code review
...
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2023-03-30 11:34:50 +02:00
4b632c29ff
remove NP template parameter where it's not necessary
...
* add CGAL_DEPRECATED
* fix ambiguity between exude_mesh_3(c3t3) (one param) versions
by removing default time_limit
2023-03-30 10:40:28 +02:00
522c04e9a3
doc
...
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2023-03-27 11:09:40 +02:00
90ce49893c
add cout
2023-03-24 14:25:02 +01:00
7f0087ee72
doc
2023-03-24 14:10:39 +01:00
03fc6bbdb2
doc
2023-03-24 11:00:26 +01:00
f5fd746503
Fix stack-use-after-scope error
2023-03-23 17:30:54 +01:00
ac5ccbd62f
Merge remote-tracking branch 'cgal/master' into Mesh_3-sizing_field_with_aabb_tree-GF
...
# Conflicts:
# Mesh_3/doc/Mesh_3/PackageDescription.txt
2023-03-23 13:53:48 +01:00
693d166835
more debug information
2023-03-22 15:58:55 +01:00
873d98fcbf
"simplify" the 6 constructors by using delegating-cstr
2023-03-22 15:50:31 +01:00
728e013cc5
bug-fix: a one-char typo
2023-03-22 15:39:43 +01:00
Sebastien Loriot
Jane Tournois
Mael
Laurent Rineau
Jane Tournois
albert-github