songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
104,985 Commits 3 Branches 156 Tags 962 MiB
Commit Graph

104985 Commits

Author SHA1 Message Date
Laurent Rineau c539c5657c fix when reading on Linux a .mesh file produced by Windows 2024-01-17 09:56:39 +01:00
Laurent Rineau 074a337e88 Mesh_3/SMDS_3: Fix reading of .mesh files 
With a `.mesh` containing `Triangles` in a comment, like that one:

```
MeshVersionFormatted 1

Dimension
3

Vertices
121
-10.0402  -10.0402  -10.0402    0
-10  10  10    0
10  10  10    0
[...]
Triangles
609
     98     76     65    0
     98     81     76    0
     65     81     98    0
Tetrahedra
244
     81     65     76     98  0
     28      1     37     34  0
     69     25     70     94  0
[...]
End
```

then the code failed. It read `Triangles` as the beginning of the triangles section.

The commit use `std::getline()` to read the comments and the keywords:
- `Vertices`
- `Triangles`
- `Tetrahedra`
 2024-01-11 11:35:05 +01:00
Sebastien Loriot eb659137e6
Mesh_3 - `edge_min_size` may cause hanging (#7863) 
## Summary of Changes

When the criterion `edge_min_size` is set, the graph of features is
likely to be invalid or at least inconsistent with the input graph.
Checking its topology does not make any sense and could lead to hanging
when trying to compute polyline feature lengths (because it's trying to
walk on different curves, jumping from one to the other, etc).

This PR disables the check-features-after-protect step when
`edge_min_size` is used, since we anyway do not expect the feature graph
to be exactly matching the one of the input.

## Release Management

* Affected package(s): Mesh_3
* License and copyright ownership: unchanged
 2023-12-22 17:15:37 +01:00
Sébastien Loriot 47e728f2ef Merge remote-tracking branch 'cgal/5.5.x-branch' 2023-12-22 17:14:12 +01:00
Sebastien Loriot cef517a9c9
Add a switch to get rid of QP_Solver dependency (#7941) 2023-12-22 17:13:10 +01:00
Sebastien Loriot 339441a137
Surface_sweep_2: Handle new overlap on the right of an event that is interior to a curve (#7243) 
Handle case of overlapping curve starting on a non start/end event.

@efifogel I don't like the fact that I'm adding some geometric tests. I
think I should check if there are overlapping curves on the right of the
event and check if the originating curves are in the status line (using
the stored hint). What do you think?

Fixes #7235
 2023-12-22 17:11:47 +01:00
Sébastien Loriot c36f0ac091 add a switch to get rid of QP_Solver dependency 2023-12-19 14:42:02 +01:00
Sébastien Loriot 5d61c35a64 fix warning 2023-12-18 15:20:10 +01:00
Sébastien Loriot aee0c1557e Revert "Ported test_sweep_conic to test_sweep and fixed the conic test cases" 
This reverts commit 2e99b211b0.
 2023-12-18 15:14:26 +01:00
Sébastien Loriot 03ea4c3df5 Revert "fix warnings" 
This reverts commit 8cc75d642c.
 2023-12-18 15:14:09 +01:00
Sébastien Loriot ee1fa58406 Merge remote-tracking branch 'cgal/5.5.x-branch' 2023-12-18 13:31:06 +01:00
Sebastien Loriot 023840c5bd
Increase precision of the intersection of 3 planes (#7913) 
Addresses #6267
 2023-12-18 13:27:17 +01:00
Sebastien Loriot f798df19a5
document the thread-safety requirement of output iterators (#7924) 2023-12-18 13:25:56 +01:00
Sebastien Loriot 00f0c85499
Kernel_23: Deal with concurrent executions and IO (#7921) 
## Summary of Changes

Write and read back in a `std::stringstream` to avoid simultaneous IO on
the same file name.
Error seen in this
[testsuite](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-124/Circular_kernel_2/TestReport_gimeno_ArchLinux-clang-CXX17-Release.gz).

## Release Management

* Affected package(s):  Kernel_23, Circular_kernel_2
* License and copyright ownership: unchanged
 2023-12-18 13:25:36 +01:00
Jane Tournois a66e78a672 when curves topology is valid, use curve_segment_length 2023-12-15 15:52:02 +01:00
Jane Tournois 3ef2ce9163 check_and_repopulate_edges() reactivated with minimal size 
disabling it may give too bad results
change the arc_length computation when minimal size is used, instead,
by approximating it by the segment length
 2023-12-15 14:44:33 +01:00
Jane Tournois 7fa2db8dfc add helper function minimal_weight() 2023-12-14 19:01:57 +01:00
Jane Tournois 85b8da120d constify more 2023-12-14 15:36:57 +01:00
Jane Tournois 54677b388c set default minimal_size_ to -1 and add helper function to check if it is set 2023-12-14 15:35:06 +01:00
Sébastien Loriot 32da8399fb Merge remote-tracking branch 'cgal/5.5.x-branch' into HEAD 2023-12-14 15:26:44 +01:00
Sebastien Loriot 2aea89ff03
Hide forward declaration to doxygen (#7928) 2023-12-14 15:25:23 +01:00
Sébastien Loriot 7935bcf42b fix mismatching cond/endcode 
remove useless previous patches
 2023-12-14 10:10:17 +01:00
Sébastien Loriot 93ba75b8a1 add missing not 2023-12-14 08:47:54 +01:00
Andreas Fabri a701dbc21c Deal with LAS.h 2023-12-13 08:36:46 +00:00
Sébastien Loriot dac26de5c3 update test 
cc @efifogel
 2023-12-12 17:09:57 +01:00
Sébastien Loriot 8cc75d642c fix warnings 2023-12-12 15:27:00 +01:00
Sébastien Loriot 35e845d8dc do no use delete event 2023-12-12 15:11:40 +01:00
Sébastien Loriot 79123c8f53 hide forward declaration to doxygen 2023-12-12 08:31:46 +01:00
Laurent Rineau 407987be86 Merge branch '5.5.x-branch' into 5.6.x-branch 2023-12-11 13:54:07 +01:00
Laurent Rineau cb4e75773d Merge pull request #7881 from afabri/Poisson-enable_structural_filtering-GF 
Poisson Surface Reconstruction: Enable Structural Filtering
 2023-12-11 13:50:41 +01:00
Laurent Rineau 4be3a1e589 Merge pull request #7892 from sloriot/CGAL-fix_dh_angle_sign 
fix dihedral angle computation
 2023-12-11 13:50:38 +01:00
Laurent Rineau ef653f0a7d Merge pull request #7907 from sloriot/T3-OFB_warning 
Prevent out-of-bound warnings

# Conflicts:
#	TDS_3/include/CGAL/Triangulation_utils_3.h
 2023-12-11 13:50:15 +01:00
Laurent Rineau 323458f5fb Merge pull request #7911 from sloriot/M3-params_errors 
Mesh_3: Fix copy/paste errors in parameters
 2023-12-11 13:48:15 +01:00
Laurent Rineau d380a34297 Merge pull request #7914 from sloriot/PMP-remesh_planar_faces_missing_remove_const 
PMP remesh_planar_patches: handle const meshes
 2023-12-11 13:48:10 +01:00
Laurent Rineau 7cfba8f54c Merge pull request #7917 from afabri/PMP-concurrentIO-GF 
PMP: Write into different files to avoid concurrent writing
 2023-12-11 13:48:04 +01:00
Laurent Rineau b50df6e06a Merge pull request #7892 from sloriot/CGAL-fix_dh_angle_sign 
fix dihedral angle computation
 2023-12-11 13:47:27 +01:00
Laurent Rineau ee4274997f Merge pull request #7907 from sloriot/T3-OFB_warning 
Prevent out-of-bound warnings
 2023-12-11 13:47:21 +01:00
Laurent Rineau b0e944d614 Merge pull request #7917 from afabri/PMP-concurrentIO-GF 
PMP: Write into different files to avoid concurrent writing
 2023-12-11 13:47:18 +01:00
Sébastien Loriot f36bdda9fe doc thread-safety of output iterators 2023-12-11 13:42:54 +01:00
Andreas Fabri f4154836ae Kernel_23: Deal with concurrent executions and IO 2023-12-11 08:35:02 +00:00
Sébastien Loriot a54f189980 Revert "more than one curve can be on the left of an event with overlapping curves on the right" 
This reverts commit 2260c4fab3.
 2023-12-07 16:09:31 +01:00
Sébastien Loriot 0714c960bb reset left event of curves after the deletion of the event 2023-12-07 16:08:33 +01:00
Andreas Fabri f0426b8aa6 PMP: Write into different files to avoid concurrent writing 2023-12-07 09:33:31 +00:00
Sébastien Loriot 6dca71b428 ease conflict resolution 2023-12-07 10:19:36 +01:00
Sébastien Loriot 2574a13557 restore the optional as it is used by Polyhedral_envelope 2023-12-07 10:12:53 +01:00
Sébastien Loriot d9d2dfc876 remove unused type definition 2023-12-07 09:59:24 +01:00
Sébastien Loriot 63556d4faa use explicitly const meshes 2023-12-06 15:50:14 +01:00
Sébastien Loriot 560f02c921 add missing remove_const 2023-12-06 15:29:17 +01:00
Mael Rouxel-Labbé d7fc8b1c7c Merge remote-tracking branch 'mine/Mesh_3-Fix_NP_backward_compatibility-GF' into M3-params_errors 2023-12-06 15:24:18 +01:00
Sébastien Loriot 0ebc2bee42 remove the optional 2023-12-06 14:17:24 +01:00