Commit Graph

377 Commits

Author SHA1 Message Date
Laurent Rineau 62c70d41ca Renew the handle of policies, for CMake-3.10
Now that we require CMake>=3.1, we can forget a lot of old CMake policies.

`CMP0053` `OLD` behavior is still needed, because of a bug in Qt5 CMake files, but it will
not be set with CMake>=3.10. Let's assume that a recent CMake version means
a recent Qt5 version.
2017-11-06 14:58:36 +01:00
Mael Rouxel-Labbé 1fce05f81f Doc fixes 2017-08-24 11:33:43 +02:00
Mael Rouxel-Labbé 3d63f86ae3 Minor doc fixes 2017-08-24 10:30:39 +02:00
Mael Rouxel-Labbé d0318957f2 Fixed a bunch of Alpha shape 3-related headers 2017-08-23 17:16:07 +02:00
Mael Rouxel-Labbé 3640902c6f Misc minor changes 2017-08-23 17:15:44 +02:00
Mael Rouxel-Labbé 16ce117040 Documented the fact that ExactComparisonTag cannot be used with periodic triangulations 2017-08-23 17:13:24 +02:00
Mael Rouxel-Labbé dba83ba5bf Fixed a few Alpha Shapes 2 headers 2017-08-23 16:40:55 +02:00
Mael Rouxel-Labbé 406f41af78 Added CGAL_DEBUG macro 2017-08-23 16:31:17 +02:00
Mael Rouxel-Labbé 63d293765f Added an assertion to forbid using ExactComparisonTag with periodic triangulations
When we set the exact comparison tag to true, we use a lazy evaluation
of predicates and store pointers to the arguments of the predicates (that is,
pointer to points). However, the points are  -- in the case of periodic --
only temporary objects and it is thus dangerous to take pointers to those
temporary values because the pointers quickly become invalid.

Thus, periodic triangulations are not allowed to use the exact tag.

A possible way to make it work is to define a small class:
Periodic_triangulation_with_stored_real_points that would inherit the base
(periodic) triangulation but store all the points of its simplices.
Then, the function  point(face_handle, int) would return an entry of that
container, of which it would be safe to take a pointer.
2017-08-23 16:19:32 +02:00
Mael Rouxel-Labbé e3d27128fb Minor doc changes to Alpha Shapes 3 2017-08-23 11:10:12 +02:00
Mael Rouxel-Labbé 72908fc076 Readability changes in Alpha_Shapes_3 2017-08-23 11:04:21 +02:00
Sébastien Loriot 9bb2d4433f Merge remote-tracking branch 'cgal/releases/CGAL-4.10-branch' 2017-08-04 13:37:58 +02:00
Maxime Gimeno 831f0239cb Fix CMP0071 warning. 2017-08-03 10:38:19 +02:00
Mael Rouxel-Labbé 85b74fb3cc Minor example improvements 2017-07-31 16:17:49 +02:00
Mael Rouxel-Labbé fd1c9d5dfa Added periodic weighted alpha shapes to the doc 2017-07-31 16:17:23 +02:00
Mael Rouxel-Labbé 8e12efbeae Improved weighted periodic example 2017-07-31 15:30:42 +02:00
Mael Rouxel-Labbé 4a9ac3cd0c Fixed 3D Alpha Shapes's Geomview output to work with all triangulations 2017-07-31 14:37:56 +02:00
Mael Rouxel-Labbé e57e138e98 Formatting change 2017-07-31 14:37:56 +02:00
Mael Rouxel-Labbé 31c5540cd5 Added an example of Alpha Shapes 3D with a regular periodic triangulation 2017-07-31 14:37:39 +02:00
Mael Rouxel-Labbé a1c57031ba P3RT3 can now be used with Alpha Shapes 3 2017-07-31 12:52:22 +02:00
Mael Rouxel-Labbé ca4776a49f Minor doc fixes 2017-07-31 12:43:12 +02:00
Maxime Gimeno 29c55b8499 Fix misisng QMap in Alpha_shape_3 demo 2017-07-10 16:11:08 +02:00
Laurent Rineau ab46739f07 Merge pull request #2213 from maxGimeno/Fix_demos_for_qglviewer2_7_0-GF
Fix demos for qglviewer 2.7.0
2017-07-10 15:00:09 +02:00
Maxime Gimeno 28d363d4aa Fix misisng QMap in Alpha_shape_3 demo 2017-07-03 09:35:13 +02:00
Mael Rouxel-Labbé b5892b5fbc Reworded ExactAlphaComparisonTag warning 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé e8c3618123 Updated documentation with changes from 19ae790 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 68d3a3eabf Modified the way weird point types are handled when ExactAlphaComparisonTag=true
Instead of requiring an implicit conversion, we require that Cartesian_converter
can convert from Traits::Point_23 to Exact_kernel::Point_23

Also it will not compile (static_assert) if this functor is not provided instead
of silently defaulting to ExactAlphaComparisingTag = false
2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 85c75bce3b Reworded the warning about ExactAlphaComparisonTag 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 1030445709 Fixed missing backticks in Alpha_Shapes_23's docs 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 1fc2282350 Fixed regular triangulation capitalization across CGAL 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 11786a7b90 Fixed minor mistakes from a rebase 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 7ce35c7538 Added point type to the doc of alpha shapes 2/3 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé c0cd440956 Moved some doc for clarity 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé 781b26f20f Document the fact that ExactAlphaComparisonTag only works for "nice" traits 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé d67163dece Various improvements to the Alpha_shapes_3 user manual 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé 6a6422073d Fixed concept refinement relationships in Alpha_shapes_3 doc 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé c765fbfda0 Clarified TDS concepts and models in alpha_shapes_3 doc
also removed mention of Regular_triangulation_euclidean_traits_3
2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé 1b3a608b30 Fixed not getting Alpha shapes 2 predicates and constructions from Lazy alpha NT 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé cdb447a22f Use Kernel_traits<Traits::Pt> to deduce the kernel rather than Traits::Kernel 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé 4e4f1ed4c0 Avoided a default traits construction 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 871cce116e Removed Regular_triangulation_euclidean_traits_3 usage in Lazy_alpha_nt_3
Regular_triangulation_euclidean_traits are deprecated (and do not do anything).
2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé ff40039d79 Fixed some Bare_point / Weighted_point typedefs in Alpha_shapes_3
The triangulation defines those types, not the traits
2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé ea295a0ee4 Made some typedefs readable for people without a 30" screen (no real changes) 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 38c212c521 Fixed test_fixed_alpha_shape_3 Point_3/Weighted_point_3 usage 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 3b36c56137 Fixed TDS in test of Alpha_shapes_3 (Regular_tr must use regular cell_base) 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 3e25674957 Weighted alpha shape traits are not based on RT_euclidean_traits anymore
Similarly to Regular_triangulation_euclidean_traits, the Kernel concept has now
absorbed all the functors that are needed by the alpha shape traits concept and
the weighted alpha shape traits can thus simply be empty shells.
2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 7a7ac15f42 Fixed weighted Alpha_shapes_3 TDS construction
When weighted, Alpha_cell_base_3 must use Regular_triangulation_cell_base_3
as base
2017-06-28 10:14:35 +02:00
Laurent Rineau 0685006e33 Merge pull request #2081 from maxGimeno/Merge_3d_demos-GF
Polyhedron_demo: Add an Alpha_shape_plugin
2017-05-29 11:16:21 +02:00
Laurent Rineau 7e651b6b78 Merge branch 'releases/CGAL-4.10-branch'
Merges two pull-requests:

- 9384ff4 Merge pull request #2133 from maxGimeno/Fix_cmake_warning_CMP0053-GF
- 0005d61 Merge pull request #2132 from sloriot/Kernel-use_CGAL_compare
2017-05-24 17:45:58 +02:00
Maxime Gimeno 5ae96fc2aa Explicitely set the policy of CMP0053 to OLD to silent the warning when it is not found. 2017-05-23 16:12:56 +02:00