Commit Graph

616 Commits

Author SHA1 Message Date
Laurent Rineau c091c7f86e Merge pull request #5532 from lrineau/Kernel_23-Do_interesect__without_division-GF
Remove operator/ from CGAL::Mpzf and implement Do_intersect_3 with RT only (without division)
2021-04-28 15:24:15 +02:00
Sebastien Loriot 5b253ad2fc
Merge pull request #4099 from sloriot/CGAL-epeck_pts_cmp
Speed up comparison of points
2021-04-21 15:24:11 +02:00
Sebastien Loriot 6d63fcc465
Merge pull request #5585 from afabri/Kernel_23-rational_rotation-GF
Kernel_23: Remove local reference in rational_rotation.h
2021-04-17 11:21:14 +02:00
Sébastien Loriot 68dc09b3d9 optimize filter failures
cmp_epeck_points.cpp runtime goes from 23s. to 5s.

based on mglisse suggestion
2021-04-10 07:12:25 +02:00
Andreas Fabri e661acaccb I should buy glasses -- and run the testsuite locally 2021-04-07 12:21:02 +01:00
Laurent Rineau 1b54449dc5 Merge pull request #4878 from danston/Kernels-decltypes-danston
Improve decltype/result_of/invoke_result
2021-04-06 15:13:21 +02:00
Laurent Rineau de704d8bb9 Merge pull request #5522 from afabri/Nef_3-accelerate_do_intersect_internally-GF
Nef_3: Do not test has_on for a point where we know that it will be true
2021-04-06 15:13:07 +02:00
Laurent Rineau 0f61f96c80 Merge pull request #5556 from MaelRL/Kernel_23-Dont_recompute_normal_in_proj_point-GF
Fix inconsistency in normal computation in robust projection code
2021-04-06 15:12:53 +02:00
Andreas Fabri 7dc015e7de Kernel_23: Remove local reference 2021-04-06 09:33:44 +01:00
Andreas Fabri 7ebdd07a4c Add <RT> to rank as expression templates don't match 2021-03-30 14:28:55 +01:00
Andreas Fabri 6c7f05e0be rank written by Sebastien 2021-03-29 16:03:06 +01:00
Mael Rouxel-Labbé 48bb925b65 Fix inconsistency in robust projection code
If the triangle/plane is degenerate, the case is handled separately.
If we know the plane is not degenerate, the normal should not
be recomputed in a different manner, which might lead
to a null normal and some issues down the line.
2021-03-26 10:41:30 +01:00
Andreas Fabri e0b410e2e6 int -> result_type 2021-03-24 16:03:51 +01:00
Laurent Rineau 21755b1123 Merge pull request #5245 from GilesBathgate/create-assertions-fix
Allow -DNDEBUG and CGAL_nnn_assertions at the same time
2021-03-24 15:05:41 +01:00
Andreas Fabri a28a7cd44a Return directly 2021-03-23 17:11:26 +01:00
Andreas Fabri e98198178f Add the functor Non_zero_dimension_3 to the Kernel 2021-03-23 15:45:54 +01:00
Andreas Fabri 45909e6d76 Let's fix it step by step, beginning with Do_intersect_3 2021-03-22 09:01:56 +01:00
Andreas Fabri be39ec02fa Add a solve that 'returns' the denominator instead of making the division 2021-03-18 14:18:11 +01:00
Laurent Rineau b32250242a CGAL_Kernel_pred_RT for Do_intersect_2 and Do_intersect_3
The code is not ready for that. A lot of overloads of
`Do_interesect_[23]` are implemented by calling the equivalent
overloads from `Intersect_23` (that requires division of coordinates).
2021-03-17 11:34:08 +01:00
Dmitry Anisimov 5235fd6d2c moved min/max definitions of Segment_2/3 inside the class 2021-03-15 10:50:14 +01:00
Dmitry Anisimov 00c185b028
Merge branch 'master' into Kernels-decltypes-danston 2021-03-12 12:06:20 +01:00
Laurent Rineau f1e550fdd2 Merge pull request #5363 from sloriot/Kernel-Oriented_side_extra_operator
Add an extra operator to have an exact plane
2021-03-03 17:33:20 +01:00
Andreas Fabri d5a5b20ce8 Make it clear that the functor is not part of the Kernel concept 2021-02-19 20:23:20 +00:00
Dmitry Anisimov 3f4c1c4628 moved point/vertex/[] definitions of Segment_2/3 inside the class 2021-02-12 11:31:03 +01:00
Dmitry Anisimov 2718072e0f projection traits removed result_of 2021-02-10 10:20:21 +01:00
Dmitry Anisimov 81d9556707 Merge remote-tracking branch 'upstream/master' into Kernels-decltypes-danston 2021-02-10 10:06:45 +01:00
Dmitry Anisimov af3f6dd07f fixed warnings with Intersect_3 and result_of 2021-02-09 17:30:06 +01:00
Laurent Rineau 3bd7181ff3 Merge pull request #5244 from afabri/Triangulation_2-Intersect_use_variant-GF
Nef_3, Triangulation_2:  Change the result type of the Intersect_2 functor
2021-02-05 16:12:58 +01:00
Sébastien Loriot 107567e809 add an extra operator to have an exact plane 2021-01-15 15:38:28 +01:00
Dmitry Anisimov 3127190bcf marc's review 2020-12-08 12:48:04 +01:00
Andreas Fabri 7314f83ac8 Fixes after comments by Laurent and Marc 2020-12-07 12:41:15 +00:00
Giles Bathgate 5a36ff89b5 Drop NDEBUG it is already visible through CGAL_NO_ASSERTIONS 2020-12-04 19:42:21 +00:00
Andreas Fabri 2e24249f13 Triangulation_2: Change the result type of the Intersect_2 functor 2020-12-04 16:44:22 +00:00
Andreas Fabri f246c4abf8 merge 2020-11-13 16:26:57 +00:00
Andreas Fabri 5791bc1400 fix do_intersect for 3 planes 2020-10-20 14:55:52 +01:00
Sébastien Loriot 209bee81b3 Merge remote-tracking branch 'cgal/5.1.x-branch' into master 2020-10-20 13:35:25 +02:00
Sébastien Loriot 335ac3d5dd Merge remote-tracking branch 'cgal/releases/CGAL-5.0-branch' 2020-10-20 13:32:03 +02:00
Sébastien Loriot e5019d04e6 Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-10-20 13:27:26 +02:00
Sébastien Loriot 87b8f66e14 update from master 2020-10-20 09:19:13 +02:00
Andreas Fabri fefbc4bc1a Add funcion intersection_point for Line/Plane 2020-10-20 09:17:15 +02:00
Andreas Fabri eafad68789 Add a function that only constructs a point intersection for 3 planes 2020-10-20 09:17:15 +02:00
Andreas Fabri 46698620e3 Hack for a fix of do_intersect(Plane_3,Plane_3,Plane_3) 2020-10-20 09:17:15 +02:00
Thomas Lin Pedersen 38e46d853c move braces 2020-10-16 16:10:48 +02:00
Thomas Lin Pedersen f856e13964 move bracers 2020-10-16 16:10:35 +02:00
Jane Tournois 5c8df6672a remove CGAL_CFG_MATCHING_BUG_ variants
the "matching bug" of msvc has been fixed since at least vs 2015
2020-09-25 14:25:14 +02:00
Dmitry Anisimov 371db977c8 better kernel checker 2020-08-20 14:12:16 +02:00
Dmitry Anisimov ad813b4cb0 further removed result_of and result 2020-07-30 16:19:02 +02:00
Dmitry Anisimov 4248a8a9f7 lazy and type mapper result_of fix 2020-07-23 16:00:06 +02:00
Laurent Rineau 2e8a59d570 Merge branch 'releases/CGAL-4.14-branch' into releases/CGAL-5.0-branch 2020-07-21 15:25:54 +02:00
Dmitry Anisimov da0635e4b1 result_of changed to decltype 2020-07-20 17:03:28 +02:00