Commit Graph

1450 Commits

Author SHA1 Message Date
Laurent Rineau a8fca35b1d Merge pull request #4735 from lrineau/Triangulation_2-fix_CDT_2_degenerate_case-GF
Fix a bug in <CGAL/Constrained_triangulation_2.h>
2020-05-27 16:32:49 +02:00
Laurent Rineau 0ea385712f Fix compatibility with C++03 2020-05-22 14:52:18 +02:00
Laurent Rineau 3cd52cdc3e Fix a bug in <CGAL/Constrained_triangulation_2.h>
The function parameter was locally shadowed by a local `int i`
variable!

Then the edge `(f, i)` in the call `remove_constrained_edge(f, i)` was
the wrong one!

The bug was introduced by ecfd82e287,
ten years ago.

The bug was only triggered on degenerated cases, when two constraints
intersect, but the code failed to compute the intersection. Then, if
the intersection vertex `vi` was either `vaa` or `vbb` (and not `vcc`
or `vdd`), then the edge `(f, i)` was the wrong one.
2020-05-19 17:25:10 +02:00
Laurent Rineau 12c0ec0935 New debug code in <CGAL/Constrained_triangulation_2.h>
... tested in `test/Triangulation_2/test_cdt_degenerate_case.cpp`.
2020-05-19 17:25:10 +02:00
Sebastien Loriot fb7d41a008
Merge pull request #4579 from sloriot/BGL-copy_face_graph_nm_vertices
Handle non-manifold vertices in copy_face_graph
2020-04-16 16:23:02 +02:00
Sébastien Loriot bb25ae576a Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-04-06 15:45:04 +02:00
Mael Rouxel-Labbé 1cb3736f1a Fix compilation errors 2020-04-03 09:03:56 +02:00
Mael Rouxel-Labbé 733f71a6bc Do not initialize variables / change the triangulation in assertions
Otherwise things break when DNDEBUG is used
2020-04-02 16:16:06 +02:00
Sébastien Loriot 161d813464 Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-03-31 15:53:39 +02:00
Laurent Rineau 868f4affc7 CT_plus_2: fix a pair of typos in the documentation 2020-03-31 15:47:01 +02:00
Sébastien Loriot ba42fcb6ca Update branch from master after trailing whitespaces and tabs removal 2020-03-27 08:36:40 +01:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Sébastien Loriot 0a46621dc6 Merge branch 'cgal/releases/CGAL-4.14-branch'
whitespace+tab removal, merged with option -Xignore-all-space
2020-03-26 13:28:46 +01:00
Sébastien Loriot 590612a563 run the script to remove tabs and trailing whitespaces 2020-03-26 13:25:16 +01:00
Sébastien Loriot d10359d09e Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-03-19 16:27:55 +01:00
Sebastien Loriot e53018d11e
Merge pull request #4565 from MaelRL/Tr-construct_point_return-GF
Triangulation_23: Grab return of construct_point() by reference when possible
2020-03-19 16:25:31 +01:00
Sébastien Loriot bda5680629 Merge remote-tracking branch 'cgal/releases/CGAL-4.14-branch' 2020-03-17 18:13:56 +01:00
Sébastien Loriot 09039464ef restrict partial specialization to avoid grab everything 2020-03-17 17:53:21 +01:00
Mael Rouxel-Labbé d8244fceb4 Replace std::set with boost::container::flat_set 2020-03-13 08:32:40 +01:00
Mael Rouxel-Labbé 1c622e0ba5 Base CDT2's edge sets on geometry to ensure determinism
When using face addresses, we do get the same combinatorics and
geometry in the result, but it is possible to create
different TDS' from one run to another, with a given face
not having the same order of points in memory.
2020-03-12 13:11:32 +01:00
Mael Rouxel-Labbé fe1fd95d23 Fix always returning by copy when it is possible to return by reference 2020-03-09 15:31:51 +01:00
Laurent Rineau 617878b063 Merge pull request #4406 from afabri/Triangulation_2-fix_Projection_traits-GF
Triangulation_2:  Projection_traits::Construct_bbox_2 must return Bbox_2
2019-12-17 09:14:23 +01:00
Andreas Fabri 4d4b891362 T2: Projection_traits::Construct_bbox_2 must return Bbox_2 2019-12-13 15:47:43 +01:00
Laurent Rineau 57152023c2 Merge pull request #4304 from MaelRL/CGAL-Header_only_doc_rewrite-GF
Documentation: switch manual to header-only by default (+misc improvements)
2019-10-29 15:23:39 +01:00
Andreas Fabri 6d4a431b18 polish 2019-10-25 10:18:41 +02:00
Sébastien Loriot 52164b1fba First pass on removing license notice in header for LGPL files 2019-10-19 15:40:30 +02:00
Sébastien Loriot 254d60f642 First pass on removing license notice in header for GPL files 2019-10-19 15:23:19 +02:00
Sébastien Loriot 7356421d80 introduce Commercial license SPDX tag 2019-10-19 12:15:19 +02:00
Sébastien Loriot 9bd9c68b83 update LGPL[23]+ and GPL[23]+ SPDX tags
ack -l --no-svg "SPDX-License-Identifier: GPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-3.0+/SPDX-License-Identifier: GPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-3.0+/SPDX-License-Identifier: LGPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: GPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-2.0+/SPDX-License-Identifier: GPL-2.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-2.0+/SPDX-License-Identifier: LGPL-2.0-or-later/"
2019-10-18 21:57:54 +02:00
Maxime Gimeno 0bda2dd231 remove c++11 2019-09-17 09:39:46 +02:00
Laurent Rineau 830bb9640f Merge pull request #4141 from albert-github/feature/bug_obsolete_images
warning: image file name tds_small.png is ambiguous.
2019-08-16 13:24:58 +02:00
Laurent Rineau fcf6ea4d5c Merge branch 'releases/CGAL-4.14-branch' 2019-08-16 13:24:32 +02:00
Laurent Rineau f70640a675 Merge branch 'releases/CGAL-4.13-branch' into releases/CGAL-4.14-branch 2019-08-16 13:24:11 +02:00
Andreas Fabri 8802f9877b Triangulation_2: Fix documentation of a typedef 2019-08-13 02:11:35 -07:00
Sebastien Loriot 472e4ab4f9
Merge pull request #4138 from albert-github/feature/bug_unbalanced
warning: unbalanced grouping commands
2019-08-12 09:15:43 +02:00
albert-github 62f2fef741 warning: image file name tds_small.png is ambiguous.
Some images were present on multiple places but the second reference was not used anymore.
2019-08-08 13:41:18 +02:00
albert-github 1a38e5295d warning: unbalanced grouping commands
Removing last "warning: unbalanced grouping commands" messages.

Note: maybe useful to add in Triangulation_2/doc/Triangulation_2/CGAL/Triangulation_2.h some `\name` parts for handles / iterators / ...
2019-08-05 16:00:53 +02:00
Sébastien Loriot b84297f8f6 update the usage for the new CGAL named function parameters 2019-07-29 09:38:39 +02:00
Sébastien Loriot 25a05e9f4c Merge branch 'CGAL-named_function_parameters-4.14' into master
Conflicts resolved by hand
2019-07-28 23:46:43 +02:00
Sébastien Loriot 2f81a21523 Merge 'CGAL-named_function_parameters' for 4.13-branch into 4.14-branch
Conflicts resolved by hand
2019-07-28 22:30:13 +02:00
Sébastien Loriot 1f8065c6c3 Merge pull request #3885 from MaelRL/PMP-Locate-GF
PMP: Add locate.h and rewrite Triangulation_2 graph traits
2019-07-18 16:40:49 +02:00
Sebastien Loriot 667e4022f7
Merge pull request #4060 from sloriot/CGAL-doc_match_brackets
match @{ and @}
2019-07-18 16:26:43 +02:00
Sébastien Loriot 560c77f567 rename named function parameter class 2019-07-15 06:25:02 +02:00
Laurent Rineau dc02598a5c Merge pull request #4016 from gdamiand/CGAL-more_viewers-gdamiand
CGAL: more viewers
2019-07-10 14:22:50 +02:00
Sébastien Loriot fbafb9d06f fix remaining mismatches and fix bugs 2019-07-10 11:40:45 +02:00
Sébastien Loriot 983645a51a match @{ and @} 2019-07-05 21:49:46 +02:00
Laurent Rineau c0ba28f80a Merge branch 'releases/CGAL-4.14-branch' 2019-07-03 11:18:20 +02:00
Laurent Rineau e79bfd5d03 Merge branch 'releases/CGAL-4.13-branch' into releases/CGAL-4.14-branch 2019-07-03 11:10:03 +02:00
Mael Rouxel-Labbé f68141a6d3 Merge branch 'PMP-Locate-GF-old' into PMP-Locate-GF 2019-07-01 11:28:25 +02:00
Laurent Rineau 32f80cbece Merge pull request #4018 from lrineau/CGAL-refresh_cmake_minimum_required-GF
CMake>=3.13: opt for for new policies up to 3.15
2019-07-01 11:16:30 +02:00