Commit Graph

897 Commits

Author SHA1 Message Date
Sebastien Loriot b1b02d64fe
P3M3: Non-cubic domains, fixes, improvements (#7062)
## Summary of Changes

- Add a dummy point generator that is agnostic to the periodic domain's
geometry, allowing P3M3 to handle non-cubic domain.
- Add an example of P3M3 running on polyhedral domains.
- Fix a few issues in SMDS_3's tet soup reading relating to
non-manifoldness + general IO code speed improvements.
- Fix a few issues in P3M3's medit output and always duplicate facets to
reduce the quantity of non-manifoldness occurences.
- Fix an issue with including Mesh_3 headers before P3M3's.
- Fix periodic point projection (for Mesh_3 optimizers) badly computing
the projection direction
- Robustify a handful of P3M3 functions that were using intermediate
constructions rather than the <Point, Offset> API (which uses filtered
predicates and thus yields proper robustness)
- Misc minor code cleaning / modernization

ToDo:
- [x] Check if some medit IO issues are fixed
- [x] Add non-manifoldness flag to read_MEDIT
- [x] Fix value of orthosphere_radius_threshold
- [x] Check calls of insert_dummy_points() (use generic)
- [x] Check doc of P3M3 about cubic domains requirement

Not done:
- [ ] Fix sharp features for periodic polyhedral domains (problems due
to changing weights creating cover change...). Code:
https://gist.github.com/MaelRL/357c52dc04e16a162f13a3c6860a1398; WIP
diff: https://gist.github.com/MaelRL/f98809964acffbacb6d3f42793e2654e

## Release Management

* Affected package(s): `Mesh_3`,  `P3M3`, `P3T3`, `SMDS3`
* Issue(s) solved (if any): Fix #6997, Fix #7214
* Feature/Small Feature (if any): TODO
* License and copyright ownership: no change
2023-05-30 19:13:45 +02:00
Sebastien Loriot 243adaaa05
Update doc testsuite to use 1.9.6 (#7441)
Replaces #6178
2023-05-19 18:03:05 +02:00
Sébastien Loriot d23fdd85bf update testsuite script to last doxygen version 2023-05-12 19:44:58 +02:00
Mael 532b82cb9b
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-05-04 17:28:47 +02:00
Jane Tournois 7eb9a5a0cc Merge remote-tracking branch 'cgal/master' into Mesh_3-triple_line_extraction_and_weights-GF
# Conflicts:
#	Mesh_3/include/CGAL/Labeled_mesh_domain_3.h
2023-04-07 15:11:30 +02:00
Mael Rouxel-Labbé cd0c81a98a Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-03-20 10:14:27 +01:00
Laurent Rineau 95dc40f610 List workflow run: skip disabled workflows 2023-03-16 10:27:11 +01:00
Nicolas Saillant 185e510278 Fix line endings 2023-03-15 14:49:57 +01:00
SaillantNicolas 10caf9fde4
added a script that list all cgal workflow last run 2023-03-03 15:42:17 +01:00
Sébastien Loriot da39109d88 fix CI and be more strict also on the operator() call 2023-02-27 09:58:26 +01:00
Mael 8f703b54cb
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-01-27 21:48:32 +01:00
Laurent Rineau 1d6830501d Merge branch '5.5.x-branch' 2023-01-05 15:46:47 +01:00
Laurent Rineau 3cabebf827 Merge branch '5.4.x-branch' into 5.5.x-branch 2023-01-05 15:46:14 +01:00
Laurent Rineau bcc59bfbb6 CONFIG_TYPE maybe used on other platforms
On MacOS, with the XCode generator, the config type is required.
2022-12-21 14:55:42 +01:00
Mael Rouxel-Labbé b115a680bf Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2022-12-06 09:47:46 +01:00
Laurent Rineau dbe12c20ee Merge pull request #7072 from afabri/CGAL-cmake-3_25-GF
CGAL: Fixes for cmake 3.25

# Conflicts:
#	Barycentric_coordinates_2/examples/Barycentric_coordinates_2/CMakeLists.txt
#	Barycentric_coordinates_2/test/Barycentric_coordinates_2/CMakeLists.txt
#	Polygonal_surface_reconstruction/examples/Polygonal_surface_reconstruction/CMakeLists.txt
#	Polygonal_surface_reconstruction/test/Polygonal_surface_reconstruction/CMakeLists.txt
#	Shape_regularization/examples/Shape_regularization/CMakeLists.txt
#	Shape_regularization/test/Shape_regularization/CMakeLists.txt
#	Weights/examples/Weights/CMakeLists.txt
#	Weights/test/Weights/CMakeLists.txt
2022-12-05 12:22:44 +01:00
Laurent Rineau f0d4d975dd Merge pull request #7072 from afabri/CGAL-cmake-3_25-GF
CGAL: Fixes for cmake 3.25

# Conflicts:
#	Barycentric_coordinates_2/examples/Barycentric_coordinates_2/CMakeLists.txt
#	Barycentric_coordinates_2/test/Barycentric_coordinates_2/CMakeLists.txt
#	Polygonal_surface_reconstruction/examples/Polygonal_surface_reconstruction/CMakeLists.txt
#	Polygonal_surface_reconstruction/test/Polygonal_surface_reconstruction/CMakeLists.txt
#	Shape_regularization/examples/Shape_regularization/CMakeLists.txt
#	Shape_regularization/test/Shape_regularization/CMakeLists.txt
#	Weights/examples/Weights/CMakeLists.txt
#	Weights/test/Weights/CMakeLists.txt
2022-12-05 12:03:21 +01:00
Sébastien Loriot 20dacdb0c7 add check that cmake_minimum_required is the first line 2022-11-23 10:46:41 +01:00
Mael Rouxel-Labbé 54cfef9dc7 Fix typo in dependency check message 2022-10-25 13:31:20 +02:00
Laurent Rineau 959d2edd5e Remove a comment (was a debug work-in-progress) 2022-09-29 14:13:04 +02:00
Laurent Rineau ba47ed444a Fix the script cgal_check_dependencies.sh 2022-09-27 14:31:50 +02:00
Laurent Rineau 4c5b5843e3 sed -i -e 's/egrep/grep -E/g' 2022-07-01 16:19:36 +02:00
Laurent Rineau 734c96e951 Merge branch 'master' into pr/lrineau/6558 2022-05-06 16:25:32 +02:00
Laurent Rineau 90accc92ea Merge pull request #6499 from MaelRL/STL-Merge_is_defaults-GF
Merge parameters::Is_default and parameters::is_default_parameter
2022-05-06 14:22:02 +02:00
Laurent Rineau 7c4e43ee1c Merge pull request #6535 from sloriot/Test-remove_cmake_generator
remove mentions to  CMAKE_GENERATOR in test scripts

# Conflicts:
#	CGAL_ipelets/demo/CGAL_ipelets/cgal_test_with_cmake
#	Set_movable_separability_2/test/Set_movable_separability_2/cgal_test_with_cmake
2022-05-06 14:21:25 +02:00
Laurent Rineau 539e2852a1 Merge pull request #6535 from sloriot/Test-remove_cmake_generator
remove mentions to  CMAKE_GENERATOR in test scripts

# Conflicts:
#	CGAL_ipelets/demo/CGAL_ipelets/cgal_test_with_cmake
#	Set_movable_separability_2/test/Set_movable_separability_2/cgal_test_with_cmake
2022-05-06 14:19:07 +02:00
Laurent Rineau 2288225448 Massive update of CMake policies to version 3.23 2022-05-06 09:34:35 +02:00
Sébastien Loriot 8e0ed828e7 remove mentions to CMAKE_GENERATOR in test scripts 2022-04-28 13:48:23 +02:00
Laurent Rineau f7424e89b9 Merge pull request #6509 from lrineau/Scripts-Fix__run_testsuite_with_ctest__on_cygwin-GF
Fix run_testsuite_with_ctest on Cygwin
2022-04-27 16:31:47 +02:00
Laurent Rineau 5af4355ab0 Merge pull request #6509 from lrineau/Scripts-Fix__run_testsuite_with_ctest__on_cygwin-GF
Fix run_testsuite_with_ctest on Cygwin
2022-04-27 16:30:49 +02:00
Laurent Rineau b68e2a5005 Fix run_testsuite_with_ctest on Cygwin 2022-04-22 11:25:09 +02:00
Mael Rouxel-Labbé 8ca3558216 Include Installation headers in NP checks (io_tags.h includes config.h) 2022-04-20 16:49:05 +02:00
Mael Rouxel-Labbé d1876deb3c Include Stream_support headers in NP checks (tags.h includes io_tags.h) 2022-04-20 16:44:43 +02:00
Sébastien Loriot 6d3176e061 move Named_parameters class in STL_extension
helpers stay in BGL because it depends on BGL tags
2022-01-07 15:12:22 +01:00
Laurent Rineau 8723095ce0 Merge branch '5.2.x-branch' into 5.3.x-branch 2021-11-30 10:26:40 +01:00
Laurent Rineau 07cfbc21d8 Update all testsuite scripts, using master versions 2021-11-30 10:23:20 +01:00
Laurent Rineau 22c4c859d2 Merge branch '5.3.x-branch' 2021-11-02 10:59:04 +01:00
Sébastien Loriot 120d94a4cf add new test for documented named parameters 2021-11-01 09:39:51 +01:00
Laurent Rineau ea15e79a89 Improve merge_pr_with_label 2021-10-29 17:06:12 +02:00
Sebastien Loriot ed3503d238
Merge pull request #6061 from sloriot/Scripts-merge_prs
Simply merge script by using gh
2021-10-19 15:46:50 +02:00
Laurent Rineau 48d4034baa Cosmetic change: I commit what is used on sosno 2021-10-18 16:35:20 +02:00
Laurent Rineau 1ad762e082 Fix to allow the `errexit` option (`bash -e`) 2021-10-18 16:34:30 +02:00
Sébastien Loriot f56cc0dcc9 simply merge script by using gh 2021-10-18 16:11:10 +02:00
Mael Rouxel-Labbé 521c72d57e Fix typos 2021-10-04 13:34:07 +02:00
Laurent Rineau e5ab9202f5 Merge pull request #4229 from gdamiand/CGAL_data-gdamiand
Regroup data: scripts and function updates
2021-09-23 16:14:11 +02:00
Sébastien Loriot c83057a7dc use new way to find python3 since cmake 3.12 and do not use old python path 2021-09-21 14:40:45 +02:00
Maxime Gimeno 5c608f0c83 FIx repetition operator for mac. 2021-08-09 15:40:13 +02:00
Maxime Gimeno 4ceb5fbb1f filter diff 2021-08-09 15:19:12 +02:00
Maxime Gimeno b579d9bd3c Remove the platforms before starting the filter testsuite 2021-08-09 14:16:50 +02:00
Maxime GIMENO 314f867564
No --depth 1 anywhere 2021-07-30 15:52:10 +02:00