Commit Graph

112103 Commits

Author SHA1 Message Date
Sébastien Loriot 18bf7051bd fix deprecation warning 2025-04-08 17:58:37 +02:00
Sven Oesau 9d1a089abf missing dimension in constructor
removing default constructor for dynamic dimension Kd_tree_rectangle
2025-04-08 11:28:37 +02:00
Sébastien Loriot 9911b4e23e remove extra template keyword 2025-04-07 11:47:02 +02:00
Sébastien Loriot 6da7046307 revert change backported that was not correct at this point in time 2025-04-07 11:45:09 +02:00
Sebastien Loriot b3d5e26c1a
Lab - Fixed loading of OpenMesh files without selection (#8832)
## Summary of Changes

A `Scene_polyhedron_selection_item` is created when loading an OpenMesh
file. When there was no selection inside the file, this selection item
was neither added to the scene nor deleted. Thus, it still received Qt
signals and caused crashes when the actual mesh was removed.

## Release Management

* Affected package(s): CGALlab
2025-04-07 09:28:48 +02:00
Sven Oesau e65e2a0950 deleting selection item in OpenMesh plugin when there is no selection 2025-04-07 09:10:00 +02:00
Mehul Yadav 24ecfdb47c
Doc Chapter_intro.txt: minor typos 2025-04-05 17:42:40 +05:30
Mehul Yadav 7a2457161a
Doc: Typo corrections Usage.txt 2025-04-05 17:38:23 +05:30
albert-github c6e12be212 Spelling corrections
Spelling corrections
2025-04-04 09:48:20 +02:00
Sébastien Loriot cc77715588 Merge pull request #6849 from JulyCode/gsoc2022-isosurface
Isosurfacing_3 (new package)
2025-04-03 21:41:22 +02:00
Sébastien Loriot 6188aae5e5 Merge pull request #8259 from loic-dubois/Hyperbolic_surface_triangulation_2-dubois
Hyperbolic surface triangulation 2 (new package)
2025-04-03 19:18:58 +02:00
Sébastien Loriot 7ff41a8950 Merge pull request #7837 from hoskillua/gsoc2023
GSoC2023 - ACVD for Simplification & Remeshing
2025-04-03 18:00:57 +02:00
Mael Rouxel-Labbé e001c7ce53 Misc minor doc changes 2025-04-03 17:08:26 +02:00
Mael Rouxel-Labbé 29505552ee Regroup related named parameters 2025-04-03 16:55:10 +02:00
Mael Rouxel-Labbé 55962d76e3 Update CHANGES.md 2025-04-03 16:26:00 +02:00
Sébastien Loriot 09564a6d7b do not use result_type 2025-04-03 16:13:27 +02:00
Sébastien Loriot a4170b1fb9 Merge pull request #8586 from MaelRL/Kernel_23-Fix_dangling_ref_in_CC3-GF
Do not rely on result_type definitions in kernels
2025-04-03 16:12:09 +02:00
Sébastien Loriot b6719fc3be Merge remote-tracking branch 'cgal/6.0.x-branch' into cgal/master 2025-04-03 16:09:51 +02:00
Sébastien Loriot f516c12c5b Merge remote-tracking branch 'cgal/5.6.x-branch' into 6.0.x-branch 2025-04-03 16:09:15 +02:00
Sebastien Loriot ede0864914
BGL - add `CGAL::dijkstra_shortest_path(vs, vt, mesh)` (#8724)
## Summary of Changes

computes the shortest path between two vertices, using Dijkstra
algorithm

Todo
- [x] write doc and integrate to 
- [x] add np
- [x] add measure to define what "shortest" means
- [x] add to ref manual top page
- [x] use in demo code

## Release Management

* Affected package(s): BGL
* [Small
feature](https://cgalwiki.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Add_CGAL::shortest_path(vs,_vt))
* Link to compiled documentation
[CGAL::shortest_path_between_two_vertices()](https://cgal.github.io/8724/v0/BGL/group__PkgBGLTraversal.html#ga5627dee8a6fe4d238cb5c91e123aa763)
* License and copyright ownership: unchanged
2025-04-03 16:07:02 +02:00
Sebastien Loriot c5a809ad30
Spelling correction (#8813)
Spelling correction
2025-04-03 16:05:14 +02:00
Sebastien Loriot 7b0c8bd405
Fix return type of point on plane constructions (#8803)
## Summary of Changes

The main issue is that the functions `point_on_plane()` and
`projection_plane()` return a `PointC3`, whereas you could have a kernel
that uses a custom point type with `PlaneC3` as its plane type. The
correct return type is thus the kernel's point.

I moved the code into PlaneC3, but the really clean fix would be to have
all of this into the function object `Construct_point_on_3`. However, a
lot of required changes immediately get pulled: `Construct_point_on_3`
does not have the Cartesian / Homogeneous split, other overloads do not
have a nice implementation and instead use directly the members in the
Rep, etc.

## Release Management

* Affected package(s): `Cartesian_kernel`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
2025-04-03 15:57:17 +02:00
Sebastien Loriot b45c29edd4
Fix Compare_xy_2 for the generic 3D projection traits (#8810)
## Summary of Changes

The previous implementation defined `Compare_xy_2` as simply
`Compare_xyz_3`. This does define an order over the projected points,
but it has a strong downside: it ignores the direction of the normal, so
its order can be the opposite of the lexicographical order
would give. This new order is in conflict with the existing
`Compare_x_2` and `Compare_y_2`, which take the normal's direction into
account.

(Also with the `Less_x_2`, `Less_y_2`, and `Less_xy_2` family, which
also exist for the projection traits.)

## Release Management

* Affected package(s): `Kernel_23`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): - 
* License and copyright ownership: no change
2025-04-03 15:54:37 +02:00
Mael Rouxel-Labbé 19a0e6e2a7 Update CHANGES.md 2025-04-03 15:54:05 +02:00
Sebastien Loriot 913c8bf40f
missing include in boost + extra care for overload resolution (#8818)
Backward compatible fix for #8759

Thanks for the idea @mglisse
2025-04-03 15:53:41 +02:00
Mael Rouxel-Labbé f5f5727d50 Update CHANGES.md 2025-04-03 15:44:50 +02:00
Sébastien Loriot bb3e3ab06b init pointers of subtraits 2025-04-03 15:38:56 +02:00
Sébastien Loriot 93e8257255 workaround possible optimisation that would alter the value of the erase_counter
The code is still not legal but works in practise.

fix similar to 5853673267
2025-04-03 12:16:27 +02:00
Sven Oesau adba9aeb6b doc fix
[skip ci]
2025-04-02 17:19:52 +02:00
Sven Oesau 96664743f5 remove default value for named parameter object 2025-04-02 16:58:47 +02:00
Sven Oesau daea460016 removing trailing whitespace 2025-04-02 12:04:14 +02:00
Sven Oesau 25443ddc54 pass on code and doc following reviews 2025-04-02 11:53:31 +02:00
Sven Oesau 0f19011bd7 removing forward declaration
reusing include guards instead of forward declaration
2025-04-02 10:32:19 +02:00
Sven Oesau 765a9d0939 adding default value for template parameter in Point_set_3 forward declaration 2025-04-02 09:14:29 +02:00
Sébastien Loriot 60b4b19ba4 add more potentially missing include directives 2025-04-02 09:10:51 +02:00
Sébastien Loriot 2ccb0f7320 add missing include directive 2025-04-02 09:06:49 +02:00
Sven Oesau ae1a157c64 replacing Point_set_3.h include with forward declaration 2025-04-02 08:44:33 +02:00
Sébastien Loriot 32ac9f22a7 work around overload resolution with recent gcc 2025-04-01 15:43:43 +02:00
Sébastien Loriot 25f7014350 in some case with needle, some non-manifold faces can be created even with a decent nb of points 2025-04-01 14:42:46 +02:00
Sven Oesau 4682171fcc added missing includes 2025-04-01 09:59:37 +02:00
Sébastien Loriot 9ff2696011 split at the midpoint to avoid patterns leading to infinite loop 2025-03-31 20:27:27 +02:00
Sébastien Loriot 9c6452dfaf do not take references to points stored in an internal vector that could be resized!
also fix debug function
2025-03-31 17:41:13 +02:00
Sven Oesau 675c10766d changed link to better picture
[skip ci]
2025-03-31 16:15:24 +02:00
Sven Oesau 29cc26f6ec added a check for presence of normals (if Point_set_3 is used) 2025-03-31 15:58:54 +02:00
Sven Oesau 5f8e3f614f
Merge branch 'CGAL:master' into Mesh_3-Poisson_domain-GF 2025-03-31 15:55:55 +02:00
Sébastien Loriot 5ed3b0d266 Merge remote-tracking branch 'cgal/6.0.x-branch' in master 2025-03-31 15:32:56 +02:00
Sébastien Loriot a838073ec7 Merge remote-tracking branch 'cgal/5.6.x-branch' into cgal/6.0.x-branch 2025-03-31 15:31:19 +02:00
Sven Oesau e1c6a9365e
Merge branch 'master' into Mesh_3-Poisson_domain-GF 2025-03-31 14:48:20 +02:00
Sven Oesau 62833a6bae adapting Poisson_surface_reconstruction_3 to surface_only() 2025-03-31 14:36:30 +02:00
Sébastien Loriot 108d8671ab fix dependencies 2025-03-31 14:15:30 +02:00