songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
113,786 Commits 3 Branches 156 Tags 959 MiB
Commit Graph

5127 Commits

Author SHA1 Message Date
Laurent Rineau d309bc89ce fix typo "and and" 2025-09-30 17:11:15 +02:00
Laurent Rineau 88f9f00922 fix warning -Wstringop-overflow 
Fix that warning, due to a copy of `tuple<Point, int, int>` in compare operators for `std::sort` and `std::unique`, in `CGAL::Polygon_mesh_processing::autorefine_impl::collect_intersections`.

```
In member function ‘std::__atomic_base<_IntTp>::__int_type std::__atomic_base<_IntTp>::fetch_add(__int_type, std::memory_order) [with _ITp = int]’,
    inlined from ‘void CGAL::Handle::incref() const’ at /mnt/testsuite/include/CGAL/Handle.h:87:29,
    inlined from ‘CGAL::Handle::Handle(const CGAL::Handle&)’ at /mnt/testsuite/include/CGAL/Handle.h:55:13,
    inlined from ‘CGAL::Lazy<CGAL::Point_3<CGAL::Simple_cartesian<CGAL::Interval_nt<false> > >, CGAL::Point_3<CGAL::Simple_cartesian<__gmp_expr<__mpq_struct [1], __mpq_struct [1]> > >, CGAL::Cartesian_converter<CGAL::Simple_cartesian<__gmp_expr<__mpq_struct [1], __mpq_struct [1]> >, CGAL::Simple_cartesian<CGAL::Interval_nt<false> >, CGAL::NT_converter<__gmp_expr<__mpq_struct [1], __mpq_struct [1]>, CGAL::Interval_nt<false> > > >::Lazy(const CGAL::Lazy<CGAL::Point_3<CGAL::Simple_cartesian<CGAL::Interval_nt<false> > >, CGAL::Point_3<CGAL::Simple_cartesian<__gmp_expr<__mpq_struct [1], __mpq_struct [1]> > >, CGAL::Cartesian_converter<CGAL::Simple_cartesian<__gmp_expr<__mpq_struct [1], __mpq_struct [1]> >, CGAL::Simple_cartesian<CGAL::Interval_nt<false> >, CGAL::NT_converter<__gmp_expr<__mpq_struct [1], __mpq_struct [1]>, CGAL::Interval_nt<false> > > >&)’ at /mnt/testsuite/include/CGAL/Lazy.h:877:7,
    inlined from ‘CGAL::Point_3<CGAL::Epeck>::Point_3(const CGAL::Point_3<CGAL::Epeck>&)’ at /mnt/testsuite/include/CGAL/Point_3.h:30:7,
    inlined from ‘std::_Head_base<_Idx, _Head, false>::_Head_base(const std::_Head_base<_Idx, _Head, false>&) [with long unsigned int _Idx = 0; _Head = CGAL::Point_3<CGAL::Epeck>]’ at /usr/include/c++/15/tuple:208:17,
    inlined from ‘std::_Tuple_impl<_Idx, _Head, _Tail ...>::_Tuple_impl(const std::_Tuple_impl<_Idx, _Head, _Tail ...>&) [with long unsigned int _Idx = 0; _Head = CGAL::Point_3<CGAL::Epeck>; _Tail = {int, int}]’ at /usr/include/c++/15/tuple:318:17,
    inlined from ‘std::tuple< <template-parameter-1-1> >::tuple(const std::tuple< <template-parameter-1-1> >&) [with _Elements = {CGAL::Point_3<CGAL::Epeck>, int, int}]’ at /usr/include/c++/15/tuple:1502:17,
    inlined from ‘bool __gnu_cxx::__ops::_Val_comp_iter<_Compare>::operator()(_Value&, _Iterator) [with _Value = std::tuple<CGAL::Point_3<CGAL::Epeck>, int, int>; _Iterator = __gnu_cxx::__normal_iterator<std::tuple<CGAL::Point_3<CGAL::Epeck>, int, int>*, std::vector<std::tuple<CGAL::Point_3<CGAL::Epeck>, int, int> > >; _Compare = CGAL::Polygon_mesh_processing::autorefine_impl::collect_intersections<CGAL::Epeck>(const std::array<CGAL::Point_3<CGAL::Epeck>, 3>&, const std::array<CGAL::Point_3<CGAL::Epeck>, 3>&, std::vector<std::tuple<CGAL::Point_3<CGAL::Epeck>, int, int> >&)::<lambda(auto:82, auto:83)>]’ at /usr/include/c++/15/bits/predefined_ops.h:240:23,
    inlined from ‘void std::__unguarded_linear_insert(_RandomAccessIterator, _Compare) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<tuple<CGAL::Point_3<CGAL::Epeck>, int, int>*, vector<tuple<CGAL::Point_3<CGAL::Epeck>, int, int> > >; _Compare = __gnu_cxx::__ops::_Val_comp_iter<CGAL::Polygon_mesh_processing::autorefine_impl::collect_intersections<CGAL::Epeck>(const std::array<CGAL::Point_3<CGAL::Epeck>, 3>&, const std::array<CGAL::Point_3<CGAL::Epeck>, 3>&, std::vector<std::tuple<CGAL::Point_3<CGAL::Epeck>, int, int> >&)::<lambda(auto:82, auto:83)> >]’ at /usr/include/c++/15/bits/stl_algo.h:1758:20:
/usr/include/c++/15/bits/atomic_base.h:631:34: warning: ‘unsigned int __atomic_fetch_add_4(volatile void*, unsigned int, int)’ writing 4 bytes into a region of size 0 overflows the destination [-Wstringop-overflow=]
  631 |       { return __atomic_fetch_add(&_M_i, __i, int(__m)); }
      |                ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
```

See for example https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-6/Constrained_triangulation_3_Examples/TestReport_cgaltest_Fedora-rawhide-Release.gz
 2025-09-25 16:25:37 +02:00
Sébastien Loriot 12f6041f5a Merge remote-tracking branch 'cgal/6.0.x-branch' into `cgal/master` 2025-09-03 16:56:24 +02:00
Sébastien Loriot 8c25c60052 Merge remote-tracking branch 'cgal/5.6.x-branch' into 'cgal/6.0.x-branch' 2025-09-03 16:55:14 +02:00
lvalque 37f9018997 Initialized the lower bound face in traversal of the AABB-tree to solve issue-7164 2025-09-03 16:41:15 +02:00
Sébastien Loriot ca869de993 more macro protections for MSVC 2025-09-02 14:17:59 +02:00
Sébastien Loriot 478dab85c1 macro protection 2025-08-29 09:55:15 +02:00
Sébastien Loriot a027377f09 fix the handling of non-simply connected faces in the output 
for now we always triangulate such faces
 2025-08-27 17:19:23 +02:00
Sébastien Loriot b2ba32307c Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/6.1.x-branch' 2025-08-13 18:07:09 +02:00
Sébastien Loriot 419057ece4 Merge remote-tracking branch 'cgal/5.6.x-branch' into 'cgal/6.0.x-branch' 2025-08-13 18:05:54 +02:00
Sébastien Loriot fdd7c17ec1 avoid large dag in centroid 2025-08-07 18:20:20 +02:00
Sébastien Loriot c259a7f429 actually from the doc the constness issue is in the default visitor... 2025-08-04 15:40:45 +02:00
Sébastien Loriot f0752ec894 fix constness issue 2025-08-04 15:24:50 +02:00
Sebastien Loriot 6a733bbf47
Allow Side_of_triangle to take ownership on an external AABB-tree (#9007) 
Convenient for using only a subset of faces for example, or to force the
building of the tree
 2025-08-04 08:40:04 +02:00
Sébastien Loriot 8e0f2d6f73 Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/master' 2025-07-31 15:19:07 +02:00
Sébastien Loriot 28eee36cb6 Merge remote-tracking branch 'cgal/5.6.x-branch' into 'cgal/6.0.x-branch' 2025-07-31 15:15:52 +02:00
Sébastien Loriot 9dcbc58ec9 add a constructor taking a lvalue of an AABB-tree 
we can construct the tree for a subset of faces and still give the ownership to the class
 2025-07-31 11:12:38 +02:00
Sébastien Loriot d182dabf94 cannot collapse only if one of the two vertex is not constrained 
+ fill maps only if required
 2025-07-28 15:41:20 +02:00
albert-github 12cde5b685 Spelling correction 
After review: euclidean -> Euclidean
 2025-06-27 13:04:28 +02:00
albert-github 7a512655f1 Spelling correction 
Spelling correction
 2025-06-27 10:56:21 +02:00
Sébastien Loriot 27a7cef2fb Merge pull request #8744 from LeoValque/PMP_triangle_soup_rounding-GF 
Add do_snap parameter to PMP::autorefine_triangle_soup
 2025-06-26 22:01:58 +02:00
Sébastien Loriot 78cfeacf01 Merge pull request #8186 from lrineau/Triangulation_3-CDT_3-lrineau 
New package: CGAL 3D conforming constrained Delaunay triangulations
 2025-06-26 21:57:17 +02:00
Sebastien Loriot d961dd767a
Add extra condition (#8930) 
avoid the user to be surprised that the topology cannot be restored if
not all CC are sampled
 2025-06-26 21:48:01 +02:00
Jane Tournois 58e52e7dad avoid risk of dangling reference, using RVO 
fix a warning on Debian
 2025-06-24 15:08:36 +02:00
albert-github 7385518583 Warnings during table generation in documentation 
With doxygen release1.14.0 doxygen is a bit stricter regarding handling tables (not ignoring superfluous tags), it now leads to some warnings (and unexpected results).
 2025-06-23 14:54:04 +02:00
Sébastien Loriot 6905ab2b21 backticks 2025-06-23 12:01:05 +02:00
Sébastien Loriot dc31a8ce3a add precondition about single CC mesh 2025-06-23 11:36:13 +02:00
Sébastien Loriot bd0e60e950 fix mutex version 2025-06-10 20:32:19 +02:00
Sebastien Loriot 9a21a1478a cosmetic 2025-06-10 18:06:16 +02:00
Sébastien Loriot 9fba4c9918 Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/master' 2025-06-10 17:32:45 +02:00
Jane Tournois 0ab9d3eebf Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3-lrineau 
# Conflicts:
#	Installation/CHANGES.md
 2025-06-10 11:18:38 +02:00
Sébastien Loriot e816b145f5 undo namespace change 2025-06-05 10:38:13 +02:00
Sébastien Loriot 6444b9a0d0 Merge pull request #8890 from afabri/PMP-stitch_deterministic-GF 
PMP: Make stitch_borders() deterministic
 2025-06-04 14:56:33 +02:00
Sébastien Loriot d5c8d87ad2 Merge pull request #8906 from albert-github/feature/bug_table_inconsistency 
Warnings during table generation in documentation
 2025-06-04 14:56:21 +02:00
Jane Tournois 4c462898a8 fix compilation of PMP::isotropic_remeshing with Epeck 
and add a test to avoid future regressions
 2025-06-03 14:06:11 +02:00
Sébastien Loriot cfbf5f2765 fix bad variable name 2025-05-26 15:54:01 +02:00
albert-github d1fea32fc3 Warnings during table generation in documentation 
With doxygen release1.14.0 doxygen is a bit stricter regarding handling tables (not ignoring superfluous tags), it now leads to some warnings (and unexpected results).
 2025-05-26 11:28:55 +02:00
Andreas Fabri 549b8f1430 Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/triangle_soup_snap_rounding.h 2025-05-20 18:15:08 +02:00
Léo Valque c20e517150 Modification for review of Andres 2025-05-20 17:39:52 +02:00
lvalque 20526dddda Apply suggestions from code review 
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
 2025-05-20 17:08:31 +02:00
lvalque 2fc5fde73b Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/triangle_soup_snap_rounding.h 
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
 2025-05-19 10:01:24 +02:00
lvalque a8eb8c737c Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/triangle_soup_snap_rounding.h 
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
 2025-05-19 10:01:04 +02:00
lvalque bc0478d53c Update Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/triangle_soup_snap_rounding.h 
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
 2025-05-19 09:59:41 +02:00
Andreas Fabri 9f0761fde4 Make the debug out put work for Surface_mesh 2025-05-14 15:13:58 +01:00
Andreas Fabri 12eb3ff18c PMP: Make stitch_borders deterministic 2025-05-14 15:00:44 +01:00
Laurent Rineau cb5e13ad1f Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2025-05-13 17:34:31 +02:00
Laurent Rineau 41c6f59e8b return true 
```
  bool OK = triangulate_polygons(points, triangles, np);

  if (!OK) return true;
```
 2025-05-13 17:23:06 +02:00
Laurent Rineau bcfd317c17 refactor does_polygon_soup_self_intersect 2025-05-13 17:22:28 +02:00
Laurent Rineau 4b029e69bd Merge branch 'CGAL:master' into Triangulation_3-CDT_3-lrineau 2025-05-13 17:14:39 +02:00
Sébastien Loriot 2d1a77cd67 be more permissive and allow duplicated points 2025-05-13 14:49:46 +02:00