songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
77,749 Commits 3 Branches 156 Tags 973 MiB
Commit Graph

64 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé ff3c780b57 Fixed return type 2017-08-29 11:21:43 +02:00
Mael Rouxel-Labbé 3640902c6f Misc minor changes 2017-08-23 17:15:44 +02:00
Mael Rouxel-Labbé dba83ba5bf Fixed a few Alpha Shapes 2 headers 2017-08-23 16:40:55 +02:00
Mael Rouxel-Labbé 63d293765f Added an assertion to forbid using ExactComparisonTag with periodic triangulations 
When we set the exact comparison tag to true, we use a lazy evaluation
of predicates and store pointers to the arguments of the predicates (that is,
pointer to points). However, the points are  -- in the case of periodic --
only temporary objects and it is thus dangerous to take pointers to those
temporary values because the pointers quickly become invalid.

Thus, periodic triangulations are not allowed to use the exact tag.

A possible way to make it work is to define a small class:
Periodic_triangulation_with_stored_real_points that would inherit the base
(periodic) triangulation but store all the points of its simplices.
Then, the function  point(face_handle, int) would return an entry of that
container, of which it would be safe to take a pointer.
 2017-08-23 16:19:32 +02:00
Mael Rouxel-Labbé ad27f5c39b Readability changes in Alpha_shapes_2 2017-08-23 11:04:46 +02:00
Mael Rouxel-Labbé 87e9bb4c43 Changed Alpha_shapes_2 to work with periodic triangulations 2017-08-23 11:02:52 +02:00
Mael Rouxel-Labbé 68d3a3eabf Modified the way weird point types are handled when ExactAlphaComparisonTag=true 
Instead of requiring an implicit conversion, we require that Cartesian_converter
can convert from Traits::Point_23 to Exact_kernel::Point_23

Also it will not compile (static_assert) if this functor is not provided instead
of silently defaulting to ExactAlphaComparisingTag = false
 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 11786a7b90 Fixed minor mistakes from a rebase 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 5effdec42d Fixed starting template parameters with <:: 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé c9551ca1ab Fixed Point type in Alpha_Shapes_2 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé a220ce40d5 Made Alpha Shapes 2 output functions readable (no real changes) 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé 4f699efd8b Fixed inaccessible functions 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé 1b3a608b30 Fixed not getting Alpha shapes 2 predicates and constructions from Lazy alpha NT 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé 13cb5d5f05 Modified alpha_shapes_2's Vb and Fb to work with the Lazy_alpha_nt modifs 
from commit 1b75558
 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé b407526ebd Fixed Lazy_alpha_NT_2 
-- Aligned with the improvements that exist in Alpha_shapes_3
-- Actually define proper overloads for side_of_bounded_circle for weighted
   points (was broken)
-- Minor stuff
 2017-06-28 10:15:30 +02:00
Mael Rouxel-Labbé 3e25674957 Weighted alpha shape traits are not based on RT_euclidean_traits anymore 
Similarly to Regular_triangulation_euclidean_traits, the Kernel concept has now
absorbed all the functors that are needed by the alpha shape traits concept and
the weighted alpha shape traits can thus simply be empty shells.
 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé d7cd4e2955 Improved readability of Lazy_alpha_nt_2 (no real changes) 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé b31e954edc Fixed default constructed traits 2017-06-28 10:14:35 +02:00
Mael Rouxel-Labbé 9cd0f31d71 Temporarily silenced weighted alpha shape traits depreciation warnings 2017-05-16 10:28:09 +02:00
Mael Rouxel-Labbé cd2a562ffa Fixed improper guards against the inclusion of deprecated headers 2017-05-16 10:17:41 +02:00
Mael Rouxel-Labbé 13fa3efc65 Removed obsolete and unused include in Alpha_shapes_2, see bb086ff 
The fact that power_side_of_bounded_power_circle_2 was not in the kernel
and this include was not used means that weighted alpha shapes 2 are bugged
(they ignore weights and only call side_of_bounded_sphere()). This will be
fixed when implicit conversions are removed.
 2017-04-21 11:40:27 +02:00
Mael Rouxel-Labbé 046058fabe Removed Alpha_shape_2 obsolete include 
squared_radius_smallest_orthogonal_circle_2() is now a kernel functor
 2017-04-19 11:08:20 +02:00
Sébastien Loriot 50510c05ea add include directive for license of all GPL header files 
done using:
ack-grep "^GPL" */package_info/*/license.txt -l | awk -F "/" '{print $1}' > /tmp/gpl_packages
for i in `cat /tmp/gpl_packages | \
          grep -v Operations_on_polyhedra | \
          grep -v Algebraic_kernel_for_circles | \
          grep -v Algebraic_kernel_for_spheres | \
          grep -v Polyhedron_IO`;
do
  echo $i
  python Scripts/developer_scripts/add_license_in_pkg_header.py $i
done
python Scripts/developer_scripts/add_license_in_pkg_header.py Operations_on_polyhedra Polygon_mesh_processing
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_circles Circular_kernel_2
python Scripts/developer_scripts/add_license_in_pkg_header.py Algebraic_kernel_for_spheres Circular_kernel_3
python Scripts/developer_scripts/add_license_in_pkg_header.py Polyhedron_IO Polyhedron
 2017-01-19 15:20:25 +01:00
Jane Tournois f1f6819be1 use Kernel functors in weighted_alpha_shape_2 2016-11-03 14:53:54 +01:00
Andreas Fabri a2f37bd26a fix Alpha_shape_2 2016-11-03 13:08:31 +01:00
Andreas Fabri 9d567c4ee7 No need for Weighted_converter 2016-11-03 13:08:31 +01:00
Andreas Fabri 078afb18b3 Alpha_shapes_2 2015-12-31 16:19:26 +01:00
Andreas Fabri 1e2ff1131e assert -> CGAL_assertion 2015-08-27 16:51:55 +02:00
Andreas Fabri 6c547e5663 Mainly added includes 2013-09-13 22:24:30 +02:00
Marc Glisse 571f370e28 Rename Exact_type_selector to Exact_field_selector. 2012-12-24 12:20:13 +01:00
Philipp Möller 88a8731ebf locate is a dependent name and needs to be qualified to be found 2012-10-03 10:14:08 +00:00
Philipp Möller 79b30908d5 WARNFIX: Silence a good part of unused variable/parameter warnings. 
Wextra results in a dreadful wall of yellow in the test-suite and is
scary when using CGAL. Reduce some of the noise by silencing the
obvious cases with CGAL_USE or comments.
 2012-08-07 11:04:32 +00:00
Sébastien Loriot 7f6b7c9ff1 remove warnings on windows 2012-01-17 10:59:01 +00:00
Sébastien Loriot 27218c61e9 QPL -> GPL3 2012-01-16 15:56:52 +00:00
Sébastien Loriot a7456a2736 merge from next 2012-01-16 15:28:51 +00:00
Sébastien Loriot 4a31206e6e add constructor from triangulation 
see:
https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Alpha_cstr_from_tri
 2012-01-16 11:02:02 +00:00
Laurent Rineau 8f59fd9592 Turn QPL into LGPLv3+ 2012-01-13 16:33:35 +00:00
Sébastien Loriot 898c7f2d34 update copyright date 2011-12-30 14:38:06 +00:00
Sébastien Loriot 12c8aaf36a *add the ExactAlphaComparisonTag to the Alpha_shape_2 class 
*Update the documentation and fix at the same time few ambiguities
*test Projection_traits
 2011-12-30 13:37:08 +00:00
Sébastien Loriot de78155f99 BUG_FIX: remove unneeded useage of nested traits' type Ray 2011-10-03 06:27:06 +00:00
Sébastien Loriot 1c2852d004 BUGFIX: Avoid segfault when calling find_optimal_alpha with less that 3 points 2011-06-09 10:04:51 +00:00
Andreas Fabri 13ef2c35b2 Fix usage of BOOST_PREVENT_MACRO_SUBSTITUTION 2011-03-13 17:41:31 +00:00
Sébastien Loriot ca91793f1a forgot to update output functions after modifications of 
commit 57811 (change classification on the bound: the simplex is inside
the alpha-complex when alpha >= its squared_radius)
 2010-08-17 07:25:59 +00:00
Sébastien Loriot 5b66d3f57f comment unused private declaration of Line_face_circulator 2010-08-16 09:33:45 +00:00
Sébastien Loriot 8f413716fb change classification on the bound: the simplex is inside 
the alpha-complex when alpha >= its squared_radius.


this was the source of a bug in find_alpha_solid which cause a bug
in find_optimal_alpha

fix approved by Mariette.
 2010-08-05 12:49:32 +00:00
Andreas Fabri 7762ed8e02 Fixed scope of size_type 2010-06-24 07:06:03 +00:00
Andreas Fabri a0e4e186c5 int -> size_type 2010-06-23 14:05:40 +00:00
Andreas Fabri a3e7878606 int -> size_type/std::size_t 2010-06-21 14:54:45 +00:00
Sébastien Loriot 52317dd49f add python script (replace_CGAL_NAMESPACE.py) to replace CGAL_BEGIN_NAMESPACE and CGAL_END_NAMESPACE 
by namespace CGAL { and } //namespace CGAL. in all .h and .cpp files
in a directory.
Apply it to all packages in the trunk
Remove macro definition from the config.h file.
 2010-06-09 07:37:13 +00:00
Sébastien Loriot ec840a9cbf add missing Using detected by intel compiler 2010-04-26 08:20:17 +00:00