Commit Graph

349 Commits

Author SHA1 Message Date
Laurent Rineau 7e9f756935 Replace all std::unary_function by CGAL::unary_function 2017-10-04 15:57:09 +02:00
Mael Rouxel-Labbé b82814a24b Changed K::Has_[static/filtered]... to use Has_[static/filtered]_...<K> instead 2017-08-29 12:35:46 +02:00
Mael Rouxel-Labbé 3640902c6f Misc minor changes 2017-08-23 17:15:44 +02:00
Mael Rouxel-Labbé aaeaf35380 Introduced the tag "Periodic_tag" to mark distinguish periodic triangulations 2017-08-23 16:18:05 +02:00
Mael Rouxel-Labbé 84d11ac797 Fixed Offset definition in P3T3's static filtered predicates 2017-08-23 11:00:03 +02:00
Mael Rouxel-Labbé f6da2ed7dc Static filter must be templated by the traits, not the kernel 2017-08-23 10:59:40 +02:00
Mael Rouxel-Labbé 1cc8449b34 Fixed using Point's default constructor instead of the base's operator() 2017-08-23 10:59:18 +02:00
Mael Rouxel-Labbé af86bfca8b Renamed P3T3's offset-handling functors (added a _3 suffix) 2017-08-22 13:38:31 +02:00
Mael Rouxel-Labbé 06bfbfec6f Cleaned useless typedef/function in P3DT3
Those are now in the class P3T3
2017-07-31 15:30:58 +02:00
Mael Rouxel-Labbé a1c57031ba P3RT3 can now be used with Alpha Shapes 3 2017-07-31 12:52:22 +02:00
Mael Rouxel-Labbé 69167aef9a Move P3T3 off output to CGAL namespace 2017-07-31 12:52:21 +02:00
Andreas Fabri c533398777 Replace >5000 function calls with an array of that size 2017-07-11 15:20:25 +02:00
Mael Rouxel-Labbé ad6361e45f Added virtual destructors 2017-07-05 11:53:09 +02:00
Mael Rouxel-Labbé 81fd184ecd Misc minor changes 2017-07-04 16:44:18 +02:00
Mael Rouxel-Labbé f14bb1747b Merge branch 'Periodic_3_Regular_triangulation_3-APelle' of github.com:CGAL/cgal-public-dev into Periodic_3_Regular_triangulation_3-APelle 2017-07-04 14:32:22 +02:00
Mael Rouxel-Labbé 006bdb18f6 Fixed not using CGAL's function_property_map in P3RT3 2017-07-04 14:31:14 +02:00
Jane Tournois e9ef53f09e do not use an erased iterator 2017-07-04 14:28:11 +02:00
Mael Rouxel-Labbé 629f38e440 Fixed size_t / int conversion warning 2017-07-04 10:51:55 +02:00
Mael Rouxel-Labbé 0c8aa344dd Revert "Add 'visited_for_vertex_extractor' to the periodic TDS vertex base"
This reverts commit 0a5e3320d99327f649a39e97ebb5e12966afec0e.

Not sure what this commit was, might have been for P3M3 ? In any case, this is
not how it should be done...
2017-07-03 18:48:28 +02:00
Mael Rouxel-Labbé 2ae3eaae17 Fixed P3T3's number_of_finite_edges() 2017-07-03 16:26:41 +02:00
Mael Rouxel-Labbé 3c42724e22 Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
Based on Kernel_Weighted_point_without...
  @ 41e7520b3e
2017-06-15 15:07:53 +02:00
Mael Rouxel-Labbé 98800d2de8 Fixed regular triangulation capitalization across CGAL 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 2dbee09cab Periodic_3 construct point 3 needs access to its base operator() 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé 1192f2eba1 Periodic_3 remove traits must overwrite construct_point_3() 2017-06-15 10:34:15 +02:00
Mael Rouxel-Labbé b3f5820ac9 Added default parameter to the P3T3 constructor
Existed long back ago, documented, were removed for seemingly no reason
2017-06-01 12:26:19 +02:00
Mael Rouxel-Labbé d88a736790 Fixed a comment 2017-06-01 11:41:06 +02:00
Mael Rouxel-Labbé 487d773257 Moved comment
since it does not apply to the function `point(periodic_point)`
2017-05-30 16:55:40 +02:00
Mael Rouxel-Labbé 178630064b Alphabetical re-ordering of "using::" 2017-05-30 11:44:22 +02:00
Mael Rouxel-Labbé c2279248e1 Changed protected -> public
Giving public access to traits wrappers is not a problem
2017-05-30 11:07:13 +02:00
Mael Rouxel-Labbé 1ebc537874 Improved readability of periodic triangulations
(only cosmetic changes)
2017-05-30 10:41:56 +02:00
Mael Rouxel-Labbé 96867f416e Dropped a useless "public:" 2017-05-30 10:09:22 +02:00
Mael Rouxel-Labbé 284921e2dd Renamed construct_periodic_3_object to construct_periodic_object
Just for consistency
2017-05-30 10:07:35 +02:00
Mael Rouxel-Labbé cc7a826efb Added default offset parameter to construct_periodic_3_segment() 2017-05-30 10:05:44 +02:00
Mael Rouxel-Labbé 91a771acbe Added some comments 2017-05-30 10:05:27 +02:00
Mael Rouxel-Labbé bf1853aabd Reworked the point() functions of periodic triangulations
Commit f554c062e39978fd8c0f15ba6a6d90597b36d768 fixed a lot of stuff
but point() functions were still a bit messy.

Now, ALL `point()` functions return a canonical point. If one wants to
get the "real" point in the complete space, one should use v->point()

point() must be the canonical point and not the real point since we
will pass P3T3 to other packages (Mesh_3/Alpha_shapes_3) that will
use tr.point(v) and expect the canonical point.

Might be worth to introduce a function "real_point()" to return v->point()
2017-05-30 09:59:09 +02:00
Mael Rouxel-Labbé 2c298448b6 Removed useless variables 2017-05-30 09:56:18 +02:00
Mael Rouxel-Labbé a88f72fe4e Moved a function
to be with similar traits functions
2017-05-30 09:43:43 +02:00
Mael Rouxel-Labbé b5006fda88 Revert "Changed some v->point() to tr.point(v)"
This reverts commit c373227616bed00f97115d5cab14ede38f3b5223.

tr.point() will now be a canonical point (a point in the base domain)
while here we do not want to have a canonical point
2017-05-29 16:20:10 +02:00
Mael Rouxel-Labbé d50022813b Clarified comment 2017-05-29 16:06:50 +02:00
Mael Rouxel-Labbé aab9c237e7 Removed duplicate "using function()" 2017-05-24 12:24:50 +02:00
Mael Rouxel-Labbé 5354134469 Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle 2017-05-24 12:18:49 +02:00
Mael Rouxel-Labbé c37731b1de Periodic_3 construct point 3 needs access to its base operator() 2017-05-22 11:27:02 +02:00
Mael Rouxel-Labbé 10a9348124 Periodic_3 remove traits must overwrite construct_point_3() 2017-05-22 11:27:02 +02:00
Mael Rouxel-Labbé 878cb53f04 Simplified inexact_orientation 2017-05-16 14:41:41 +02:00
Mael Rouxel-Labbé 30c1ac60bb Changed some v->point() to tr.point(v) 2017-05-16 11:24:40 +02:00
Mael Rouxel-Labbé 94fc29291d Fixed trying to access cell's hidden_points in P3T3
Only regular triangulation cells have the hidden_points member
2017-05-16 11:23:11 +02:00
Mael Rouxel-Labbé 33956eaff1 Re-organized P3 triangulations constructors 2017-05-16 11:20:30 +02:00
Mael Rouxel-Labbé 650e257f2d Moved Periodic_3_construct_(weighted_)point_3 to /internal
and small modifications
2017-05-16 11:12:23 +02:00
Mael Rouxel-Labbé 0b5ef494ce Periodic_3 traits v3.0
Version 2.0 was commit: 5b8b5c21ec18c878a93be2fca95f9c9dafd58ac6

Short version:
Made it work without point/weighted_point implicit conversions
and made it more generic by reworking the inheritance of adaptors and providing
appropriate constructors

Long version:
-- Reworked P3_construct_point_3 and P3_construct_weighted_point_3 to inherit
a base Construct_point_3 and initialize it properly at construction.

-- Renamed Traits_with_offset / Regular_traits_with_offset adaptors. These
classes now inherit the base functor and the constructors allow to initialize
that base from an existing functor (meaning that we don't default constructor
functors anymore). This also means that we can use the base operator() of the
functors and can thus use all possible inputs (with or without offsets).

-- Static filters now probably inherit the correct *_filtered_traits_base_3.

-- All traits classes now have constructor to be able to initialize traits
from a given domain and a given base kernel (rather than default construct)

-- Fixed Del/regular_remove_traits inherting the wrong classes

-- Filtered traits have exact and approximate traits rather than exact and
approximate domains with default constructed traits

One problem is left:
Filtered traits members are initialized with a default constructed base kernel.
Ideally, it should use Cartesian_converter(Base::kernel()), but this does not
exist...
2017-05-16 10:55:01 +02:00
Mael Rouxel-Labbé e72e8db2a2 Fixed some includes 2017-05-15 17:51:37 +02:00