Laurent Rineau
5457a6a30b
Merge pull request #3857 from MaelRL/CGAL-Fix_duplicate_non_manifold_vertices-GF
...
PMP: Fix duplicate_non_manifold_vertices() with pinched vertices
2019-05-14 16:18:40 +02:00
Laurent Rineau
8e872081fc
Merge pull request #3898 from lrineau/Mesh_3-stop_during_protection-lrineau
...
Mesh_3 `Protect_edges_sizing_field`: handle the `stop` Boolean
# Conflicts:
# .travis/build_package.sh
# Installation/cmake/modules/CGALConfig_binary.cmake.in
# Installation/cmake/modules/CGALConfig_install.cmake.in
# Installation/cmake/modules/CGAL_SetupCGAL_CoreDependencies.cmake
# Installation/lib/cmake/CGAL/CGALConfig.cmake
# Polygon_mesh_processing/include/CGAL/Polygon_mesh_slicer.h
# Polyhedron/demo/Polyhedron/Plugins/Classification/CMakeLists.txt
# Polyhedron/demo/Polyhedron/Plugins/Mesh_3/CMakeLists.txt
2019-05-14 16:18:24 +02:00
Mael Rouxel-Labbé
3e386c9de6
Fix naming consistency
2019-05-14 08:25:13 +02:00
Mael Rouxel-Labbé
ba46772096
Minor comment change
2019-05-14 08:17:45 +02:00
Mael Rouxel-Labbé
ab137195c6
Fix overly naive swap algorithm in duplicate polygon removal
2019-05-14 08:16:29 +02:00
Mael Rouxel-Labbé
09b1ea231f
Fix polygons-to-be-erased ID swapping
...
Bugged approach would swap away from the polygons-to-be-erased area at the end
of the container
2019-05-13 13:11:47 +02:00
Mael Rouxel-Labbé
eae6a294c7
Fix unused point IDs swapping
...
Bugged approach would swap away from the to-be-erased zones at the back
of the vector
2019-05-13 13:10:27 +02:00
Sébastien Loriot
c49f173d83
polyline orientation depend on supporting mesh
2019-05-08 10:13:40 +02:00
Maxime Gimeno
cfea874cc1
take the right vectors
2019-05-07 11:24:30 +02:00
Maxime Gimeno
962bac73b2
don't test if not closed
2019-05-07 11:12:59 +02:00
Maxime Gimeno
a059b7aa38
don't touch polylines <=2 points
2019-05-07 10:52:18 +02:00
Maxime Gimeno
29ba7a8992
check that there are at least 2 points in the polyline before testing
2019-05-07 10:19:44 +02:00
Maxime Gimeno
fe675e87b1
Fix test and update doc.
2019-05-07 09:58:27 +02:00
Maxime Gimeno
0105eefe45
Add a test to detect if the result of the slicer is cw oriented when seen from the positive side of the slice-plane. If it is, reverse the orientation. Add assertions in the test.
2019-05-07 09:40:47 +02:00
Sébastien Loriot
6e31445f62
fix the prev/next pointers after polyline removal
2019-04-30 15:09:36 +02:00
Mael Rouxel-Labbé
c21a47d329
Change some unordered sets to dynamic pmaps in non-manifold related functions
2019-04-30 08:54:13 +02:00
Sébastien Loriot
c14ef91134
add missing include directive
2019-04-26 11:28:05 +02:00
Sebastien Loriot
0a19fa0690
Merge pull request #3827 from sloriot/BGL_PMP-reserve_call_before_copy
...
Add calls to reserve before creating meshes
2019-04-23 09:44:31 +02:00
Sebastien Loriot
fdc8d79a69
Merge pull request #3843 from sloriot/PMP-speed_orient_soup
...
Speed-up polygon soup orientation
2019-04-23 09:43:55 +02:00
Mael Rouxel-Labbé
10080d8142
Fixed duplicate non manifold vertices for pinched vertices
2019-04-17 16:04:21 +02:00
albert-github
1dd7473818
Correction of links
...
Correction of redirected links and links that moved to another place.
2019-04-11 21:37:05 +02:00
Sébastien Loriot
bd955e57d3
fix conversion warnings
2019-04-10 14:28:35 +02:00
Sébastien Loriot
028fcd7b34
add missing include directive
2019-04-10 11:06:26 +02:00
Sébastien Loriot
07d1601ec9
remove useless (and harmful for the new method) call to clear
2019-04-05 12:17:17 +02:00
Sébastien Loriot
f972d0a228
init edge map for is_polygon_mesh_a_polygon_soup
2019-04-05 11:40:47 +02:00
Sébastien Loriot
49f1d2ba1b
replace the edge map by a vector of flat_map
...
it is very efficient since there should not be isolated vertices.
On large data, the runtime of the function is divided by 3 to 4
2019-04-05 11:12:01 +02:00
Sébastien Loriot
9c39f2260f
add calls to reserve before creating meshes
2019-04-02 21:54:30 +02:00
Laurent Rineau
14e93b7fe2
Merge pull request #3794 from maxGimeno/Demo-Fix_off_reading-GF
...
PMP: Fix in normalize()
2019-03-26 17:01:53 +01:00
Laurent Rineau
4ec173c0e7
Merge pull request #3793 from maxGimeno/Fixes_for_warnings-GF
...
Fixes for warnings
2019-03-26 16:43:56 +01:00
Maxime Gimeno
a508397a58
Don't use ternary operator
2019-03-25 16:06:20 +01:00
Maxime Gimeno
24d5971372
Test that norm != 0 in normalize()
2019-03-25 15:44:20 +01:00
Laurent Rineau
1014687627
Merge pull request #3775 from MaelRL/Doc_fixes-GF
...
Doc fixes
2019-03-25 12:24:49 +01:00
Maxime Gimeno
801eb23ca3
Fix uninit warning in PMP
2019-03-25 12:09:04 +01:00
Laurent Rineau
2863e74fb5
Merge pull request #3735 from janetournois/PMP-fix_isotropic_remeshing_with_tiny_constraints-jtournois
...
PMP : fix isotropic remeshing surviving tiny constraints
2019-03-19 18:30:57 +01:00
Mael Rouxel-Labbé
a990164993
Fixed missing backtick
2019-03-15 20:50:24 +01:00
Mael Rouxel-Labbé
6f13a63978
Rephrase intersection doc for clarity
2019-03-15 20:24:50 +01:00
Jane Tournois
d137b20acd
add checking if (s, p, q) is degenerate
2019-03-12 14:04:36 +01:00
Jane Tournois
0de369dd02
add debug code
2019-03-12 12:17:11 +01:00
Jane Tournois
c64bfb8e86
do not construct normals to make the test
2019-03-11 15:18:01 +01:00
Jane Tournois
9cbb6f3785
test inversion only on faces that really need to be tested
...
and rename function collapse_does_not_invert_face(he) to
collapse_would_invert_face(he) for clarity
2019-03-08 16:22:17 +00:00
Jane Tournois
6f12a4ab6f
fix the test ``collapse_does_not_invert_face()`
...
Testing orientation of normals per patch (identified by their Id) is not a
good solution, because it can happen that we are trying to collapse an edge
that is sharp but which has both of its incident faces on the same surface
patch (wrt ids).
The new test is a lot simpler : for each non-degenerate face of the link of
the edge to be collapsed, simply check if its own normal has changed
orientation or not. The adjacent faces do not need to be taken into account
2019-03-08 16:19:31 +00:00
Jane Tournois
664de7e32e
use the new API of `PMP::remove_degenerate_faces()`
...
If there is no degenerate faces to deal with, i.e. if the function
has nothing to do, it now returns `true`, and not `0` anymore.
This change was introduced by commit e4ad5d96a7
2019-03-07 11:22:41 +01:00
Sébastien Loriot
9040b59cb8
workaround a case when the intersection polyline is not split
...
the polyline goes from border to interior but the node is
of degree 2 and the polyline is not split
***************
* *
* *
* *
-*---------*-*---
| * * |
| * * |
| ************* |
| |
| |
| |
|_________________|
2019-03-01 18:06:54 +01:00
Sébastien Loriot
a83dac3826
handle non-manifold vertices is patches to be removed
...
because they are duplicated in interior_vertices
2019-03-01 18:06:08 +01:00
Sébastien Loriot
0f078003c2
also handle non-manifold vertices at isolated nodes
2019-03-01 15:55:16 +01:00
Sébastien Loriot
ff01ed7a5f
better handling of border non-manifold vertices for the clipping
2019-03-01 14:20:29 +01:00
Laurent Rineau
9f9ae00369
Merge remote-tracking branch 'cgal/releases/CGAL-4.13-branch'
2019-02-22 16:39:48 +01:00
Mael Rouxel-Labbé
c3ace2b72c
Fixed VPM / Geom traits not propertly passed / used in triangulate_faces
2019-02-21 14:44:16 +01:00
Laurent Rineau
fdd8357915
Merge pull request #3580 from afabri/Stream_support-Color-GF
...
Fix warnings (Add/remove copy constructors, and other warnings)
Co-authored-by: Laurent Rineau <laurent.rineau@cgal.org>
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
Co-authored-by: Maxime GIMENO <maxime.gimeno@gmail.com>
2019-02-13 15:25:07 +00:00
Sébastien Loriot
7db3d2604b
use only initialized values
2019-02-08 11:05:12 +01:00
Laurent Rineau
8d12ec9b9c
Merge pull request #3637 from sloriot/PMP-doc_bug_fix
...
fix wrong ref
2019-02-07 13:31:07 +01:00
Sébastien Loriot
6c6244d9b8
Merge pull request #3516 from maxGimeno/Demo-fixes-GF
...
Polyhedron Demo: Fixes.
2019-01-31 11:41:58 +01:00
Sébastien Loriot
02de899d26
fix wrong ref
2019-01-28 15:17:58 +01:00
Laurent Rineau
afc3de2894
Merge branch 'master' into Stream_support-Color-GF
2019-01-23 09:37:08 +01:00
Laurent Rineau
1ca9dbc514
Merge pull request #3596 from maxGimeno/PMP-Make_do_intersect_faster-GF
...
PMP:: speed up PMP::do_intersect()
Co-authored-by: Sebastien Loriot <sebastien.loriot@cgal.org>
2019-01-22 10:49:59 +01:00
Laurent Rineau
28e520b121
Merge pull request #3594 from sloriot/PMP-remove_null_edges_on_border
...
Null edges removal fix on the border
2019-01-22 09:15:08 +01:00
Laurent Rineau
6ffd76a87e
Merge pull request #2792 from afabri/Intersections_3-Add_missing_do_intersect-GF
...
Intersections_3: Add missing do_intersect() overloads
2019-01-18 16:37:54 +01:00
Andreas Fabri
6596ba981c
Polygon, Surface_mesher, Nef,..
2019-01-17 19:35:02 +01:00
Sébastien Loriot
4e308223ad
handle non-manifold vertices in a selection + duplicate them prior if allowed
2019-01-17 18:06:25 +01:00
Sébastien Loriot
651c31a179
in case there is a non-manifold vertex, we cannot update the selection
2019-01-17 13:48:30 +01:00
Sébastien Loriot
99bd8c7172
handle non monotonic border while removing a zone of degenerate faces
2019-01-16 18:15:51 +01:00
Sébastien Loriot
ef5fe7ffac
handle polygon attached by non-manifold vertices
2019-01-16 15:26:06 +01:00
Sébastien Loriot
e0184766d2
ignore topological issues instead of crashing
2019-01-16 10:13:16 +01:00
Sébastien Loriot
785d0deb46
add missing return
2019-01-16 10:11:43 +01:00
Sébastien Loriot
656a5a316a
fix compilation error + indent + simplify
2019-01-14 17:45:09 +01:00
Sébastien Loriot
3edad4c820
do not use what you deleted
2019-01-14 17:34:43 +01:00
Maxime Gimeno
8ab7e69a5c
Test global bbox intersection before creating all bboxes.
2019-01-14 16:03:23 +01:00
Maxime Gimeno
79199281e6
Merge remote-tracking branch 'cgal/master' into Demo-fixes-GF
2019-01-14 09:52:13 +01:00
Sébastien Loriot
68f6a77d63
use dedicated code for removing null border edges + fix that code
2019-01-14 09:12:54 +01:00
Sébastien Loriot
551be55235
Merge remote-tracking branch 'cgal/releases/CGAL-4.13-branch'
2018-12-31 10:29:57 +01:00
Sébastien Loriot
1be277202b
Merge remote-tracking branch 'cgal/releases/CGAL-4.12-branch' into HEAD
2018-12-31 10:29:19 +01:00
Sebastien Loriot
e828d7a29d
Merge pull request #3558 from sloriot/PMP-bbox_empty_meshZ
...
Handle empty meshes
2018-12-31 10:22:42 +01:00
Sébastien Loriot
fe5c3a77f9
swap the edge too
2018-12-21 09:51:58 +01:00
Laurent Rineau
698c13d973
Merge pull request #3500 from sloriot/PMP-stitching_nm_bug-4.13
...
Fix for stitching (4.13 and master)
2018-12-19 16:12:01 +01:00
Laurent Rineau
2583258973
Merge pull request #3530 from sloriot/PMP-coref_empty_meshes-4.13
...
Handle case of empty meshes (4.13+)
2018-12-19 16:06:58 +01:00
Sébastien Loriot
0f0f03e08b
handle empty meshes
2018-12-19 16:05:08 +01:00
Laurent Rineau
a82bb996ae
Merge pull request #3500 from sloriot/PMP-stitching_nm_bug-4.13
...
Fix for stitching (4.13 and master)
2018-12-19 16:00:24 +01:00
Laurent Rineau
b53a562e89
Merge pull request #3499 from sloriot/PMP-stitching_nm_bug
...
Fix for stitching (4.12)
2018-12-19 15:44:45 +01:00
Maxime Gimeno
ca4a568fa7
Fix Remove Degenerated Faces
2018-12-11 16:16:50 +01:00
Sébastien Loriot
fa52560c62
handle case of empty meshes
2018-12-11 07:02:06 +01:00
Sébastien Loriot
8da9e7ceec
handle case of empty meshes
2018-12-11 06:44:27 +01:00
Laurent Rineau
8070b01a22
Merge pull request #3472 from sloriot/PMP-fix_clip_on_border
...
Fix clipping on border edges
2018-12-10 14:38:26 +01:00
Sébastien Loriot
3069612c37
two halfedges with the same target and source points are non-manifold
...
similar as 44addb1 from 4.12-branch
2018-11-30 10:01:01 +01:00
Sébastien Loriot
44addb1f83
two halfedges with the same target and source points are non-manifold
2018-11-30 09:56:33 +01:00
Sébastien Loriot
ae9659539e
simplify type
2018-11-22 16:58:13 +01:00
Sébastien Loriot
78e375f15c
add a special handling for degenerate faces on the border
2018-11-22 16:14:18 +01:00
Sébastien Loriot
293f54dc25
no need to consider polylines to skip
...
they are not really used in remove_used_polylines
and a polyline might be written as to skip while
only a portion is (if the dangling part is the
one edge per polyline)
2018-11-22 14:08:20 +01:00
Sébastien Loriot
f070af9a70
workaround when interseciont polyline goes to the border
2018-11-22 13:38:31 +01:00
Sébastien Loriot
0ecbdbea4b
handle case when clipping plane hit an extended bbox corner
2018-11-20 13:10:14 +01:00
Sébastien Loriot
7d19fe6940
be more robust in case of tangency
2018-11-20 10:50:32 +01:00
Sébastien Loriot
0c33bf461f
register vertex -> node_id upon creation
...
The former method relied on intersection edges
which did not have isolated vertices
2018-11-20 10:41:37 +01:00
Sébastien Loriot
6f5ba0ddfa
handle clipping with clipper on border edge
2018-11-19 14:26:05 +01:00
Sébastien Loriot
54381db68a
fix -Wmaybe-uninitialized warnings
2018-11-12 19:27:53 +01:00
Sébastien Loriot
018652517b
Merge remote-tracking branch 'cgal/releases/CGAL-4.13-branch'
2018-11-12 10:08:29 +01:00
Sébastien Loriot
089377d238
Merge remote-tracking branch 'cgal/releases/CGAL-4.12-branch' into HEAD
2018-11-12 10:07:27 +01:00
Sébastien Loriot
65f386b7a3
use the vertex point map provided and not the default one
2018-11-08 14:23:28 +01:00
Sébastien Loriot
3e46680513
use the true name parameter type
2018-11-08 14:22:59 +01:00
Sébastien Loriot
a51a153c31
fix when bbox has a 0-width + update testsuite
2018-11-06 10:56:04 +01:00
Sébastien Loriot
8a27676102
handle case of a non closed intersection polyline
2018-11-06 10:27:30 +01:00
Sébastien Loriot
6b8a36ba0c
update clipping code for surface case and use Face_graph_output_builder
...
This fixes a bug when a patch with no input vertex must be
classified wrt the clipper
2018-11-05 16:26:33 +01:00