songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
106,175 Commits 3 Branches 156 Tags 974 MiB
Commit Graph

137 Commits

Author SHA1 Message Date
Sébastien Loriot 6383bf9676 revert changes to not block the integration of new Orthtree 2023-11-07 08:35:37 +01:00
JacksonCampolattaro e39ca2aef8 Replace more `boost::tie`s with structured bindings 2023-09-24 18:08:35 +02:00
JacksonCampolattaro 37d60b4ac6 Replace pointer with std::optional 
This is not an ideal solution, but the Scene_points class has bigger issues.
 2023-09-16 15:37:15 +02:00
Sébastien Loriot da33014535 Merge remote-tracking branch 'cgal/master' 2023-09-14 09:07:00 +02:00
Sébastien Loriot 28dc304676 Merge branch 'cgal/master' 2023-09-01 13:03:05 +02:00
JacksonCampolattaro 2d8f7d483d Rename Properties.h for clarity 2023-08-30 15:32:38 +02:00
JacksonCampolattaro 50006c97b4 Fix an issue with file loading where adding normals would cause additional points to be created 2023-07-26 11:04:03 +02:00
albert-github e4dff1ffaf issue #7395 Improvement of layout of model relations 
Corrections after review.
 2023-07-21 11:41:27 +02:00
albert-github 301728a8a9 issue #7395 Improvement of layout of model relations 
- Completed the cgalModels part
 2023-07-09 12:43:36 +02:00
JacksonCampolattaro 9050fab7cb Add a tiny unit test for point insertion & reservation, and fix the bug it catches 2023-06-20 10:41:13 +02:00
JacksonCampolattaro 8b72b0a6b0 Add a couple of simple copy tests, and ensure they pass 2023-06-16 10:45:55 +02:00
JacksonCampolattaro 9bf32ef785 Push_property_map & Property_back_inserter use references instead of pointers 2023-06-07 13:58:17 +02:00
JacksonCampolattaro 497014022e Fix join() behavior; mark all indices as active instead of inactive 2023-06-07 11:26:09 +02:00
JacksonCampolattaro 82dd686f4b Adapted Point_set_3 to use the new property system 
Garbage management is still done by the point set
 2023-06-06 21:44:37 +02:00
Sébastien Loriot fc034c6a5d boost::unit -> std::uint 2023-04-23 18:40:39 +02:00
Sébastien Loriot 9242a810c4 Merge remote-tracking branch 'cgal/master' into Region_growing-revision-soesau 2023-02-07 11:31:55 +01:00
Sébastien Loriot 464f5a0d46 remove extra cond 2023-01-31 10:49:33 +01:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Sébastien Loriot d3b13fb11c Merge branch 'cgal/5.5.x-branch' 2022-12-05 19:00:39 +01:00
Sébastien Loriot 0fb05d1480 fix warning 2022-11-15 20:04:23 +01:00
albert-github eed54a0ae5 spelling corrections 
Some spelling corrections (Directories starting with `O`-`S` , first part),
some backward work
some forward work
 2022-11-15 18:45:39 +01:00
Jane Tournois 38fd07dfc4 differentiate has_normal_map() between const and non-const point set 2022-11-08 10:24:43 +01:00
Jane Tournois 826b2a19c4 Merge branch 'PSP-fix_has_normal_map-GF' of https://github.com/janetournois/cgal into PSP-fix_has_normal_map-GF 2022-11-07 13:15:55 +00:00
Jane Tournois 32486e4be8 precise default normal 2022-11-07 14:14:30 +01:00
Jane Tournois a24c6ac84c
Apply suggestions from Mael's code review 
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
 2022-11-07 14:13:18 +01:00
Sebastien Loriot 1a226ed877
Restore [revious API 2022-11-07 10:41:22 +01:00
Jane Tournois 9ed334bcf9 now normal_map is always valid 
since it is created before it's used, when not available
 2022-11-04 14:27:09 +01:00
Jane Tournois dcf0ea09b3 create normal_map when not already created before usage 2022-11-04 14:12:52 +01:00
Jane Tournois 0ee5493f02 revert unintended change 2022-10-25 12:53:39 +02:00
Jane Tournois e99f442830 NP_helper::has_normal_map should not always return true 
look for a normal_map in the point set, and in the named parameters

# Conflicts:
#	BGL/include/CGAL/boost/graph/named_params_helper.h
#	Point_set_processing_3/include/CGAL/jet_estimate_normals.h
 2022-10-25 12:12:29 +02:00
Andreas Fabri 1c28b3df45 Point_set_3: Fix typos in the reference manual page 2022-10-24 15:15:50 +01:00
Sven Oesau 17e0923058
Merge branch 'master' into Region_growing-revision-soesau 2022-06-24 11:06:56 +02:00
Sven Oesau 7bb0a10027 fixed friend class declaration 2022-06-09 14:27:47 +02:00
Sven Oesau 0baac6f556 bugfix Point_set_3_index is now hashable 
moved Index out of Point_set_3
 2022-06-09 10:33:02 +02:00
Sébastien Loriot 6691e13f36 fix partial specialization 
follow up of 594d8bf38e
 2022-05-23 13:50:11 +02:00
Sébastien Loriot 594d8bf38e remove tag that is not used and add a way to pass default Point and Normal maps 2022-05-18 15:23:23 +02:00
Mael Rouxel-Labbé b24959c688 Add a typedef to make NP helpers work with Point_set_3 2022-04-04 11:33:27 +02:00
Andreas Fabri 440a8dfb7b Fix file name 2022-02-03 08:41:04 +00:00
Andreas Fabri 735752bec9 Do the remaining changes after Laurent's check 2022-02-03 08:02:11 +00:00
Sébastien Loriot 6d3176e061 move Named_parameters class in STL_extension 
helpers stay in BGL because it depends on BGL tags
 2022-01-07 15:12:22 +01:00
Sébastien Loriot f7c8e4919a add static function to check for the presence of a normal map 2022-01-07 13:10:29 +01:00
Sébastien Loriot 5f1803489b replaces overloads with default NamedParameters for Point_set_processing_3 
+enhancement of the NP for Point_set_processing_3
 2022-01-06 15:11:23 +01:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps: 
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
 2021-10-08 15:38:47 +02:00
Laurent Rineau 412881645c Merge pull request #5369 from sgiraudot/Point_set_3-Fix_broken_properties_and_types-GF 
[Point Set 3] Fix broken properties and types
 2021-02-18 15:23:28 +01:00
Simon Giraudot d257d999fb Fix function properties_and_types() 2021-01-18 15:49:55 +01:00
Mael Rouxel-Labbé 0d66e19361 IO documentation fixes 
See @sloriot's review:

https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Polgyon_soup_mesh_IO/2nd_round/Answer_to_review

(+ some commits before and after this one)
 2020-07-24 17:06:00 +02:00
Mael Rouxel-Labbé 26355e2e32 Uniformize capital / third person usage of \brief 2020-06-25 15:13:47 +02:00
Mael Rouxel-Labbé e09eb39a80 Misc cleaning 2020-06-21 11:39:14 +02:00
Mael Rouxel-Labbé 07017616ec Organize Point_set_3 I/O + various fixes along the way 2020-06-19 15:34:49 +02:00