songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
110,723 Commits 3 Branches 156 Tags 973 MiB
Commit Graph

3068 Commits

Author SHA1 Message Date
Sebastien Loriot 166681a6ce
Periodic_3_mesh_3: Avoid Making Copies (#8639) 
## Summary of Changes

Turn several copies into `const&` to avoid allocation of data members of
traits object with multiprecision coordinates. In release mode the gain
is around 10%..

To address the timeouts in the testsuite in Debug mode, I also changed
cell size and approximation error.

## Release Management

* Affected package(s): Periodic_triangulation_3_mesh_3
* License and copyright ownership: unchanged
 2024-12-10 16:24:25 +01:00
Andreas Fabri e9775789e5
Apply suggestions from code review 
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
 2024-12-06 14:49:33 +01:00
Sébastien Loriot caf716cf47 Merge remote-tracking branch 'cgal/6.0.x-branch' in master 2024-12-06 09:58:43 +01:00
Andreas Fabri fc0f1977f6 Add a const& 2024-12-03 08:27:37 +00:00
Jane Tournois 47e575b779 remove extra "else" 2024-11-29 10:33:11 +01:00
Andreas Fabri 0261184dee WIP 2024-11-28 14:31:01 +00:00
Jane Tournois 7e1f24e5fb when sizing field is smaller than min_size, return min_size! 2024-11-26 18:08:10 +01:00
Sébastien Loriot 0833af4680 Merge remote-tracking branch 'cgal/master' into HEAD 2024-10-22 08:21:55 +02:00
Sébastien Loriot a99dcceae8 Merge pull request #8519 from albert-github/feature/issue_8515_1 
issue #8515 Spelling mistakes found checking `en-GB` to `en-US`
 2024-10-14 09:42:14 +02:00
albert-github dd02af92a2 issue #8515 Spelling mistakes found checking `en-GB` to `en-US` 
Spelling corrections, `en-GB` -> `en-US`
 2024-10-05 11:28:29 +02:00
Andreas Fabri 5fe32284af Typo: labelled is UK English 2024-10-03 11:23:23 +01:00
Jane Tournois 93fd7f87c7 vertices(edge) is not available in P3T3 2024-08-20 10:58:38 +02:00
Jane Tournois 4a35823f1f ease dump code reading 2024-08-19 12:24:59 +02:00
Jane Tournois 481de41e2f use c++11 for loops 2024-08-19 12:24:32 +02:00
Jane Tournois 14a9db6d00 weight_modifier was likely to make the weight too small 
let's keep the minimal weight as given in meshing criteria
 2024-08-19 12:23:32 +02:00
Jane Tournois fd498e398a fix approx_is_too_large(edge) that needs the corresponding curve_index to be valid 
use minimal_size instead of 0

fix 5e64bced8e37ce076f26317e9ea7638a14c9696c

fix approx_is_too_large(edge) that needs the corresponding curve_index to be valid

and fix the default edge_min_size
 2024-08-12 12:37:03 +01:00
Jane Tournois 0bc3658893 use the 5 parameters version to avoid re-calling locate(p) and locate(q) 2024-08-08 15:28:09 +02:00
Jane Tournois f8de6e72b8 take min_size into account inside Mesh_edge_criteria_3 2024-08-08 15:26:59 +02:00
Jane Tournois 5d814aee2a remove ref (can become invalid) 2024-06-25 15:16:07 +02:00
Laurent Rineau 6f4b598b6a Merge pull request #8278 from albert-github/feature/bug_spell_20240511 
Spelling correction
 2024-06-13 12:48:43 +02:00
Laurent Rineau d5aa8b1a44 Merge pull request #8268 from janetournois/Mesh_3-fix_concept-jtournois 
Mesh_3 - fix concept `MeshFacetCriteria_3`
 2024-06-12 10:06:08 +02:00
albert-github c35a0a7f11 Spelling correction 
Spelling correction due to updated dictionary.
(dictionary was updated after the previous spelling correction :-( )
 2024-06-11 10:12:12 +02:00
Laurent Rineau 5b003a7808 Merge pull request #8246 from albert-github/feature/bug_spell_20240531 
Spelling corrections
 2024-06-10 18:47:22 +02:00
Jane Tournois 8d6d934395 convert tuple to struct for Facets_erase_counters 2024-06-10 15:52:09 +02:00
Jane Tournois accfc2aa31 convert tuple to struct for Move 2024-06-10 15:51:31 +02:00
Jane Tournois 8e39809c58 remove more tuples 2024-06-07 17:38:02 +02:00
Jane Tournois 7be4da73a3 remove useless tuple 2024-06-07 17:37:34 +02:00
Jane Tournois 986b596d10 Merge remote-tracking branch 'cgal/master' into Mesh_3-avoid_tuples-jtournois 
# Conflicts:
#	Mesh_3/include/CGAL/Mesh_3/Refine_facets_3.h
 2024-06-07 15:48:31 +02:00
Jane Tournois 4d486527d2 fix doc 2024-06-07 15:18:57 +02:00
Jane Tournois 3cf86606d8 avoid compiler warning 2024-06-04 08:55:48 +02:00
Jane Tournois bb0c3f22f6 use typedefs 2024-06-04 08:52:08 +02:00
Laurent Rineau 212c6bc5ce Merge pull request #8241 from lrineau/Mesh_3-add_a_scope_after_if-GF 
Mesh_3: add a scope after if(...)
 2024-06-03 17:40:24 +02:00
Jane Tournois b2a679ee78 typedefs 2024-05-31 19:05:38 +02:00
albert-github 36c8b7589d Spelling corrections 
Last batch (for now) of spelling corrections in doxygen and normal comments
 2024-05-31 19:05:34 +02:00
Jane Tournois 5b1a406dcc use c++17 to simplify code 2024-05-31 09:38:20 +02:00
Jane Tournois fe6e71724b replace tuple with struct to improve readability 2024-05-30 15:33:29 +01:00
Jane Tournois c0f53c4a3e avoid using the get<i>(tuple) API, hardly readable 2024-05-30 15:33:22 +01:00
Laurent Rineau c538ff16c2 Mesh_3: add a scope after if(...) 2024-05-30 15:24:19 +02:00
Mael Rouxel-Labbé 4ba0ec0421 Merge remote-tracking branch 'cgal/master' into Mesh_3-update_benchmark-jtournois 2024-05-29 12:57:39 +02:00
Sebastien Loriot d06a57a292
Mesh_3 edge_distance criterion : an upper bound for the distances of the feature edge to the input feature (#7532) 
## Summary of Changes

Fixes issue #5110.
Adds a edge_distance criteria to the mesh generation process.
This criteria is an upper bound for the distance from the edge to the 1D
feature.

## Release Management

* Affected package(s): Mesh_3
* Issue(s) solved (if any): fix #5110
* Link to small feature page :
[Mesh_3_edge_distance_criteria](https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Mesh_3_edge_distance_criteria)
* Link to compiled documentation
[*here*](https://cgal.github.io/7532/v1/Manual/index.html):
*
[Mesh_edge_criteria_3](https://cgal.github.io/7532/v1/Mesh_3/classCGAL_1_1Mesh__edge__criteria__3.html)
  * [Mesh_criteria_3](https://cgal.github.io/7532/v1/Mesh_3)
 2024-05-27 10:58:15 +02:00
Laurent Rineau 022b19d3ca Merge pull request #8057 from sloriot/AABB_tree-2d_and_3d 
Updating the AABB-tree to work in both 2D and 3D
 2024-05-15 16:12:19 +02:00
Jane Tournois 1bbcc40ee3 Merge branch 'Mesh-3-edge-distance-criterium-aclement' of https://github.com/ange-clement/cgal into Mesh-3-edge-distance-criterium-aclement 2024-04-29 15:16:42 +02:00
Jane Tournois fe09beb53e fix template parameters doc 2024-04-29 15:15:46 +02:00
Laurent Rineau da893f8f8b minor changes 2024-04-29 14:58:10 +02:00
Laurent Rineau 67466144bb Merge pull request #8139 from janetournois/Mesh_3-revert_encroachment_loop-jtournois 
Mesh_3 - revert encroachment rule modification, and fix infinite refinement
 2024-04-22 14:53:50 +02:00
Jane Tournois 7a8075ebd9 comments 2024-04-16 16:54:21 +02:00
Jane Tournois 973f8a1f66 make default edge distance be 0 for consistency with other criteria (instead of DBL_MAX) 
rename check_distance_field() to has_distance_field()
 2024-04-16 15:32:59 +02:00
Jane Tournois a8debb0d2d Revert "Fix sometimes creating holes in the C3T3" 
This reverts commit 06d272169f.

There may be an inconsistency between exact and inexact computations,
in the facet encroachment rule

This code was leading to a local infinite refinement loop during cells refinement
 2024-04-11 14:16:41 +02:00
ange-clement 37798b73d7 Optimisation in refine_balls : added a is_edge_in_complex boolean, the check is processed once instead of twice. 2024-04-04 12:42:41 +02:00
ange-clement e558f43e01 Added check_distance_field in Edge criteria so that refine_balls() only check edge distance when necessary. 2024-04-04 12:08:13 +02:00