Sébastien Loriot
6db2bff67b
handle call to corefinement functions with identical meshes
2016-11-23 15:48:00 +01:00
Sébastien Loriot
3f316c9596
fix warnings and add missing include directive
2016-11-23 14:35:55 +01:00
Jane Tournois
e5dcef0528
deal with surface patch indices during collapse
...
for checking that faces do not get inverted
2016-11-21 17:55:25 +01:00
Jane Tournois
5a2eaa96a0
use Patch_id(-1) as invalid patch id
2016-11-21 17:46:22 +01:00
Jane Tournois
0b4ecf6531
is_corner should return true for a dart
2016-11-21 14:51:08 +01:00
Jane Tournois
c28dc6f210
avoid conversion warning
2016-11-21 14:47:46 +01:00
Jane Tournois
8f8ccc3c39
fix the case where patch2 was not met yet
2016-11-18 17:44:10 +01:00
Jane Tournois
f1cb55bf80
deal with boundaries by skipping null_face
2016-11-17 16:29:03 +01:00
Mael Rouxel-Labbé
92b4a49e38
Documentation changes for PMP's border_halfedges()
2016-11-17 14:17:26 +01:00
Jane Tournois
fb1af78ab5
check orientation of faces surface patch per surface patch
2016-11-17 11:45:17 +01:00
Mael Rouxel-Labbé
0851d2b4e8
Fixed an implementation of PMP's border_halfedges() returning interior edges
...
and the corresponding documentation.
2016-11-16 11:22:35 +01:00
Jane Tournois
b29c578d19
fix the boundary case
...
once the no-inversion test has been performed, check that we don't have
a boundary problematic case
It would require to reswap, and break the border of the patch to be remeshed
2016-11-15 17:18:13 +01:00
Jane Tournois
e4f9f9fea7
check that relaxation does not produce an inverted face
...
it can happen close to the boundary, where things are naturally
more constrained
2016-11-15 17:17:53 +01:00
Jane Tournois
2e6d55f813
remove a todo
2016-11-15 17:17:32 +01:00
Jane Tournois
7be46604ec
fix collapse step
...
the inverse orientation test should also be performed on the border
2016-11-15 17:17:16 +01:00
Jane Tournois
e8adc69337
rename function to improve code readability
2016-11-15 17:17:04 +01:00
Jane Tournois
33ef17760f
avoid collapsing an isolated constrained edge in the "middle" of a patch
2016-11-15 17:16:39 +01:00
Sébastien Loriot
f128addaca
fix order of the parameters
2016-11-13 19:54:13 +01:00
Sébastien Loriot
5ec738fcd8
qualify a call to choose_param
2016-11-13 19:53:46 +01:00
Sébastien Loriot
b34d8cd6b8
use readable property map API
...
operator[]() is only required in Lvalue property map
2016-11-11 10:04:35 +01:00
Sébastien Loriot
478a40c9aa
add an undocumented function to remove border edges
...
this works even if it does not satisfy the link condition
2016-11-10 18:52:20 +01:00
Sébastien Loriot
1501b4400c
int -> std::size_t for node ids
2016-11-10 14:38:10 +01:00
Sébastien Loriot
d7c6d30def
directly use the halfedge used to create the points
2016-11-10 14:27:10 +01:00
Sébastien Loriot
48fa75f829
the halfedges reported for intersection on a vertex or an edge was incorrect
...
copy-paste error...
2016-11-10 14:22:22 +01:00
Sébastien Loriot
167c52b00d
add todos, assertions and comments
2016-11-10 09:45:19 +01:00
Sébastien Loriot
f68a2a4dff
edges are not sorted and do not appear twice: do not skip them using indices
2016-11-10 09:41:18 +01:00
Sébastien Loriot
ddaf6cd90b
avoid reporting several time the same node per edge and face
...
This happens only in the case of coplanar triangles and can
be avoided by only reporting the node when it is first
created
2016-11-10 09:23:02 +01:00
Sébastien Loriot
918b71339f
bugfix: copy-paste error, wrong mesh
2016-11-04 09:55:56 +01:00
Sébastien Loriot
1ed98a7d9a
simply the detection of coplanar faces
...
coplanar faces are made of 3 intersection edges and each of its vertex
has a node-id != -1
2016-11-03 14:31:20 +01:00
Sébastien Loriot
cab2634387
bug fix in the detection of intersection edges in the middle of a coplanar patch
...
do not remove the edges from the intersection map while we are still using them
2016-11-03 14:18:12 +01:00
Sébastien Loriot
8c8a62b7e0
Correctly handle tangencies of input model
...
this handle the case of identical models (even differently meshed)
and model that are tangent only at vertices
(backport from Operations_on_polyhedra)
2016-11-03 10:41:00 +01:00
Mael Rouxel-Labbé
8c7e45b2eb
Fixed missing include in self_intersections.h
2016-10-31 15:24:33 +01:00
Mael Rouxel-Labbé
3591b39d33
Fixed self intersection tests
...
Adjacent faces that were coplanar and overlapping were not being detected
2016-10-28 14:25:16 +02:00
Laurent Rineau
d37c400fc9
Merge pull request #1606 from sloriot/PMP-make_border_test_safer
...
Make a test safer
2016-10-26 14:39:19 +02:00
Jane Tournois
2d72090cba
this internal property map is not needed anymore
2016-10-25 17:14:57 +02:00
Sébastien Loriot
9d5e675c61
add missing include directive
2016-10-24 14:50:48 +02:00
Laurent Rineau
24b7757282
Merge pull request #1517 from sloriot/PMP-more_bbox_3_overloads
...
More bbox 3 overloads for face graph models
2016-10-24 11:47:13 +02:00
Sébastien Loriot
e075757f18
remove assertion always true to avoid a warning
2016-10-21 18:04:30 +02:00
Mael Rouxel-Labbé
f27fa0d0e8
Add missing include directive
2016-10-21 17:58:11 +02:00
Sébastien Loriot
c2d5b501ed
make a test safer
2016-10-21 17:36:41 +02:00
Sébastien Loriot
1bdede2bcd
fix warning
2016-10-20 18:04:11 +02:00
Sébastien Loriot
f4d67dd4af
Refresh branch from master
2016-10-19 14:27:08 +02:00
Sébastien Loriot
f9ecd715b5
Revert "rename functions computing simplex bbox to bbox_3"
...
This reverts commit 357f261231 .
The names have to be different otherwise for models of FaceGraph
have face, vertex and edge descriptors being pure integer the
overloads will be ambiguous
2016-10-19 14:14:09 +02:00
Sébastien Loriot
eceb0a8b11
add doc for self-intersection tests restricted to a set of faces
...
also add an overload without named parameters
2016-10-19 13:57:23 +02:00
Andreas Fabri
423242be31
dihedral_angle() -> approximate_dihedral_angle()
2016-10-11 15:35:20 +02:00
Laurent Rineau
223c1cf5a4
Merge pull request #1530 from lrineau/Installation-compute_dependencies-GF
...
Compute and fix packages dependencies
2016-10-05 13:11:04 +02:00
Laurent Rineau
a2f14458f9
Merge pull request #1505 from sloriot/PMP-fix_empty_range_remeshing_bug
...
Fix a bug in isotropic remeshing when the range is empty
2016-10-05 13:02:27 +02:00
Sébastien Loriot
f27bb9168c
use latest way to get the vertex point map
2016-09-30 16:00:41 +02:00
Sébastien Loriot
6713621ae3
Update branch with master
2016-09-30 15:43:06 +02:00
Laurent Rineau
6eb6c57401
sync with master
2016-09-30 15:24:02 +02:00
Andreas Fabri
c58582b5ec
Add global function dihedral_angle()
2016-09-30 15:23:15 +02:00
Andreas Fabri
cb4931f1e4
Fix package Polygon_mesh_processing: include headers
2016-09-30 15:23:14 +02:00
Sébastien Loriot
d95b3fb00e
remove_isolated_vertices was no longer documented due to a missing \endcond
2016-09-30 10:11:01 +02:00
Sébastien Loriot
357f261231
rename functions computing simplex bbox to bbox_3
...
overloads are possible thanks to a specialization of graph_traits
for named parameter being empty.
That way, the compiler do not try to instantiate the one from boost,
which was looking for vertex_descriptor and edge_descriptor in the
name parameters.
2016-09-30 10:04:12 +02:00
Sébastien Loriot
2398d2612a
remove TODOs
2016-09-29 17:19:44 +02:00
Sébastien Loriot
896ae54bdd
update the text for named parameters
2016-09-29 17:11:46 +02:00
Sébastien Loriot
efa9b9bac4
rename boolean operation functions
...
The change of names comes from the fact the the constness of input meshes
cannot be guaranteed without having different type of input and output
meshes
2016-09-29 15:25:43 +02:00
Sébastien Loriot
69d790acbe
use Construct_bbox_3 from a geom_traits to compute the bbox
2016-09-29 14:58:21 +02:00
Sébastien Loriot
ce13630917
rename overload as there are some ambiguities that cannot be overcame
2016-09-29 14:09:50 +02:00
Sébastien Loriot
5143325085
add function to get the bounding box of a vertex, an edge, or a face
2016-09-29 14:09:46 +02:00
Sébastien Loriot
35c2d8dc52
mark intersection edges in output models (in-place cases) using output pmap
2016-09-29 10:40:43 +02:00
Sébastien Loriot
d9e91e4fa4
set null_face as face of newly created edges
...
depending of the type of input, it might be reusing some old
attributes (like Surface_mesh for example)
2016-09-29 10:21:05 +02:00
Sébastien Loriot
8a000baa12
rename functions to disambiguate the call to put/get free functions
2016-09-29 10:20:21 +02:00
Sébastien Loriot
3abb3efd67
fix a typo leading to a bug
2016-09-29 10:18:35 +02:00
Laurent Rineau
a3b065175b
Merge pull request #1332 from janetournois/PMP-about_internal_pmaps-jtournois
...
BGL : detect internal property maps, and use it in PMP isotropic remeshing
2016-09-28 18:01:13 +02:00
Laurent Rineau
b085f1e7a0
Merge pull request #1442 from sloriot/Polyhedron_demo-add_remove_self_intersections
...
Add an action to remove self-intersections in a mesh
2016-09-28 18:00:41 +02:00
Sébastien Loriot
46b0abbb3b
do nothing if the face range is empty
2016-09-28 13:56:22 +02:00
Sébastien Loriot
5de5315ef5
vertex point map must be default constructible
2016-09-27 17:32:12 +02:00
Sébastien Loriot
6488a8a172
fix warnings
2016-09-27 17:31:38 +02:00
Sébastien Loriot
37f760383d
fix template paramaters
2016-09-27 17:30:54 +02:00
Sébastien Loriot
4316b82952
fix warning
2016-09-27 17:28:44 +02:00
Sébastien Loriot
2eb6e14db4
fix typos
2016-09-27 17:27:50 +02:00
Sébastien Loriot
de9580e17d
add missing include and fix warnings
2016-09-27 17:27:03 +02:00
Sébastien Loriot
90b518113d
add a function to generate a default named parameters from an existing one
...
this is more a syntactic sugar to make clear in the code that something
is not meant to be used
2016-09-27 17:19:00 +02:00
Sébastien Loriot
3b573238b3
copy-paste error
2016-09-27 11:01:55 +02:00
Sébastien Loriot
e63b67a9ad
Get the default kernel from the property map given instead of the default one
2016-09-27 10:55:48 +02:00
Sébastien Loriot
27b011789c
avoid a warning in release mode
2016-09-26 09:19:49 +02:00
Laurent Rineau
119763e168
Merge pull request #1474 from janetournois/PMP-isotropic_remeshing_fix_doc-jtournois
...
(From a merge of branch 'cgal/releases/CGAL-4.9-branch')
2016-09-23 17:02:56 +02:00
Laurent Rineau
45d87bb333
Merge pull request #1439 from janetournois/PMP-remove_useless_includes-GF
...
PMP : remove useless includes
2016-09-23 16:51:12 +02:00
Jane Tournois
a646158eb0
update doc
2016-09-22 12:10:06 +02:00
Jane Tournois
23d5411e60
remove more useless choose_const_pmap
2016-09-22 12:10:06 +02:00
Jane Tournois
97a534fd8b
don't attemp to get the vertex_point map of PMesh when it does not exist
2016-09-22 12:10:06 +02:00
Jane Tournois
064a3510b2
remove useless using boost::choose_pmap and boost::choose_const_pmap
2016-09-22 12:10:06 +02:00
Jane Tournois
ef85908fe1
use get_property_map and get_const_property_map everywhere in PMP
2016-09-22 12:10:06 +02:00
Jane Tournois
76e6333a18
fix the use of const_type
2016-09-22 12:10:06 +02:00
Jane Tournois
fc58055ec3
use get_const_property_map
2016-09-22 12:10:06 +02:00
Jane Tournois
1aac56ca61
add const_type, and get_const_pmap
2016-09-22 12:10:06 +02:00
Jane Tournois
c234af207e
fix unused parameter warning
2016-09-22 12:10:06 +02:00
Jane Tournois
756eac95d3
fix compilation error
2016-09-22 12:10:06 +02:00
Jane Tournois
6d9e974bab
add documentation
2016-09-22 12:10:06 +02:00
Jane Tournois
047be1346c
add the use of face_index_map wherever it's needed
...
remeshing_test now crashes, don't know why yet
2016-09-22 12:05:51 +02:00
Jane Tournois
d50cbf4930
use get_property_map for face_index_map
...
in isotropic_remeshing and border_halfedges
2016-09-22 12:05:51 +02:00
Jane Tournois
7e1fab420a
add get_property_map to get either the internal pmap or cgal_no_property
2016-09-22 12:05:51 +02:00
Jane Tournois
d03077abda
iterator type of FaceRange should be multi-pass, so ForwardIterator
2016-09-20 15:03:13 +02:00
Sébastien Loriot
6aec9dbc8c
fix typo
2016-09-20 09:17:10 +02:00
Laurent Rineau
e2d04e54e0
Merge remote-tracking branch 'cgal/releases/CGAL-4.8-branch'
...
> 3176b37 Merge pull request #1452 from mglisse/Number_types-Eigen_Literal-glisse
> 1705702 Merge pull request #1417 from afabri/Polyline_simplification-Bugfix_choose_correct_Itag-GF
> 3bef239 Merge pull request #1462 from sloriot/PMP-add_missing_include
2016-09-15 17:25:20 +02:00
Sebastien Loriot
343fb726fa
Add missing include directive
2016-09-15 15:52:47 +02:00
Jane Tournois
bffb1f63f7
document that exact constructions are not supported
...
and write a proposal about how to support exact constructions
2016-09-13 11:05:55 +02:00
Jane Tournois
e0bce515cf
add a macro to be less verbose
2016-09-12 17:16:30 +02:00
Sébastien Loriot
b7db87ab40
add a plugin to remove self-intersection in a mesh
2016-09-08 15:01:44 +02:00