Commit Graph

2800 Commits

Author SHA1 Message Date
Laurent Rineau 0d7c2c41af Merge pull request #3139 from lrineau/Mesh_3-fix_verbose_mode-lrineau
Mesh_3: fix verbose mode (when the manifold criterion is used)
2018-06-06 14:39:13 +02:00
Laurent Rineau 335034e3cf Fix the CGAL_MESH_3_VERBOSE mode 2018-05-31 16:11:07 +02:00
Laurent Rineau 116248e7df Also add a test for mesher.one_step() 2018-05-31 15:59:12 +02:00
Laurent Rineau 7a48ff7e65 Add a comment to retrieve the issue quickly 2018-05-31 14:39:33 +02:00
Laurent Rineau 805a424519 Add a test of CGAL_MESH_3_VERBOSE 2018-05-31 14:39:13 +02:00
Laurent Rineau a959f4115d Do not include the headers of deprecated classes 2018-05-30 18:38:08 +02:00
Andreas Fabri 89d96f4ce8 An #ifdef inside a CGAL_assertion_msg() does not compile on VC12 2018-05-30 08:15:31 +01:00
Laurent Rineau e6b02e3785 Attempt to fix the compilation issue with MSCV 2012 and Boost 1.53
```
[ 50%] Building CXX object CMakeFiles/mesh_implicit_sphere_variable_size.dir/mesh_implicit_sphere_variable_size.cpp.obj
	C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe  @C:\Users\afabri\AppData\Local\Temp\nmCD61.tmp
mesh_implicit_sphere_variable_size.cpp
C:\3rdPartyLibs\boost_1_53_0\boost/type_traits/remove_cv.hpp(37) : error C2039: 'unqualified_type' : is not a member of 'boost::detail::cv_traits_imp<T>'
        with
        [
            T=double (__cdecl *const *)(const Point &)
        ]
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-4.13-Ic-23/Mesh_3_Examples/TestReport_afabri_x64_Cygwin-Windows8_MSVC2012-Release-64bits.gz

Maybe passing a function pointer instead of a function lvalue will fix the
compilation error.
2018-05-29 11:00:09 +02:00
Laurent Rineau e14bad3df4 Workaround for MSVC
The MSVC is confused by the name `Function` being at the same time a
template parameter and a typedef of the base class.

```
...\include\CGAL/Implicit_mesh_domain_3.h(73): error C2248: 'CGAL::Labeled_mesh_domain_3<BGT,int,std::pair<int,int>>::Function': cannot access private typedef declared in class 'CGAL::Labeled_mesh_domain_3<BGT,int,std::pair<int,int>>'
        with
        [
            BGT=K
        ]
```
2018-05-29 10:30:43 +02:00
Laurent Rineau 2766e1ff5d Merge 'master' and fix conflicts 2018-05-28 16:40:09 +02:00
Laurent Rineau 588cc67897 Merge pull request #3096 from MaelRL/CGAL-Fix_deprecated_code_usage-GF
Fix some deprecation-related issues
2018-05-28 13:58:41 +02:00
Laurent Rineau 2ad4781a05 Merge pull request #3092 from maxGimeno/Travis-Check_including_all_headers-GF
Infrastructure : Test compilation of headers
2018-05-28 13:58:19 +02:00
Laurent Rineau 46bf950f2d Merge pull request #3073 from MaelRL/Mesh_3-Add_add_corner-GF
Mesh_3: Add `add_corner()` and similar corner-adding functions
2018-05-28 13:58:02 +02:00
Laurent Rineau f20743cc20 Merge pull request #3096 from MaelRL/CGAL-Fix_deprecated_code_usage-GF
Fix some deprecation-related issues
2018-05-28 11:00:45 +02:00
Laurent Rineau d7d39e9036 Merge pull request #3092 from maxGimeno/Travis-Check_including_all_headers-GF
Infrastructure : Test compilation of headers
2018-05-28 11:00:39 +02:00
Mael Rouxel-Labbé 497c8ccb50 Fixed conversion warning (changes mirrored from: 683fa43) 2018-05-24 14:18:40 +02:00
Mael Rouxel-Labbé edf84b155e Added a virtual destructor to silence a warning 2018-05-24 14:17:58 +02:00
Andreas Fabri 76c260142b Add #include 2018-05-23 11:48:59 +02:00
Andreas Fabri 4de6c30323 Add missing #include 2018-05-23 11:48:59 +02:00
Andreas Fabri 6e828da0e9 Move stuff to CGAL/boost/parameter 2018-05-23 11:48:59 +02:00
Andreas Fabri f6cd1e0bcf Factorize boost parameters in the file CGAL/boost/parameter.h 2018-05-23 11:48:59 +02:00
Andreas Fabri c15306df4c Put duplicated functors in an extra file 2018-05-23 11:48:58 +02:00
Mael Rouxel-Labbé b41f1d6272 Various deprecation-related improvements 2018-05-18 16:47:54 +02:00
Laurent Rineau 13518a0501 Fix check_headers 2018-05-16 17:38:39 +02:00
Laurent Rineau 05d7baceb1
Merge branch 'master' into Mesh_3-improve_polylines_to_protect-GF 2018-05-16 11:36:24 +02:00
Laurent Rineau 6653dabc62 Add the license-checking #include 2018-05-16 11:07:13 +02:00
Laurent Rineau 337d49a3ad Fix compatibility with C++03 2018-05-15 16:25:32 +02:00
Laurent Rineau f458dc5cc4 Document that the implicit function is CopyConstructible 2018-05-15 15:13:05 +02:00
Laurent Rineau cd032f05fc Do not store const& to the function/functor by copy by value
However, one cannot store a function type directly, but only *pointers* to
function types. So I used Boost MPL to discriminate between function types
and other callable (such as lambdas or functors, that can be copied).
2018-05-15 15:13:05 +02:00
Laurent Rineau 301181ca53 Fix compilation bug with CGAL_MESH_3_PROTECTION_DEBUG 2018-05-15 15:13:05 +02:00
Laurent Rineau c616f66811 Use static_evaluate 2018-05-15 15:13:05 +02:00
Laurent Rineau ae0b45b79f Fix a compilation bug if Mesh_3 and Mesh_2 are both used
The conflict is withing the Boost parameters defined for Lloyd 2D and
Lloyd 3D.
2018-05-15 15:13:05 +02:00
Laurent Rineau d982483431 Add (deprecated) in the list of classes 2018-05-15 15:13:04 +02:00
Laurent Rineau 2bb3d11cd0 Remove unused typedef 2018-05-15 15:13:04 +02:00
Laurent Rineau a69ea141b6 Add deprecation notice to Implicit_mesh_domain_3, in the doc 2018-05-15 15:13:04 +02:00
Laurent Rineau a140ed004c Remove the `const bool = true` from the function wrappers 2018-05-15 15:13:04 +02:00
Laurent Rineau b4a14010a1 Document create_implicit_mesh_domain() 2018-05-15 15:13:04 +02:00
Laurent Rineau 2def8c6e8f typo: missing space 2018-05-15 15:13:04 +02:00
Laurent Rineau 6d64ec2a0b Document CGAL::Image_3 2018-05-15 15:13:04 +02:00
Laurent Rineau b090edb03d Remove mentions of the deprecated classes 2018-05-15 15:13:04 +02:00
Laurent Rineau d56c54179f Remove the buggy concept LabelImage_3 2018-05-15 15:13:04 +02:00
Laurent Rineau e46cd8ad1a Remove the last -Wconversion warnings from all Mesh_3
I have only compiled tests and examples. Maybe the Mesh_3 plugin of the 3D
demo has other warnings.
2018-05-15 15:13:04 +02:00
Laurent Rineau d1c5eb655b Adapt the test suite to the deprecation of Implicit_mesh_domain_3 2018-05-15 15:13:04 +02:00
Laurent Rineau 30ff350986 Deprecate Implicit_mesh_domain_3 as well 2018-05-15 15:13:04 +02:00
Laurent Rineau f0233cfbf7 Remove the domain classes deprecated since CGAL-4.5.
Mael talked about that in his review.
2018-05-15 15:13:04 +02:00
Laurent Rineau ae255e248f Remove trivial, useless, buggy documentation comments 2018-05-15 14:56:24 +02:00
Laurent Rineau b8b4b6b351 Typo: missing ) 2018-05-15 14:56:24 +02:00
Laurent Rineau b61cef82dd Wording
See Mael's comment:
https://github.com/CGAL/cgal/pull/2739#discussion_r175448829
2018-05-15 14:56:24 +02:00
Laurent Rineau ffbd029f40 New wording
See Mael's comment:
https://github.com/CGAL/cgal/pull/2739#discussion_r175410322
2018-05-15 14:56:24 +02:00
Laurent Rineau dc3e86e281 Unify sentence "Construct a... " and "Construction from"
See Mael's comment:
https://github.com/CGAL/cgal/pull/2739#discussion_r175405016
2018-05-15 14:56:23 +02:00