Commit Graph

4654 Commits

Author SHA1 Message Date
Sébastien Loriot 9543deb304 Merge pull request #6046 from MaelRL/PM-Fix_pmaps_reference_types_master-GF
Various fixes for property maps (master)
2021-10-29 17:40:15 +02:00
Laurent Rineau e9cb30955c Merge pull request #6037 from sloriot/PMP-nm_map_license
Add missing license include directive
2021-10-29 17:00:02 +02:00
Laurent Rineau cdedec4449 Merge pull request #6075 from danston/PMP-remove_runtime_assert_in_hdist-danston
Removed Runtime Assert From the Hausdorff Distance Test
2021-10-29 16:59:26 +02:00
Laurent Rineau 04cde86a24 Merge pull request #6080 from sloriot/PMP-max_w
Workaround compilation error on Windows, about `max`
2021-10-29 16:59:22 +02:00
Laurent Rineau 5d965e0507 Merge pull request #6051 from MaelRL/PMP-Forward_GT_orient_to_bound_volume-GF
PMP: Forward the geometric traits in `orient_to_bound_a_volume()`
2021-10-29 16:46:39 +02:00
Laurent Rineau 4a17e26e28 Merge pull request #6068 from sloriot/PMP-sampling_doc
Fix NPs and improve doc
2021-10-29 16:46:33 +02:00
Sébastien Loriot f4f484c5e0 workaround warning 2021-10-25 09:47:29 +02:00
Dmitry Anisimov d4f1d36f7f removed runtime assert from the hdist test 2021-10-21 15:20:16 +02:00
Sébastien Loriot b793e7cd90 fix NPs and improve doc 2021-10-19 17:38:12 +02:00
Mael Rouxel-Labbé 1ab6b44d7d Fix NP forwarding in volume_CC 2021-10-15 10:22:08 +02:00
Mael Rouxel-Labbé 1f73af6cc4 Drive-by cleaning 2021-10-14 11:09:04 +02:00
Mael Rouxel-Labbé 91e7f1d20c Forward the geom traits in orient_to_bound_a_volume 2021-10-14 11:06:04 +02:00
Sébastien Loriot bdec97bccb remove backtick 2021-10-12 15:02:42 +02:00
Mael Rouxel-Labbé 8166579e55 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_master-GF 2021-10-11 19:58:07 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Sébastien Loriot 64ead81a1c add missing license include directive 2021-10-08 15:28:13 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Laurent Rineau f581ff74d3 Merge pull request #5427 from sloriot/CGAL_data-moving_files
Regroup data: moving files

# Conflicts:
#	Nef_3/archive/triangulation/include/CGAL/partition_is_valid_2.h
2021-10-07 14:44:01 +02:00
Laurent Rineau fb9333f0d0 Merge pull request #6028 from MaelRL/CGAL-Fix_typos-GF
Fix typos
2021-10-07 14:27:21 +02:00
Laurent Rineau 94ee9b1613 Merge pull request #6030 from MaelRL/CGAL-Minor_fixes-GF
Fix uninitialized id maps in heat method
2021-10-07 14:27:16 +02:00
Sébastien Loriot 1857a25d28 Merge remote-tracking branch 'cgal/master' into CGAL_data-moving_files 2021-10-06 13:50:31 +02:00
Sébastien Loriot 8a0b290478 char* -> string 2021-10-05 17:42:25 +02:00
Sébastien Loriot 33d60307c7 fix path 2021-10-05 17:42:25 +02:00
Sébastien Loriot efbd86df7f extra manual fixes 2021-10-05 17:42:21 +02:00
Mael Rouxel-Labbé 863ab7541c Various whitespace fixes 2021-10-05 12:14:03 +02:00
Mael Rouxel-Labbé 84d84278b9 Fix VPM type 2021-10-05 12:14:02 +02:00
Mael Rouxel-Labbé 521c72d57e Fix typos 2021-10-04 13:34:07 +02:00
Mael Rouxel-Labbé 625848e629 Fix missing ':' in various namespaces 2021-10-04 13:21:47 +02:00
Sébastien Loriot 6dad5b6922 rename file 2021-10-04 11:00:40 +02:00
Sébastien Loriot b5e7d03634 fix runtime issues 2021-10-04 10:22:13 +02:00
Sébastien Loriot 8350dea94a char* -> std::string 2021-10-04 09:49:24 +02:00
Sébastien Loriot 47028cd184 automatically move data files in data dir + update paths
Done for OFF/OBJ/STL/XYZ/PWN/PLY
2021-10-04 09:42:49 +02:00
Laurent Rineau 01017f9deb Merge pull request #6022 from sloriot/PMP-deps
Reduce dependencies
2021-09-30 16:49:34 +02:00
Laurent Rineau 804feece28 Merge pull request #5761 from danston/Weights-unification-danston
[Small Feature] Weights Unification
2021-09-29 16:59:34 +02:00
Laurent Rineau bb58df3ae5 Merge pull request #6021 from MaelRL/PMP-Snap_with_KD_tree-GF
Improvements for PMP's snapping code
2021-09-29 16:59:26 +02:00
Sébastien Loriot 2b666db30c use function
avoid compilation error about unknown function
2021-09-29 12:11:42 +02:00
Laurent Rineau 7e42541573 Merge pull request #5633 from sloriot/PMP-add_filter_for_caps_needles
Add a filter in function to remove caps/needle
2021-09-29 11:46:47 +02:00
Laurent Rineau e87bf84395 Merge pull request #5994 from MaelRL/PMP-Detect_sharp_edges_const-GF
Enhancements & fixes for PMP::detect_features
2021-09-29 11:46:41 +02:00
Laurent Rineau 0d304fe737 Merge pull request #6015 from sloriot/PMP-snap_fix_w
Fix vv snapping weight
2021-09-29 11:46:28 +02:00
Sébastien Loriot c374b382a5 reduce dependancies 2021-09-29 11:06:39 +02:00
Mael Rouxel-Labbé b92c22d0a9 Improve preprocessing of snapping (don't move fixed vertices during collapsing) 2021-09-28 16:49:19 +02:00
Mael Rouxel-Labbé 60567eccbb Add Kd_tree-based vertex-vertex snapping + PMP::snap visitor 2021-09-28 16:25:43 +02:00
Sébastien Loriot 542d3603be fix weight for vertex-vertex snapping 2021-09-27 19:46:14 +02:00
Mael 4e5fbb6f22
Specify namespace
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
2021-09-27 12:15:09 +02:00
Mael Rouxel-Labbé 878d94e299 Fix sign call 2021-09-24 09:47:33 +02:00
Sébastien Loriot f632a11d0d fix invalid OFF headers 2021-09-23 18:56:15 +02:00
Mael Rouxel-Labbé 2bc5643972 Fix comparison 2021-09-21 16:50:19 +02:00
Laurent Rineau 8cdfc3b214 Merge pull request #5941 from afabri/PMP-edge_lenght_area-GF
Polygon Mesh Processing:  Add measure functions not using sqrt
2021-09-20 17:07:09 +02:00
Mael Rouxel-Labbé c7519ef93c Cache the squared cos value 2021-09-15 14:59:55 +02:00
Mael Rouxel-Labbé fd12c73cba Enhance tests 2021-09-15 14:59:40 +02:00