That fixes the following CMake warning:
-- Configuring test in test/Snap_rounding_2
Requested component: Core
Requested component: MPFR
Requested component: GMP
CMake Warning (dev) at
Installation/cmake/modules/CGAL_CreateSingleSourceCGALProgram.cmake:19
(add_executable):
Policy CMP0037 is not set: Target names should not be reserved and should
match a validity pattern. Run "cmake --help-policy CMP0037" for policy
details. Use the cmake_policy command to set the policy and suppress this
warning.
The target name "test" is reserved or not valid for certain CMake features,
such as generator expressions, and may result in undefined behavior.
Call Stack (most recent call first):
buildEX/test/Snap_rounding_2/CMakeLists.txt:19
(create_single_source_cgal_program)
This warning is for project developers. Use -Wno-dev to suppress
it.
2. Made the required changes in the concepts i.e. in "Snap_rounding_2/doc/Snap_rounding_2/Concepts/SnapRoundingTraits_2.h"
3. Added documentation for the reserve() method of Kd_tree
4. Deleted the un maintained olk kd_tree package
2. "Snap_rounding_kd_2.h" "Snap_rounding_traits_2.h" Added documentation and changed Copyright information and authors appropriately.
3. "kd_tree.h" Renamed the reserve_to_capacity() to reserve().
4. Snap_rounding_kd_new.h deleted
bad() implies fail() but std::basic_ios::operator! is actually equivalent
to std::basic_ios::fail(), not bad().
For example,
std::ifstream is(argv[1]);
if (is.bad()) {
is probably wrong because, in case the file does not exist, only the failbit it set,
and not the badbit.
Other example:
double x;
is >> x;
If the stream 'is' does not contains a string that can represent a double,
then failbit is set (and maybe the eofbit if the stream is actually too
short), but not the badbit.
bad() can be used, in case fail() returned true, to discriminate between a
I/O error and a logical error.
See:
http://en.cppreference.com/w/cpp/io/basic_ios/operator_boolhttp://en.cppreference.com/w/cpp/io/ios_base/iostate
In the only use case in the code base SAVED_OBJECT is a
pointer. Technically the deallocation of the objects should happen
inside the snap rounding algorithm itself, but this would some
modifications to the algorithm necessary. For simplicity
Multiple_kd_tree now takes ownership of the SAVED_OBJECTs and
deallocates them.
Successfully test in CGAL-4.3-Ic-102
This commit fixes a few issues in the doxygen documentation and in particular
the figure for the generation of latex doc.
Approved by the interim release manager
xplain why this merge is necessary,
this happens if you have an empty line or the text directly after /!*
to find them in the generated documentation, grep for "pre class=\"fragment\""
(a few of them are legitimate however)
Sébastien Loriot
Philipp Möller
Andreas Fabri
Laurent Rineau
m.overtheil
Eric Berberich
Waqar Khan
Philipp Möller