Commit Graph

385 Commits

Author SHA1 Message Date
Laurent Rineau 2cb68b7ce0 minor rephrases in the documentation 2025-06-03 16:59:11 +02:00
Jane Tournois 2bf182a302 add example to user manual and use plc_facet_id in output 2025-06-03 14:51:44 +02:00
Jane Tournois a910785202 keep on renaming NP and examples + document all examples
_from_soup.cpp's name was too long for msvc
2025-06-03 11:22:35 +02:00
Jane Tournois 1afaad6fdf use right named parameter name 2025-06-03 10:57:44 +02:00
Jane Tournois a75ddb4ba1 replace input with triangle mesh 2025-06-03 09:25:45 +02:00
Sébastien Loriot 99c70b1ef2 fix doc errors 2025-06-02 19:03:19 +02:00
Jane Tournois 2c06c028cf fix example 2025-06-02 17:04:05 +02:00
Jane Tournois c1bc60b067 rename example and change it to use planar patches
instead of patches that are separated by sharp edges (which may be non planar)
2025-06-02 15:41:07 +02:00
Jane Tournois fa45ad8943 rename example according to np `plc_facet_id` 2025-06-02 12:54:57 +02:00
Jane Tournois 19f10ea890 rename plc_face_id to plc_facet_id 2025-06-02 12:49:03 +02:00
Jane Tournois 08e0d6b839 replace face by facet wherever it makes sense 2025-06-02 12:15:39 +02:00
Jane Tournois 9efcb22083 fix include 2025-06-02 12:12:15 +02:00
Jane Tournois 2145617b2c replace assertion with exception 2025-06-02 12:03:23 +02:00
Jane Tournois ab8fed4841 use try/catch to pre-catch non-planar PLC facets when CDT_2 fails 2025-06-02 11:22:38 +02:00
Jane Tournois 1f3e98abac replace face_patch_map with plc_face_id
the patches actually correspond to PLC faces,
which must be planar, and do not match the "face patches"
of PMP::isotropic_remeshing for example

+ add a np to CGAL::IO::write_MEDIT(ccdt) to save the corresponding PLC ids,
or just "1" everywhere as patch id
2025-05-30 16:52:00 +02:00
Jane Tournois bbc534f0b3 wip review monique round 5 2025-05-30 14:57:45 +02:00
Laurent Rineau e955df4e28 fix the example 2025-05-28 10:21:38 +02:00
Jane Tournois b49dccb35d vocabulary
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-05-26 15:44:02 +02:00
Jane Tournois e0ea913a3f image fixes 2025-05-26 12:40:07 +02:00
Jane Tournois 6bd4573e99 Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-05-26 11:23:32 +01:00
Jane Tournois a5671fe445 change package description thumbnail 2025-05-26 12:23:14 +02:00
Jane Tournois 2349549633 change title image vase->pyramid 2025-05-26 12:01:06 +02:00
Sébastien Loriot d6cea063c1 do not repeat package name 2025-05-26 11:48:22 +02:00
Laurent Rineau b39b1a4a65 need Eigen 2025-05-23 16:44:43 +02:00
Laurent Rineau 17d4e5cfd5 fix the example 2025-05-23 16:34:50 +02:00
Jane Tournois 9be03bd2d2 fix image colors, and caption 2025-05-23 16:21:11 +02:00
Laurent Rineau 4e591900d1 fix a bug in get_remeshing_triangulation 2025-05-23 15:42:08 +02:00
Laurent Rineau ee487a8c42 add an example of fpmap with region growing 2025-05-23 15:41:28 +02:00
Laurent Rineau 5d4cc6cb07 output the intermediate mesh to a file 2025-05-23 12:31:05 +02:00
Laurent Rineau b3722b1885 rename convert_to_triangulation_3 2025-05-23 12:30:32 +02:00
Laurent Rineau 2db51dbc85 additional pass on the user manual
In particular, @sloriot, I have added the subsection _Representation of Piecewise
Linear Complexes_, to talk about face IDs, among other things.
2025-05-22 15:23:23 +02:00
Laurent Rineau bb61127254 always use read_polygon_mesh and write_MEDIT 2025-05-21 15:34:47 +02:00
Laurent Rineau 3db82de277 Tr_of_default/Tr 2025-05-21 14:00:34 +02:00
Sébastien Loriot ef989ee51f add dependencies added by PMP::triangulate_faces and PMP::does_self_intersect 2025-05-21 10:16:44 +02:00
Laurent Rineau 73fd95ab6b fix warnings 2025-05-20 16:49:14 +02:00
Laurent Rineau a94a768c04 refactor write_MEDIT
... and use it more in CDT_3 examples
2025-05-20 16:49:02 +02:00
Laurent Rineau 37463c9150 2D case 2025-05-20 16:41:08 +02:00
Laurent Rineau 7955df7f66 remove ccdt.convert_for_remeshing()
and inline it into `CGAL::convert_to_triangulation_3(ccdt)`
2025-05-20 16:24:27 +02:00
Laurent Rineau f880735a57 remove the trailing call to PMP::autorefine 2025-05-20 13:55:07 +02:00
Laurent Rineau fec07c6488 Tr_or_default/Tr 2025-05-19 18:49:45 +02:00
Laurent Rineau ae597dd2ea review Mael 2025-05-19 18:47:14 +02:00
Laurent Rineau 4d5876392d doc of convert_to_triangulation_3(ccdt) 2025-05-19 18:34:32 +02:00
Laurent Rineau f3f72fcbf3 review Mael 2025-05-19 17:59:56 +02:00
Laurent Rineau aca6fbe2ea reorganize doc of make_conforming_constrained_Delaunay_triangulation_3 2025-05-19 17:57:17 +02:00
Laurent Rineau 5db49a1b89 review Mael 2025-05-19 17:14:57 +02:00
Laurent Rineau 9203757f57 review Mael 2025-05-19 16:43:22 +02:00
Laurent Rineau 881ce6df5b review Mael 2025-05-19 16:33:11 +02:00
Laurent Rineau 578ff5bdc6 use read_polygon_(soup|mesh) 2025-05-19 16:16:51 +02:00
Laurent Rineau f540227441 review my Mael 2025-05-19 16:16:36 +02:00
Laurent Rineau f619c0cf58 face/polygon 2025-05-19 16:00:38 +02:00
Laurent Rineau e2e6db6c47 Conforming _Constrained_ Delaunay Triangulation 2025-05-19 15:57:39 +02:00
Laurent Rineau 7c3ac1bcd1 use the introduction by Mael (rephrased a bit) 2025-05-19 15:57:06 +02:00
Laurent Rineau 6d0931d6c8 remove (face) and (faces) 2025-05-19 15:46:20 +02:00
Laurent Rineau 713b5d8d57 fix Figures 2025-05-19 15:29:30 +02:00
Laurent Rineau 6e3baa07a6 add a reference to the doc chapter Triangulation_3 2025-05-19 15:23:42 +02:00
Laurent Rineau fd1e8cac9f fix " : " 2025-05-19 15:04:42 +02:00
Laurent Rineau d07dc0daad remove the lambda expression
maybe solve that issue:
```
    21>C:\CGAL_ROOT\CGAL-6.1-Ic-155\include\CGAL/Conforming_constrained_Delaunay_triangulation_vertex_data_3.h(82,1): error C2888: '==::<lambda_f8bc645280bb56be32d0268df7c48762>': symbol cannot be defined within namespace 'CGAL' [C:\CGAL_ROOT\CGAL-6.1-Ic-155\cmake\platforms\MSVC-2019-Community-Release\test\Constrained_triangulation_3_Examples\ccdt_3_preprocessing.vcxproj]
```
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-155/Constrained_triangulation_3_Examples/TestReport_Christo_MSVC-2019-Community-Release.gz
2025-05-16 16:33:03 +02:00
Laurent Rineau 679ecb8ced doc: fix link to CGAL::IO::write_MEDIT(ostream&, CDT_3 const&) 2025-05-15 10:59:49 +02:00
Jane Tournois d14b1fdd6b apply Andreas' doc review
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2025-05-15 10:22:13 +02:00
Laurent Rineau 77833e3513 fix doc (figs) 2025-05-14 10:48:36 +02:00
Laurent Rineau 8e398f0aa2 (max) 2025-05-14 10:38:12 +02:00
Laurent Rineau afed97a9c6 test one example with TBB 2025-05-13 17:33:35 +02:00
Laurent Rineau 2035e0c312 refactoring 2025-05-13 17:32:31 +02:00
Sébastien Loriot fba1b5068e be consistant 2025-05-13 15:24:36 +02:00
Sébastien Loriot dca12bcd6b simplify patch id copies 2025-05-13 15:12:59 +02:00
Sébastien Loriot b1634370ae use triangle soup after autorefine as non-manifold edge will result in self-intersections in a mesh 2025-05-13 14:50:03 +02:00
Sébastien Loriot 2887ee0a36 reuse existing map 2025-05-13 14:49:30 +02:00
Sébastien Loriot d6146730a8 fix condition 2025-05-13 13:51:19 +02:00
Sébastien Loriot 57524e12e4 fix rw_points type and construction 2025-05-13 13:43:30 +02:00
Sébastien Loriot e4bd0348a4 avoid precondition checking after creating the mesh from a soup 2025-05-13 13:42:25 +02:00
Laurent Rineau 89966ea79b fix `polygon_id_to_sm_face_map`
The name was wrong, because one needs actually the mapping in two sides.
2025-05-13 12:33:01 +02:00
Sébastien Loriot 9b6bf75b11 missing call to orient soup 2025-05-13 11:43:49 +02:00
Sébastien Loriot 317b64d705 add a macro to reduce dependencies 2025-05-13 11:32:31 +02:00
Sébastien Loriot f40c64ba13 rename np 2025-05-13 11:26:47 +02:00
Sébastien Loriot 0064ea9f3e add missing precondition check for soup + always assert in debug 2025-05-13 11:20:26 +02:00
Jane Tournois 45e9662fd4 remove cdt_3_full_preprocessing for now 2025-05-12 18:39:00 +02:00
Sébastien Loriot 6879158e32 typo 2025-05-12 17:50:47 +02:00
Sébastien Loriot 0aba404db4 workaround anchor issues by adding subgroups to disambiguate overloads 2025-05-12 17:47:53 +02:00
Jane Tournois f44cace75d add missing link to Basic_viewer 2025-05-12 17:05:49 +02:00
Jane Tournois abcc812ea4 fix compilation of tests 2025-05-12 16:20:47 +02:00
Jane Tournois dd27c1edf6 missing git add 2025-05-12 16:16:07 +02:00
Jane Tournois ebd9ecab58 documentation of check_preconditions, the new NP 2025-05-12 15:47:42 +02:00
Jane Tournois 270c507ce7 v0 of add named parameter check_preconditions()
optional parameter, to check a priori that preconditions are satisfied
2025-05-12 15:14:08 +02:00
Jane Tournois 4083e353aa add an example with non-triangulated self-intersecting input 2025-05-12 13:00:32 +02:00
Jane Tournois edeac22b47 Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-05-12 12:12:51 +02:00
Jane Tournois ca1a5982b6 add an example with self-intersections and autorefinement 2025-05-12 12:12:32 +02:00
Sébastien Loriot b366197efc missing deps 2025-05-12 11:45:24 +02:00
Jane Tournois 144ec8de0f remove comment 2025-05-12 11:06:46 +02:00
Jane Tournois b70e78f22b document CGAL::IO::write_MEDIT 2025-05-12 10:52:19 +02:00
Jane Tournois 0c3b8b8b11 workaround static_assert for msvc <= 2019 2025-05-12 09:52:51 +02:00
Laurent Rineau 3409d4c974 fix warnings 2025-05-11 23:00:33 +02:00
Laurent Rineau 7c2537b62a merge issue 2025-05-09 16:16:24 +02:00
Laurent Rineau e3190d62db other fixes for MSVC 2017 2025-05-09 16:14:18 +02:00
Jane Tournois 0830299bbf Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-05-09 16:04:33 +02:00
Jane Tournois 697101bf8e fix remeshing example and test
add edge_is_constrained_map to convert_to_triangulation_3()
similarly to what is done with a C3T3
2025-05-09 16:04:19 +02:00
Laurent Rineau c388b62f3b fixes for msvc 2017 2025-05-09 16:04:05 +02:00
Laurent Rineau a8fb8c5981 fix compilation of cdt_3_plugin 2025-05-09 15:29:01 +02:00
Jane Tournois 4305fd7da0 Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-05-09 14:36:17 +02:00
Jane Tournois e3a7e453fe fix compilation with CCDT_cb 2025-05-09 14:35:18 +02:00
Laurent Rineau d4a5cba43c small fixes 2025-05-09 10:00:24 +02:00
Jane Tournois 7180a85762 remove from CCDT_Cb/Vb everything that is needed by Simplicial_Cb/Vb
to separate the needs of different packages
all the needed info is available in ccdt_data() in CCDT_Cb/Vb
2025-05-07 22:42:25 +02:00
Jane Tournois 5bc1169626 Merge branch 'Triangulation_3-CDT_3-lrineau' of https://github.com/lrineau/cgal into Triangulation_3-CDT_3-lrineau 2025-05-07 22:29:21 +02:00
Sébastien Loriot 011da26188 unused variable 2025-05-07 17:10:29 +02:00
Laurent Rineau 05dd421eb0 leftovers after the renaming of Base_with_time_stamp
see commit e1ff8c1773902548350380f7b258c1b218609e30
2025-05-06 17:03:06 +02:00
Laurent Rineau 5ddac6888c new test 2025-05-06 17:01:13 +02:00
Laurent Rineau 774ef98ed6 fix the second constructor in 2D case, and amend the test 2025-05-06 17:01:01 +02:00
Laurent Rineau 0f296df8a7 deal with 2D inputs 2025-05-06 13:09:42 +02:00
Laurent Rineau b394cfd319 add does_polygon_soup_self_intersect
undocumented for now
2025-05-06 13:08:18 +02:00
Laurent Rineau a9469fc688 document that the triangulation must be 3D 2025-05-05 15:47:18 +02:00
Jane Tournois dff7b6f78c use Remeshing Cb and Vb in example using Tetrahedral_remeshing 2025-05-05 15:12:02 +02:00
Jane Tournois 0575a1e579 write the full documentation only once in the function templates
and add links to it
This avoids future divergence between the 2 versions, and makes things more
clear for the reader
2025-05-05 12:34:52 +02:00
Jane Tournois c3831eef9c wip review Mael
- expose nothing from cell_data and vertex_data
- add const ref
- doc
2025-05-02 16:17:55 +02:00
Jane Tournois 084f08434e rename example - name is too long for msvc 2025-05-02 16:07:49 +02:00
Jane Tournois 2581f4fb89 workaround to avoid duplication of title phrase, and have \n between 2 lines 2025-05-02 15:58:55 +02:00
Jane Tournois 65edb3d613 move sync_vertex_type_with_dimension_and_index() to a lambda function
to avoid undocumented functions in the vertex base
2025-05-02 15:11:32 +02:00
Jane Tournois b9fd8a3b8e rename Base_with_time_stamp to Triangulation_simplex_base_with_time_stamp 2025-05-02 14:44:36 +02:00
Laurent Rineau e31144344f another fix, so that it works as well on Linux 2025-05-02 14:23:31 +02:00
Laurent Rineau d6ae7c9686 MSVC 2019 does not have std::basic_format_string
See https://github.com/microsoft/STL/pull/3074 implemented later in Sept 2022.
2025-05-02 10:57:56 +02:00
Laurent Rineau d47c44f7f3 fix when Qt6 is not available 2025-05-02 09:56:56 +02:00
Laurent Rineau 108cf8e44f fix ws 2025-04-30 17:33:57 +02:00
Laurent Rineau b190978599 fix the static assertions
... by using Boost containers instead of those from the STL.
2025-04-30 11:32:18 +02:00
Laurent Rineau 0ec75e54ee Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into pr/lrineau/8186 2025-04-29 17:41:39 +02:00
Laurent Rineau 1c4e24621c fix the assertions about nothrow_movable in CDT_3
using Boost implementation of `unordered_map` instead of the std:: version.
2025-04-29 17:41:30 +02:00
Jane Tournois da73a5db7f fix type name 2025-04-29 15:58:08 +02:00
Laurent Rineau 9f38c6887f fix doc 2025-04-29 15:47:47 +02:00
Laurent Rineau 958d50eb20 more debug message 2025-04-29 15:47:41 +02:00
Jane Tournois c95bcb5cb7 wip review Mael 2025-04-29 15:17:54 +02:00
Laurent Rineau 89752983f7 protect debug messages with the flag debug_missing_region() 2025-04-29 13:40:44 +02:00
Sébastien Loriot d06d47909d fix dependencies 2025-04-29 09:34:48 +02:00
Laurent Rineau 13f8e779e0 fix unused variable 2025-04-28 21:00:52 +02:00
Laurent Rineau 45073ebbe1 fix deps 2025-04-28 20:59:08 +02:00
Laurent Rineau dff20e576e disable MSVC warning C4455 for the file 2025-04-28 17:27:53 +02:00
Laurent Rineau c0abf42c57 add CGAL::draw for CCDT_3 2025-04-28 17:07:54 +02:00
Laurent Rineau 58bc7b1a76 always use `auto` for the traits functors 2025-04-28 17:07:54 +02:00
Laurent Rineau 3d850306d9 Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2025-04-25 10:13:08 +02:00
Laurent Rineau 80054315e3 rename a typo 2025-04-25 10:12:27 +02:00
Jane Tournois 0c865cdfad use the generic sentence also for IsDegenerate_3 2025-04-25 09:30:51 +02:00
Laurent Rineau 1add4ff3c3 Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2025-04-25 09:00:14 +02:00
Sébastien Loriot 946472addd fix license checking headers 2025-04-24 20:32:59 +02:00
Laurent Rineau 0db1be0ec8 register the new example in the documentation 2025-04-24 17:44:01 +02:00
Laurent Rineau 596a54e80b Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2025-04-24 17:40:32 +02:00
Laurent Rineau e3478fed98 add an example polygon soup with face patch map 2025-04-24 17:39:24 +02:00
Jane Tournois 1524845269 add the requirements for Gt of Projection_traits_3<Gt>
and a new concept ProjectionTraitsGeometricTraits_3
2025-04-24 15:04:54 +02:00
Laurent Rineau c3bf6f945b Andreas is right: it should be `int` 2025-04-24 12:57:51 +02:00
Jane Tournois 88c7abd0b8 remove unused types,
and types already available in TriangulationTraits_3
and DelaunayTriangulationTraits_3
2025-04-24 12:56:47 +02:00
Laurent Rineau 17c749f44f face_patch_map for polygon soups 2025-04-24 12:56:33 +02:00
Laurent Rineau 8fc4c928a3 improve user manual of CDT_3 2025-04-23 09:13:07 +02:00
Jane Tournois e26c6ade83 wip triangulation traits 2025-04-22 18:37:17 +02:00
Jane Tournois 4a1fa1a2d8 rename concept headers 2025-04-22 16:46:32 +02:00
Jane Tournois 695f2903bb move tests from T3 to CT3 2025-04-22 12:08:10 +02:00