Commit Graph

170 Commits

Author SHA1 Message Date
Andreas Fabri 310ef4c219 more integral_division() 2024-01-12 08:03:00 +00:00
Andreas Fabri 961f00d52b Kernel_d: Use integral_division() 2024-01-12 07:04:01 +00:00
Sébastien Loriot 9a0bdb5d96 boost::variant ---> std::variant 2023-06-15 10:57:10 +02:00
Sébastien Loriot 604dcdc435 boost::optional => std::optional 2023-06-15 10:57:09 +02:00
Mael 0ff7882997
Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Mael da0b13699c
Merge branch 'master' into Kernel-Compare_distance_3_RT_FT__always_Filtered_predicate_RT_FT-GF 2022-12-02 23:19:29 +01:00
Mael Rouxel-Labbé 18ff1d4256 Add missing CGAL enums to Homogeneous_d 2022-11-24 11:39:50 +01:00
albert-github 45478184de spelling corrections
Some spelling corrections (Directories starting with `E`-` L`),
some backward work
some forward work
2022-11-15 13:39:40 +01:00
Andreas Fabri bb604fc538 Kernel_d: Address -Wmaybe-uninitialized warning 2022-10-26 08:27:50 +01:00
Sébastien Loriot 4f5f8341cc use std::enable_if_t 2022-06-10 07:37:53 +02:00
Mael Rouxel-Labbé 3a0a4a6067 Do not forbid any non-fundamental type conversion:
This is because kernel converters are required before type equality
is established, and so one needs conversion for e.g. PointC3.

That could be added and then non-fundamental types could be forbidden
in parameters of converters, but that's for another time...
2021-12-17 12:22:40 +01:00
Mael Rouxel-Labbé 71cbd212dc Converters now simply forward fundamental types, forbid others 2021-12-03 16:48:51 +01:00
Mael Rouxel-Labbé 5da1eaefc8 Fewer const& 2021-11-16 16:39:31 +01:00
Mael Rouxel-Labbé caba3482a6 Disable fundamental type conversions (other than potentially K1::RT / K1::FT) 2021-11-16 16:38:49 +01:00
Sébastien Loriot 152a084019 do not include itself 2021-09-21 13:34:58 +02:00
Sébastien Loriot 98e471849b moving files from internal to PKG/internal 2021-08-26 11:33:39 +02:00
Mael Rouxel-Labbé 78ff9185b3 Harmonize ASCII usage across all packages 2021-06-23 23:34:32 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Dmitry Anisimov 00c185b028
Merge branch 'master' into Kernels-decltypes-danston 2021-03-12 12:06:20 +01:00
Laurent Rineau ab5517e1ac Apply the same for Homogeneous_iterator 2021-02-09 09:27:30 +01:00
Laurent Rineau 21cda32aef Simplify `value_type` and change `reference` 2021-02-09 09:27:02 +01:00
Andreas Fabri 75bdca5e9f Use solution which does not depend on result_type as proposedby Laurent 2021-02-03 09:31:33 +00:00
Andreas Fabri a1189511f9 No need for multiplies 2021-02-03 09:10:59 +00:00
Andreas Fabri 9e9e485387 Fix result_type 2021-02-02 11:19:53 +00:00
Andreas Fabri 4fd0e5ca31 Add equal_to, minus, multiplies to CGAL::Kernel_d with a nested result_type 2021-02-02 10:11:42 +00:00
Dmitry Anisimov e4f5d0b5bd kernel_d result_of to decltype 2020-07-22 16:28:40 +02:00
Laurent Rineau 489e853a65 Fix ambiguous comparisons error with C++20 with Hyperplane_d as well 2020-06-10 18:25:33 +02:00
Laurent Rineau 127d76c370 Fix ambiguous comparisons error with C++20
```
/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Kernel_d/afftrafo-test.cpp:136:31: error: use of overloaded operator '==' is ambiguous (with operand types 'VectorHd<CGAL::VectorHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >::RT, CGAL::VectorHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >::LA>' (aka 'VectorHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >') and 'Vector_d<CGAL::Homogeneous_d<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > > >')
    CGAL_TEST(v.transform(at9)==3*v){}
              ~~~~~~~~~~~~~~~~^ ~~~
/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Kernel_d/include/CGAL/test_macros.h:10:28: note: expanded from macro 'CGAL_TEST'
                           ^
/mnt/testsuite/include/CGAL/Kernel_d/VectorHd.h:350:6: note: candidate function
bool operator==(const VectorHd<RT,LA>& w) const
     ^
/mnt/testsuite/include/CGAL/Kernel_d/Vector_d.h:90:8: note: candidate function (with reversed parameter order)
  bool operator==(const Self& w) const
       ^
```

```
/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Kernel_d/afftrafo-test.cpp:141:33: error: use of overloaded operator '==' is ambiguous (with operand types 'DirectionHd<CGAL::DirectionHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >::RT, CGAL::DirectionHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >::LA>' (aka 'DirectionHd<__gmp_expr<mpz_t, mpz_t>, CGAL::Linear_algebraHd<__gmp_expr<mpz_t, mpz_t>, std::allocator<__gmp_expr<mpz_t, mpz_t> > > >') and 'Direction' (aka 'Direction_d<Homogeneous_d<__gmp_expr<__mpz_struct [1], __mpz_struct [1]> > >'))
    CGAL_TEST(dir.transform(at9)==dir){}
              ~~~~~~~~~~~~~~~~~~^ ~~~
/home/cgal_tester/build/src/cmake/platforms/ArchLinux-clang-CXX20-Release/test/Kernel_d/include/CGAL/test_macros.h:10:28: note: expanded from macro 'CGAL_TEST'
                           ^
/mnt/testsuite/include/CGAL/Kernel_d/DirectionHd.h:181:6: note: candidate function
bool operator==(const DirectionHd<RT,LA>& w) const
     ^
/mnt/testsuite/include/CGAL/Kernel_d/Direction_d.h:61:8: note: candidate function (with reversed parameter order)
  bool operator==(const Self& w) const
       ^
```
2020-06-10 18:10:58 +02:00
Sébastien Loriot 8bb22d5b2c extra run of the script to remove tabs and trailing whitespaces
right after the merge of the 5.0 release branch

+ manual fix of the files (indentation was changed in the meantime):
   * Spatial_sorting/include/CGAL/Multiscale_sort.h
   * Spatial_sorting/test/Spatial_sorting/test_multiscale.cpp
2020-03-26 14:26:59 +01:00
Sébastien Loriot 8b153fb495 Merge branch 'cgal/releases/CGAL-5.0-branch'
whitespace+tab removal, merged with option -Xignore-space-change
2020-03-26 14:22:32 +01:00
Sébastien Loriot 0779373835 extra run of the script to remove tabs and trailing whitespaces
right after the  merge of 4.14 release branch

+ manual fix on one line in:
    * Arrangement_on_surface_2/include/CGAL/IO/Arr_text_formatter.h
    * .travis/generate_travis.sh
2020-03-26 14:16:06 +01:00
Sebastien Loriot 6b2b1e8470
Merge pull request #4238 from sloriot/sloriot/CGAL-Variadics
use Variadic templates
2020-03-17 18:21:56 +01:00
Ahmed Essam 613eedb77b Fix perfect forwarding 2020-03-02 07:37:36 +01:00
Sébastien Loriot 52164b1fba First pass on removing license notice in header for LGPL files 2019-10-19 15:40:30 +02:00
Sébastien Loriot 7356421d80 introduce Commercial license SPDX tag 2019-10-19 12:15:19 +02:00
Sébastien Loriot 9bd9c68b83 update LGPL[23]+ and GPL[23]+ SPDX tags
ack -l --no-svg "SPDX-License-Identifier: GPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-3.0+/SPDX-License-Identifier: GPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-3.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-3.0+/SPDX-License-Identifier: LGPL-3.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: GPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: GPL-2.0+/SPDX-License-Identifier: GPL-2.0-or-later/"
ack -l --no-svg "SPDX-License-Identifier: LGPL-2.0\+" | xargs sed -i "s/SPDX-License-Identifier: LGPL-2.0+/SPDX-License-Identifier: LGPL-2.0-or-later/"
2019-10-18 21:57:54 +02:00
Sebastien Loriot dc7c2958b9
Fix forward
Co-Authored-By: Laurent Rineau <Laurent.Rineau@cgal.org>
2019-10-10 11:32:33 +02:00
Sébastien Loriot 6368c5b393 use perfect forwarding 2019-10-10 06:54:51 +02:00
Sébastien Loriot 1b00fd3f54 use Variadic templates 2019-09-19 23:11:04 +02:00
Sébastien Loriot c0edb5ecaa remove CGAL_CXX11 macro usage 2019-07-08 11:42:17 +02:00
Mael Rouxel-Labbé 2848158354 Fix typos 2019-05-20 08:54:04 +02:00
Sébastien Loriot 1d908c1c0b remove code for CGAL_INTERSECTION_VERSION 1 2019-03-29 13:28:32 +01:00
Laurent Rineau afc3de2894
Merge branch 'master' into Stream_support-Color-GF 2019-01-23 09:37:08 +01:00
Andreas Fabri 0178843532 No need for Lin_d constructor 2019-01-21 09:51:26 +01:00
Laurent Rineau 6ffd76a87e Merge pull request #2792 from afabri/Intersections_3-Add_missing_do_intersect-GF
Intersections_3:  Add missing do_intersect() overloads
2019-01-18 16:37:54 +01:00
Andreas Fabri 383d93d10a Fix Kernel_d 2019-01-18 15:29:34 +01:00
Andreas Fabri a48e367e45 Fix Kernel_d 2019-01-10 18:16:54 +01:00
Andreas Fabri 11131d3f6b Simplify Point_d and Vector_d 2019-01-10 14:08:09 +01:00
Andreas Fabri 3c1e450be2 Do for Point_d the same as for Vector_d 2019-01-09 17:26:04 +01:00
Andreas Fabri 30953ef2c1 Deal with Vector_d as well 2019-01-07 12:26:03 +01:00