Commit Graph

4363 Commits

Author SHA1 Message Date
Sébastien Loriot 90bc05e715 Merge pull request #6047 from MaelRL/PM-Fix_pmaps_reference_types_5.3-GF
Various fixes for property maps (5.3)
2021-10-29 17:39:22 +02:00
Laurent Rineau 7c185a3e5c Merge pull request #6051 from MaelRL/PMP-Forward_GT_orient_to_bound_volume-GF
PMP: Forward the geometric traits in `orient_to_bound_a_volume()`
2021-10-29 16:50:09 +02:00
Laurent Rineau 8a797935aa Merge pull request #6068 from sloriot/PMP-sampling_doc
Fix NPs and improve doc
2021-10-29 16:50:03 +02:00
Sébastien Loriot b793e7cd90 fix NPs and improve doc 2021-10-19 17:38:12 +02:00
Mael Rouxel-Labbé 1ab6b44d7d Fix NP forwarding in volume_CC 2021-10-15 10:22:08 +02:00
Mael Rouxel-Labbé 1f73af6cc4 Drive-by cleaning 2021-10-14 11:09:04 +02:00
Mael Rouxel-Labbé 91e7f1d20c Forward the geom traits in orient_to_bound_a_volume 2021-10-14 11:06:04 +02:00
Mael Rouxel-Labbé 131242bb80 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_5.3-GF 2021-10-12 09:29:23 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Laurent Rineau 0e3b73852f Merge branch '5.2.x-branch' into 5.3.x-branch 2021-10-07 14:26:14 +02:00
Mael Rouxel-Labbé 863ab7541c Various whitespace fixes 2021-10-05 12:14:03 +02:00
Mael Rouxel-Labbé 84d84278b9 Fix VPM type 2021-10-05 12:14:02 +02:00
Laurent Rineau 999ce8134a Merge pull request #6022 from sloriot/PMP-deps
Reduce dependencies
2021-09-30 16:48:55 +02:00
Sébastien Loriot 2b666db30c use function
avoid compilation error about unknown function
2021-09-29 12:11:42 +02:00
Laurent Rineau b19086946c Merge pull request #5994 from MaelRL/PMP-Detect_sharp_edges_const-GF
Enhancements & fixes for PMP::detect_features
2021-09-29 11:45:38 +02:00
Sébastien Loriot c374b382a5 reduce dependancies 2021-09-29 11:06:39 +02:00
Sébastien Loriot 542d3603be fix weight for vertex-vertex snapping 2021-09-27 19:46:14 +02:00
Mael 4e5fbb6f22
Specify namespace
Co-authored-by: Laurent Rineau <Laurent.Rineau@cgal.org>
2021-09-27 12:15:09 +02:00
Mael Rouxel-Labbé 878d94e299 Fix sign call 2021-09-24 09:47:33 +02:00
Mael Rouxel-Labbé 2bc5643972 Fix comparison 2021-09-21 16:50:19 +02:00
Mael Rouxel-Labbé c7519ef93c Cache the squared cos value 2021-09-15 14:59:55 +02:00
Mael Rouxel-Labbé fd12c73cba Enhance tests 2021-09-15 14:59:40 +02:00
Mael Rouxel-Labbé a5bbd05c42 Do not compute square roots + various improvements 2021-09-15 14:46:56 +02:00
Mael Rouxel-Labbé 8b7ab25966 Minor cleaning 2021-09-15 14:08:25 +02:00
Sébastien Loriot 75ca34c2a5 Merge remote-tracking branch 'cgal/5.2.x-branch' into HEAD 2021-09-06 18:52:40 +02:00
Sébastien Loriot 000b03b595 follow up of #5889
cherry-picking for autorefinement
2021-09-06 18:44:07 +02:00
Sebastien Loriot 2f0a643a84
Merge pull request #5889 from sloriot/PMP-cherry_picks_from_5089
Bug fixes cherry picked from #5049
2021-08-30 15:51:23 +02:00
Sébastien Loriot cff3cdb40e Merge remote-tracking branch 'cgal/5.2.x-branch' into HEAD 2021-08-12 10:23:57 +02:00
Sébastien Loriot 050e81d5fd set coplanar status of patches before classification
cherry-picked from #5049
2021-08-04 14:58:16 +02:00
Sébastien Loriot 8903e746f0 Correctly split intersection polylines when boundary/interior status changes along the polyline
Cherry-picked from #5049
2021-08-04 14:58:16 +02:00
Sébastien Loriot 6349441c4b better handling of boundary cases (cherry-picked from #5049) 2021-08-04 14:57:51 +02:00
Mael 753fc4d434 Minor comment fixes 2021-08-04 09:11:35 +02:00
Sébastien Loriot 9dc3f84d73 try to workaround non-determinism 2021-08-03 14:25:50 +02:00
Sébastien Loriot 10ed1a058e add more tests 2021-07-29 17:22:37 +02:00
Sébastien Loriot 743a5fc29e add split case with a plane containing border edges 2021-07-29 13:21:16 +02:00
Simon Lopez 7f6c39e898 Skip shared edges which are border edges 2021-07-29 10:52:13 +02:00
Jane Tournois ec7a211a1d add parameters to isotropic_remeshing
to able/disable split, collapse, and flip
2021-06-22 14:22:32 +02:00
albert-github 2a54687e77 Correction of hyperlinks
The link checker gave a number of redirects and incorrect links.
- the redirects have been solved ass far as possible
- the incorrect links have been checked and corrected where possible, others  have been reported through issues;
2021-06-04 13:52:14 +02:00
Laurent Rineau f427e6b87d Merge pull request #5686 from sloriot/PMP-remove_si_boundary_cycles
Allow more repair
2021-05-19 17:24:06 +02:00
Laurent Rineau e222e772f1 Merge pull request #5589 from MaelRL/Number_types-Fix_approx_sqrt_mpq-GF
Fix approximate_sqrt return types

# Conflicts:
#	Polygon_mesh_processing/test/Polygon_mesh_processing/test_pmp_distance.cpp
2021-05-18 18:16:44 +02:00
Laurent Rineau 26ad68e486 Merge pull request #5649 from sloriot/CGAL-no_boost_shared_ptr
Replace internal use of boost shared_ptr
2021-05-18 18:14:12 +02:00
Laurent Rineau 1ac4c2903a Merge pull request #5589 from MaelRL/Number_types-Fix_approx_sqrt_mpq-GF
Fix approximate_sqrt return types
2021-05-18 17:32:26 +02:00
Laurent Rineau 49aff67985 Merge pull request #5689 from janetournois/PMP-isotropic_remeshing_fixes-jtournois
PMP::isotropic_remeshing - fixes about "isolated constraints"

# Conflicts:
#	Polygon_mesh_processing/test/Polygon_mesh_processing/CMakeLists.txt
2021-05-18 17:31:55 +02:00
Laurent Rineau e0a4dd0680 Merge pull request #5677 from sloriot/CGAL-IO_namespace
CGAL IO namespace

# Conflicts:
#	Installation/test/Installation/test_gmp_mpfr_dll.cpp
2021-05-18 17:31:40 +02:00
Laurent Rineau b33a2f17bd Merge pull request #5689 from janetournois/PMP-isotropic_remeshing_fixes-jtournois
PMP::isotropic_remeshing - fixes about "isolated constraints"

# Conflicts:
#	Polygon_mesh_processing/test/Polygon_mesh_processing/CMakeLists.txt
2021-05-18 17:06:45 +02:00
Jane Tournois 74e2ee9734 do not collapse isolated constraints 2021-05-06 19:40:52 +02:00
Jane Tournois 14385aaf15 add a test with isolated constraints, on and away from mesh borders 2021-05-06 17:48:39 +02:00
Jane Tournois 3a6e31de65 do not split isolated constraints 2021-05-06 15:56:23 +01:00
Jane Tournois 64e568f748 an isolated constraint can be on the mesh border
the halfedge status for a pair of opposite halfedges can be
MESH_BORDER and ISOLATED_CONSTRAINT, but MESH_BORDER has
priority
2021-05-06 16:56:05 +02:00