Commit Graph

265 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé 131242bb80 Merge branch 'PM-Fix_pmaps_reference_types-GF' into PM-Fix_pmaps_reference_types_5.3-GF 2021-10-12 09:29:23 +02:00
Mael Rouxel-Labbé 590ddf8015 Various fixes for pmaps:
- Use `value_type` when the returned type is not a reference
- Enforce `reference = value_type` if the returned type is not
  a reference (to avoid `typename PM::reference r = get(m, k)`,
  which will take a ref to a temporary if the `reference`
  typedef is an actualy reference)
- Do not use `put_get_helper` if the property map is not a `lvalue`
  **mutable** property map: the `put()` is `map[k] = v`, which
  is broken if `operator[]` does not return a reference
- The concept `boost::lvalue_property_map_tag` requires `operator[](key)`,
  not a reference in `get(map, key)`. You can have a readable property map
  returning a reference through its `get(map, key)`, but if there is
  no `operator[]`, it's just a `boost::readable_property_map_tag`
- Some const correctness to avoid copying maps with state
  or heavy keys in `get(map, key)` / `put(map, key, value)`
- Base the category of a wrapping pmap on what it offers instead
  of just forwarding the base property map's category
- Tried to do something like mutable lvalue pmap:
  * `value_type& operator[](key&)`
  * `ref get(map, const key&)`
  * `put(map, const key&, const value_type&)`
  and non-mutable lvalue pmap:
  * `const value_type& operator[](const key&)`
  * `ref get(map, const key&)`
  but not everything fits properly...
2021-10-08 15:38:47 +02:00
Mael Rouxel-Labbé df560987a6 Whitespace & cleaning changes 2021-10-08 12:13:43 +02:00
Sébastien Loriot 4e519a3c7a move documented IO functions in IO namespace 2021-05-05 13:15:37 +02:00
Sébastien Loriot fb6f703b55 IO namespace for files in IO directories 2021-05-04 14:36:06 +02:00
Sebastien Loriot 77e5d1d26f
Merge pull request #4852 from JacksonCampolattaro/gsoc2020-Octree-campolattaro
Add Octree Package
2021-04-17 14:26:01 +02:00
Sebastien Loriot b7323389c7
Merge pull request #5622 from maxGimeno/CMake-Update_versions_in_scripts-maxGimeno
Update maximum cmake versions
2021-04-17 10:58:14 +02:00
Maxime Gimeno c49152359c update max version of cmake and announce the new minimal in CHANGE.md 2021-04-15 15:08:54 +02:00
Simon Giraudot 8e7ea14f58 Fix conversion warning 2021-04-14 10:57:53 +02:00
Simon Giraudot 3de09ad3da Fix consistency assertions/comments 2021-04-14 09:20:40 +02:00
Simon Giraudot e87747d082 Fix candidate counting 2021-04-14 09:20:17 +02:00
Simon Giraudot 10f6992b2a Rebase on master 2021-04-07 14:32:31 +02:00
Simon Giraudot 8f4dec8107 Avoid timeouts in testsuite 2021-04-07 14:27:44 +02:00
Simon Giraudot 4ec9bd6c9a Optimize location of node 2021-04-07 14:26:19 +02:00
Simon Giraudot 4c0018791c Fix bbox, width and depth computations in Octree wrapper 2021-04-07 14:13:29 +02:00
Maxime Gimeno 17602e589e Merge remote-tracking branch 'cgal/master' into CGAL-clang_tidy__nullptr_on_Mesh_2-GF 2021-04-07 09:17:51 +02:00
Laurent Rineau 343ef10367 Merge pull request #5547 from sgiraudot/Fix_stdpow_related_warnings-GF
Fix warning: std::pow(float, int) returns double instead of float in recent C++
2021-04-06 15:13:00 +02:00
Simon Giraudot 1794620ab9 Move index access property map to property map package 2021-04-01 09:43:14 +02:00
Simon Giraudot 616cd5a549 Apply corrections from review 2021-04-01 08:55:51 +02:00
Simon Giraudot 91de37ec3a Fix warning: std::pow(float, int) returns double instead of float in recent C++ 2021-03-23 11:25:53 +01:00
Simon Giraudot 987b177833 Fix conversion warning 2021-03-18 08:36:34 +01:00
Simon Giraudot 9fe8708fc2 Fix bug that created empty octrees 2021-03-15 10:18:55 +01:00
Simon Giraudot a5f139f9df Remove unused variables 2021-03-11 09:34:33 +01:00
Simon Giraudot b22bd4e498 Update dependencies 2021-03-08 11:11:36 +01:00
Simon Giraudot 46b9452ef4 Rebase on master 2021-03-04 13:48:11 +01:00
Laurent Rineau 3621aaaf3e Merge pull request #5426 from sgiraudot/PSP-RANSAC-Fix_warnings-GF
[PSP/RANSAC] Fix warnings
2021-03-03 17:33:05 +01:00
Laurent Rineau 05d0f01fc4 Merge pull request #5487 from sgiraudot/Shape_detection-Disable_long_tests-GF
Shape Detection: Disable expensive tests by default
2021-03-03 17:21:27 +01:00
Laurent Rineau 45373bef84 Merge pull request #5426 from sgiraudot/PSP-RANSAC-Fix_warnings-GF
[PSP/RANSAC] Fix warnings
2021-03-03 17:10:18 +01:00
Simon Giraudot 6e811d6a8f Rebase on master 2021-03-03 12:56:57 +01:00
Simon Giraudot 5955028010 Disable expensive tests by default 2021-02-23 08:18:47 +01:00
Maxime Gimeno b80daff6fb Fixes 2021-02-19 11:31:52 +01:00
Maxime Gimeno 7f189620d8 Remove CMAKE_CXX_STANDARD commands in cmake scripts 2021-02-08 10:06:23 +01:00
Simon Giraudot 0cf9990bf0 Fix conversion warning in RANSAC 2021-02-04 08:33:54 +01:00
Laurent Rineau f176529041 Merge pull request #5357 from sloriot/CGAL-boost_function_output-master
Include non-deprecated header (master)
2021-01-21 16:22:39 +01:00
Laurent Rineau 52bb68c012 Merge pull request #5356 from sloriot/CGAL-boost_function_output-5.2
Include non-deprecated header (5.2)
2021-01-21 16:18:55 +01:00
Simon Giraudot a19836bfb6 Fix RANSAC's use of outdated Octree API 2021-01-20 11:20:01 +01:00
Simon Giraudot 1dcf876679 Remove TODOs 2021-01-19 14:07:13 +01:00
Simon Giraudot ae8ec55eac Merge remote-tracking branch 'jackson/gsoc2020-Octree-campolattaro' into gsoc2020-Octree-campolattaro 2021-01-19 09:54:58 +01:00
Sébastien Loriot bc161f2ae9 Merge 'CGAL-Eigen3_support-5.2' 2021-01-15 10:59:20 +01:00
Sébastien Loriot f4935dc199 Merge branch 'CGAL-Eigen3_support-5.1' 2021-01-15 10:54:02 +01:00
Sébastien Loriot eecb00534e fix macro name to be consistent with find_package 2021-01-15 10:43:34 +01:00
Sébastien Loriot ad911271a9 Merge commit '6594e7549bd70923990d86c31e2aa267a79bb629' into HEAD 2021-01-15 10:12:17 +01:00
Sébastien Loriot 6594e7549b do no include a deprecated header 2021-01-15 10:07:59 +01:00
Sébastien Loriot bdd4efe3b3 Merge commit 'efc0c525e8b' into HEAD 2021-01-15 10:06:56 +01:00
Sébastien Loriot efc0c525e8 include non-deprecated header 2021-01-15 10:02:00 +01:00
Maxime Gimeno 5948bc846e Try to remove Filtered_kernel from the dependencies of BGL 2021-01-11 14:11:30 +01:00
Maxime Gimeno 5d2ad68148 Add new Dependences. ATTENTION BGL is propagated through the NPs in Stream_support 2021-01-08 15:58:46 +01:00
Maxime Gimeno 3d1c41fd14 Merge remote-tracking branch 'cgal/master' into CGAL_IO-maxGimeno 2021-01-07 15:05:28 +01:00
Laurent Rineau 47c4fc8aa2 Merge pull request #5279 from sgiraudot/RANSAC-Fix_ptrdiff_overflow-GF
[RANSAC] Fix ptrdiff overflow
2020-12-16 17:49:07 +01:00
Laurent Rineau fe34a5aa04 Merge pull request #5279 from sgiraudot/RANSAC-Fix_ptrdiff_overflow-GF
[RANSAC] Fix ptrdiff overflow
2020-12-16 17:47:45 +01:00