Commit Graph

208 Commits

Author SHA1 Message Date
Laurent Saboret 4f375320a0 Fixed bug in make_surface_mesh(implicit surface, sphere, Manifold_tag) when the implicit surface crosses the sphere:
* The bug could be reproduced on Linux/g++ 4.3.1 by:
> poisson_reconstruction Compressor_top_clean_30kpoints.pwn Compressor-poisson.off
or
> APSS_reconstruction robocat_deci.off robocat_deci-apss.off
=> infinite loop that crashes when the process max memory is reached, or
   assertion failure "(x,y,z) is already inserted on surface", or
   assertion failure "A facet is not in conflict with its refinement point"

* The fix was to use Manifold_with_boundary_tag.
2009-09-08 14:08:23 +00:00
Pierre Alliez 937d57808f update barycentric coordinates - thanks Andreas. 2009-09-08 07:03:30 +00:00
Laurent Saboret f26a4c18f0 Fixed assertion failure "tester(d)" in Triangulation_3::find_conflicts() when running the Delaunay refinement:
* To reproduce the bug:
> poisson_reconstruction data/sphere926.pwn sphere926-poisson.off
(try several times)

* The fix is:
- implement Robust_circumcenter_filtered_traits_3::compute_squared_radius_3_object()
- compare denominator with 1E-13 (instead of 1E-14) to switch to exact arithmetic
2009-09-07 17:10:06 +00:00
Laurent Saboret 0a9f6181d5 Fixed infinite loop in Min_sphere_d:
* On Linux/g++, the bug could be reproduced by:
> poisson_reconstruction data/sphere926.pwn sphere926-poisson.off

* The fix was do use Min_sphere_of_spheres_d instead of Min_sphere_d
2009-09-07 14:06:13 +00:00
Laurent Saboret f7e2037760 * Fixed images width (as requested by LR):
set max-width instead of width in HTML.
* Also set width=1.0 for most images in PDF (prettier).
2009-09-03 15:22:38 +00:00
Laurent Saboret 10854a4ba1 Fixed compilation error due to the global change "CGALi" -> "internal". 2009-09-02 13:16:45 +00:00
Laurent Saboret fe8353441a Port to Windows 64 2009-09-02 12:10:05 +00:00
Laurent Saboret be09d80d95 * Bug fix: fixed compatibility of TAUCS/BLAS/LAPACK precompiled libraries with Visual C++ 9.0 2008:
CGAL 3.5 will include TAUCS/BLAS/LAPACK precompiled libraries for Visual C++ 8.0 and 9.0. 
Auto-link is modified accordingly.

* Also fixed compatibility of cgal_test_with_cmake.bat scripts with VC++ 9.0.
2009-08-26 16:23:28 +00:00
Andreas Fabri 5d0c59cbd9 VC++ doesn't know whether Tds is the template parameter or the inherited typedef ... Tds; which is defined in the scope of the base class Triangulation_3 2009-08-25 21:06:46 +00:00
Sylvain Pion 8573fe26ce Rename CGALi to internal. 2009-08-24 17:10:04 +00:00
Laurent Saboret fa8674926a Improved traces 2009-08-24 16:05:20 +00:00
Laurent Saboret ad52daf904 * Finished to implement the changes requested by PA on 08/24.
* Committed Surface_reconstruction_statistics.xls with PA changes committed on 08/24.
* Fixed figures numbering.
2009-08-24 16:00:06 +00:00
Laurent Saboret b81dc194e6 Update images wrt Surface_reconstruction_images.ppt r51238 (as requested by PA) 2009-08-24 12:10:30 +00:00
Laurent Saboret 70ba3ec8c1 Compressed images 2009-08-24 12:08:42 +00:00
Laurent Saboret 5e741020a7 Convert PNG images to JPG to save space in CGAL tarball (requested by SP) 2009-08-24 10:11:30 +00:00
Pierre Alliez f61de989cb minor fixes on performances.tex
(needs more fixes)
2009-08-14 12:07:48 +00:00
Pierre Alliez 79fdf05aa0 case studies: done for failure cases. 2009-08-14 12:02:24 +00:00
Pierre Alliez f43babb999 more on case studies (degraded conditions) 2009-08-14 11:24:32 +00:00
Pierre Alliez ac626b2fb0 more on case studies (ideal sampling conditions) 2009-08-14 10:06:32 +00:00
Pierre Alliez 7d5cd23287 more on case studies. 2009-08-14 09:50:46 +00:00
Pierre Alliez 9109f19e63 recontruction: improve bench images. 2009-08-14 09:01:17 +00:00
Laurent Saboret 89065b78a8 Turn on TAUCS traces to debug random crash in test suite 2009-08-07 10:50:18 +00:00
Laurent Saboret 318876bb07 User Manual: added Case Studies and Performance sections for Poisson reconstruction 2009-08-06 16:38:37 +00:00
Laurent Saboret 7e99eef316 Images used in the User Manual (rasterized) 2009-08-04 14:41:59 +00:00
Laurent Saboret ac3d842098 Fixed the default Surface Mesher parameters:
* Default Surface Mesher parameters for Poisson are now  
- triangle radius = 100 * point set average spacing and 
- approximation distance = 0.25 * point set average spacing 
(instead of 0.1 * point set radius and 0.002 * point set radius).
As Poisson is a function piecewise linear in the tetrahedra of the underlying triangulation, the goal of this change is to ensure that the Surface Mesher creates a mesh with triangles larger than the underlying tetrahedra.

* Default Surface Mesher parameters for APSS are now the same as Poisson to ease comparison among both methods, and simplify code maintenance
(instead of APSS distance = 1.5 * Poisson distance to get reconstructed surfaces of roughly the same number of faces).
2009-08-04 11:35:02 +00:00
Laurent Saboret 8107390e77 Fixed compilation error on Linux/g++ 2009-08-03 17:28:38 +00:00
Laurent Saboret 31f36744c7 * Fixed color of reconstructed surfaces (magenta -> light gray).
* Fixed size of splats for nicer screenshots:
- knn parameter allows now to change the size of splats
- fixed offset by 1 in use of knn
- knn default changed from 18 (medium) to 6 (small)
- knn min changed from 6 (small) to 1 (tiny)

* Compute reconstruction error after APSS and Poisson (in fact the distance from input points to reconstructed mesh).
2009-08-03 15:36:25 +00:00
Laurent Saboret d5475f496c Improved performance traces 2009-08-03 14:47:05 +00:00
Laurent Saboret 7ef33128f2 Fixed bug in Point Set demo Save As dialog: prompt warning if saving failed 2009-08-03 07:57:39 +00:00
Laurent Saboret f7831a6a82 Improved performance traces 2009-07-31 10:49:16 +00:00
Laurent Saboret fa4a22f837 Bug fix: fixed scene item name when loading a file with several dots in the name. 2009-07-31 09:44:13 +00:00
Laurent Saboret 0a8d0e30f3 Temporary workaround:
remove robocat_deci from tst suite to avoid an infinite loop with APSS.
2009-07-30 17:12:35 +00:00
Laurent Saboret 1a1ecba11a Fixed bug in Save As dialog 2009-07-30 17:11:24 +00:00
Laurent Saboret aacac9bdf0 Improved performance traces 2009-07-30 12:55:44 +00:00
Laurent Saboret f46faa4ca0 Fixed minimum value of percentage field (set to 0.01%) 2009-07-29 15:49:50 +00:00
Laurent Saboret eef098c440 Use approximation distance = 0.015 (instead of 0.01) to match the recommended values. 2009-07-29 12:56:39 +00:00
Laurent Rineau f1a3f94274 Merge to trunk commits from CGAL-3.5-branch so far.
Merged revisions 50855,50859,50863,50868,50871,50878-50879,50886,50893,50930-50934 via svnmerge from 
svn+ssh://scm.gforge.inria.fr/svn/cgal/branches/CGAL-3.5-branch

........
  r50855 | lrineau | 2009-07-27 13:47:18 +0200 (Mon, 27 Jul 2009) | 1 line
  
  Attempt to fix links to precompiled demos.
........
  r50859 | lrineau | 2009-07-27 14:37:54 +0200 (Mon, 27 Jul 2009) | 2 lines
  
  update the AUTHORS list
........
  r50863 | lrineau | 2009-07-27 14:53:14 +0200 (Mon, 27 Jul 2009) | 3 lines
  
  Remove occurences of "3.4" in various files (problem reported by
  J. Reichel)
........
  r50868 | lrineau | 2009-07-27 15:38:39 +0200 (Mon, 27 Jul 2009) | 2 lines
  
  Fix target names conflicts with Triangulation_2.
........
  r50871 | lrineau | 2009-07-27 15:48:57 +0200 (Mon, 27 Jul 2009) | 2 lines
  
  Taucs will be updated for CGAL-3.5.
........
  r50878 | lrineau | 2009-07-27 16:10:03 +0200 (Mon, 27 Jul 2009) | 2 lines
  
  There was still a 3.4 in that file.
........
  r50879 | lrineau | 2009-07-27 16:16:11 +0200 (Mon, 27 Jul 2009) | 2 lines
  
  Fix a problem with \cgalrawversion{}: use "\cgalrawversion" instead!
........
  r50886 | reichel | 2009-07-27 19:09:07 +0200 (Mon, 27 Jul 2009) | 2 lines
  
  Set CGAL_SONAME_VERSION to 4 and CGAL_SOVERSION to 4.0.0.
........
  r50893 | lsaboret | 2009-07-28 10:27:31 +0200 (Tue, 28 Jul 2009) | 2 lines
  
  * Fixed include path.
  * Fixed order of libraries: TAUCS must be listed before LAPACK.
........
  r50930 | lrineau | 2009-07-29 11:58:00 +0200 (Wed, 29 Jul 2009) | 2 lines
  
  Add periodic_3_demo to "make demos".
........
  r50931 | lrineau | 2009-07-29 11:59:33 +0200 (Wed, 29 Jul 2009) | 2 lines
  
  Add CGAL ipelets to "make demos".
........
  r50932 | lrineau | 2009-07-29 12:57:59 +0200 (Wed, 29 Jul 2009) | 2 lines
  
  Add the polyhedron demo to "make demos".
........
  r50933 | lrineau | 2009-07-29 13:04:50 +0200 (Wed, 29 Jul 2009) | 2 lines
  
  Add the points set demo to "make demos".
........
  r50934 | lrineau | 2009-07-29 13:09:22 +0200 (Wed, 29 Jul 2009) | 2 lines
  
  Make the windows installer fetch the manual from the right place!
........
2009-07-29 12:49:27 +00:00
Laurent Saboret 47065c2ae1 * Workaround orientation bug in output_surface_facets_to_off(): call output_surface_facets_to_polyhedron() then save polyhedron to OFF.
* Also change make_surface_mesh() tag parameter from Manifold_with_boundary_tag to Manifold_tag as implicit functions have no boundaries.
2009-07-29 09:45:42 +00:00
Laurent Saboret f7ca35ad47 * Workaround orientation bug in output_surface_facets_to_off(): call output_surface_facets_to_polyhedron() then save polyhedron to OFF.
* Also change make_surface_mesh() tag parameter from Manifold_with_boundary_tag to Manifold_tag as implicit functions have no boundaries.
2009-07-29 09:13:15 +00:00
Laurent Saboret f9d7cbd843 Update trunk/Surface_reconstruction_points_3 wrt CGAL-3.5-branch for revisions 50663-r50904:
r50904 | lsaboret:
Fixed compilation error in cgal_test_with_cmake introduced in r50885

r50901 | lrineau:
-#include <Qt/qglobal.h>
+#include <QtCore/qglobal.h>

r50885 | lsaboret:
* Fixed compilation errors on Windows/VC++ introduced in r50866 (one needs to update a DLL's config file when renaming the DLL).
* Use "PS_demo_" prefix instead of "reconstruction_" in target names (to be coherent, and because long names break cmake on Windows - see r50533).
* Renamed polyhedron_demo_plugin() as point_set_demo_plugin() (to be coherent, and because the code diverges from Polyhedron demo).

r50877 | lsaboret:
Fixed link error on Windows (in splatting code)

r50688 | palliez:
point set demo: one attempt to solve compilation issues.

r50679 | palliez:
move point set demo

r50678 | palliez:
move point set demo

r50677 | palliez:
move point set demo

r50676 | palliez:
move point set demo

r50675 | palliez:
move point set demo

r50668 | lsaboret:
* Updated Point_set_processing_3 reference manual to describe the influence of each knn parameter.
* Fixed bug in Point_set_processing_3 examples/tests: use reasonable default knn parameters (0.1 or 0.15% of point set was overkill.* Updated the Point Set demo to use the recommended knn values by default.

r50666 | ggael:
automagically computes the slpat radii when needed

r50663 | ggael:
remove the splatting mode if it is not supported
2009-07-28 12:07:14 +00:00
Laurent Saboret 341a2a7a28 Move Surface_reconstruction_points_3 with APSS (targeting CGAL 3.6) from experimental-packages to trunk 2009-07-28 09:20:13 +00:00
Laurent Saboret 4b8de7a701 Move Surface_reconstruction_points_3 with APSS (targeting CGAL 3.6) from experimental-packages to trunk 2009-07-28 08:25:53 +00:00
Laurent Saboret 0295e64d9b Move Surface_reconstruction_points_3 with APSS (targeting CGAL 3.6) from experimental-packages to trunk 2009-07-28 07:26:07 +00:00
Laurent Saboret 740a0faa6e Move Surface_reconstruction_points_3 with APSS (targeting CGAL 3.6) from experimental-packages to trunk 2009-07-28 07:24:21 +00:00
Laurent Rineau aa5fac11fe Change targets names to avoid conflicts with target names from the
polyhedron demo.
2009-07-27 13:15:58 +00:00
Pierre Alliez 44305e3ff0 point set demo: one attempt to solve compilation issues. 2009-07-19 07:11:08 +00:00
Pierre Alliez 237985093b move point set demo 2009-07-17 16:47:50 +00:00
Pierre Alliez 9e2bb054e6 move point set demo 2009-07-17 16:44:43 +00:00
Pierre Alliez a1abe90c8f move point set demo 2009-07-17 16:44:00 +00:00
Pierre Alliez 20b534eadf move point set demo 2009-07-17 16:42:18 +00:00